98099 2012-10-01 17:12:16 -0700 [Gtk] crash when accelerated composition is turned off 2012-10-01 18:13:56 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier alex mrobinson webkit.review.bot oldest_to_newest 732139 0 a.renevier 2012-10-01 17:12:16 -0700 Hi, when a accelerated composition is turned off on a page (for example, because no element require compositing anymore), WebKitGTK often crashes in #0 0xb68f063f in WebKit::AcceleratedCompositingContext::flushPendingLayerChanges() () from /home/arno/webkit/WebKit.upstream/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 #1 0xb68f06f5 in WebKit::AcceleratedCompositingContext::flushAndRenderLayers() () from /home/arno/webkit/WebKit.upstream/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 #2 0xb68f07e0 in WebKit::AcceleratedCompositingContext::layerFlushTimerFired() () from /home/arno/webkit/WebKit.upstream/WebKitBuild/Release/.libs/libwebkitgtk-3.0.so.0 #3 0xb68f0801 in WebKit::AcceleratedCompositingContext::layerFlushTimerFiredCallback(WebKit::AcceleratedCompositingContext*) () flushPendingLayerChanges is reached while m_rootLayer has been cleared, and this results in a crash. This happens because frame->view()->updateLayoutAndStyleIfNeededRecursive() is called in flushAndRenderLayers, and this may result in root compositing layer being set to null. 732152 1 166579 a.renevier 2012-10-01 17:19:32 -0700 Created attachment 166579 Patch patch proposal: check if compositing is enabled after call to updateLayoutAndStyleIfNeededRecursive 732156 2 166579 mrobinson 2012-10-01 17:24:11 -0700 Comment on attachment 166579 Patch Nice fix. It probably makes sense to keep the check in both places, no? 732163 3 166581 a.renevier 2012-10-01 17:33:11 -0700 Created attachment 166581 Patch updated patch 732164 4 166581 mrobinson 2012-10-01 17:34:52 -0700 Comment on attachment 166581 Patch Thanks! 732182 5 166581 webkit.review.bot 2012-10-01 18:13:53 -0700 Comment on attachment 166581 Patch Clearing flags on attachment: 166581 Committed r130108: <http://trac.webkit.org/changeset/130108> 732183 6 webkit.review.bot 2012-10-01 18:13:56 -0700 All reviewed patches have been landed. Closing bug. 166579 2012-10-01 17:19:32 -0700 2012-10-01 17:33:09 -0700 Patch bug-98099-20121001171843.patch text/plain 1998 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNzExYTRjMTdj MjlhZTFkNzg0YTM1ZmY2ZDdlMmZjNWE5NDk1N2UyYS4uMDFmYzIzYmEzMjEzMDU4MDkwYTUzZWQ0 Nzc3NmE5NmZjYzcwODYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy LTEwLTAxICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0d0a10gY3Jhc2ggd2hlbiBhY2NlbGVyYXRlZCBjb21wb3NpdGlvbiBpcyB0dXJu ZWQgb2ZmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODA5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGZy YW1lLT52aWV3KCktPnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKSBtYXkg cmVzZXQgcm9vdAorICAgICAgICBjb21wb3NpdGluZyBsYXllciBpbiBmbHVzaEFuZFJlbmRlckxh eWVycy4gU28sIHdlIGNoZWNrIGlmIGNvbXBvc2l0aW5nCisgICAgICAgIGlzIGVuYWJsZWQgYWZ0 ZXJ3YXJkcywgYW5kIHJldHVybiBpZiBpdCBpcyBub3QuCisKKyAgICAgICAgVGhpcyBidWcgaXMg aGFuZGxlZCBieSBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy90b2dnbGUtY29tcG9zaXRpbmcuaHRt bAorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRl eHRHTC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0 OjpmbHVzaEFuZFJlbmRlckxheWVycyk6CisKIDIwMTItMTAtMDEgIENsYXVkaW8gU2FhdmVkcmEg IDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTYXZlIG9yaWdpbmFsIHVy aSBmb3IgZG93bmxvYWRlZCBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRHTC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEdM LmNwcAppbmRleCBmMWIxMGI5Y2MwNDMyNzU3YzNhMWRlNWNjMTY4NjFmYmZhNmE0ZGRmLi40Y2Ex Y2RhNjE5MjE3MDYwY2JhNTBiOTg1ZDAwOTQ4ZTRmNDUzZmY1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEdM LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENv bXBvc2l0aW5nQ29udGV4dEdMLmNwcApAQCAtMzI5LDE0ICszMjksMTQgQEAgYm9vbCBBY2NlbGVy YXRlZENvbXBvc2l0aW5nQ29udGV4dDo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKCkKIAogdm9p ZCBBY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dDo6Zmx1c2hBbmRSZW5kZXJMYXllcnMoKQog ewotICAgIGlmICghZW5hYmxlZCgpKQotICAgICAgICByZXR1cm47Ci0KICAgICBGcmFtZSogZnJh bWUgPSBjb3JlKG1fd2ViVmlldyktPm1haW5GcmFtZSgpOwogICAgIGlmICghZnJhbWUgfHwgIWZy YW1lLT5jb250ZW50UmVuZGVyZXIoKSB8fCAhZnJhbWUtPnZpZXcoKSkKICAgICAgICAgcmV0dXJu OwogICAgIGZyYW1lLT52aWV3KCktPnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNp dmUoKTsKIAorICAgIGlmICghZW5hYmxlZCgpKQorICAgICAgICByZXR1cm47CisKICAgICBHTENv bnRleHQqIGNvbnRleHQgPSBtX3JlZGlyZWN0ZWRXaW5kb3ctPmNvbnRleHQoKTsKICAgICBpZiAo Y29udGV4dCAmJiAhY29udGV4dC0+bWFrZUNvbnRleHRDdXJyZW50KCkpCiAgICAgICAgIHJldHVy bjsK 166581 2012-10-01 17:33:11 -0700 2012-10-01 18:13:53 -0700 Patch bug-98099-20121001173221.patch text/plain 1773 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggNzExYTRjMTdj MjlhZTFkNzg0YTM1ZmY2ZDdlMmZjNWE5NDk1N2UyYS4uMDFmYzIzYmEzMjEzMDU4MDkwYTUzZWQ0 Nzc3NmE5NmZjYzcwODYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEy LTEwLTAxICBBcm5hdWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0d0a10gY3Jhc2ggd2hlbiBhY2NlbGVyYXRlZCBjb21wb3NpdGlvbiBpcyB0dXJu ZWQgb2ZmCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 ODA5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGZy YW1lLT52aWV3KCktPnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKSBtYXkg cmVzZXQgcm9vdAorICAgICAgICBjb21wb3NpdGluZyBsYXllciBpbiBmbHVzaEFuZFJlbmRlckxh eWVycy4gU28sIHdlIGNoZWNrIGlmIGNvbXBvc2l0aW5nCisgICAgICAgIGlzIGVuYWJsZWQgYWZ0 ZXJ3YXJkcywgYW5kIHJldHVybiBpZiBpdCBpcyBub3QuCisKKyAgICAgICAgVGhpcyBidWcgaXMg aGFuZGxlZCBieSBMYXlvdXRUZXN0cy9jb21wb3NpdGluZy90b2dnbGUtY29tcG9zaXRpbmcuaHRt bAorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRl eHRHTC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdDb250ZXh0 OjpmbHVzaEFuZFJlbmRlckxheWVycyk6CisKIDIwMTItMTAtMDEgIENsYXVkaW8gU2FhdmVkcmEg IDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTYXZlIG9yaWdpbmFsIHVy aSBmb3IgZG93bmxvYWRlZCBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvV2Vi Q29yZVN1cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHRHTC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEdM LmNwcAppbmRleCBmMWIxMGI5Y2MwNDMyNzU3YzNhMWRlNWNjMTY4NjFmYmZhNmE0ZGRmLi5mNTRk MmVjNDhkNDhlZjg5MDFkMDJiYjI4ZjEwMTUyZDViMzczNGMwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dEdM LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENv bXBvc2l0aW5nQ29udGV4dEdMLmNwcApAQCAtMzM3LDYgKzMzNyw5IEBAIHZvaWQgQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ0NvbnRleHQ6OmZsdXNoQW5kUmVuZGVyTGF5ZXJzKCkKICAgICAgICAgcmV0 dXJuOwogICAgIGZyYW1lLT52aWV3KCktPnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1 cnNpdmUoKTsKIAorICAgIGlmICghZW5hYmxlZCgpKQorICAgICAgICByZXR1cm47CisKICAgICBH TENvbnRleHQqIGNvbnRleHQgPSBtX3JlZGlyZWN0ZWRXaW5kb3ctPmNvbnRleHQoKTsKICAgICBp ZiAoY29udGV4dCAmJiAhY29udGV4dC0+bWFrZUNvbnRleHRDdXJyZW50KCkpCiAgICAgICAgIHJl dHVybjsK