98089 2012-10-01 16:16:23 -0700 Missing sys/mman.h include on Mac 2013-01-16 14:41:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Normal --- 0 net147 webkit-unassigned ap darin hausmann webkit.review.bot zeno oldest_to_newest 732098 0 net147 2012-10-01 16:16:23 -0700 Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp needs sys/mman.h include on Mac (see https://bugs.webkit.org/show_bug.cgi?id=97995#c5). 732103 1 166567 net147 2012-10-01 16:18:39 -0700 Created attachment 166567 Patch 733244 2 ap 2012-10-02 17:14:43 -0700 I want to r+ this based on the comment you cited, but I don't understand why the build isn't broken because of this. 733263 3 net147 2012-10-02 17:35:30 -0700 An indirect include from one of the other headers perhaps. 796651 4 hausmann 2012-12-22 00:52:17 -0800 I don't understand why this is needed. The Mac (apple & QT) bots are green. 796665 5 net147 2012-12-22 04:29:01 -0800 (In reply to comment #4) > I don't understand why this is needed. The Mac (apple & QT) bots are green. See https://bugs.webkit.org/show_bug.cgi?id=97995#c5 808708 6 166567 darin 2013-01-16 14:15:41 -0800 Comment on attachment 166567 Patch Eventually we’ll have to figure out a policy for Mac includes. Generally speaking the Mac port works by including certain global includes as part of the prefix, and patches like this are only needed because some other ports are leaving things out of the global prefix. But since we have a "config.h" that is used on all platforms, these could instead be fixed by adding more to the "config.h" or something it includes on those ports. Instead of constantly taking small patches like this one. But I’ll set that aside for now and say r=me 808733 7 166567 webkit.review.bot 2013-01-16 14:41:11 -0800 Comment on attachment 166567 Patch Clearing flags on attachment: 166567 Committed r139926: <http://trac.webkit.org/changeset/139926> 808734 8 webkit.review.bot 2013-01-16 14:41:15 -0800 All reviewed patches have been landed. Closing bug. 166567 2012-10-01 16:18:39 -0700 2013-01-16 14:41:11 -0800 Patch bug-98089.patch text/plain 1109 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwMDk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTEwLTAxICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAg IEFkZCBtaXNzaW5nIHN5cy9tbWFuLmggaW5jbHVkZSBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDg5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG1hZHZpc2UgZnVuY3Rpb24gYW5kIE1B RFZfRlJFRSBjb25zdGFudCByZXF1aXJlIHN5cy9tbWFuLmguCisKKyAgICAgICAgKiBqaXQvRXhl Y3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcDoKKwogMjAxMi0xMC0wMSAgSm9uYXRoYW4g TGl1ICA8bmV0MTQ3QGdtYWlsLmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIHN5cy9tbWFu LmggaW5jbHVkZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs b2NhdG9yRml4ZWRWTVBvb2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAkocmV2aXNpb24gMTMwMDky KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yRml4ZWRW TVBvb2wuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiwxMCBAQAogI2luY2x1ZGUgPHd0 Zi9QYWdlUmVzZXJ2YXRpb24uaD4KICNpbmNsdWRlIDx3dGYvVk1UYWdzLmg+CiAKKyNpZiBPUyhE QVJXSU4pCisjaW5jbHVkZSA8c3lzL21tYW4uaD4KKyNlbmRpZgorCiAjaWYgT1MoTElOVVgpCiAj aW5jbHVkZSA8c3RkaW8uaD4KICNlbmRpZgo=