98080 2012-10-01 15:18:57 -0700 Address a FIXME in JSArray::sort 2017-04-13 08:49:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=97603 InRadar P2 Normal --- 1 fpizlo fpizlo barraclough bfulgham ggaren mhahnenberg msaboff oliver sam webkit.review.bot oldest_to_newest 732041 0 fpizlo 2012-10-01 15:18:57 -0700 And get rid of fast sorting of sparse maps. Patch forthcoming. 732058 1 166560 fpizlo 2012-10-01 15:37:12 -0700 Created attachment 166560 the patch 732062 2 webkit.review.bot 2012-10-01 15:38:59 -0700 Attachment 166560 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/runtime/JSArray.cpp:873: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style. 732176 3 fpizlo 2012-10-01 18:05:37 -0700 Landed in http://trac.webkit.org/changeset/130102 1296999 4 bfulgham 2017-04-13 08:47:46 -0700 <rdar://problem/12407844> 166560 2012-10-01 15:37:12 -0700 2012-10-01 15:50:40 -0700 the patch fixarray.patch text/plain 15179 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwMDgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDEyLTEwLTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QWRkcmVzcyBhIEZJWE1FIGluIEpTQXJyYXk6OnNvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDgwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x MjQwNzg0ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBHZXQgcmlkIG9mIGZhc3Qgc29ydGluZyBvZiBzcGFyc2UgbWFwcy4gSSBkb24ndCBrbm93IHRo YXQgaXQncyBicm9rZW4gYnV0IEkgZG8ga25vdyB0aGF0IHdlIGRvbid0CisgICAgICAgIGhhdmUg Y292ZXJhZ2UgZm9yIGl0LiBUaGVuIGFsc28gYWRkcmVzcyB0aGUgRklYTUUgaW4gSlNBcnJheTo6 c29ydCByZWdhcmRpbmcgc2lkZS1lZmZlY3RpbmcKKyAgICAgICAgY29tcGFyZSBmdW5jdGlvbnMu CisKKyAgICAgICAgKiBydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6 YXJyYXlQcm90b0Z1bmNTb3J0KToKKyAgICAgICAgKiBydW50aW1lL0pTQXJyYXkuY3BwOgorICAg ICAgICAoSlNDOjpKU0FycmF5Ojpzb3J0TnVtZXJpYyk6CisgICAgICAgIChKU0M6OkpTQXJyYXk6 OnNvcnQpOgorICAgICAgICAoSlNDOjpKU0FycmF5Ojpjb21wYWN0Rm9yU29ydGluZyk6CisgICAg ICAgICogcnVudGltZS9KU0FycmF5Lmg6CisgICAgICAgIChKU0FycmF5KToKKyAgICAgICAgKiBy dW50aW1lL0pTT2JqZWN0Lmg6CisgICAgICAgIChKU0M6OkpTT2JqZWN0OjpoYXNTcGFyc2VNYXAp OgorICAgICAgICAoSlNPYmplY3QpOgorCiAyMDEyLTEwLTAxICBKb25hdGhhbiBMaXUgIDxuZXQx NDdAZ21haWwuY29tPgogCiAgICAgICAgIFJlbW92ZSB1bnVzZWQgc3lzL21tYW4uaCBpbmNsdWRl CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5 cGUuY3BwCShyZXZpc2lvbiAxMzAwNzcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9BcnJheVByb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1NSw3ICs2NTUsNyBAQCBF bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9GCiAgICAgQ2FsbERhdGEgY2Fs bERhdGE7CiAgICAgQ2FsbFR5cGUgY2FsbFR5cGUgPSBnZXRDYWxsRGF0YShmdW5jdGlvbiwgY2Fs bERhdGEpOwogCi0gICAgaWYgKHRoaXNPYmotPmNsYXNzSW5mbygpID09ICZKU0FycmF5OjpzX2lu Zm8gJiYgIWFzQXJyYXkodGhpc09iaiktPmluU3BhcnNlSW5kZXhpbmdNb2RlKCkgJiYgIXNob3Vs ZFVzZVNsb3dQdXQodGhpc09iai0+c3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpKSkgeworICAg IGlmICh0aGlzT2JqLT5jbGFzc0luZm8oKSA9PSAmSlNBcnJheTo6c19pbmZvICYmICFhc0FycmF5 KHRoaXNPYmopLT5oYXNTcGFyc2VNYXAoKSAmJiAhc2hvdWxkVXNlU2xvd1B1dCh0aGlzT2JqLT5z dHJ1Y3R1cmUoKS0+aW5kZXhpbmdUeXBlKCkpKSB7CiAgICAgICAgIGlmIChpc051bWVyaWNDb21w YXJlRnVuY3Rpb24oZXhlYywgY2FsbFR5cGUsIGNhbGxEYXRhKSkKICAgICAgICAgICAgIGFzQXJy YXkodGhpc09iaiktPnNvcnROdW1lcmljKGV4ZWMsIGZ1bmN0aW9uLCBjYWxsVHlwZSwgY2FsbERh dGEpOwogICAgICAgICBlbHNlIGlmIChjYWxsVHlwZSAhPSBDYWxsVHlwZU5vbmUpCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmNwcAkocmV2aXNpb24gMTMwMDc3 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTYwMSwxMyArNjAxLDEwIEBAIHZvaWQgSlNBcnJheTo6c29ydE51bWVyaWMoRXhl Y1N0YXRlKiBleGUKICAgICAgICAgcmV0dXJuOwogICAgICAgICAKICAgICBjYXNlIEFycmF5V2l0 aEFycmF5U3RvcmFnZTogewotICAgICAgICB1bnNpZ25lZCBsZW5ndGhOb3RJbmNsdWRpbmdVbmRl ZmluZWQgPSBjb21wYWN0Rm9yU29ydGluZyhleGVjLT5nbG9iYWxEYXRhKCkpOworICAgICAgICB1 bnNpZ25lZCBsZW5ndGhOb3RJbmNsdWRpbmdVbmRlZmluZWQgPSBjb21wYWN0Rm9yU29ydGluZygp OwogICAgICAgICBBcnJheVN0b3JhZ2UqIHN0b3JhZ2UgPSBtX2J1dHRlcmZseS0+YXJyYXlTdG9y YWdlKCk7Ci0gICAgICAgIAotICAgICAgICBpZiAoc3RvcmFnZS0+bV9zcGFyc2VNYXAuZ2V0KCkp IHsKLSAgICAgICAgICAgIHRocm93T3V0T2ZNZW1vcnlFcnJvcihleGVjKTsKLSAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgfQorCisgICAgICAgIEFTU0VSVCghc3RvcmFnZS0+bV9zcGFyc2VN YXApOwogICAgICAgICAKICAgICAgICAgaWYgKCFsZW5ndGhOb3RJbmNsdWRpbmdVbmRlZmluZWQp CiAgICAgICAgICAgICByZXR1cm47CkBAIC02NDYsMTIgKzY0Myw5IEBAIHZvaWQgSlNBcnJheTo6 c29ydChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgIHJldHVybjsKICAgICAgICAgCiAgICAgY2Fz ZSBBcnJheVdpdGhBcnJheVN0b3JhZ2U6IHsKLSAgICAgICAgdW5zaWduZWQgbGVuZ3RoTm90SW5j bHVkaW5nVW5kZWZpbmVkID0gY29tcGFjdEZvclNvcnRpbmcoZXhlYy0+Z2xvYmFsRGF0YSgpKTsK KyAgICAgICAgdW5zaWduZWQgbGVuZ3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkID0gY29tcGFjdEZv clNvcnRpbmcoKTsKICAgICAgICAgQXJyYXlTdG9yYWdlKiBzdG9yYWdlID0gbV9idXR0ZXJmbHkt PmFycmF5U3RvcmFnZSgpOwotICAgICAgICBpZiAoc3RvcmFnZS0+bV9zcGFyc2VNYXAuZ2V0KCkp IHsKLSAgICAgICAgICAgIHRocm93T3V0T2ZNZW1vcnlFcnJvcihleGVjKTsKLSAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgfQorICAgICAgICBBU1NFUlQoIXN0b3JhZ2UtPm1fc3BhcnNlTWFw KTsKICAgICAgICAgCiAgICAgICAgIGlmICghbGVuZ3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkKQog ICAgICAgICAgICAgcmV0dXJuOwpAQCAtODExLDE4ICs4MDUsMTcgQEAgdm9pZCBKU0FycmF5Ojpz b3J0KEV4ZWNTdGF0ZSogZXhlYywgSlNWYQogICAgICAgICByZXR1cm47CiAgICAgICAgIAogICAg IGNhc2UgQXJyYXlXaXRoQXJyYXlTdG9yYWdlOiB7Ci0gICAgICAgIEFycmF5U3RvcmFnZSogc3Rv cmFnZSA9IG1fYnV0dGVyZmx5LT5hcnJheVN0b3JhZ2UoKTsKLSAgICAgICAgCiAgICAgICAgIC8v IEZJWE1FOiBUaGlzIGlnbm9yZXMgZXhjZXB0aW9ucyByYWlzZWQgaW4gdGhlIGNvbXBhcmUgZnVu Y3Rpb24gb3IgaW4gdG9OdW1iZXIuCiAgICAgICAgIAogICAgICAgICAvLyBUaGUgbWF4aW11bSB0 cmVlIGRlcHRoIGlzIGNvbXBpbGVkIGluIC0gYnV0IHRoZSBjYWxsZXIgaXMgY2xlYXJseSB1cCB0 byBubyBnb29kCiAgICAgICAgIC8vIGlmIGEgbGFyZ2VyIGFycmF5IGlzIHBhc3NlZC4KLSAgICAg ICAgQVNTRVJUKHN0b3JhZ2UtPmxlbmd0aCgpIDw9IHN0YXRpY19jYXN0PHVuc2lnbmVkPihzdGQ6 Om51bWVyaWNfbGltaXRzPGludD46Om1heCgpKSk7Ci0gICAgICAgIGlmIChzdG9yYWdlLT5sZW5n dGgoKSA+IHN0YXRpY19jYXN0PHVuc2lnbmVkPihzdGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1h eCgpKSkKKyAgICAgICAgQVNTRVJUKGFycmF5U3RvcmFnZSgpLT5sZW5ndGgoKSA8PSBzdGF0aWNf Y2FzdDx1bnNpZ25lZD4oc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptYXgoKSkpOworICAgICAg ICBpZiAoYXJyYXlTdG9yYWdlKCktPmxlbmd0aCgpID4gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHN0 ZDo6bnVtZXJpY19saW1pdHM8aW50Pjo6bWF4KCkpKQogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICAKLSAgICAgICAgdW5zaWduZWQgdXNlZFZlY3Rvckxlbmd0aCA9IG1pbihzdG9yYWdlLT5s ZW5ndGgoKSwgc3RvcmFnZS0+dmVjdG9yTGVuZ3RoKCkpOwotICAgICAgICB1bnNpZ25lZCBub2Rl Q291bnQgPSB1c2VkVmVjdG9yTGVuZ3RoICsgKHN0b3JhZ2UtPm1fc3BhcnNlTWFwID8gc3RvcmFn ZS0+bV9zcGFyc2VNYXAtPnNpemUoKSA6IDApOworICAgICAgICB1bnNpZ25lZCB1c2VkVmVjdG9y TGVuZ3RoID0gbWluKGFycmF5U3RvcmFnZSgpLT5sZW5ndGgoKSwgYXJyYXlTdG9yYWdlKCktPnZl Y3Rvckxlbmd0aCgpKTsKKyAgICAgICAgQVNTRVJUKCFhcnJheVN0b3JhZ2UoKS0+bV9zcGFyc2VN YXApOworICAgICAgICB1bnNpZ25lZCBub2RlQ291bnQgPSB1c2VkVmVjdG9yTGVuZ3RoOwogICAg ICAgICAKICAgICAgICAgaWYgKCFub2RlQ291bnQpCiAgICAgICAgICAgICByZXR1cm47CkBAIC04 NTAsMTQgKzg0MywxOCBAQCB2b2lkIEpTQXJyYXk6OnNvcnQoRXhlY1N0YXRlKiBleGVjLCBKU1Zh CiAgICAgICAgIAogICAgICAgICAvLyBJdGVyYXRlIG92ZXIgdGhlIGFycmF5LCBpZ25vcmluZyBt aXNzaW5nIHZhbHVlcywgY291bnRpbmcgdW5kZWZpbmVkIG9uZXMsIGFuZCBpbnNlcnRpbmcgYWxs IG90aGVyIG9uZXMgaW50byB0aGUgdHJlZS4KICAgICAgICAgZm9yICg7IG51bURlZmluZWQgPCB1 c2VkVmVjdG9yTGVuZ3RoOyArK251bURlZmluZWQpIHsKLSAgICAgICAgICAgIEpTVmFsdWUgdiA9 IHN0b3JhZ2UtPm1fdmVjdG9yW251bURlZmluZWRdLmdldCgpOworICAgICAgICAgICAgaWYgKG51 bURlZmluZWQgPiBhcnJheVN0b3JhZ2UoKS0+dmVjdG9yTGVuZ3RoKCkpCisgICAgICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgICAgICBKU1ZhbHVlIHYgPSBhcnJheVN0b3JhZ2UoKS0+bV92ZWN0 b3JbbnVtRGVmaW5lZF0uZ2V0KCk7CiAgICAgICAgICAgICBpZiAoIXYgfHwgdi5pc1VuZGVmaW5l ZCgpKQogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgdHJlZS5hYnN0cmFjdG9y KCkubV9ub2Rlc1tudW1EZWZpbmVkXS52YWx1ZSA9IHY7CiAgICAgICAgICAgICB0cmVlLmluc2Vy dChudW1EZWZpbmVkKTsKICAgICAgICAgfQogICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBudW1E ZWZpbmVkOyBpIDwgdXNlZFZlY3Rvckxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICBKU1ZhbHVl IHYgPSBzdG9yYWdlLT5tX3ZlY3RvcltpXS5nZXQoKTsKKyAgICAgICAgICAgIGlmIChpID4gYXJy YXlTdG9yYWdlKCktPnZlY3Rvckxlbmd0aCgpKQorICAgICAgICAgICAgICAgIGJyZWFrOworICAg ICAgICAgICAgSlNWYWx1ZSB2ID0gYXJyYXlTdG9yYWdlKCktPm1fdmVjdG9yW2ldLmdldCgpOwog ICAgICAgICAgICAgaWYgKHYpIHsKICAgICAgICAgICAgICAgICBpZiAodi5pc1VuZGVmaW5lZCgp KQogICAgICAgICAgICAgICAgICAgICArK251bVVuZGVmaW5lZDsKQEAgLTg3MSw1MSArODY4LDM0 IEBAIHZvaWQgSlNBcnJheTo6c29ydChFeGVjU3RhdGUqIGV4ZWMsIEpTVmEKICAgICAgICAgCiAg ICAgICAgIHVuc2lnbmVkIG5ld1VzZWRWZWN0b3JMZW5ndGggPSBudW1EZWZpbmVkICsgbnVtVW5k ZWZpbmVkOwogICAgICAgICAKLSAgICAgICAgaWYgKFNwYXJzZUFycmF5VmFsdWVNYXAqIG1hcCA9 IHN0b3JhZ2UtPm1fc3BhcnNlTWFwLmdldCgpKSB7Ci0gICAgICAgICAgICBuZXdVc2VkVmVjdG9y TGVuZ3RoICs9IG1hcC0+c2l6ZSgpOwotICAgICAgICAgICAgaWYgKG5ld1VzZWRWZWN0b3JMZW5n dGggPiBzdG9yYWdlLT52ZWN0b3JMZW5ndGgoKSkgewotICAgICAgICAgICAgICAgIC8vIENoZWNr IHRoYXQgaXQgaXMgcG9zc2libGUgdG8gYWxsb2NhdGUgYW4gYXJyYXkgbGFyZ2UgZW5vdWdoIHRv IGhvbGQgYWxsIHRoZSBlbnRyaWVzLgotICAgICAgICAgICAgICAgIGlmICgobmV3VXNlZFZlY3Rv ckxlbmd0aCA+IE1BWF9TVE9SQUdFX1ZFQ1RPUl9MRU5HVEgpIHx8ICFpbmNyZWFzZVZlY3Rvckxl bmd0aChleGVjLT5nbG9iYWxEYXRhKCksIG5ld1VzZWRWZWN0b3JMZW5ndGgpKSB7Ci0gICAgICAg ICAgICAgICAgICAgIHRocm93T3V0T2ZNZW1vcnlFcnJvcihleGVjKTsKLSAgICAgICAgICAgICAg ICAgICAgcmV0dXJuOwotICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICBzdG9yYWdl ID0gbV9idXR0ZXJmbHktPmFycmF5U3RvcmFnZSgpOwotICAgICAgICAgICAgfQotICAgICAgICAg ICAgCi0gICAgICAgICAgICBTcGFyc2VBcnJheVZhbHVlTWFwOjpjb25zdF9pdGVyYXRvciBlbmQg PSBtYXAtPmVuZCgpOwotICAgICAgICAgICAgZm9yIChTcGFyc2VBcnJheVZhbHVlTWFwOjpjb25z dF9pdGVyYXRvciBpdCA9IG1hcC0+YmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7Ci0gICAgICAg ICAgICAgICAgdHJlZS5hYnN0cmFjdG9yKCkubV9ub2Rlc1tudW1EZWZpbmVkXS52YWx1ZSA9IGl0 LT5zZWNvbmQuZ2V0Tm9uU3BhcnNlTW9kZSgpOwotICAgICAgICAgICAgICAgIHRyZWUuaW5zZXJ0 KG51bURlZmluZWQpOwotICAgICAgICAgICAgICAgICsrbnVtRGVmaW5lZDsKLSAgICAgICAgICAg IH0KLSAgICAgICAgICAgIAotICAgICAgICAgICAgZGVhbGxvY2F0ZVNwYXJzZUluZGV4TWFwKCk7 Ci0gICAgICAgIH0KKyAgICAgICAgQVNTRVJUKCFhcnJheVN0b3JhZ2UoKS0+bV9zcGFyc2VNYXAp OwogICAgICAgICAKLSAgICAgICAgQVNTRVJUKHRyZWUuYWJzdHJhY3RvcigpLm1fbm9kZXMuc2l6 ZSgpID49IG51bURlZmluZWQpOworICAgICAgICAvLyBUaGUgYXJyYXkgc2l6ZSBtYXkgaGF2ZSBj aGFuZ2VkLiAgRmlndXJlIG91dCB0aGUgbmV3IGJvdW5kcy4KKyAgICAgICAgdW5zaWduZWQgbmV3 ZXN0VXNlZFZlY3Rvckxlbmd0aCA9IG1pbihhcnJheVN0b3JhZ2UoKS0+bGVuZ3RoKCksIGFycmF5 U3RvcmFnZSgpLT52ZWN0b3JMZW5ndGgoKSk7CiAgICAgICAgIAotICAgICAgICAvLyBGSVhNRTog SWYgdGhlIGNvbXBhcmUgZnVuY3Rpb24gY2hhbmdlZCB0aGUgbGVuZ3RoIG9mIHRoZSBhcnJheSwg dGhlIGZvbGxvd2luZyBtaWdodCBiZQotICAgICAgICAvLyBtb2RpZnlpbmcgdGhlIHZlY3RvciBp bmNvcnJlY3RseS4KKyAgICAgICAgdW5zaWduZWQgZWxlbWVudHNUb0V4dHJhY3RUaHJlc2hvbGQg PSBtaW4obWluKG5ld2VzdFVzZWRWZWN0b3JMZW5ndGgsIG51bURlZmluZWQpLCBzdGF0aWNfY2Fz dDx1bnNpZ25lZD4odHJlZS5hYnN0cmFjdG9yKCkubV9ub2Rlcy5zaXplKCkpKTsKKyAgICAgICAg dW5zaWduZWQgdW5kZWZpbmVkRWxlbWVudHNUaHJlc2hvbGQgPSBtaW4obmV3ZXN0VXNlZFZlY3Rv ckxlbmd0aCwgbmV3VXNlZFZlY3Rvckxlbmd0aCk7CisgICAgICAgIHVuc2lnbmVkIGNsZWFyRWxl bWVudHNUaHJlc2hvbGQgPSBtaW4obmV3ZXN0VXNlZFZlY3Rvckxlbmd0aCwgdXNlZFZlY3Rvckxl bmd0aCk7CiAgICAgICAgIAogICAgICAgICAvLyBDb3B5IHRoZSB2YWx1ZXMgYmFjayBpbnRvIG1f c3RvcmFnZS4KICAgICAgICAgQVZMVHJlZTxBVkxUcmVlQWJzdHJhY3RvckZvckFycmF5Q29tcGFy ZSwgNDQ+OjpJdGVyYXRvciBpdGVyOwogICAgICAgICBpdGVyLnN0YXJ0X2l0ZXJfbGVhc3QodHJl ZSk7CiAgICAgICAgIEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSA9IGV4ZWMtPmdsb2JhbERhdGEo KTsKLSAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG51bURlZmluZWQ7ICsraSkgewot ICAgICAgICAgICAgc3RvcmFnZS0+bV92ZWN0b3JbaV0uc2V0KGdsb2JhbERhdGEsIHRoaXMsIHRy ZWUuYWJzdHJhY3RvcigpLm1fbm9kZXNbKml0ZXJdLnZhbHVlKTsKKyAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IGVsZW1lbnRzVG9FeHRyYWN0VGhyZXNob2xkOyArK2kpIHsKKyAgICAg ICAgICAgIGFycmF5U3RvcmFnZSgpLT5tX3ZlY3RvcltpXS5zZXQoZ2xvYmFsRGF0YSwgdGhpcywg dHJlZS5hYnN0cmFjdG9yKCkubV9ub2Rlc1sqaXRlcl0udmFsdWUpOwogICAgICAgICAgICAgKytp dGVyOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICAvLyBQdXQgdW5kZWZpbmVkIHZhbHVl cyBiYWNrIGluLgotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBudW1EZWZpbmVkOyBpIDwgbmV3 VXNlZFZlY3Rvckxlbmd0aDsgKytpKQotICAgICAgICAgICAgc3RvcmFnZS0+bV92ZWN0b3JbaV0u c2V0VW5kZWZpbmVkKCk7Ci0gICAgICAgIAorICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBlbGVt ZW50c1RvRXh0cmFjdFRocmVzaG9sZDsgaSA8IHVuZGVmaW5lZEVsZW1lbnRzVGhyZXNob2xkOyAr K2kpCisgICAgICAgICAgICBhcnJheVN0b3JhZ2UoKS0+bV92ZWN0b3JbaV0uc2V0VW5kZWZpbmVk KCk7CisKICAgICAgICAgLy8gRW5zdXJlIHRoYXQgdW51c2VkIHZhbHVlcyBpbiB0aGUgdmVjdG9y IGFyZSB6ZXJvZWQgb3V0LgotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBuZXdVc2VkVmVjdG9y TGVuZ3RoOyBpIDwgdXNlZFZlY3Rvckxlbmd0aDsgKytpKQotICAgICAgICAgICAgc3RvcmFnZS0+ bV92ZWN0b3JbaV0uY2xlYXIoKTsKLSAgICAgICAgCi0gICAgICAgIHN0b3JhZ2UtPm1fbnVtVmFs dWVzSW5WZWN0b3IgPSBuZXdVc2VkVmVjdG9yTGVuZ3RoOworICAgICAgICBmb3IgKHVuc2lnbmVk IGkgPSB1bmRlZmluZWRFbGVtZW50c1RocmVzaG9sZDsgaSA8IGNsZWFyRWxlbWVudHNUaHJlc2hv bGQ7ICsraSkKKyAgICAgICAgICAgIGFycmF5U3RvcmFnZSgpLT5tX3ZlY3RvcltpXS5jbGVhcigp OwogICAgICAgICAKKyAgICAgICAgYXJyYXlTdG9yYWdlKCktPm1fbnVtVmFsdWVzSW5WZWN0b3Ig PSB1bmRlZmluZWRFbGVtZW50c1RocmVzaG9sZDsKKwogICAgICAgICByZXR1cm47CiAgICAgfQog ICAgICAgICAKQEAgLTk4Miw3ICs5NjIsNyBAQCB2b2lkIEpTQXJyYXk6OmNvcHlUb0FyZ3VtZW50 cyhFeGVjU3RhdGUqCiAgICAgfQogfQogCi11bnNpZ25lZCBKU0FycmF5Ojpjb21wYWN0Rm9yU29y dGluZyhKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEpCit1bnNpZ25lZCBKU0FycmF5Ojpjb21wYWN0 Rm9yU29ydGluZygpCiB7CiAgICAgQVNTRVJUKCFpblNwYXJzZUluZGV4aW5nTW9kZSgpKTsKIApA QCAtMTAxNiwyMyArOTk2LDcgQEAgdW5zaWduZWQgSlNBcnJheTo6Y29tcGFjdEZvclNvcnRpbmco SlNHbAogICAgICAgICAKICAgICAgICAgdW5zaWduZWQgbmV3VXNlZFZlY3Rvckxlbmd0aCA9IG51 bURlZmluZWQgKyBudW1VbmRlZmluZWQ7CiAgICAgICAgIAotICAgICAgICBpZiAoU3BhcnNlQXJy YXlWYWx1ZU1hcCogbWFwID0gc3RvcmFnZS0+bV9zcGFyc2VNYXAuZ2V0KCkpIHsKLSAgICAgICAg ICAgIG5ld1VzZWRWZWN0b3JMZW5ndGggKz0gbWFwLT5zaXplKCk7Ci0gICAgICAgICAgICBpZiAo bmV3VXNlZFZlY3Rvckxlbmd0aCA+IHN0b3JhZ2UtPnZlY3Rvckxlbmd0aCgpKSB7Ci0gICAgICAg ICAgICAgICAgLy8gQ2hlY2sgdGhhdCBpdCBpcyBwb3NzaWJsZSB0byBhbGxvY2F0ZSBhbiBhcnJh eSBsYXJnZSBlbm91Z2ggdG8gaG9sZCBhbGwgdGhlIGVudHJpZXMgLSBpZiBub3QsCi0gICAgICAg ICAgICAgICAgLy8gZXhjZXB0aW9uIGlzIHRocm93biBieSBjYWxsZXIuCi0gICAgICAgICAgICAg ICAgaWYgKChuZXdVc2VkVmVjdG9yTGVuZ3RoID4gTUFYX1NUT1JBR0VfVkVDVE9SX0xFTkdUSCkg fHwgIWluY3JlYXNlVmVjdG9yTGVuZ3RoKGdsb2JhbERhdGEsIG5ld1VzZWRWZWN0b3JMZW5ndGgp KQotICAgICAgICAgICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgICAgICAgICAKLSAgICAg ICAgICAgICAgICBzdG9yYWdlID0gbV9idXR0ZXJmbHktPmFycmF5U3RvcmFnZSgpOwotICAgICAg ICAgICAgfQotICAgICAgICAgICAgCi0gICAgICAgICAgICBTcGFyc2VBcnJheVZhbHVlTWFwOjpj b25zdF9pdGVyYXRvciBlbmQgPSBtYXAtPmVuZCgpOwotICAgICAgICAgICAgZm9yIChTcGFyc2VB cnJheVZhbHVlTWFwOjpjb25zdF9pdGVyYXRvciBpdCA9IG1hcC0+YmVnaW4oKTsgaXQgIT0gZW5k OyArK2l0KQotICAgICAgICAgICAgICAgIHN0b3JhZ2UtPm1fdmVjdG9yW251bURlZmluZWQrK10u c2V0V2l0aG91dFdyaXRlQmFycmllcihpdC0+c2Vjb25kLmdldE5vblNwYXJzZU1vZGUoKSk7Ci0g ICAgICAgICAgICAKLSAgICAgICAgICAgIGRlYWxsb2NhdGVTcGFyc2VJbmRleE1hcCgpOwotICAg ICAgICB9CisgICAgICAgIEFTU0VSVCghc3RvcmFnZS0+bV9zcGFyc2VNYXApOwogICAgICAgICAK ICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gbnVtRGVmaW5lZDsgaSA8IG5ld1VzZWRWZWN0b3JM ZW5ndGg7ICsraSkKICAgICAgICAgICAgIHN0b3JhZ2UtPm1fdmVjdG9yW2ldLnNldFVuZGVmaW5l ZCgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuaAkocmV2aXNp b24gMTMwMDc3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDMsNyArMTAzLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAg ICAgYm9vbCB1bnNoaWZ0Q291bnRTbG93Q2FzZShKU0dsb2JhbERhdGEmLCBib29sLCB1bnNpZ25l ZCk7CiAgICAgICAgIAotICAgICAgICB1bnNpZ25lZCBjb21wYWN0Rm9yU29ydGluZyhKU0dsb2Jh bERhdGEmKTsKKyAgICAgICAgdW5zaWduZWQgY29tcGFjdEZvclNvcnRpbmcoKTsKICAgICB9Owog CiAgICAgaW5saW5lIEJ1dHRlcmZseSogY3JlYXRlQXJyYXlCdXR0ZXJmbHkoSlNHbG9iYWxEYXRh JiBnbG9iYWxEYXRhLCB1bnNpZ25lZCBpbml0aWFsTGVuZ3RoKQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCShyZXZpc2lvbiAxMzAwNzcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMjcs NiArMzI3LDE5IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgfQogICAgICAgICB9CiAg ICAgICAgIAorICAgICAgICBib29sIGhhc1NwYXJzZU1hcCgpCisgICAgICAgIHsKKyAgICAgICAg ICAgIHN3aXRjaCAoc3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpKSB7CisgICAgICAgICAgICBj YXNlIEFMTF9CTEFOS19JTkRFWElOR19UWVBFUzoKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CisgICAgICAgICAgICBjYXNlIEFMTF9BUlJBWV9TVE9SQUdFX0lOREVYSU5HX1RZUEVTOgor ICAgICAgICAgICAgICAgIHJldHVybiBtX2J1dHRlcmZseS0+YXJyYXlTdG9yYWdlKCktPm1fc3Bh cnNlTWFwOworICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgICAgICB9 CisgICAgICAgIH0KKyAgICAgICAgCiAgICAgICAgIGJvb2wgaW5TcGFyc2VJbmRleGluZ01vZGUo KQogICAgICAgICB7CiAgICAgICAgICAgICBzd2l0Y2ggKHN0cnVjdHVyZSgpLT5pbmRleGluZ1R5 cGUoKSkgewpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwMDg0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMDEgIEZpbGlwIFBp emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBBZGRyZXNzIGEgRklYTUUgaW4gSlNB cnJheTo6c29ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTgwODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyNDA3ODQ0PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9qcy9qc2MtdGVzdC1s aXN0OgorICAgICAgICAqIGZhc3QvanMvc2NyaXB0LXRlc3RzL3NvcnQtd2l0aC1zaWRlLWVmZmVj dGluZy1jb21wYXJpc29ucy5qczogQWRkZWQuCisgICAgICAgICogZmFzdC9qcy9zb3J0LXdpdGgt c2lkZS1lZmZlY3RpbmctY29tcGFyaXNvbnMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2pzL3NvcnQtd2l0aC1zaWRlLWVmZmVjdGluZy1jb21wYXJpc29ucy5odG1sOiBBZGRl ZC4KKwogMjAxMi0xMC0wMSAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFNldCB0aGUgbGluZS1oZWlnaHQgb2YgdGhlIGJvZHkgdG8gMCB0byBtYWtlIHRoaXMgdGVz dCBub3QgYmUgdGV4dCByZW5kZXJpbmcgZGVwZW5kZW50LgpJbmRleDogTGF5b3V0VGVzdHMvZmFz dC9qcy9qc2MtdGVzdC1saXN0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvanNj LXRlc3QtbGlzdAkocmV2aXNpb24gMTMwMDc3KQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9qc2Mt dGVzdC1saXN0CSh3b3JraW5nIGNvcHkpCkBAIC0yOTcsNiArMjk3LDcgQEAgZmFzdC9qcy9zb3J0 LW5vLWppdC1jb2RlLWNyYXNoCiBmYXN0L2pzL3NvcnQtbm9uLW51bWJlcnMKIGZhc3QvanMvc29y dC1yYW5kb21seQogZmFzdC9qcy9zb3J0LXN0YWJpbGl0eQorZmFzdC9qcy9zb3J0LXdpdGgtc2lk ZS1lZmZlY3RpbmctY29tcGFyaXNvbnMKIGZhc3QvanMvc3BhcnNlLWFycmF5CiBmYXN0L2pzL3N0 YWNrLW92ZXJmbG93LWFycml0eS1jYXRjaAogZmFzdC9qcy9zdGFjay1vdmVyZmxvdy1jYXRjaApJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9zb3J0LXdpdGgtc2lkZS1lZmZlY3RpbmctY29tcGFy aXNvbnMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvc29y dC13aXRoLXNpZGUtZWZmZWN0aW5nLWNvbXBhcmlzb25zLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvc29ydC13aXRoLXNpZGUtZWZmZWN0aW5nLWNvbXBh cmlzb25zLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAorQ2hlY2tz IHRoYXQgc29ydGluZyBhbiBhcnJheSB3aXRoIGEgc2lkZS1lZmZlY3RpbmcgY29tcGFyaXNvbiBm dW5jdGlvbiBkb2Vzbid0IHRyaWdnZXIgYXNzZXJ0aW9ucy4KKworT24gc3VjY2VzcywgeW91IHdp bGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09N UExFVEUiLgorCisKK1BBU1MgSXQgd29ya2VkLgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg dHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvc29ydC13 aXRoLXNpZGUtZWZmZWN0aW5nLWNvbXBhcmlzb25zLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC9qcy9zb3J0LXdpdGgtc2lkZS1lZmZlY3RpbmctY29tcGFyaXNvbnMuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvc29ydC13aXRoLXNpZGUtZWZmZWN0 aW5nLWNvbXBhcmlzb25zLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9zb3J0LXdpdGgtc2lkZS1lZmZl Y3RpbmctY29tcGFyaXNvbnMuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9q cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvc29ydC13aXRoLXNpZGUtZWZmZWN0aW5nLWNvbXBh cmlzb25zLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3Rz L3NvcnQtd2l0aC1zaWRlLWVmZmVjdGluZy1jb21wYXJpc29ucy5qcwkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvanMvc2NyaXB0LXRlc3RzL3NvcnQtd2l0aC1zaWRlLWVmZmVjdGlu Zy1jb21wYXJpc29ucy5qcwkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyMSBAQAorZGVzY3JpcHRp b24oCisiQ2hlY2tzIHRoYXQgc29ydGluZyBhbiBhcnJheSB3aXRoIGEgc2lkZS1lZmZlY3Rpbmcg Y29tcGFyaXNvbiBmdW5jdGlvbiBkb2Vzbid0IHRyaWdnZXIgYXNzZXJ0aW9ucy4iCispOworCit2 YXIgYXJyYXkgPSBbXTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAyMDAwMDsgKytpKQorICAgIGFy cmF5LnB1c2goaSk7CisKK2FycmF5LnNvcnQoZnVuY3Rpb24oYSwgYikgeworICAgIGFycmF5LnNo aWZ0KCk7CisgICAgaWYgKGEgPCBiKQorICAgICAgICByZXR1cm4gLTE7CisgICAgaWYgKGEgPiBi KQorICAgICAgICByZXR1cm4gMTsKKyAgICByZXR1cm4gMDsKK30pOworCit0ZXN0UGFzc2VkKCJJ dCB3b3JrZWQuIik7CisKKwo=