9808 2006-07-09 11:02:11 -0700 REGRESSION: Incorrect layout (and ERROR) when forcing ATSU For All Text 2006-07-10 09:13:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 48929 0 mitz 2006-07-09 11:02:11 -0700 To reproduce this bug, open the attached test case, choose Use ATSU For All Text from Safari's Debug menu and reload the page. Notice that the layout changes (the line breaks after Lorem) and if you are using a debug build, an error will be printed: ERROR: unexpected result from ATSUGetGlyphBounds(): actualNumBounds(389998136) != 1 48930 1 9299 mitz 2006-07-09 11:02:47 -0700 Created attachment 9299 Test case 48932 2 9300 mitz 2006-07-09 11:18:33 -0700 Created attachment 9300 Patch with manual test and changelog 48994 3 9300 darin 2006-07-09 17:37:24 -0700 Comment on attachment 9300 Patch with manual test and changelog Will this extra check have a measurable performance impact? If not, then r=me, but how can we be sure? 49054 4 9300 mitz 2006-07-09 23:26:58 -0700 Comment on attachment 9300 Patch with manual test and changelog Going to play it safe performance-wise and move the check into the complex path where it matters. 49102 5 9341 mitz 2006-07-10 07:46:26 -0700 Created attachment 9341 Patch Move the empty run check down into floatWidthForComplexText() 49110 6 9341 darin 2006-07-10 08:29:23 -0700 Comment on attachment 9341 Patch r=me Even better if there was a comment explaining that this is not just an optimization, but required for correct results, but the layout test should suffice. 49117 7 darin 2006-07-10 09:13:38 -0700 Committed revision 15305. 9299 2006-07-09 11:02:47 -0700 2006-07-09 11:02:47 -0700 Test case ATSUI regression.html text/html 126 mitz PGRpdiBzdHlsZT0id2lkdGg6IDUwMDsgYm9yZGVyOiBzb2xpZCBibHVlOyI+CjxzcGFuPkxvcmVt PC9zcGFuPiBpcHN1bQo8L2Rpdj4KQ2hvb3NlIDxpPlVzZSBBVFNVIEZvciBBbGwgVGV4dDwvaT4g YW5kIHJlbG9hZC4K 9300 2006-07-09 11:18:33 -0700 2006-07-09 23:26:58 -0700 Patch with manual test and changelog 9808_r1.patch text/plain 2416 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTI2MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDYtMDctIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD05ODA4CisgICAgICAgICAgUkVHUkVTU0lPTjogSW5jb3JyZWN0IGxheW91dCAoYW5kIEVS Uk9SKSB3aGVuIGZvcmNpbmcgQVRTVSBGb3IgQWxsIFRleHQKKworICAgICAgICAqIG1hbnVhbC10 ZXN0cy9BVFNVLWJhZC1sYXlvdXQuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vRm9u dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb250OjpmbG9hdFdpZHRoKTogUmV0dXJuIDAgaW1t ZWRpYXRlbHkgZm9yIHJ1bnMgd2l0aCBsZW5ndGggMC4KKwogMjAwNi0wNy0wOSAgQnJhZHkgRWlk c29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqCklu ZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9BVFNVLWJhZC1sYXlvdXQuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9BVFNVLWJhZC1sYXlvdXQuaHRtbAkocmV2aXNpb24g MCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL0FUU1UtYmFkLWxheW91dC5odG1sCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL1czQy8vRFRE IEhUTUwgNC4wMS8vRU4iCisgICAgICAgICJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9zdHJp Y3QuZHRkIj4KKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorPC9oZWFkPgorPGJvZHk+Cis8cD48 Yj5CVUcgSUQ6PC9iPiA8YSBocmVmPSJodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hv d19idWcuY2dpP2lkPTk4MDgiPkJ1Z3ppbGxhIGJ1ZyA5ODA4PC9hPiBSRUdSRVNTSU9OOiBJbmNv cnJlY3QgbGF5b3V0IChhbmQgRVJST1IpIHdoZW4gZm9yY2luZyBBVFNVIEZvciBBbGwgVGV4dDwv cD4KKworPHAgaWQ9InRlc3QiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnNreWJsdWU7IHBhZGRp bmc6M3B4OyI+PGI+U1RFUFMgVE8gVEVTVDo8L2I+IAorQ2hvb3NlIDxpPlVzZSBBVFNVIEZvciBB bGwgVGV4dDwvaT4gZnJvbSBTYWZhcmkmcnNxdW87cyA8aT5EZWJ1ZzwvaT4gbWVudSBhbmQgcmVs b2FkIHRoaXMgcGFnZS4KKzwvcD4KKworPHAgaWQ9InN1Y2Nlc3MiIHN0eWxlPSJiYWNrZ3JvdW5k LWNvbG9yOnBhbGVncmVlbjsgcGFkZGluZzozcHg7Ij48Yj5URVNUIFBBU1M6PC9iPiAKK1RoZSB0 ZXh0ICZsZHF1bztMb3JlbSBpcHN1bSZyZHF1bzsgYmVsb3cgd2lsbCByZW1haW4gb24gb25lIGxp bmUuCis8L3A+CisKKzxwIGlkPSJmYWlsdXJlIiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjojRkYz MzAwOyBwYWRkaW5nOjNweDsiPjxiPlRFU1QgRkFJTDo8L2I+ICAKK1RoZXJlIHdpbGwgYmUgYSBs aW5lIGJyZWFrIGFmdGVyICZsZHF1bztMb3JlbSZyZHF1bzsgKGFuZCBhdCBtYW55IG90aGVyIHBs YWNlcyBvbiB0aGlzIHBhZ2UpLgorPC9wPgorCis8c3Bhbj5Mb3JlbTwvc3Bhbj4gaXBzdW0KKwor PC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9Gb250LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL0ZvbnQuY3BwCShyZXZpc2lvbiAxNTI1OCkKKysrIFdl YkNvcmUvcGxhdGZvcm0vRm9udC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxNCw3ICs1MTQsOSBA QCB2b2lkIEZvbnQ6OmRyYXdUZXh0KEdyYXBoaWNzQ29udGV4dCogY29uCiAKIGZsb2F0IEZvbnQ6 OmZsb2F0V2lkdGgoY29uc3QgVGV4dFJ1biYgcnVuLCBjb25zdCBUZXh0U3R5bGUmIHN0eWxlKSBj b25zdAogewotICAgIGlmIChjYW5Vc2VHbHlwaENhY2hlKHJ1bikpCisgICAgaWYgKHJ1bi5sZW5n dGgoKSA9PSAwKQorICAgICAgICByZXR1cm4gMDsKKyAgICBlbHNlIGlmIChjYW5Vc2VHbHlwaENh Y2hlKHJ1bikpCiAgICAgICAgIHJldHVybiBmbG9hdFdpZHRoRm9yU2ltcGxlVGV4dChydW4sIHN0 eWxlLCAwLCAwLCAwKTsKICAgICBlbHNlCiAgICAgICAgIHJldHVybiBmbG9hdFdpZHRoRm9yQ29t cGxleFRleHQocnVuLCBzdHlsZSk7Cg== 9341 2006-07-10 07:46:26 -0700 2006-07-10 08:29:23 -0700 Patch 9808_r2.patch text/plain 2354 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTMwMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDYtMDctIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD05ODA4CisgICAgICAgICAgUkVHUkVTU0lPTjogSW5jb3JyZWN0IGxheW91dCAoYW5kIEVS Uk9SKSB3aGVuIGZvcmNpbmcgQVRTVSBGb3IgQWxsIFRleHQKKworICAgICAgICAqIG1hbnVhbC10 ZXN0cy9BVFNVLWJhZC1sYXlvdXQuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFj L0ZvbnRNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpGb250OjpmbG9hdFdpZHRoRm9yQ29tcGxl eFRleHQpOiBSZXR1cm4gMCBpbW1lZGlhdGVseSBmb3IgZW1wdHkgcnVucy4KKwogMjAwNi0wNy0x MCAgUm9iIEJ1aXMgIDxidWlzQGtkZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVq IHZpYSBJUkMuCkluZGV4OiBXZWJDb3JlL21hbnVhbC10ZXN0cy9BVFNVLWJhZC1sYXlvdXQuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9BVFNVLWJhZC1sYXlvdXQuaHRt bAkocmV2aXNpb24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL0FUU1UtYmFkLWxheW91dC5o dG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMg Ii0vL1czQy8vRFREIEhUTUwgNC4wMS8vRU4iCisgICAgICAgICJodHRwOi8vd3d3LnczLm9yZy9U Ui9odG1sNC9zdHJpY3QuZHRkIj4KKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorPC9oZWFkPgor PGJvZHk+Cis8cD48Yj5CVUcgSUQ6PC9iPiA8YSBocmVmPSJodHRwOi8vYnVnemlsbGEub3BlbmRh cndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDgiPkJ1Z3ppbGxhIGJ1ZyA5ODA4PC9hPiBSRUdS RVNTSU9OOiBJbmNvcnJlY3QgbGF5b3V0IChhbmQgRVJST1IpIHdoZW4gZm9yY2luZyBBVFNVIEZv ciBBbGwgVGV4dDwvcD4KKworPHAgaWQ9InRlc3QiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnNr eWJsdWU7IHBhZGRpbmc6M3B4OyI+PGI+U1RFUFMgVE8gVEVTVDo8L2I+IAorQ2hvb3NlIDxpPlVz ZSBBVFNVIEZvciBBbGwgVGV4dDwvaT4gZnJvbSBTYWZhcmkmcnNxdW87cyA8aT5EZWJ1ZzwvaT4g bWVudSBhbmQgcmVsb2FkIHRoaXMgcGFnZS4KKzwvcD4KKworPHAgaWQ9InN1Y2Nlc3MiIHN0eWxl PSJiYWNrZ3JvdW5kLWNvbG9yOnBhbGVncmVlbjsgcGFkZGluZzozcHg7Ij48Yj5URVNUIFBBU1M6 PC9iPiAKK1RoZSB0ZXh0ICZsZHF1bztMb3JlbSBpcHN1bSZyZHF1bzsgYmVsb3cgd2lsbCByZW1h aW4gb24gb25lIGxpbmUuCis8L3A+CisKKzxwIGlkPSJmYWlsdXJlIiBzdHlsZT0iYmFja2dyb3Vu ZC1jb2xvcjojRkYzMzAwOyBwYWRkaW5nOjNweDsiPjxiPlRFU1QgRkFJTDo8L2I+ICAKK1RoZXJl IHdpbGwgYmUgYSBsaW5lIGJyZWFrIGFmdGVyICZsZHF1bztMb3JlbSZyZHF1bzsgKGFuZCBhdCBt YW55IG90aGVyIHBsYWNlcyBvbiB0aGlzIHBhZ2UpLgorPC9wPgorCis8c3Bhbj5Mb3JlbTwvc3Bh bj4gaXBzdW0KKworPC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9tYWMv Rm9udE1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL21hYy9Gb250TWFjLm1t CShyZXZpc2lvbiAxNTMwMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbWFjL0ZvbnRNYWMubW0JKHdv cmtpbmcgY29weSkKQEAgLTUwNSw2ICs1MDUsOSBAQCB2b2lkIEZvbnQ6OmRyYXdDb21wbGV4VGV4 dChHcmFwaGljc0NvbnRlCiAKIGZsb2F0IEZvbnQ6OmZsb2F0V2lkdGhGb3JDb21wbGV4VGV4dChj b25zdCBUZXh0UnVuJiBydW4sIGNvbnN0IFRleHRTdHlsZSYgc3R5bGUpIGNvbnN0CiB7CisgICAg aWYgKHJ1bi5mcm9tKCkgPT0gcnVuLnRvKCkpCisgICAgICAgIHJldHVybiAwOworCiAgICAgQVRT VUxheW91dFBhcmFtZXRlcnMgcGFyYW1zKHJ1biwgc3R5bGUpOwogICAgIHBhcmFtcy5pbml0aWFs aXplKHRoaXMpOwogICAgIAo=