98074 2012-10-01 14:46:10 -0700 Update main frame scroll position immediately for programmatic scrolls 2012-10-25 15:10:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97287 1 thorton webkit-unassigned andersca bdakin beidson jamesr simon.fraser tonikitoo webkit.review.bot oldest_to_newest 732009 0 thorton 2012-10-01 14:46:10 -0700 http://trac.webkit.org/changeset/115681 disabled this because it caused brokenness with user scrolls, however, we should be able to immediately commit programmatic scrolls. This will aid in running the layout tests with tiled drawing on, as many of the tests depend on the scroll position being updated immediately after a scrollTo or scrollBy. 732016 1 166551 thorton 2012-10-01 14:50:43 -0700 Created attachment 166551 patch 732928 2 bdakin 2012-10-02 12:14:13 -0700 I'm wondering if this patch makes this code that Brady added recently totally unnecessary: http://trac.webkit.org/changeset/129652 749279 3 simon.fraser 2012-10-23 20:40:03 -0700 It might do, yes. 749280 4 simon.fraser 2012-10-23 20:40:28 -0700 We need this change to make scrollTo() followed by layerTreeAsText() do the right thing in tests. 750198 5 thorton 2012-10-24 16:37:39 -0700 I'm going to land this, then investigate rolling out Brady's change if we don't need it anymore. 750204 6 thorton 2012-10-24 16:41:37 -0700 (In reply to comment #5) > I'm going to land this, then investigate rolling out Brady's change if we don't need it anymore. Ergh, I didn't update the changelog after merging the change. Oh, well. http://trac.webkit.org/changeset/132422 751258 7 thorton 2012-10-25 15:10:00 -0700 http://trac.webkit.org/changeset/115681 should have been warning enough... this broke the Find overlay again :\ 166551 2012-10-01 14:50:43 -0700 2012-10-23 20:39:37 -0700 patch 0001-commit-programmatic-scrolls-immediately.patch text/plain 2790 thorton RnJvbSBmZTlmMjYyYTA0MmRmYTU3NjdkZjc1MDllMGNmODJjZmZhYTU3ODg0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gSG9ydG9uIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+ CkRhdGU6IE1vbiwgMSBPY3QgMjAxMiAxMzoyNTo0MSAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMS8z XSBjb21taXQgcHJvZ3JhbW1hdGljIHNjcm9sbHMgaW1tZWRpYXRlbHkKCi0tLQogU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE3ICsrKysrKysr KysrKysrKysrCiAuLi4vcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwICAg ICAgICB8ICAgMTAgKysrKysrLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCsp LCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlNGZlZGE1Li43MTU2NTI3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTItMTAtMDEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CiAKKyAgICAgICAgVXBkYXRlIG1haW4gZnJhbWUgc2Nyb2xsIHBvc2l0 aW9uIGltbWVkaWF0ZWx5IGZvciBwcm9ncmFtbWF0aWMgc2Nyb2xscworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgwNzQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbW1lZGlhdGVseSB1cGRhdGUgdGhlIG1h aW4gZnJhbWUgc2Nyb2xsIHBvc2l0aW9uIGFmdGVyIGEgcHJvZ3JhbW1hdGljIHNjcm9sbCwKKyAg ICAgICAgc28gdGhhdCBwZXJmb3JtaW5nIGEgc2Nyb2xsQnkgb3Igc2Nyb2xsVG8gd2lsbCBiZSBp bnN0YW50bHkgcmVmbGVjdGVkIGluCisgICAgICAgIGFsbCBvZiB0aGUgc2Nyb2xsIG9mZnNldCBh Y2Nlc3NvcnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyB0aGlzIHdpbGwgYmUgdGVzdGVkIGJ5 IG1hbnkgc2Nyb2xsaW5nIHRlc3RzIG9uY2UgV2ViS2l0VGVzdFJ1bm5lcgorICAgICAgICBjYW4g dXNlIHRocmVhZGVkIHNjcm9sbGluZy4KKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9s bGluZ0Nvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5h dG9yOjpyZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUpOgorCisyMDEyLTEwLTAxICBUaW0gSG9y dG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCiAgICAgICAgIFNjcm9sbFZpZXc6OnNl dFNjcm9sbFBvc2l0aW9uIGlzIG92ZXJyaWRkZW4gYnkgRnJhbWVWaWV3LCBidXQgaXMgbm90IHZp cnR1YWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4 MDY0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmNwcAppbmRleCBhNzZjMTFmLi5hYWNkZWE0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCkBA IC0yNDYsMTIgKzI0NiwxNCBAQCBib29sIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpyZXF1ZXN0U2Ny b2xsUG9zaXRpb25VcGRhdGUoRnJhbWVWaWV3KiBmcmFtZVZpZXcsIGNvbgogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKICNpZiBFTkFCTEUoVEhSRUFERURfU0NST0xMSU5HKQotICAgIGlmIChmcmFt ZVZpZXctPmZyYW1lKCktPmRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkpIHsKLSAgICAgICAgLy8g SWYgdGhpcyBmcmFtZSB2aWV3J3MgZG9jdW1lbnQgaXMgYmVpbmcgcHV0IGludG8gdGhlIHBhZ2Ug Y2FjaGUsIHdlIGRvbid0IHdhbnQgdG8gdXBkYXRlIG91cgotICAgICAgICAvLyBtYWluIGZyYW1l IHNjcm9sbCBwb3NpdGlvbi4gSnVzdCBsZXQgdGhlIEZyYW1lVmlldyB0aGluayB0aGF0IHdlIGRp ZC4KKworICAgIGlmIChmcmFtZVZpZXctPmluUHJvZ3JhbW1hdGljU2Nyb2xsKCkgfHwgZnJhbWVW aWV3LT5mcmFtZSgpLT5kb2N1bWVudCgpLT5pblBhZ2VDYWNoZSgpKQogICAgICAgICB1cGRhdGVN YWluRnJhbWVTY3JvbGxQb3NpdGlvbihzY3JvbGxQb3NpdGlvbiwgZnJhbWVWaWV3LT5pblByb2dy YW1tYXRpY1Njcm9sbCgpKTsKKworICAgIC8vIElmIHRoaXMgZnJhbWUgdmlldydzIGRvY3VtZW50 IGlzIGJlaW5nIHB1dCBpbnRvIHRoZSBwYWdlIGNhY2hlLCB3ZSBkb24ndCB3YW50IHRvIHVwZGF0 ZSBvdXIKKyAgICAvLyBtYWluIGZyYW1lIHNjcm9sbCBwb3NpdGlvbi4gSnVzdCBsZXQgdGhlIEZy YW1lVmlldyB0aGluayB0aGF0IHdlIGRpZC4KKyAgICBpZiAoZnJhbWVWaWV3LT5mcmFtZSgpLT5k b2N1bWVudCgpLT5pblBhZ2VDYWNoZSgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9CiAK ICAgICBtX3Njcm9sbGluZ1RyZWVTdGF0ZS0+c2V0UmVxdWVzdGVkU2Nyb2xsUG9zaXRpb24oc2Ny b2xsUG9zaXRpb24sIGZyYW1lVmlldy0+aW5Qcm9ncmFtbWF0aWNTY3JvbGwoKSk7CiAgICAgc2No ZWR1bGVUcmVlU3RhdGVDb21taXQoKTsKLS0gCjEuNy45LjYgKEFwcGxlIEdpdC0zMS4xKQoK