98069 2012-10-01 14:25:03 -0700 Add a GraphicsLayerFactory getter to ChromeClient 2012-10-01 15:31:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca eric webkit.review.bot oldest_to_newest 731982 0 andersca 2012-10-01 14:25:03 -0700 Add a GraphicsLayerFactory getter to ChromeClient 731983 1 166543 andersca 2012-10-01 14:27:31 -0700 Created attachment 166543 Patch 732049 2 166543 kling 2012-10-01 15:28:11 -0700 Comment on attachment 166543 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166543&action=review r=me > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). anders pls > Source/WebCore/ChangeLog:11 > + * WebCore.xcodeproj/project.pbxproj: > + GraphicsLayerFactory.h needs to be a private header now. Don't think you need this, since you're forward-declaring the type. 732052 3 andersca 2012-10-01 15:31:20 -0700 Committed r130085: <http://trac.webkit.org/changeset/130085> 166543 2012-10-01 14:27:31 -0700 2012-10-01 15:28:11 -0700 Patch bug-98069-20121001142644.patch text/plain 5438 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU0YTFlMGRiNjY4MmU5 MDk3YmE3M2YxNWRhNDZiM2FiZDgzY2MzMC4uNzYxYTVlNTliNjZhMjUxYzZlYTNiMzUxYzIyOGVk YjNiMGUzZTZjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEwLTAxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQWRkIGEgR3JhcGhp Y3NMYXllckZhY3RvcnkgZ2V0dGVyIHRvIENocm9tZUNsaWVudAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgwNjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRo ZSBjaGFuZ2Ugc3VjaCBhcyBhcHByb2FjaCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1mdW5j dGlvbiBkZXNjcmlwdGlvbnMgYmVsb3cgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmUueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKyAgICAgICAgR3JhcGhpY3NMYXllckZhY3RvcnkuaCBu ZWVkcyB0byBiZSBhIHByaXZhdGUgaGVhZGVyIG5vdy4KKworICAgICAgICAqIHBhZ2UvQ2hyb21l Q2xpZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWVDbGllbnQ6OmdyYXBoaWNzTGF5ZXJG YWN0b3J5KToKKyAgICAgICAgTmV3IGZ1bmN0aW9uIHRoYXQgY2FuIGJlIG92ZXJyaWRkZW4gYnkg cG9ydHMgdG8gY3VzdG9taXplIHRoZSBsYXllciB0eXBlIGNyZWF0ZWQgZm9yIGEgcGFnZS4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpncmFwaGljc0xheWVyRmFjdG9yeSk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oOgorICAgICAgICBBZGQg aGVscGVyIGdldHRlciB0aGF0J3MgdW51c2VkIGZvciBub3cgYnV0IHdpbGwgYmUgY2FsbGVkIGJ5 IFJlbmRlckxheWVyQmFja2luZyB3aGVuIGNyZWF0aW5nIGdyYXBoaWNzIGxheWVycy4KKworMjAx Mi0xMC0wMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAg IFdvdWxkIGxpa2UgYSB3YXkgdG8gY3VzdG9taXplIHRoZSB0eXBlIG9mIEdyYXBoaWNzTGF5ZXJz IGNyZWF0ZWQgb24gYSBwZXIgcGFnZSBiYXNpcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgwNTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv V2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDIzNmRjYzZiOGZlZmJlMGRkMzk4OWYx ZjI1NTMxYTM0NDFjZDcyZjcuLjFmYjIwNDE5NDllZTdiZGIyNTQ0NTZjYTllOTBkNzNmNTE5Mzdi NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBi eHByb2oKQEAgLTU0Nyw3ICs1NDcsNyBAQAogCQkxQUJBNzZDQjExRDIwRTU3MDA0QzIwMUMgLyog Q1NTVmFsdWVLZXl3b3Jkcy5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7 IGZpbGVSZWYgPSBFNDFFQTAzOTExOTgzNzQ5MDA3MTBCQzUgLyogQ1NTVmFsdWVLZXl3b3Jkcy5j cHAgKi87IH07CiAJCTFBQzIyNjBDMERCNjlGMTkwMDg5QjY2OSAvKiBKU0RPTUFwcGxpY2F0aW9u Q2FjaGUuY3BwIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0g MUFDMjI2MEEwREI2OUYxOTAwODlCNjY5IC8qIEpTRE9NQXBwbGljYXRpb25DYWNoZS5jcHAgKi87 IH07CiAJCTFBQzIyNjBEMERCNjlGMTkwMDg5QjY2OSAvKiBKU0RPTUFwcGxpY2F0aW9uQ2FjaGUu aCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDFBQzIyNjBC MERCNjlGMTkwMDg5QjY2OSAvKiBKU0RPTUFwcGxpY2F0aW9uQ2FjaGUuaCAqLzsgfTsKLQkJMUFD Njk1OTMxNjFBMUU1MzAwMzczMkNCIC8qIEdyYXBoaWNzTGF5ZXJGYWN0b3J5LmggaW4gSGVhZGVy cyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAxQUM2OTU5MjE2MUExRTUzMDAz NzMyQ0IgLyogR3JhcGhpY3NMYXllckZhY3RvcnkuaCAqLzsgfTsKKwkJMUFDNjk1OTMxNjFBMUU1 MzAwMzczMkNCIC8qIEdyYXBoaWNzTGF5ZXJGYWN0b3J5LmggaW4gSGVhZGVycyAqLyA9IHtpc2Eg PSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAxQUM2OTU5MjE2MUExRTUzMDAzNzMyQ0IgLyogR3Jh cGhpY3NMYXllckZhY3RvcnkuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRl LCApOyB9OyB9OwogCQkxQUNEMUI2MzBCMDI5NzM5MDA3RTUwMTYgLyogRE9NQ1NTU3R5bGVEZWNs YXJhdGlvbkludGVybmFsLmggaW4gQ29weSBHZW5lcmF0ZWQgSGVhZGVycyAqLyA9IHtpc2EgPSBQ QlhCdWlsZEZpbGU7IGZpbGVSZWYgPSA4NUU3MTE0NDBBQzVENTM0MDA1MzI3MEYgLyogRE9NQ1NT U3R5bGVEZWNsYXJhdGlvbkludGVybmFsLmggKi87IH07CiAJCTFBQ0U1M0RGMEE4RDE4ODEwMDIy OTQ3RCAvKiBKU0RPTVBhcnNlci5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZp bGU7IGZpbGVSZWYgPSAxQUNFNTNERDBBOEQxODgxMDAyMjk0N0QgLyogSlNET01QYXJzZXIuY3Bw ICovOyB9OwogCQkxQUNFNTNFMDBBOEQxODgxMDAyMjk0N0QgLyogSlNET01QYXJzZXIuaCBpbiBI ZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDFBQ0U1M0RFMEE4RDE4 ODEwMDIyOTQ3RCAvKiBKU0RPTVBhcnNlci5oICovOyB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xp ZW50LmgKaW5kZXggZmE1YjQ4NWUwOTEyZDUzZWExYjgxM2FiZGZiZTU0M2I4OTZmZTAzNC4uNDBk ZWI0NmMzOTJjMjEwZjA1ZDk5ZDUzMmMzOGIzOTNlNGZmMGU3NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0No cm9tZUNsaWVudC5oCkBAIC03OCw2ICs3OCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogI2lm IFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAgICBjbGFzcyBHcmFwaGljc0xheWVyOwor ICAgIGNsYXNzIEdyYXBoaWNzTGF5ZXJGYWN0b3J5OwogI2VuZGlmCiAKICNpZiBFTkFCTEUoSU5Q VVRfVFlQRV9DT0xPUikKQEAgLTI0Niw2ICsyNDcsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgIHZpcnR1YWwgdm9pZCBlbGVtZW50RGlkQmx1cihjb25zdCBOb2RlKikgeyB9OwogCiAj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQorICAgICAgICAvLyBBbGxvd3MgcG9ydHMg dG8gY3VzdG9taXplIHRoZSB0eXBlIG9mIGdyYXBoaWNzIGxheWVycyBjcmVhdGVkIGJ5IHRoaXMg cGFnZS4KKyAgICAgICAgdmlydHVhbCBHcmFwaGljc0xheWVyRmFjdG9yeSogZ3JhcGhpY3NMYXll ckZhY3RvcnkoKSBjb25zdCB7IHJldHVybiAwOyB9CisKICAgICAgICAgLy8gUGFzcyAwIGFzIHRo ZSBHcmFwaGljc0xheWVyIHRvIGRldGF0Y2ggdGhlIHJvb3QgbGF5ZXIuCiAgICAgICAgIHZpcnR1 YWwgdm9pZCBhdHRhY2hSb290R3JhcGhpY3NMYXllcihGcmFtZSosIEdyYXBoaWNzTGF5ZXIqKSA9 IDA7CiAgICAgICAgIC8vIFNldHMgYSBmbGFnIHRvIHNwZWNpZnkgdGhhdCB0aGUgbmV4dCB0aW1l IGNvbnRlbnQgaXMgZHJhd24gdG8gdGhlIHdpbmRvdywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggZjk2NzIzM2VmN2U1NTky MGNiNGRlOWJkODAyZDY1ODgxZDA5NjdjNi4uZDY2N2IwOWNhYmY2ODk1YjY2MWI3ZjljZGExOTQ0 NzY2ZDcyMjg1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQ29tcG9zaXRvci5jcHAKQEAgLTI0NTIsNiArMjQ1MiwxNiBAQCBTY3JvbGxpbmdDb29yZGlu YXRvciogUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpzY3JvbGxpbmdDb29yZGluYXRvcigpIGNvbnN0 CiAgICAgcmV0dXJuIDA7CiB9CiAKK0dyYXBoaWNzTGF5ZXJGYWN0b3J5KiBSZW5kZXJMYXllckNv bXBvc2l0b3I6OmdyYXBoaWNzTGF5ZXJGYWN0b3J5KCkgY29uc3QKK3sKKyAgICBpZiAoRnJhbWUq IGZyYW1lID0gbV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+ZnJhbWUoKSkgeworICAgICAgICBp ZiAoUGFnZSogcGFnZSA9IGZyYW1lLT5wYWdlKCkpCisgICAgICAgICAgICByZXR1cm4gcGFnZS0+ Y2hyb21lKCktPmNsaWVudCgpLT5ncmFwaGljc0xheWVyRmFjdG9yeSgpOworICAgIH0KKworICAg IHJldHVybiAwOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBVU0Uo QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKaW5kZXggMmE3Y2RkMDcxZDQ5ZWEyNGI4ZDcyNWMzMTBh YjliNGQwNzljMjZjNy4uNWQ4MDNhOTk2M2QyNjdmOGRiZTYzMDZjZTAzYzVmNzEzYjdmN2Q0MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRv ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu aApAQCAtMjgzLDYgKzI4Myw3IEBAIHByaXZhdGU6CiAKICAgICBib29sIGlzRmx1c2hpbmdMYXll cnMoKSBjb25zdCB7IHJldHVybiBtX2ZsdXNoaW5nTGF5ZXJzOyB9CiAKKyAgICBHcmFwaGljc0xh eWVyRmFjdG9yeSogZ3JhcGhpY3NMYXllckZhY3RvcnkoKSBjb25zdDsKICAgICBTY3JvbGxpbmdD b29yZGluYXRvciogc2Nyb2xsaW5nQ29vcmRpbmF0b3IoKSBjb25zdDsKIAogICAgIC8vIFdoZXRo ZXIgYSBydW5uaW5nIHRyYW5zaXRpb24gb3IgYW5pbWF0aW9uIGVuZm9yY2VzIHRoZSBuZWVkIGZv ciBhIGNvbXBvc2l0aW5nIGxheWVyLgo=