98066 2012-10-01 14:02:28 -0700 WebDocument doesn't export document language to outside users. 2012-10-03 09:46:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bcwhite bcwhite abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 731963 0 bcwhite 2012-10-01 14:02:28 -0700 The WebDocument class does not make available the determined "content-language" to users of that class. Patch forthcoming... -- Brian 732796 1 166709 bcwhite 2012-10-02 10:34:41 -0700 Created attachment 166709 Patch 732798 2 webkit.review.bot 2012-10-02 10:36:00 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 732904 3 166709 webkit.review.bot 2012-10-02 11:51:22 -0700 Comment on attachment 166709 Patch Clearing flags on attachment: 166709 Committed r130191: <http://trac.webkit.org/changeset/130191> 732906 4 webkit.review.bot 2012-10-02 11:51:25 -0700 All reviewed patches have been landed. Closing bug. 733150 5 ap 2012-10-02 15:35:10 -0700 Please note that Content-Language is not "document language". It's "intended audience language". This distinction becomes of importance when dealing with a language textbook, for example. 733176 6 abarth 2012-10-02 16:12:53 -0700 Brian, would you be willing to add a comment to that effect to the API header? 733643 7 bcwhite 2012-10-03 06:45:16 -0700 Interesting! Unexpected, but understandable. The patch has been accepted and "landed" so I assume that means I can't just submit a new patch with the comment. How do I proceed? -- Brian 733790 8 abarth 2012-10-03 09:46:11 -0700 Please create a new bug and attach the patch that adds the comment. You can link from this bug to that bug by including the URL in a comment. 166709 2012-10-02 10:34:41 -0700 2012-10-02 11:51:22 -0700 Patch bug-98066-20121002133352.patch text/plain 2335 bcwhite U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY1NGExZWFjZWEyOWU5ZDM3OGQ0ZTQzMjVlMmY3NzNjZjFlZjZkMDEuLmEzOWIyNjgzOTRhNDNh NDFmZWY5OGY5NGRjYjY4NzQ2YzZlZWU0MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMTAtMDIgIEJyaWFuIFdoaXRlICA8YmN3aGl0ZUBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgV2ViRG9jdW1lbnQgZG9lc24ndCBleHBvcnQgZG9jdW1lbnQgbGFu Z3VhZ2UgdG8gb3V0c2lkZSB1c2Vycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk4MDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2hyb21pdW0gdXNlcyB0aGUgZG9jdW1lbnQgbGFuZ3VhZ2UgdG8gb2Zm ZXIgdHJhbnNsYXRpb24uICBJdCdzIGJlZW4gZG9pbmcKKyAgICAgICAgaXRzIG93biBkZXRlY3Rp b24gb2YgdGhpcyBwcm9wZXJ0eSBidXQgaXQgd291bGQgYmUgYmV0dGVyIHRvIGdldCBpdCBmcm9t CisgICAgICAgIGV4aXN0aW5nIGV4dHJhY3Rpb24gY29kZS4KKworICAgICAgICAqIHB1YmxpYy9X ZWJEb2N1bWVudC5oOgorICAgICAgICAoV2ViRG9jdW1lbnQpOgorICAgICAgICAqIHNyYy9XZWJE b2N1bWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkRvY3VtZW50Ojpjb250ZW50TGFuZ3Vh Z2UpOgorICAgICAgICAoV2ViS2l0KToKKwogMjAxMi0xMC0wMSAgQWxleGFuZGVyIFBhdmxvdiAg PGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtEZXZpY2Ug TWV0cmljc10gUmVtb3ZlIHRoZSBndXR0ZXIgb3ZlcmxheSBtb3ZpbmcgaXRzIGZ1bmN0aW9uYWxp dHkgaW50byB0aGUgSW5zcGVjdG9yT3ZlcmxheQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYkRvY3VtZW50LmgKaW5kZXggZTBjNDQ0MjUwYTllMDM5ZjBhNmNhNzgxNjE0ZTBiOWJh YzVkMGQ1Mi4uN2U4ODVhY2M0NzQzMzYxYjc0MDZjMDY0NmM5Y2RjMTNhZGEzOTMxOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRG9jdW1lbnQuaAorKysgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEb2N1bWVudC5oCkBAIC03OSw2ICs3OSw3 IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfRVhQT1JUIFdlYlNlY3VyaXR5T3JpZ2luIHNlY3VyaXR5 T3JpZ2luKCkgY29uc3Q7CiAKICAgICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyBlbmNvZGluZygp IGNvbnN0OworICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGNvbnRlbnRMYW5ndWFnZSgpIGNv bnN0OwogCiAgICAgLy8gVGhlIHVybCBvZiB0aGUgT3BlblNlYXJjaCBEZXNyaXB0aW9uIERvY3Vt ZW50IChpZiBhbnkpLgogICAgIFdFQktJVF9FWFBPUlQgV2ViVVJMIG9wZW5TZWFyY2hEZXNjcmlw dGlvblVSTCgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRG9jdW1lbnQu Y3BwCmluZGV4IDM0ODY2MTNiZWNkZmNkYjJlMDRiYmE1OWI2MjZhNTQ3ZmUzNjIxY2EuLmVhMTI4 N2ZlMmExYjU1MGIwMTAyOGQ1YjBhMWU2YTJiZWM1YjgyYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJEb2N1bWVudC5jcHAKQEAgLTgxLDYgKzgxLDExIEBAIFdlYlN0cmluZyBX ZWJEb2N1bWVudDo6ZW5jb2RpbmcoKSBjb25zdAogICAgIHJldHVybiBjb25zdFVud3JhcDxEb2N1 bWVudD4oKS0+ZW5jb2RpbmcoKTsKIH0KIAorV2ViU3RyaW5nIFdlYkRvY3VtZW50Ojpjb250ZW50 TGFuZ3VhZ2UoKSBjb25zdAoreworICAgIHJldHVybiBjb25zdFVud3JhcDxEb2N1bWVudD4oKS0+ Y29udGVudExhbmd1YWdlKCk7Cit9CisKIFdlYlVSTCBXZWJEb2N1bWVudDo6b3BlblNlYXJjaERl c2NyaXB0aW9uVVJMKCkgY29uc3QKIHsKICAgICByZXR1cm4gY29uc3RfY2FzdDxEb2N1bWVudCo+ KGNvbnN0VW53cmFwPERvY3VtZW50PigpKS0+b3BlblNlYXJjaERlc2NyaXB0aW9uVVJMKCk7Cg==