<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98065</bug_id>
          
          <creation_ts>2012-10-01 14:02:13 -0700</creation_ts>
          <short_desc>Avoid dumping layer properties that differ in tiled drawing mode</short_desc>
          <delta_ts>2012-10-02 00:13:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>97287</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Horton">thorton</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>bdakin</cc>
    
    <cc>eric</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>731962</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-10-01 14:02:13 -0700</bug_when>
    <thetext>There are a few things that only happen in tiled drawing mode:

* the &quot;FrameView layer&quot; has drawsContent and a background color set.
* there is a &quot;TileCache flattening layer&quot; in between the &quot;FrameView layer&quot; and what would ordinarily be its children

We can update the layer tree logging code to minimize the differences to layer tree dumps.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731974</commentid>
    <comment_count>1</comment_count>
      <attachid>166540</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-10-01 14:15:17 -0700</bug_when>
    <thetext>Created attachment 166540
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731975</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-01 14:17:47 -0700</bug_when>
    <thetext>Attachment 166540 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1
Source/WebCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:17:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:18:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731976</commentid>
    <comment_count>3</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-10-01 14:18:46 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Attachment 166540 [details] did not pass style-queue:
&gt; 
&gt; Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebCore/ChangeLog&apos;, u&apos;Source/WebCor...&quot; exit_code: 1
&gt; Source/WebCore/ChangeLog:16:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
&gt; Source/WebCore/ChangeLog:17:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
&gt; Source/WebCore/ChangeLog:18:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
&gt; Total errors found: 3 in 4 files
&gt; 
&gt; 
&gt; If any of these errors are false positives, please file a bug against check-webkit-style.

Silly stylebot, those aren&apos;t filechangedescriptions. Maybe I shouldn&apos;t use *.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731977</commentid>
    <comment_count>4</comment_count>
      <attachid>166540</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2012-10-01 14:19:10 -0700</bug_when>
    <thetext>Comment on attachment 166540
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166540&amp;action=review

&gt; Source/WebCore/platform/graphics/GraphicsLayer.cpp:84
&gt; +    , m_isTileCacheFlatteningLayer(false)

Sucks to add memory storage for something that&apos;s only used for dumping.

How about adding shouldDumpLayer() etc. to GraphicsLayerClient?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>732362</commentid>
    <comment_count>5</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2012-10-02 00:13:12 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 166540 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=166540&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/graphics/GraphicsLayer.cpp:84
&gt; &gt; +    , m_isTileCacheFlatteningLayer(false)
&gt; 
&gt; Sucks to add memory storage for something that&apos;s only used for dumping.

I assumed that changing the little bitfield thing from 12 1 bit members to 13 1 bit members wouldn&apos;t increase storage at all. Is that not true?

&gt; How about adding shouldDumpLayer() etc. to GraphicsLayerClient?

That won&apos;t help us find the parent of the tile cache flattening layer :P</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166540</attachid>
            <date>2012-10-01 14:15:17 -0700</date>
            <delta_ts>2012-10-01 14:19:46 -0700</delta_ts>
            <desc>patch</desc>
            <filename>0001-avoid-dumping-layer-properties-that-differ-in-tiled-.patch</filename>
            <type>text/plain</type>
            <size>7237</size>
            <attacher name="Tim Horton">thorton</attacher>
            
              <data encoding="base64">RnJvbSA0OWYyOWVlNmMyMmUyMmU2YzA1NjEzYjMyMDcwMzEzNGRiYTE5ZDBhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gSG9ydG9uIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+
CkRhdGU6IE1vbiwgMSBPY3QgMjAxMiAxMzozMToxOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0ggMS8y
XSBhdm9pZCBkdW1waW5nIGxheWVyIHByb3BlcnRpZXMgdGhhdCBkaWZmZXIgaW4gdGlsZWQKIGRy
YXdpbmcKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg
ICAgICAgfCAgIDMwICsrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcCB8ICAgMjUgKysrKysrKysrKy0tLS0tLQogU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oICAgfCAgICA0ICsr
KwogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgICAgfCAg
ICA0ICsrLQogNCBmaWxlcyBjaGFuZ2VkLCA1NCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZwppbmRleCBlNGZlZGE1Li44ZWI4YWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs
MzUgQEAKIDIwMTItMTAtMDEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+
CiAKKyAgICAgICAgQXZvaWQgZHVtcGluZyBsYXllciBwcm9wZXJ0aWVzIHRoYXQgZGlmZmVyIGlu
IHRpbGVkIGRyYXdpbmcgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9OTgwNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBUaGVyZSBhcmUgYSBmZXcgZXhwZWN0ZWQgZGlmZmVyZW5jZXMgYmV0d2VlbiBs
YXllciB0cmVlIGR1bXBzIGluIFdlYktpdDIncyB0aWxlZAorICAgICAgICBkcmF3aW5nIG1vZGUg
dnMuIFdlYktpdDEgb3IgV2ViS2l0MiArIHRoZSBvcmRpbmFyeSBEcmF3aW5nQXJlYUltcGwsIHdo
aWNoIHdlIGNhbgorICAgICAgICBtaW5pbWl6ZSBieSBtb2RpZnlpbmcgdGhlIGxheWVyIHRyZWUg
bG9nZ2luZyBjb2RlLgorCisgICAgICAgIFVzZSB0aGUgZXhpc3RlbmNlIG9mIHRoZSB0aWxlIGNh
Y2hlIGZsYXR0ZW5pbmcgbGF5ZXIgYXMgYW4gaW5kaWNhdGlvbiB0aGF0IHdlJ3JlCisgICAgICAg
IGluIFdlYktpdDIncyB0aWxlZCBkcmF3aW5nIG1vZGUsIGFuZCBhdm9pZCBkdW1waW5nIHNvbWUg
cHJvcGVydGllcyB0aGF0IGRpZmZlcgorICAgICAgICBmcm9tIG5vcm1hbCBEcmF3aW5nQXJlYUlt
cGwvV2ViS2l0MSBpbXBsZW1lbnRhdGlvbnM6CisKKyAgICAgICAgKiBTa2lwIGRyYXdzQ29udGVu
dCBvbiB0aGUgRnJhbWVWaWV3IGxheWVyCisgICAgICAgICogU2tpcCBiYWNrZ3JvdW5kQ29sb3Ig
b24gdGhlIEZyYW1lVmlldyBsYXllcgorICAgICAgICAqIFNraXAgb3ZlciB0aGUgVGlsZUNhY2hl
IGZsYXR0ZW5pbmcgbGF5ZXIsIHN0cmFpZ2h0IHRvIGl0cyBjaGlsZHJlbi4KKworICAgICAgICBO
byBuZXcgdGVzdHMsIGFzIHRoaXMgaXMgb25seSB0ZXN0YWJsZSB3aXRoIHRpbGVkIGRyYXdpbmcg
ZW5hYmxlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6R3JhcGhpY3NMYXllcik6CisgICAg
ICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyOjpkdW1wUHJvcGVydGllcyk6CisgICAgICAgICog
cGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oOgorICAgICAgICAoV2ViQ29yZTo6R3Jh
cGhpY3NMYXllcjo6aXNUaWxlQ2FjaGVGbGF0dGVuaW5nTGF5ZXIpOgorICAgICAgICAoV2ViQ29y
ZTo6R3JhcGhpY3NMYXllcjo6c2V0SXNUaWxlQ2FjaGVGbGF0dGVuaW5nTGF5ZXIpOgorICAgICAg
ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
UmVuZGVyTGF5ZXJCYWNraW5nOjpjcmVhdGVQcmltYXJ5R3JhcGhpY3NMYXllcik6CisKKzIwMTIt
MTAtMDEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAg
U2Nyb2xsVmlldzo6c2V0U2Nyb2xsUG9zaXRpb24gaXMgb3ZlcnJpZGRlbiBieSBGcmFtZVZpZXcs
IGJ1dCBpcyBub3QgdmlydHVhbAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9OTgwNjQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
Z3JhcGhpY3MvR3JhcGhpY3NMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9HcmFwaGljc0xheWVyLmNwcAppbmRleCAyYWUzZmU3Li4yYzA3MjVhIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcApAQCAt
ODEsNiArODEsNyBAQCBHcmFwaGljc0xheWVyOjpHcmFwaGljc0xheWVyKEdyYXBoaWNzTGF5ZXJD
bGllbnQqIGNsaWVudCkKICAgICAsIG1fbWFpbnRhaW5zUGl4ZWxBbGlnbm1lbnQoZmFsc2UpCiAg
ICAgLCBtX2FwcGxpZXNQYWdlU2NhbGUoZmFsc2UpCiAgICAgLCBtX3VzaW5nVGlsZUNhY2hlKGZh
bHNlKQorICAgICwgbV9pc1RpbGVDYWNoZUZsYXR0ZW5pbmdMYXllcihmYWxzZSkKICAgICAsIG1f
cGFpbnRpbmdQaGFzZShHcmFwaGljc0xheWVyUGFpbnRBbGxXaXRoT3ZlcmZsb3dDbGlwKQogICAg
ICwgbV9jb250ZW50c09yaWVudGF0aW9uKENvbXBvc2l0aW5nQ29vcmRpbmF0ZXNUb3BEb3duKQog
ICAgICwgbV9wYXJlbnQoMCkKQEAgLTU0Myw2ICs1NDQsMTEgQEAgdm9pZCBHcmFwaGljc0xheWVy
OjpkdW1wTGF5ZXIoVGV4dFN0cmVhbSYgdHMsIGludCBpbmRlbnQsIExheWVyVHJlZUFzVGV4dEJl
aGF2aW8KIAogdm9pZCBHcmFwaGljc0xheWVyOjpkdW1wUHJvcGVydGllcyhUZXh0U3RyZWFtJiB0
cywgaW50IGluZGVudCwgTGF5ZXJUcmVlQXNUZXh0QmVoYXZpb3IgYmVoYXZpb3IpIGNvbnN0CiB7
CisgICAgLy8gVXNlIGV4aXN0ZW5jZSBvZiB0aGUgdGlsZSBjYWNoZSBmbGF0dGVuaW5nIGxheWVy
IGFzIGFuIGluZGljYXRpb24gdGhhdCB3ZSdyZQorICAgIC8vIGluIFdlYktpdDIncyB0aWxlZCBk
cmF3aW5nIG1vZGUsIGFuZCBhdm9pZCBkdW1waW5nIHNvbWUgcHJvcGVydGllcyB0aGF0IGRpZmZl
cgorICAgIC8vIGZyb20gbm9ybWFsIERyYXdpbmdBcmVhSW1wbC9XZWJLaXQxIGltcGxlbWVudGF0
aW9ucy4KKyAgICBib29sIGlzVGlsZUNhY2hlRmxhdHRlbmluZ0xheWVyUGFyZW50ID0gbV9jaGls
ZHJlbi5zaXplKCkgPT0gMSAmJiBtX2NoaWxkcmVuWzBdLT5pc1RpbGVDYWNoZUZsYXR0ZW5pbmdM
YXllcigpOworCiAgICAgaWYgKG1fcG9zaXRpb24gIT0gRmxvYXRQb2ludCgpKSB7CiAgICAgICAg
IHdyaXRlSW5kZW50KHRzLCBpbmRlbnQgKyAxKTsKICAgICAgICAgdHMgPDwgIihwb3NpdGlvbiAi
IDw8IG1fcG9zaXRpb24ueCgpIDw8ICIgIiA8PCBtX3Bvc2l0aW9uLnkoKSA8PCAiKVxuIjsKQEAg
LTU3OCw3ICs1ODQsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXI6OmR1bXBQcm9wZXJ0aWVzKFRleHRT
dHJlYW0mIHRzLCBpbnQgaW5kZW50LCBMYXllclRyZWVBc1RleHRCZQogICAgICAgICB0cyA8PCAi
KHByZXNlcnZlczNEICIgPDwgbV9wcmVzZXJ2ZXMzRCA8PCAiKVxuIjsKICAgICB9CiAKLSAgICBp
ZiAobV9kcmF3c0NvbnRlbnQpIHsKKyAgICBpZiAoIWlzVGlsZUNhY2hlRmxhdHRlbmluZ0xheWVy
UGFyZW50ICYmIG1fZHJhd3NDb250ZW50KSB7CiAgICAgICAgIHdyaXRlSW5kZW50KHRzLCBpbmRl
bnQgKyAxKTsKICAgICAgICAgdHMgPDwgIihkcmF3c0NvbnRlbnQgIiA8PCBtX2RyYXdzQ29udGVu
dCA8PCAiKVxuIjsKICAgICB9CkBAIC02MDMsNyArNjA5LDcgQEAgdm9pZCBHcmFwaGljc0xheWVy
OjpkdW1wUHJvcGVydGllcyhUZXh0U3RyZWFtJiB0cywgaW50IGluZGVudCwgTGF5ZXJUcmVlQXNU
ZXh0QmUKICAgICAgICAgdHMgPDwgIilcbiI7CiAgICAgfQogCi0gICAgaWYgKG1fYmFja2dyb3Vu
ZENvbG9yU2V0KSB7CisgICAgaWYgKCFpc1RpbGVDYWNoZUZsYXR0ZW5pbmdMYXllclBhcmVudCAm
JiBtX2JhY2tncm91bmRDb2xvclNldCkgewogICAgICAgICB3cml0ZUluZGVudCh0cywgaW5kZW50
ICsgMSk7CiAgICAgICAgIHRzIDw8ICIoYmFja2dyb3VuZENvbG9yICIgPDwgbV9iYWNrZ3JvdW5k
Q29sb3IubmFtZUZvclJlbmRlclRyZWVBc1RleHQoKSA8PCAiKVxuIjsKICAgICB9CkBAIC02NDQs
MTQgKzY1MCwxNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXI6OmR1bXBQcm9wZXJ0aWVzKFRleHRTdHJl
YW0mIHRzLCBpbnQgaW5kZW50LCBMYXllclRyZWVBc1RleHRCZQogICAgICAgICAgICAgdHMgPDwg
IiAiIDw8IG1fcmVwbGljYXRlZExheWVyOzsKICAgICAgICAgdHMgPDwgIilcbiI7CiAgICAgfQot
ICAgIAotICAgIGlmIChtX2NoaWxkcmVuLnNpemUoKSkgeworCisgICAgLy8gU2tpcCB0aGUgVGls
ZUNhY2hlIGZsYXR0ZW5pbmcgbGF5ZXIsIGFzIGl0IG9ubHkgZXhpc3RzIG9uIHNvbWUgcGxhdGZv
cm1zLgorICAgIGNvbnN0IFZlY3RvcjxHcmFwaGljc0xheWVyKj4mIGNoaWxkcmVuID0gaXNUaWxl
Q2FjaGVGbGF0dGVuaW5nTGF5ZXJQYXJlbnQgPyBtX2NoaWxkcmVuWzBdLT5jaGlsZHJlbigpIDog
bV9jaGlsZHJlbjsKKworICAgIGlmIChjaGlsZHJlbi5zaXplKCkpIHsKICAgICAgICAgd3JpdGVJ
bmRlbnQodHMsIGluZGVudCArIDEpOwotICAgICAgICB0cyA8PCAiKGNoaWxkcmVuICIgPDwgbV9j
aGlsZHJlbi5zaXplKCkgPDwgIlxuIjsKLSAgICAgICAgCisgICAgICAgIHRzIDw8ICIoY2hpbGRy
ZW4gIiA8PCBjaGlsZHJlbi5zaXplKCkgPDwgIlxuIjsKKwogICAgICAgICB1bnNpZ25lZCBpOwot
ICAgICAgICBmb3IgKGkgPSAwOyBpIDwgbV9jaGlsZHJlbi5zaXplKCk7IGkrKykKLSAgICAgICAg
ICAgIG1fY2hpbGRyZW5baV0tPmR1bXBMYXllcih0cywgaW5kZW50ICsgMiwgYmVoYXZpb3IpOwor
ICAgICAgICBmb3IgKGkgPSAwOyBpIDwgY2hpbGRyZW4uc2l6ZSgpOyBpKyspCisgICAgICAgICAg
ICBjaGlsZHJlbltpXS0+ZHVtcExheWVyKHRzLCBpbmRlbnQgKyAyLCBiZWhhdmlvcik7CiAgICAg
ICAgIHdyaXRlSW5kZW50KHRzLCBpbmRlbnQgKyAxKTsKICAgICAgICAgdHMgPDwgIilcbiI7CiAg
ICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp
Y3NMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXll
ci5oCmluZGV4IDM3ZWE4ZDAuLmM3NDUyMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgKQEAgLTQwMiw2ICs0MDIsOSBAQCBwdWJsaWM6
CiAgICAgc3RhdGljIHZvaWQgc2V0R3JhcGhpY3NMYXllckZhY3RvcnkoR3JhcGhpY3NMYXllckZh
Y3RvcnkpOwogI2VuZGlmCiAKKyAgICBib29sIGlzVGlsZUNhY2hlRmxhdHRlbmluZ0xheWVyKCkg
eyByZXR1cm4gbV9pc1RpbGVDYWNoZUZsYXR0ZW5pbmdMYXllcjsgfQorICAgIHZvaWQgc2V0SXNU
aWxlQ2FjaGVGbGF0dGVuaW5nTGF5ZXIoYm9vbCBpc1RpbGVDYWNoZUZsYXR0ZW5pbmdMYXllcikg
eyBtX2lzVGlsZUNhY2hlRmxhdHRlbmluZ0xheWVyID0gaXNUaWxlQ2FjaGVGbGF0dGVuaW5nTGF5
ZXI7IH0KKwogcHJvdGVjdGVkOgogICAgIC8vIFNob3VsZCBiZSBjYWxsZWQgZnJvbSBkZXJpdmVk
IGNsYXNzIGRlc3RydWN0b3JzLiBTaG91bGQgY2FsbCB3aWxsQmVEZXN0cm95ZWQoKSBvbiBzdXBl
ci4KICAgICB2aXJ0dWFsIHZvaWQgd2lsbEJlRGVzdHJveWVkKCk7CkBAIC00NjgsNiArNDcxLDcg
QEAgcHJvdGVjdGVkOgogICAgIGJvb2wgbV9tYWludGFpbnNQaXhlbEFsaWdubWVudCA6IDE7CiAg
ICAgYm9vbCBtX2FwcGxpZXNQYWdlU2NhbGUgOiAxOyAvLyBTZXQgZm9yIHRoZSBsYXllciB3aGlj
aCBoYXMgdGhlIHBhZ2Ugc2NhbGUgYXBwbGllZCB0byBpdC4KICAgICBib29sIG1fdXNpbmdUaWxl
Q2FjaGUgOiAxOworICAgIGJvb2wgbV9pc1RpbGVDYWNoZUZsYXR0ZW5pbmdMYXllciA6IDE7CiAK
ICAgICBHcmFwaGljc0xheWVyUGFpbnRpbmdQaGFzZSBtX3BhaW50aW5nUGhhc2U7CiAgICAgQ29t
cG9zaXRpbmdDb29yZGluYXRlc09yaWVudGF0aW9uIG1fY29udGVudHNPcmllbnRhdGlvbjsgLy8g
YWZmZWN0cyBvcmllbnRhdGlvbiBvZiBsYXllciBjb250ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2ViQ29y
ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAppbmRleCA0NTllOTUxLi5mYjA2ZTVl
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5n
LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNw
cApAQCAtMTgwLDggKzE4MCwxMCBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6Y3JlYXRlUHJp
bWFyeUdyYXBoaWNzTGF5ZXIoKQogICAgIG1fZ3JhcGhpY3NMYXllciA9IGNyZWF0ZUdyYXBoaWNz
TGF5ZXIobGF5ZXJOYW1lKTsKICAgICBtX2NyZWF0aW5nUHJpbWFyeUdyYXBoaWNzTGF5ZXIgPSBm
YWxzZTsKIAotICAgIGlmIChtX3VzaW5nVGlsZWRDYWNoZUxheWVyKQorICAgIGlmIChtX3VzaW5n
VGlsZWRDYWNoZUxheWVyKSB7CiAgICAgICAgIG1fY29udGFpbm1lbnRMYXllciA9IGNyZWF0ZUdy
YXBoaWNzTGF5ZXIoIlRpbGVDYWNoZSBGbGF0dGVuaW5nIExheWVyIik7CisgICAgICAgIG1fY29u
dGFpbm1lbnRMYXllci0+c2V0SXNUaWxlQ2FjaGVGbGF0dGVuaW5nTGF5ZXIodHJ1ZSk7CisgICAg
fQogCiAgICAgaWYgKG1faXNNYWluRnJhbWVSZW5kZXJWaWV3TGF5ZXIpIHsKICAgICAgICAgYm9v
bCBpc1RyYW5zcGFyZW50ID0gZmFsc2U7Ci0tIAoxLjcuOS42IChBcHBsZSBHaXQtMzEuMSkKCg==
</data>
<flag name="review"
          id="178895"
          type_id="1"
          status="-"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>