98061 2012-10-01 12:53:54 -0700 Disable hinting when webkit-font-smoothing:antialiased is used on Mac. 2012-10-09 13:06:22 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 bungeman bungeman mitz reed senorblanco webkit.review.bot oldest_to_newest 731915 0 bungeman 2012-10-01 12:53:54 -0700 Disable hinting when webkit-font-smoothing:antialiased is used on Mac. 731922 1 166529 bungeman 2012-10-01 13:02:56 -0700 Created attachment 166529 Patch 732650 2 reed 2012-10-02 07:55:12 -0700 are we putting this on hold, pending the search for other mechanisms that are more explicit? 735907 3 167371 bungeman 2012-10-05 13:17:48 -0700 Created attachment 167371 Patch 735922 4 bungeman 2012-10-05 13:33:38 -0700 USE(SKIA_ON_MAC_CHROMIUM) is currently always true when FontSkia.cpp is included. However, this documents for the future merging of the various 'Font' implementations that this is Mac specific. Requesting re-evaluation now that the Skia changes have settled down. 735934 5 reed 2012-10-05 13:48:28 -0700 works for me 735951 6 167371 senorblanco 2012-10-05 14:18:37 -0700 Comment on attachment 167371 Patch I think we prefer #if PLATFORM(CHROMIUM) && OS(DARWIN) in platform/graphics/skia. SKIA_ON_MAC_CHROMIUM only seems to be used in cross-platform code, and should be replaced with the above now anyway. 735979 7 167371 buildbot 2012-10-05 14:47:13 -0700 Comment on attachment 167371 Patch Attachment 167371 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14183532 New failing tests: http/tests/workers/terminate-during-sync-operation.html 736244 8 167457 bungeman 2012-10-06 09:14:54 -0700 Created attachment 167457 Patch 736246 9 bungeman 2012-10-06 09:34:23 -0700 Changed test to '#if OS(DARWIN)' since this is the desired behavior, Chromium or not (though Chromium is the only one currently using this file). It would be nice if the test could be more like '#if SKIA_FONT_HOST(CORE_GRAPHICS)' since that's what we're really getting at here. The webkit-font-smoothing css property is just exposing a CoreGraphics API. It just happens to be that currently 'OS(DARWIN)' will have the same value as the ephemeral 'SKIA_FONT_HOST(CORE_GRAPHICS)'. That's why I proposed using SKIA_ON_MAC_CHROMIUM, as it seemed closer to 'SKIA_FONT_HOST(CORE_GRAPHICS)'. The test '#if OS(DARWIN)' is fine for now, but I have modified the comment to clarify the situation. 738104 10 167457 senorblanco 2012-10-09 13:00:10 -0700 Comment on attachment 167457 Patch OK. r=me 738114 11 167457 webkit.review.bot 2012-10-09 13:06:18 -0700 Comment on attachment 167457 Patch Clearing flags on attachment: 167457 Committed r130800: <http://trac.webkit.org/changeset/130800> 738115 12 webkit.review.bot 2012-10-09 13:06:22 -0700 All reviewed patches have been landed. Closing bug. 166529 2012-10-01 13:02:56 -0700 2012-10-05 13:17:45 -0700 Patch bug-98061-20121001160209.patch text/plain 2024 bungeman SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDA2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTAxICBCZW4gV2Fn bmVyICA8YnVuZ2VtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERpc2FibGUgaGludGluZyB3 aGVuIHdlYmtpdC1mb250LXNtb290aGluZzphbnRpYWxpYXNlZCBpcyB1c2VkIG9uIE1hYy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDYxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm9ybWFsIGFudGkt YWxpYXNlZCB0ZXh0IG1hdGNoZXMgc3VicGl4ZWwgYW50aS1hbGlhc2VkIHRleHQuCisgICAgICAg IEhvd2V2ZXIsIHRleHQgbWFya2VkIHdpdGggd2Via2l0LWZvbnQtc21vb3RoaW5nOmFudGlhbGlh c2VkIHNob3VsZCBiZSBkcmF3biB3aXRob3V0IGhpbnRpbmcgdG8gbWF0Y2ggU2FmYXJpLgorICAg ICAgICBTZWUgY3JidWcuY29tLzE1MjMwNCAuIAorCisgICAgICAgIFRlc3QgaXMgZmFzdC9jc3Mv Zm9udC1zbW9vdGhpbmcuaHRtbCwgYnV0IERSVCBydW5zIHdpdGggZm9udCBzbW9vdGhpbmcgZGlz YWJsZWQsIHNvIG5vIGNoYW5nZSB2aXNpYmxlLiAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3NraWEvRm9udFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2V0dXBQYWludCk6Cisg ICAgICAgIFNldCBrTm9fSGludGluZyB3aGVuIHdlYmtpdC1mb250LXNtb290aGluZyBpcyBhbnRp YWxpYXNlZC4KKwogMjAxMi0xMC0wMSAgR2xlbm4gQWRhbXMgIDxnbGVubkBza3luYXYuY29tPgog CiAgICAgICAgIFlZREVCVUcgZG9lc24ndCBwcmludCB0b2tlbiB2YWx1ZXMKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3BwCShy ZXZpc2lvbiAxMzAwNjQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ZvbnRTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgIkZvbnQuaCIKIAorI2luY2x1ZGUgIkZvbnRTbW9vdGhpbmdN b2RlLmgiCiAjaW5jbHVkZSAiR2x5cGhCdWZmZXIuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRl eHQuaCIKICNpbmNsdWRlICJMYXlvdXRUZXN0U3VwcG9ydC5oIgpAQCAtNzEsNyArNzIsMTIgQEAg c3RhdGljIHZvaWQgc2V0dXBQYWludChTa1BhaW50KiBwYWludCwgYwogICAgIHBhaW50LT5zZXRB dXRvaGludGVkKGZhbHNlKTsgLy8gZnJlZXR5cGUgc3BlY2lmaWMKICAgICBwYWludC0+c2V0TENE UmVuZGVyVGV4dChzaG91bGRTbW9vdGhGb250cyk7CiAgICAgcGFpbnQtPnNldFN1YnBpeGVsVGV4 dCh0cnVlKTsKLSAgICAKKworICAgIC8vIE9uIE1hYyBkaXNhYmxlIGhpbnRpbmcgd2hlbiB3ZWJr aXQtZm9udC1zbW9vdGhpbmc6YW50aWFsaWFzZWQgaXMgdXNlZC4KKyAgICAvLyBTZWUgY3JidWcu Y29tLzE1MjMwNAorICAgIGlmIChmb250LT5mb250RGVzY3JpcHRpb24oKS5mb250U21vb3RoaW5n KCkgPT0gQW50aWFsaWFzZWQpCisgICAgICAgIHBhaW50LT5zZXRIaW50aW5nKFNrUGFpbnQ6OmtO b19IaW50aW5nKTsKKwogICAgIGlmIChmb250LT5mb250RGVzY3JpcHRpb24oKS50ZXh0UmVuZGVy aW5nTW9kZSgpID09IEdlb21ldHJpY1ByZWNpc2lvbikKICAgICAgICAgcGFpbnQtPnNldEhpbnRp bmcoU2tQYWludDo6a05vX0hpbnRpbmcpOwogfQo= 167371 2012-10-05 13:17:48 -0700 2012-10-06 09:14:49 -0700 Patch bug-98061-20121005161655.patch text/plain 2061 bungeman SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDUzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTAxICBCZW4gV2Fn bmVyICA8YnVuZ2VtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERpc2FibGUgaGludGluZyB3 aGVuIHdlYmtpdC1mb250LXNtb290aGluZzphbnRpYWxpYXNlZCBpcyB1c2VkIG9uIE1hYy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDYxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm9ybWFsIGFudGkt YWxpYXNlZCB0ZXh0IG1hdGNoZXMgc3VicGl4ZWwgYW50aS1hbGlhc2VkIHRleHQuCisgICAgICAg IEhvd2V2ZXIsIHRleHQgbWFya2VkIHdpdGggd2Via2l0LWZvbnQtc21vb3RoaW5nOmFudGlhbGlh c2VkIHNob3VsZCBiZSBkcmF3biB3aXRob3V0IGhpbnRpbmcgdG8gbWF0Y2ggU2FmYXJpLgorICAg ICAgICBTZWUgY3JidWcuY29tLzE1MjMwNCAuIAorCisgICAgICAgIFRlc3QgaXMgZmFzdC9jc3Mv Zm9udC1zbW9vdGhpbmcuaHRtbCwgYnV0IERSVCBydW5zIHdpdGggZm9udCBzbW9vdGhpbmcgZGlz YWJsZWQsIHNvIG5vIGNoYW5nZSB2aXNpYmxlLiAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3NraWEvRm9udFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2V0dXBQYWludCk6Cisg ICAgICAgIFNldCBrTm9fSGludGluZyB3aGVuIHdlYmtpdC1mb250LXNtb290aGluZyBpcyBhbnRp YWxpYXNlZC4KKwogMjAxMi0xMC0wNSAgSm9lIE1hc29uICA8am1hc29uQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIEZpeCByZWdyZXNzaW9uIGluIHByb3h5IGF1dGgKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvRm9udFNraWEuY3Bw CShyZXZpc2lvbiAxMzA1MzcpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0ZvbnRTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1 ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkZvbnQuaCIKIAorI2luY2x1ZGUgIkZvbnRTbW9vdGhp bmdNb2RlLmgiCiAjaW5jbHVkZSAiR2x5cGhCdWZmZXIuaCIKICNpbmNsdWRlICJHcmFwaGljc0Nv bnRleHQuaCIKICNpbmNsdWRlICJMYXlvdXRUZXN0U3VwcG9ydC5oIgpAQCAtNzEsNiArNzIsMTMg QEAgc3RhdGljIHZvaWQgc2V0dXBQYWludChTa1BhaW50KiBwYWludCwgYwogICAgIHBhaW50LT5z ZXRBdXRvaGludGVkKGZhbHNlKTsgLy8gZnJlZXR5cGUgc3BlY2lmaWMKICAgICBwYWludC0+c2V0 TENEUmVuZGVyVGV4dChzaG91bGRTbW9vdGhGb250cyk7CiAgICAgcGFpbnQtPnNldFN1YnBpeGVs VGV4dCh0cnVlKTsKKworI2lmIFVTRShTS0lBX09OX01BQ19DSFJPTUlVTSkKKyAgICAvLyBPbiBN YWMgZGlzYWJsZSBoaW50aW5nIHdoZW4gd2Via2l0LWZvbnQtc21vb3RoaW5nOmFudGlhbGlhc2Vk IGlzIHVzZWQuCisgICAgLy8gU2VlIGNyYnVnLmNvbS8xNTIzMDQKKyAgICBpZiAoZm9udC0+Zm9u dERlc2NyaXB0aW9uKCkuZm9udFNtb290aGluZygpID09IEFudGlhbGlhc2VkKQorICAgICAgICBw YWludC0+c2V0SGludGluZyhTa1BhaW50OjprTm9fSGludGluZyk7CisjZW5kaWYKICAgICAKICAg ICBpZiAoZm9udC0+Zm9udERlc2NyaXB0aW9uKCkudGV4dFJlbmRlcmluZ01vZGUoKSA9PSBHZW9t ZXRyaWNQcmVjaXNpb24pCiAgICAgICAgIHBhaW50LT5zZXRIaW50aW5nKFNrUGFpbnQ6OmtOb19I aW50aW5nKTsK 167457 2012-10-06 09:14:54 -0700 2012-10-09 13:06:18 -0700 Patch bug-98061-20121006121400.patch text/plain 2071 bungeman SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDU4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTAxICBCZW4gV2Fn bmVyICA8YnVuZ2VtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERpc2FibGUgaGludGluZyB3 aGVuIHdlYmtpdC1mb250LXNtb290aGluZzphbnRpYWxpYXNlZCBpcyB1c2VkIG9uIE1hYy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDYxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm9ybWFsIGFudGkt YWxpYXNlZCB0ZXh0IG1hdGNoZXMgc3VicGl4ZWwgYW50aS1hbGlhc2VkIHRleHQuCisgICAgICAg IEhvd2V2ZXIsIHRleHQgbWFya2VkIHdpdGggd2Via2l0LWZvbnQtc21vb3RoaW5nOmFudGlhbGlh c2VkIHNob3VsZCBiZSBkcmF3biB3aXRob3V0IGhpbnRpbmcgdG8gbWF0Y2ggU2FmYXJpLgorICAg ICAgICBTZWUgY3JidWcuY29tLzE1MjMwNCAuIAorCisgICAgICAgIFRlc3QgaXMgZmFzdC9jc3Mv Zm9udC1zbW9vdGhpbmcuaHRtbCwgYnV0IERSVCBydW5zIHdpdGggZm9udCBzbW9vdGhpbmcgZGlz YWJsZWQsIHNvIG5vIGNoYW5nZSB2aXNpYmxlLiAKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL3NraWEvRm9udFNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2V0dXBQYWludCk6Cisg ICAgICAgIFNldCBrTm9fSGludGluZyB3aGVuIHdlYmtpdC1mb250LXNtb290aGluZyBpcyBhbnRp YWxpYXNlZC4KKwogMjAxMi0xMC0wNiAgQnl1bmd3b28gTGVlICA8Ync4MC5sZWVAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgRml4IGJ1aWxkIHdhcm5pbmcgOiAtV3VudXNlZC1wYXJhbWV0ZXIuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ZvbnRTa2lhLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ZvbnRT a2lhLmNwcAkocmV2aXNpb24gMTMwNTgyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9Gb250U2tpYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJGb250LmgiCiAKKyNpbmNsdWRlICJGb250 U21vb3RoaW5nTW9kZS5oIgogI2luY2x1ZGUgIkdseXBoQnVmZmVyLmgiCiAjaW5jbHVkZSAiR3Jh cGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiTGF5b3V0VGVzdFN1cHBvcnQuaCIKQEAgLTcxLDYg KzcyLDEzIEBAIHN0YXRpYyB2b2lkIHNldHVwUGFpbnQoU2tQYWludCogcGFpbnQsIGMKICAgICBw YWludC0+c2V0QXV0b2hpbnRlZChmYWxzZSk7IC8vIGZyZWV0eXBlIHNwZWNpZmljCiAgICAgcGFp bnQtPnNldExDRFJlbmRlclRleHQoc2hvdWxkU21vb3RoRm9udHMpOwogICAgIHBhaW50LT5zZXRT dWJwaXhlbFRleHQodHJ1ZSk7CisKKyNpZiBPUyhEQVJXSU4pCisgICAgLy8gV2hlbiB1c2luZyBD b3JlR3JhcGhpY3MsIGRpc2FibGUgaGludGluZyB3aGVuIHdlYmtpdC1mb250LXNtb290aGluZzph bnRpYWxpYXNlZCBpcyB1c2VkLgorICAgIC8vIFNlZSBjcmJ1Zy5jb20vMTUyMzA0CisgICAgaWYg KGZvbnQtPmZvbnREZXNjcmlwdGlvbigpLmZvbnRTbW9vdGhpbmcoKSA9PSBBbnRpYWxpYXNlZCkK KyAgICAgICAgcGFpbnQtPnNldEhpbnRpbmcoU2tQYWludDo6a05vX0hpbnRpbmcpOworI2VuZGlm CiAgICAgCiAgICAgaWYgKGZvbnQtPmZvbnREZXNjcmlwdGlvbigpLnRleHRSZW5kZXJpbmdNb2Rl KCkgPT0gR2VvbWV0cmljUHJlY2lzaW9uKQogICAgICAgICBwYWludC0+c2V0SGludGluZyhTa1Bh aW50OjprTm9fSGludGluZyk7Cg==