98052 2012-10-01 11:32:08 -0700 [BlackBerry] Add a early return in buildCMakeProjectOrExit() 2012-10-01 12:23:39 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mxie webkit-unassigned rwlbuis tonikitoo webkit.review.bot oldest_to_newest 731833 0 mxie 2012-10-01 11:32:08 -0700 We would like to have an option to separate the CMake configure and build to two steps. 731838 1 166513 mxie 2012-10-01 11:41:17 -0700 Created attachment 166513 Patch 731841 2 webkit.review.bot 2012-10-01 11:42:54 -0700 Attachment 166513 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitdi..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 731850 3 166515 mxie 2012-10-01 11:48:59 -0700 Created attachment 166515 Patch 731852 4 166515 rwlbuis 2012-10-01 11:50:02 -0700 Comment on attachment 166515 Patch LGTM. 731885 5 166515 webkit.review.bot 2012-10-01 12:12:34 -0700 Comment on attachment 166515 Patch Rejecting attachment 166515 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [chromium] ASSERT that the embedder has set a default locale When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14124035 731898 6 166515 webkit.review.bot 2012-10-01 12:23:36 -0700 Comment on attachment 166515 Patch Clearing flags on attachment: 166515 Committed r130066: <http://trac.webkit.org/changeset/130066> 731899 7 webkit.review.bot 2012-10-01 12:23:39 -0700 All reviewed patches have been landed. Closing bug. 166513 2012-10-01 11:41:17 -0700 2012-10-01 11:48:56 -0700 Patch bug-98052-20121001144031.patch text/plain 1446 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2RhOWRkZDZlYzI5YzVhMDA4ZTc2YTQ3NDhmZTgyZjZi NjU0NmQ5My4uNWYxNDBkZjMyOTgwOWNmZTMzNWIzNmM3NDk3NDgxNzM5NDdiYWViMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEwLTAxICBNaW5nIFhpZSAgPG14aWVAcmltLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gQWRkIGEgZWFybHkgcmV0dXJuIGluIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIG9w dGlvbiBhbGxvd3Mgb3VyIGJ1aWxkIHRvIG9ubHkgcnVuIHRoZSBDTWFrZSBidWlsZCBjb25maWd1 cmF0aW9uCisgICAgICAgIHN0ZXAgd2hlbiBlbnZpcm9ubWVudCB2YXJpYWJsZSBHRU5FUkFURV9D TUFLRV9QUk9KRUNUX09OTFkgaXMgc3BlY2lmaWVkLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRkaXJzLnBtOgorICAgICAgICAoYnVpbGRDTWFrZVByb2plY3RPckV4aXQpOgorCiAyMDEyLTEw LTAxICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYXBoYWVsLmt1Ym8uZGEuY29zdGFAaW50ZWwu Y29tPgogCiAgICAgICAgIFtHVEtdIFJlbHkgb24gdGhlIGdlbmVyYWwgaW1wbGVtZW50YXRpb24g Zm9yIGRldGVjdGluZyB0aGUgQXBhY2hlIHNlcnZlciBwYXRoLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IDcwNjBkMmRlZmJmYzc3MDFlMWE5NmQ1MmM4MzE2OTRjNzk2ZTg1MzAuLjQyMWMxMWUyMmE4MGZi MGJkNWU3Y2UxMmRhYjg4NGQ2ZTQzZDI4ODAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIxNzAsNiAr MjE3MCw5IEBAIHN1YiBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgkJCQkQCkKIAogICAgICRyZXR1 cm5Db2RlID0gZXhpdFN0YXR1cyhnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCgk cG9ydCwgJHByZWZpeFBhdGgsIEBjbWFrZUFyZ3MpKTsKICAgICBleGl0KCRyZXR1cm5Db2RlKSBp ZiAkcmV0dXJuQ29kZTsKKyAgICBpZiAoaXNCbGFja0JlcnJ5KCkpIHsKKyAgICAgICAgcmV0dXJu IDAgaWYgKGRlZmluZWQoJEVOVnsiR0VORVJBVEVfQ01BS0VfUFJPSkVDVF9PTkxZIn0pIGVxICcx Jyk7CisgICAgfQogICAgICRyZXR1cm5Db2RlID0gZXhpdFN0YXR1cyhidWlsZENNYWtlR2VuZXJh dGVkUHJvamVjdCgkbWFrZUFyZ3MpKTsKICAgICBleGl0KCRyZXR1cm5Db2RlKSBpZiAkcmV0dXJu Q29kZTsKICAgICByZXR1cm4gMDsK 166515 2012-10-01 11:48:59 -0700 2012-10-01 12:23:36 -0700 Patch bug-98052-20121001144813.patch text/plain 1501 mxie U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2RhOWRkZDZlYzI5YzVhMDA4ZTc2YTQ3NDhmZTgyZjZi NjU0NmQ5My4uYmJlYTRlNWE3MWU2MGU3MTE4N2NkYTE5YWFiNzI1Y2FkNzM3YjcyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTEwLTAxICBNaW5nIFhpZSAgPG14aWVAcmltLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gQWRkIGEgZWFybHkgcmV0dXJuIGluIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDUyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBvcHRp b24gYWxsb3dzIG91ciBidWlsZCB0byBvbmx5IHJ1biB0aGUgQ01ha2UgYnVpbGQgY29uZmlndXJh dGlvbgorICAgICAgICBzdGVwIHdoZW4gZW52aXJvbm1lbnQgdmFyaWFibGUgR0VORVJBVEVfQ01B S0VfUFJPSkVDVF9PTkxZIGlzIHNwZWNpZmllZC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 ZGlycy5wbToKKyAgICAgICAgKGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KToKKwogMjAxMi0xMC0w MSAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8cmFwaGFlbC5rdWJvLmRhLmNvc3RhQGludGVsLmNv bT4KIAogICAgICAgICBbR1RLXSBSZWx5IG9uIHRoZSBnZW5lcmFsIGltcGxlbWVudGF0aW9uIGZv ciBkZXRlY3RpbmcgdGhlIEFwYWNoZSBzZXJ2ZXIgcGF0aC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA3 MDYwZDJkZWZiZmM3NzAxZTFhOTZkNTJjODMxNjk0Yzc5NmU4NTMwLi40MjFjMTFlMjJhODBmYjBi ZDVlN2NlMTJkYWI4ODRkNmU0M2QyODgwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yMTcwLDYgKzIx NzAsOSBAQCBzdWIgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoJCQkJEApCiAKICAgICAkcmV0dXJu Q29kZSA9IGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QoJHBv cnQsICRwcmVmaXhQYXRoLCBAY21ha2VBcmdzKSk7CiAgICAgZXhpdCgkcmV0dXJuQ29kZSkgaWYg JHJldHVybkNvZGU7CisgICAgaWYgKGlzQmxhY2tCZXJyeSgpKSB7CisgICAgICAgIHJldHVybiAw IGlmIChkZWZpbmVkKCRFTlZ7IkdFTkVSQVRFX0NNQUtFX1BST0pFQ1RfT05MWSJ9KSBlcSAnMScp OworICAgIH0KICAgICAkcmV0dXJuQ29kZSA9IGV4aXRTdGF0dXMoYnVpbGRDTWFrZUdlbmVyYXRl ZFByb2plY3QoJG1ha2VBcmdzKSk7CiAgICAgZXhpdCgkcmV0dXJuQ29kZSkgaWYgJHJldHVybkNv ZGU7CiAgICAgcmV0dXJuIDA7Cg==