98040 2012-10-01 09:15:20 -0700 [Qt] QNX build fails when building against Qt without clipboard support 2012-10-21 23:37:42 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74040 1 milian.wolff milian.wolff webkit.review.bot oldest_to_newest 731737 0 milian.wolff 2012-10-01 09:15:20 -0700 Building Qt for QNX 6.5.0 will result in a built with QT_NO_CLIPBOARD defined. Thus QGuiApplication has no clipboard() method. This breaks compilation in WebEditorClient.cpp -> WebEditorClient::supportsGlobalSelection(): make[2]: Entering directory `/home/milian/projects/qt5/build-qnx650/qtwebkit/Source/WebKit2' qcc -Vgcc_ntoarmv7le -c -Wno-psabi -lang-c++ -O2 -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -D_REENTRANT -DQT_NO_CLIPBOARD -DBUILDING_QT__=1 -DNDEBUG -DENABLE_3D_RENDERING=1 -DENABLE_BLOB=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_CSS_BOX_DECORATION_BREAK=1 -DENABLE_CSS_EXCLUSIONS=1 -DENABLE_CSS_FILTERS=1 -DENABLE_CSS_IMAGE_SET=1 -DENABLE_CSS_REGIONS=1 -DENABLE_CSS_STICKY_POSITION=1 -DENABLE_DATALIST_ELEMENT=1 -DENABLE_DETAILS_ELEMENT=1 -DENABLE_FAST_MOBILE_SCROLLING=1 -DENABLE_FILTERS=1 -DENABLE_FTPDIR=1 -DENABLE_FULLSCREEN_API=1 -DENABLE_GESTURE_EVENTS=1 -DENABLE_ICONDATABASE=1 -DENABLE_IFRAME_SEAMLESS=1 -DENABLE_INPUT_TYPE_COLOR=1 -DENABLE_INSPECTOR=1 -DENABLE_INSPECTOR_SERVER=1 -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_LEGACY_NOTIFICATIONS=1 -DENABLE_LEGACY_VIEWPORT_ADAPTION=1 -DENABLE_LEGACY_VENDOR_PREFIXES=1 -DENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1 -DENABLE_METER_ELEMENT=1 -DENABLE_NOTIFICATIONS=1 -DENABLE_PAGE_VISIBILITY_API=1 -DENABLE_PROGRESS_ELEMENT=1 -DENABLE_REQUEST_ANIMATION_FRAME=1 -DENABLE_SHARED_WORKERS=1 -DENABLE_SMOOTH_SCROLLING=1 -DENABLE_SQL_DATABASE=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_TOUCH_ADJUSTMENT=1 -DENABLE_TOUCH_EVENTS=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_WEB_TIMING=1 -DENABLE_WORKERS=1 -DWTF_USE_TILED_BACKING_STORE=1 -DHAVE_QTQUICK=1 -DHAVE_QTPRINTSUPPORT=1 -DHAVE_QSTYLE=1 -DHAVE_QTTESTLIB=1 -DWTF_USE_ZLIB=1 -DPLUGIN_ARCHITECTURE_UNSUPPORTED=1 -DWTF_USE_3D_GRAPHICS=1 -DENABLE_WEBGL=1 -DENABLE_CSS_SHADERS=1 -DENABLE_TOUCH_SLIDER=1 -DENABLE_ACCELERATED_2D_CANVAS=0 -DENABLE_ANIMATION_API=0 -DENABLE_BATTERY_STATUS=0 -DENABLE_CSP_NEXT=0 -DENABLE_CSS_GRID_LAYOUT=0 -DENABLE_CSS_HIERARCHIES=0 -DENABLE_CSS_IMAGE_ORIENTATION=0 -DENABLE_CSS_IMAGE_RESOLUTION=0 -DENABLE_CSS_VARIABLES=0 -DENABLE_CSS3_TEXT_DECORATION=0 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_DATAGRID=0 -DENABLE_DATA_TRANSFER_ITEMS=0 -DENABLE_DEVICE_ORIENTATION=0 -DENABLE_DIRECTORY_UPLOAD=0 -DENABLE_DOWNLOAD_ATTRIBUTE=0 -DENABLE_FILE_SYSTEM=0 -DENABLE_GAMEPAD=0 -DENABLE_GEOLOCATION=0 -DENABLE_HIGH_DPI_CANVAS=0 -DENABLE_INDEXED_DATABASE=0 -DENABLE_INPUT_SPEECH=0 -DENABLE_INPUT_TYPE_DATE=0 -DENABLE_INPUT_TYPE_DATETIME=0 -DENABLE_INPUT_TYPE_DATETIMELOCAL=0 -DENABLE_INPUT_TYPE_MONTH=0 -DENABLE_INPUT_TYPE_TIME=0 -DENABLE_INPUT_TYPE_WEEK=0 -DENABLE_LEGACY_CSS_VENDOR_PREFIXES=0 -DENABLE_LINK_PREFETCH=0 -DENABLE_LINK_PRERENDER=0 -DENABLE_MATHML=0 -DENABLE_MEDIA_SOURCE=0 -DENABLE_MEDIA_STATISTICS=0 -DENABLE_MEDIA_STREAM=0 -DENABLE_MHTML=0 -DENABLE_MICRODATA=0 -DENABLE_MUTATION_OBSERVERS=0 -DENABLE_NAVIGATOR_CONTENT_UTILS=0 -DENABLE_NETSCAPE_PLUGIN_API=0 -DENABLE_NETWORK_INFO=0 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_QUOTA=0 -DENABLE_SCRIPTED_SPEECH=0 -DENABLE_SHADOW_DOM=0 -DENABLE_STYLE_SCOPED=0 -DENABLE_SVG_DOM_OBJC_BINDINGS=0 -DENABLE_TEXT_AUTOSIZING=0 -DENABLE_TEXT_NOTIFICATIONS_ONLY=0 -DENABLE_TOUCH_ICON_LOADING=0 -DENABLE_UNDO_MANAGER=0 -DENABLE_VIBRATION=0 -DENABLE_VIDEO=0 -DENABLE_VIDEO_TRACK=0 -DENABLE_WEB_AUDIO=0 -DENABLE_XSLT=0 -DBUILDING_WebKit2 -DBUILDING_WEBKIT -DQT_ASCII_CAST_WARNINGS -DSQLITE_CORE -DSQLITE_OMIT_LOAD_EXTENSION -DSQLITE_OMIT_COMPLETE -DSTATICALLY_LINKED_WITH_WebCore -DSTATICALLY_LINKED_WITH_ANGLE -DSTATICALLY_LINKED_WITH_JavaScriptCore -DSTATICALLY_LINKED_WITH_WTF -DQT_NO_DEBUG -DQT_QUICK_LIB -DQT_QML_LIB -DQT_SQL_LIB -DQT_NETWORK_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/home/milian/projects/qt5/install-qnx650/mkspecs/qnx-armv7le-qcc -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2 -I. -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2 -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Platform -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Platform/CoreIPC -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Platform/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Shared -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Shared/API/c -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Shared/CoreIPCSupport -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Shared/Plugins -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Shared/Plugins/Netscape -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/Shared/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/API/C -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/API/cpp -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/API/cpp/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/API/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/Authentication -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/CoordinatedGraphics -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/Downloads -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/InspectorServer -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/InspectorServer/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/Launcher -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/Notifications -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/Plugins -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/UIProcess/texmap -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/ApplicationCache -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Authentication -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Battery -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Cookies -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Cookies/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Downloads -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Downloads/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/FullScreen -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Geolocation -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/IconDatabase -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/InjectedBundle -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/InjectedBundle/DOM -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/InjectedBundle/API/c -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/KeyValueStorage -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/MediaCache -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/NetworkInfo -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Notifications -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Plugins -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/Plugins/Netscape -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/ResourceCache -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/WebCoreSupport -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/WebCoreSupport/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/WebPage -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebKit2/PluginProcess -I/home/milian/projects/qt5/qtwebkit/Source/WebKit/qt/Api -I/home/milian/projects/qt5/qtwebkit/Source/WTF/wtf/qt -Igenerated -I/home/milian/projects/qt5/qtwebkit/Source -I../include -I/home/milian/projects/qt5/install-qnx650/include -I/home/milian/projects/qt5/install-qnx650/include/QtScript -I/home/milian/projects/qt5/qtwebkit/Source/WebCore -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/filesystem -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/geolocation -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/indexeddb -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/navigatorcontentutils -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/notifications -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/quota -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/webaudio -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/webdatabase -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/Modules/websockets -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/accessibility -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bindings -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bindings/generic -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bridge -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bridge/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/css -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/dom -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/dom/default -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/editing -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/fileapi -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/history -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/html -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/html/canvas -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/html/parser -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/html/shadow -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/html/track -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/inspector -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/loader -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/loader/appcache -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/loader/archive -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/loader/cache -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/loader/icon -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/mathml -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/page -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/page/animation -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/page/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/page/scrolling -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/animation -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/audio -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/filters -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/filters/arm -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/opengl -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/opentype -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/surfaces -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/texmap -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/graphics/transforms -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/image-decoders -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/image-decoders/bmp -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/image-decoders/ico -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/image-decoders/gif -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/image-decoders/jpeg -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/image-decoders/png -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/image-decoders/webp -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/leveldb -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/mock -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/network -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/network/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/qt -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/sql -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/text -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/platform/text/transcoder -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/plugins -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/rendering -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/rendering/mathml -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/rendering/style -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/rendering/svg -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/storage -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/animation -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/graphics -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/graphics/filters -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/svg/properties -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/testing -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/websockets -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/workers -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/xml -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/xml/parser -I/home/milian/projects/qt5/qtwebkit/Source/ThirdParty -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bridge/jsc -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bindings/js -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/bridge/c -I/home/milian/projects/qt5/qtwebkit/Source/WebCore/testing/js -I../WebCore/generated -I/home/milian/projects/qt5/qtbase/src/3rdparty/sqlite -I/home/milian/projects/qt5/qtwebkit/Source/ThirdParty/ANGLE/include/GLSLANG -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore -I/home/milian/projects/qt5/qtwebkit/Source -I/home/milian/projects/qt5/qtwebkit/Source/WTF -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/assembler -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/bytecode -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/bytecompiler -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/heap -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/dfg -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/debugger -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/disassembler -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/interpreter -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/jit -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/llint -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/parser -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/profiler -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/runtime -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/tools -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/yarr -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/API -I/home/milian/projects/qt5/qtwebkit/Source/JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/generated -I/home/milian/projects/qt5/qtwebkit/Source/WTF -I/home/milian/projects/qt5/install-qnx650/include/QtQuick -I/home/milian/projects/qt5/install-qnx650/include/QtQuick/5.0.0 -I/home/milian/projects/qt5/install-qnx650/include/QtQuick/5.0.0/QtQuick -I/home/milian/projects/qt5/install-qnx650/include/QtQml -I/home/milian/projects/qt5/install-qnx650/include/QtSql -I/home/milian/projects/qt5/install-qnx650/include/QtNetwork -I/home/milian/projects/qt5/install-qnx650/include/QtGui -I/home/milian/projects/qt5/install-qnx650/include/QtGui/5.0.0 -I/home/milian/projects/qt5/install-qnx650/include/QtGui/5.0.0/QtGui -I/home/milian/projects/qt5/install-qnx650/include/QtCore -I/home/milian/projects/qt5/install-qnx650/include/QtCore/5.0.0 -I/home/milian/projects/qt5/install-qnx650/include/QtCore/5.0.0/QtCore -I/opt/qnx650/target/qnx6/usr/include -I/opt/qnx650/target/qnx6/usr/include/freetype2 -I. -o obj/release/WebProcess/WebCoreSupport/WebEditorClient.o /home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp /home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp: In member function 'virtual bool WebKit::WebEditorClient::supportsGlobalSelection()': /home/milian/projects/qt5/qtwebkit/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:488: error: 'class QGuiApplication' has no member named 'clipboard' 731739 1 166490 milian.wolff 2012-10-01 09:21:32 -0700 Created attachment 166490 Patch 747243 2 166490 hausmann 2012-10-21 23:17:34 -0700 Comment on attachment 166490 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166490&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:487 > +#if PLATFORM(QT) && !defined(QT_NO_CLIPBOARD) This is a bit risky for new else clause changes, but ok. 747257 3 166490 webkit.review.bot 2012-10-21 23:37:38 -0700 Comment on attachment 166490 Patch Clearing flags on attachment: 166490 Committed r132032: <http://trac.webkit.org/changeset/132032> 747258 4 webkit.review.bot 2012-10-21 23:37:42 -0700 All reviewed patches have been landed. Closing bug. 166490 2012-10-01 09:21:32 -0700 2012-10-21 23:37:38 -0700 Patch bug-98040-20121001182045.patch text/plain 1624 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGRhMTc0YWRmZjVkOWQz ODM2NGQ4ZTRiYjFlM2M4Y2QxYzg5NjFlZi4uOWZmM2ZhMjM1MzFlZTQzMTc2Y2Y3ZjU0ZTYzMzk2 ZmEyNjA1NGJkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTAxICBNaWxp YW4gV29sZmYgIDxtaWxpYW4ud29sZmZAa2RhYi5jb20+CisKKyAgICAgICAgW1F0XSBRTlggYnVp bGQgZmFpbHMgd2hlbiBidWlsZGluZyBhZ2FpbnN0IFF0IHdpdGhvdXQgY2xpcGJvYXJkIHN1cHBv cnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDQw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3JhY2Vm dWxseSBoYW5kbGUgUVRfTk9fQ0xJUEJPQVJEIGFuZCBkbyBub3QgdHJ5IHRvIGFjY2VzcyBxQXBw LT5jbGlwYm9hcmQoKQorICAgICAgICBpbiBzdWNoIGNhc2VzLiBJbnN0ZWFkLCByZXR1cm4gZmFs c2UgdG8gaW5kaWNhdGUgZ2xvYmFsIHNlbGVjdGlvbiBpcyB1bnN1cHBvcnRlZC4KKworICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViRWRpdG9yQ2xpZW50OjpzdXBwb3J0c0dsb2JhbFNlbGVjdGlvbik6CisK IDIwMTItMDktMjcgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNv bT4KIAogICAgICAgICBbUXRdIEZpeCB2aWV3cG9ydCBRTUwgYXV0byB0ZXN0cyBhZnRlciB0aGUg dmlld3BvcnQgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQuY3BwCmluZGV4IGZlNGU5ZDMyYTc3 MTZmYzQ4ZWExNTQ1OWY3ZDBiNmEyZTUyMjZiMGYuLjFjOGMwYjdiNWMwNDZlOWU1ZTkwZGU1ZTE3 YmEyZDliNzEzMDlkZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5jcHAKQEAgLTQ4NCw3ICs0ODQs NyBAQCB2b2lkIFdlYkVkaXRvckNsaWVudDo6cmVxdWVzdENoZWNraW5nT2ZTdHJpbmcoV1RGOjpQ YXNzUmVmUHRyPFdlYkNvcmU6OlRleHRDaGVjawogCiBib29sIFdlYkVkaXRvckNsaWVudDo6c3Vw cG9ydHNHbG9iYWxTZWxlY3Rpb24oKQogewotI2lmIFBMQVRGT1JNKFFUKQorI2lmIFBMQVRGT1JN KFFUKSAmJiAhZGVmaW5lZChRVF9OT19DTElQQk9BUkQpCiAgICAgcmV0dXJuIHFBcHAtPmNsaXBi b2FyZCgpLT5zdXBwb3J0c1NlbGVjdGlvbigpOwogI2VsaWYgUExBVEZPUk0oR1RLKSAmJiBQTEFU Rk9STShYMTEpCiAgICAgcmV0dXJuIHRydWU7Cg==