98031 2012-10-01 07:48:22 -0700 [Qt] QNX build fails due to disabled LLInt 2012-11-20 04:24:41 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 74040 1 milian.wolff milian.wolff abecsi hausmann iamsergio sergio.martins vestbo webkit.review.bot oldest_to_newest 731692 0 milian.wolff 2012-10-01 07:48:22 -0700 LLInt is enabled by default, whenever JIT is disabled, see Platform.h loc 932. On QNX, JIT is disabled, but LLInt for the Qt port is only enabled on Linux and non-ARM machines, see bug 95749. Now, the patch from bug 95749 works just fine on ARMv7 QNX. Thus I propose to change the buildsystem to also enable LLInt on QNX. Sadly, I have not found a way to properly check for an ARMv7, as there QT_ARCH is also set to "arm". 731718 1 166483 milian.wolff 2012-10-01 08:43:56 -0700 Created attachment 166483 Patch 747252 2 166483 hausmann 2012-10-21 23:33:42 -0700 Comment on attachment 166483 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166483&action=review > Source/JavaScriptCore/DerivedSources.pri:87 > -linux-*:!equals(QT_ARCH, "arm") { > +!equals(QT_ARCH, "arm"):linux-*|qnx { I think the safest way to write this is to use if(): linux-*:!equals(QT_ARCH, "arm") becomes if(linux-*|qnx):!equals(QT_ARCH, "arm") Then it's unambigious to qmake as well as to the reader :) Similar in the other cases below. 756346 3 milian.wolff 2012-11-01 09:37:44 -0700 Ok, I'll update the patch but first let me clarify something: if(linux-*|qnx):!equals(QT_ARCH, "arm") That is actually *not* what I want, but instead if(linux-*:!equals(QT_ARCH, "arm"))|qnx Using that I can actually compile QtWebKit on QNX/ARMv7le. But the above leads me to believe that the assembly-magic is not working on ARM, is that correct? How can one use webkit on an embedded ARM device, then? The JIT is disabled and without LLInt assembly the LLInt cannot be built. But either JIT or LLInt is a requirement, see Platform.h loc 932. 770578 4 milian.wolff 2012-11-19 04:07:19 -0800 Closing this one as we should rather try to get the DFG running on QNX. LLInt is not a good choice for an ARM platform. 771744 5 sergio.martins 2012-11-20 04:24:41 -0800 JIT will be enabled here: https://bugs.webkit.org/show_bug.cgi?id=102794 166483 2012-10-01 08:43:56 -0700 2012-10-21 23:33:42 -0700 Patch bug-98031-20121001174309.patch text/plain 2423 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NGI5NjE1MDFhZDE0YjU4MDY5ZGNmNzJkNmViNTZiNjFmNGU1MGEzLi5mNTI2M2ZiODYwZDFiYTVl NmZiZDEwNzlkZTc1ODU1MWVmYmVmMWMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMi0xMC0wMSAgTWlsaWFuIFdvbGZmICA8bWlsaWFuLndvbGZmQGtkYWIu Y29tPgorCisgICAgICAgIFtRdF0gUU5YIGJ1aWxkIGZhaWxzIGR1ZSB0byBkaXNhYmxlZCBMTElu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTgwMzEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUg TExJbnQgb24gUU5YLCBhcyBpdCBpcyByZXF1aXJlZCB0aGVyZSBzaW5jZSBKSVQgaXMgZGlzYWJs ZWQuCisgICAgICAgIFFUX0FSQ0ggaXMgYWxzbyBzZXQgdG8gImFybSIgdGhlcmUgZXZlbiB0aG91 Z2ggaXQgaXMgdXN1YWxseSBhcm12Ny1sZQorICAgICAgICB3aGljaCBzZWVtcyB0byB3b3JrIGp1 c3QgZmluZS4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLnByaToKKyAgICAgICAgKiBKYXZh U2NyaXB0Q29yZS5wcm86CisKIDIwMTItMTAtMDEgIEpvbmF0aGFuIExpdSAgPG5ldDE0N0BnbWFp bC5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVudXNlZCBzeXMvbW1hbi5oIGluY2x1ZGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9EZXJpdmVkU291cmNlcy5wcmkgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJjZXMucHJpCmluZGV4IGMwM2I2YzBhMzdkMjQwMGZl OWUxYjM5MDNkZTY5Mzc5YjEwZTA1OTAuLjkxZDFhZGM2MGRiNzAwMDQyZmFkMGY5ZjFjYWIwMmFm YTQ5NDBkYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9EZXJpdmVkU291cmNl cy5wcmkKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQpAQCAt ODQsNyArODQsNyBAQCBrbGdlbi5pbnB1dCA9IEtFWVdPUkRMVVRfRklMRVMKIGtsZ2VuLmNvbW1h bmRzID0gcHl0aG9uICQka2xnZW4uc2NyaXB0ICR7UU1BS0VfRklMRV9OQU1FfSA+ICR7UU1BS0Vf RklMRV9PVVR9CiBHRU5FUkFUT1JTICs9IGtsZ2VuCiAKLWxpbnV4LSo6IWVxdWFscyhRVF9BUkNI LCAiYXJtIikgeworIWVxdWFscyhRVF9BUkNILCAiYXJtIik6bGludXgtKnxxbnggewogICAgICNH RU5FUkFUT1I6IExMSW50CiAgICAgbGxpbnQub3V0cHV0ID0gTExJbnRBc3NlbWJseS5oCiAgICAg bGxpbnQuc2NyaXB0ID0gJCRQV0Qvb2ZmbGluZWFzbS9hc20ucmIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8gYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvSmF2YVNjcmlwdENvcmUucHJvCmluZGV4IDA4MjI0NGY4ZGFjNmQ5YTg0OGNlMTA1NWJkMWJk ZDdlMGM2MjEyNDUuLjNiMzNjYmJjZDk5NGVmZGY3MzNmOWZlN2VlNzM5NzUyMWNmYWFiYzEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8KKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwpAQCAtNyw3ICs3LDcgQEAK IFRFTVBMQVRFID0gc3ViZGlycwogQ09ORklHICs9IG9yZGVyZWQKIAotbGludXgtKjohZXF1YWxz KFFUX0FSQ0gsICJhcm0iKSB7CishZXF1YWxzKFFUX0FSQ0gsICJhcm0iKTpsaW51eC0qfHFueCB7 CiAgICAgTExJbnRPZmZzZXRzRXh0cmFjdG9yLmZpbGUgPSBMTEludE9mZnNldHNFeHRyYWN0b3Iu cHJvCiAgICAgTExJbnRPZmZzZXRzRXh0cmFjdG9yLm1ha2VmaWxlID0gTWFrZWZpbGUuTExJbnRP ZmZzZXRzRXh0cmFjdG9yCiAgICAgU1VCRElSUyArPSBMTEludE9mZnNldHNFeHRyYWN0b3IKQEAg LTE4LDcgKzE4LDkgQEAgdGFyZ2V0LmZpbGUgPSBUYXJnZXQucHJpCiAKIFNVQkRJUlMgKz0gZGVy aXZlZF9zb3VyY2VzIHRhcmdldAogCi1saW51eC0qOiFlcXVhbHMoUVRfQVJDSCwgImFybSIpOmFk ZFN0cmljdFN1YmRpck9yZGVyQmV0d2VlbihMTEludE9mZnNldHNFeHRyYWN0b3IsIGRlcml2ZWRf c291cmNlcykKKyFlcXVhbHMoUVRfQVJDSCwgImFybSIpOmxpbnV4LSp8cW54IHsKKyAgICBhZGRT dHJpY3RTdWJkaXJPcmRlckJldHdlZW4oTExJbnRPZmZzZXRzRXh0cmFjdG9yLCBkZXJpdmVkX3Nv dXJjZXMpCit9CiBhZGRTdHJpY3RTdWJkaXJPcmRlckJldHdlZW4oZGVyaXZlZF9zb3VyY2VzLCB0 YXJnZXQpCiAKIGpzYy5maWxlID0ganNjLnBybwo=