98022 2012-10-01 05:59:25 -0700 Web Inspector: move cookies model out of the items view (into sdk component). 2012-10-02 00:47:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 731623 0 pfeldman 2012-10-01 05:59:25 -0700 Otherwise Audits require code that belongs to the resources component. 731625 1 166458 pfeldman 2012-10-01 06:02:16 -0700 Created attachment 166458 Patch 732378 2 166458 webkit.review.bot 2012-10-02 00:47:51 -0700 Comment on attachment 166458 Patch Clearing flags on attachment: 166458 Committed r130130: <http://trac.webkit.org/changeset/130130> 732379 3 webkit.review.bot 2012-10-02 00:47:54 -0700 All reviewed patches have been landed. Closing bug. 166458 2012-10-01 06:02:16 -0700 2012-10-02 00:47:51 -0700 Patch bug-98022-20121001170129.patch text/plain 5532 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY4ZTUyY2ZjM2U3ZjAy Y2UzMjZjMTg1YmQ3ZWVkMWE3MmUxOGMzMy4uYjljYjBiYjgwYjEyMDE5ZDdmYWVmYTg0YzQ4ODdk OGFiNzFiZjU0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTAxICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IG1vdmUgY29va2llcyBtb2RlbCBvdXQgb2YgdGhlIGl0ZW1zIHZpZXcgKGludG8gc2RrIGNv bXBvbmVudCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05ODAyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE90aGVyd2lzZSBBdWRpdHMgcmVxdWlyZSBjb2RlIHRoYXQgYmVsb25ncyB0byB0aGUgcmVzb3Vy Y2VzIGNvbXBvbmVudC4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29va2llSXRl bXNWaWV3LmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQ29va2llUGFyc2VyLmpz OgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvb2tpZXMuZ2V0Q29va2llc0FzeW5jKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5Db29raWVzLmJ1aWxkQ29va2llc0Zyb21TdHJpbmcpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkNvb2tpZXMuY29va2llTWF0Y2hlc1Jlc291cmNlVVJMKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5Db29raWVzLmNvb2tpZURvbWFpbk1hdGNoZXNSZXNvdXJjZURvbWFp bik6CisKIDIwMTItMDktMjcgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRp Z2lhLmNvbT4KIAogICAgICAgICBNYWtlIHN1cmUgdGhhdCB0aGUgaGlzdG9yeSBwb3NpdGlvbiBp cyBhcHBsaWVkIGNvcnJlY3RseSB3aGVuIHVzaW5nIGRlbGVnYXRlc1Njcm9sbGluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVJdGVtc1ZpZXcu anMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nvb2tpZUl0ZW1zVmlldy5q cwppbmRleCAxNjk4ZDMyNTM3OGQ3ODlkY2NhZGIzNDU1NTMwYjk2ZTg5MWEyN2Q2Li40OTk5ZGEy NzQ5YTNiNDM2NWQ5NDk4ZDM0OTEzNDcyYTNjN2VlOTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nvb2tpZUl0ZW1zVmlldy5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nvb2tpZUl0ZW1zVmlldy5qcwpAQCAtMjAxLDU2 ICsyMDEsMyBAQCBXZWJJbnNwZWN0b3IuU2ltcGxlQ29va2llc1RhYmxlLnByb3RvdHlwZSA9IHsK IH0KIAogV2ViSW5zcGVjdG9yLlNpbXBsZUNvb2tpZXNUYWJsZS5wcm90b3R5cGUuX19wcm90b19f ID0gV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90eXBlOwotCi1XZWJJbnNwZWN0b3IuQ29va2llcyA9 IHt9Ci0KLVdlYkluc3BlY3Rvci5Db29raWVzLmdldENvb2tpZXNBc3luYyA9IGZ1bmN0aW9uKGNh bGxiYWNrKQotewotICAgIGZ1bmN0aW9uIG15Y2FsbGJhY2soZXJyb3IsIGNvb2tpZXMsIGNvb2tp ZXNTdHJpbmcpCi0gICAgewotICAgICAgICBpZiAoZXJyb3IpCi0gICAgICAgICAgICByZXR1cm47 Ci0gICAgICAgIGlmIChjb29raWVzU3RyaW5nKQotICAgICAgICAgICAgY2FsbGJhY2soV2ViSW5z cGVjdG9yLkNvb2tpZXMuYnVpbGRDb29raWVzRnJvbVN0cmluZyhjb29raWVzU3RyaW5nKSwgZmFs c2UpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBjYWxsYmFjayhjb29raWVzLCB0cnVlKTsK LSAgICB9Ci0KLSAgICBQYWdlQWdlbnQuZ2V0Q29va2llcyhteWNhbGxiYWNrKTsKLX0KLQotV2Vi SW5zcGVjdG9yLkNvb2tpZXMuYnVpbGRDb29raWVzRnJvbVN0cmluZyA9IGZ1bmN0aW9uKHJhd0Nv b2tpZVN0cmluZykKLXsKLSAgICB2YXIgcmF3Q29va2llcyA9IHJhd0Nvb2tpZVN0cmluZy5zcGxp dCgvO1xzKi8pOwotICAgIHZhciBjb29raWVzID0gW107Ci0KLSAgICBpZiAoISgvXlxzKiQvLnRl c3QocmF3Q29va2llU3RyaW5nKSkpIHsKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCByYXdD b29raWVzLmxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICB2YXIgY29va2llID0gcmF3Q29va2ll c1tpXTsKLSAgICAgICAgICAgIHZhciBkZWxpbUluZGV4ID0gY29va2llLmluZGV4T2YoIj0iKTsK LSAgICAgICAgICAgIHZhciBuYW1lID0gY29va2llLnN1YnN0cmluZygwLCBkZWxpbUluZGV4KTsK LSAgICAgICAgICAgIHZhciB2YWx1ZSA9IGNvb2tpZS5zdWJzdHJpbmcoZGVsaW1JbmRleCArIDEp OwotICAgICAgICAgICAgdmFyIHNpemUgPSBuYW1lLmxlbmd0aCArIHZhbHVlLmxlbmd0aDsKLSAg ICAgICAgICAgIGNvb2tpZXMucHVzaCh7IG5hbWU6IG5hbWUsIHZhbHVlOiB2YWx1ZSwgc2l6ZTog c2l6ZSB9KTsKLSAgICAgICAgfQotICAgIH0KLQotICAgIHJldHVybiBjb29raWVzOwotfQotCi1X ZWJJbnNwZWN0b3IuQ29va2llcy5jb29raWVNYXRjaGVzUmVzb3VyY2VVUkwgPSBmdW5jdGlvbihj b29raWUsIHJlc291cmNlVVJMKQotewotICAgIHZhciB1cmwgPSByZXNvdXJjZVVSTC5hc1BhcnNl ZFVSTCgpOwotICAgIGlmICghdXJsIHx8ICFXZWJJbnNwZWN0b3IuQ29va2llcy5jb29raWVEb21h aW5NYXRjaGVzUmVzb3VyY2VEb21haW4oY29va2llLmRvbWFpbiwgdXJsLmhvc3QpKQotICAgICAg ICByZXR1cm4gZmFsc2U7Ci0gICAgcmV0dXJuICh1cmwucGF0aC5zdGFydHNXaXRoKGNvb2tpZS5w YXRoKQotICAgICAgICAmJiAoIWNvb2tpZS5wb3J0IHx8IHVybC5wb3J0ID09IGNvb2tpZS5wb3J0 KQotICAgICAgICAmJiAoIWNvb2tpZS5zZWN1cmUgfHwgdXJsLnNjaGVtZSA9PT0gImh0dHBzIikp OwotfQotCi1XZWJJbnNwZWN0b3IuQ29va2llcy5jb29raWVEb21haW5NYXRjaGVzUmVzb3VyY2VE b21haW4gPSBmdW5jdGlvbihjb29raWVEb21haW4sIHJlc291cmNlRG9tYWluKQotewotICAgIGlm IChjb29raWVEb21haW4uY2hhckF0KDApICE9PSAnLicpCi0gICAgICAgIHJldHVybiByZXNvdXJj ZURvbWFpbiA9PT0gY29va2llRG9tYWluOwotICAgIHJldHVybiAhIXJlc291cmNlRG9tYWluLm1h dGNoKG5ldyBSZWdFeHAoIl4oW15cXC5dK1xcLik/IiArIGNvb2tpZURvbWFpbi5zdWJzdHJpbmco MSkuZXNjYXBlRm9yUmVnRXhwKCkgKyAiJCIpLCAiaSIpOwotfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db29raWVQYXJzZXIuanMgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Nvb2tpZVBhcnNlci5qcwppbmRleCBlYmIzMWJiZjkz NjM5NDc4Nzc0ZDFhOGEyMTg4MGNkNjA2YmJkYzg0Li5hMzY5YWM4ZDlkYjg1MDA0ZTlkYTVkZTVm Yjc3ZWVlYWViNDE2M2MyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0Nvb2tpZVBhcnNlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0Nvb2tpZVBhcnNlci5qcwpAQCAtMjgxLDMgKzI4MSw1NiBAQCBXZWJJbnNwZWN0b3Iu Q29va2llLlR5cGUgPSB7CiAgICAgUmVxdWVzdDogMCwKICAgICBSZXNwb25zZTogMQogfTsKKwor V2ViSW5zcGVjdG9yLkNvb2tpZXMgPSB7fQorCitXZWJJbnNwZWN0b3IuQ29va2llcy5nZXRDb29r aWVzQXN5bmMgPSBmdW5jdGlvbihjYWxsYmFjaykKK3sKKyAgICBmdW5jdGlvbiBteWNhbGxiYWNr KGVycm9yLCBjb29raWVzLCBjb29raWVzU3RyaW5nKQorICAgIHsKKyAgICAgICAgaWYgKGVycm9y KQorICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBpZiAoY29va2llc1N0cmluZykKKyAgICAg ICAgICAgIGNhbGxiYWNrKFdlYkluc3BlY3Rvci5Db29raWVzLmJ1aWxkQ29va2llc0Zyb21TdHJp bmcoY29va2llc1N0cmluZyksIGZhbHNlKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgY2Fs bGJhY2soY29va2llcywgdHJ1ZSk7CisgICAgfQorCisgICAgUGFnZUFnZW50LmdldENvb2tpZXMo bXljYWxsYmFjayk7Cit9CisKK1dlYkluc3BlY3Rvci5Db29raWVzLmJ1aWxkQ29va2llc0Zyb21T dHJpbmcgPSBmdW5jdGlvbihyYXdDb29raWVTdHJpbmcpCit7CisgICAgdmFyIHJhd0Nvb2tpZXMg PSByYXdDb29raWVTdHJpbmcuc3BsaXQoLztccyovKTsKKyAgICB2YXIgY29va2llcyA9IFtdOwor CisgICAgaWYgKCEoL15ccyokLy50ZXN0KHJhd0Nvb2tpZVN0cmluZykpKSB7CisgICAgICAgIGZv ciAodmFyIGkgPSAwOyBpIDwgcmF3Q29va2llcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAg dmFyIGNvb2tpZSA9IHJhd0Nvb2tpZXNbaV07CisgICAgICAgICAgICB2YXIgZGVsaW1JbmRleCA9 IGNvb2tpZS5pbmRleE9mKCI9Iik7CisgICAgICAgICAgICB2YXIgbmFtZSA9IGNvb2tpZS5zdWJz dHJpbmcoMCwgZGVsaW1JbmRleCk7CisgICAgICAgICAgICB2YXIgdmFsdWUgPSBjb29raWUuc3Vi c3RyaW5nKGRlbGltSW5kZXggKyAxKTsKKyAgICAgICAgICAgIHZhciBzaXplID0gbmFtZS5sZW5n dGggKyB2YWx1ZS5sZW5ndGg7CisgICAgICAgICAgICBjb29raWVzLnB1c2goeyBuYW1lOiBuYW1l LCB2YWx1ZTogdmFsdWUsIHNpemU6IHNpemUgfSk7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBy ZXR1cm4gY29va2llczsKK30KKworV2ViSW5zcGVjdG9yLkNvb2tpZXMuY29va2llTWF0Y2hlc1Jl c291cmNlVVJMID0gZnVuY3Rpb24oY29va2llLCByZXNvdXJjZVVSTCkKK3sKKyAgICB2YXIgdXJs ID0gcmVzb3VyY2VVUkwuYXNQYXJzZWRVUkwoKTsKKyAgICBpZiAoIXVybCB8fCAhV2ViSW5zcGVj dG9yLkNvb2tpZXMuY29va2llRG9tYWluTWF0Y2hlc1Jlc291cmNlRG9tYWluKGNvb2tpZS5kb21h aW4sIHVybC5ob3N0KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHJldHVybiAodXJsLnBh dGguc3RhcnRzV2l0aChjb29raWUucGF0aCkKKyAgICAgICAgJiYgKCFjb29raWUucG9ydCB8fCB1 cmwucG9ydCA9PSBjb29raWUucG9ydCkKKyAgICAgICAgJiYgKCFjb29raWUuc2VjdXJlIHx8IHVy bC5zY2hlbWUgPT09ICJodHRwcyIpKTsKK30KKworV2ViSW5zcGVjdG9yLkNvb2tpZXMuY29va2ll RG9tYWluTWF0Y2hlc1Jlc291cmNlRG9tYWluID0gZnVuY3Rpb24oY29va2llRG9tYWluLCByZXNv dXJjZURvbWFpbikKK3sKKyAgICBpZiAoY29va2llRG9tYWluLmNoYXJBdCgwKSAhPT0gJy4nKQor ICAgICAgICByZXR1cm4gcmVzb3VyY2VEb21haW4gPT09IGNvb2tpZURvbWFpbjsKKyAgICByZXR1 cm4gISFyZXNvdXJjZURvbWFpbi5tYXRjaChuZXcgUmVnRXhwKCJeKFteXFwuXStcXC4pPyIgKyBj b29raWVEb21haW4uc3Vic3RyaW5nKDEpLmVzY2FwZUZvclJlZ0V4cCgpICsgIiQiKSwgImkiKTsK K30K