<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>98020</bug_id>
          
          <creation_ts>2012-10-01 05:14:22 -0700</creation_ts>
          <short_desc>Fix compilation warnings</short_desc>
          <delta_ts>2012-10-01 12:05:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>haraken</cc>
    
    <cc>kenneth</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>731595</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-01 05:14:22 -0700</bug_when>
    <thetext>We have the following compilation warnings on WebKit EFL bots:

/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/efl/PluginViewEfl.cpp:158:6: warning: unused parameter ‘rect’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/efl/PluginViewEfl.cpp:322:6: warning: unused parameter ‘region’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:590:9: warning: unused parameter ‘type’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:590:9: warning: unused parameter ‘target’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:590:9: warning: unused parameter ‘stream’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:597:9: warning: unused parameter ‘stream’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:597:9: warning: unused parameter ‘len’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:597:9: warning: unused parameter ‘buffer’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter ‘scheme’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter ‘realm’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter ‘username’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter ‘ulen’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter ‘password’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter ‘plen’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:77:27: warning: unused parameter ‘origin’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:387:16: warning: deleting ‘void*’ is undefined [enabled by default]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:390:13: warning: unused parameter ‘data’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:390:13: warning: unused parameter ‘canvas’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:390:13: warning: unused parameter ‘eventInfo’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:395:13: warning: unused parameter ‘data’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:395:13: warning: unused parameter ‘canvas’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:395:13: warning: unused parameter ‘eventInfo’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:400:13: warning: unused parameter ‘data’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:400:13: warning: unused parameter ‘canvas’ [-Wunused-parameter]
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:400:13: warning: unused parameter ‘eventInfo’ [-Wunused-parameter]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731598</commentid>
    <comment_count>1</comment_count>
      <attachid>166455</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-01 05:17:16 -0700</bug_when>
    <thetext>Created attachment 166455
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731604</commentid>
    <comment_count>2</comment_count>
      <attachid>166455</attachid>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-10-01 05:28:07 -0700</bug_when>
    <thetext>Comment on attachment 166455
Patch

Looks fine to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731620</commentid>
    <comment_count>3</comment_count>
      <attachid>166455</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-01 05:56:38 -0700</bug_when>
    <thetext>Comment on attachment 166455
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166455&amp;action=review

&gt; Source/WebCore/plugins/PluginView.cpp:594
&gt; +    UNUSED_PARAM(type);
&gt; +    UNUSED_PARAM(target);
&gt; +    UNUSED_PARAM(stream);

Or you can just remove type, target and stream from the method arguments?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731627</commentid>
    <comment_count>4</comment_count>
      <attachid>166459</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-01 06:04:41 -0700</bug_when>
    <thetext>Created attachment 166459
Patch

Take Haraken&apos;s feedback into consideration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731629</commentid>
    <comment_count>5</comment_count>
      <attachid>166459</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-01 06:06:05 -0700</bug_when>
    <thetext>Comment on attachment 166459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166459&amp;action=review

&gt; Source/WebCore/plugins/PluginView.cpp:1482
&gt; +    UNUSED_PARAM(scheme);
&gt; +    UNUSED_PARAM(realm);
&gt; +    UNUSED_PARAM(username);
&gt; +    UNUSED_PARAM(ulen);
&gt; +    UNUSED_PARAM(password);
&gt; +    UNUSED_PARAM(plen);

You can remove these arguments too?

&gt; Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:394
&gt; +    UNUSED_PARAM(data);
&gt; +    UNUSED_PARAM(canvas);
&gt; +    UNUSED_PARAM(eventInfo);

Ditto.

&gt; Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:402
&gt; +    UNUSED_PARAM(data);
&gt; +    UNUSED_PARAM(canvas);
&gt; +    UNUSED_PARAM(eventInfo);

Ditto.

&gt; Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:410
&gt; +    UNUSED_PARAM(data);
&gt; +    UNUSED_PARAM(canvas);
&gt; +    UNUSED_PARAM(eventInfo);

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731632</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-01 06:15:03 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 166459 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=166459&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/plugins/PluginView.cpp:1482
&gt; &gt; +    UNUSED_PARAM(scheme);
&gt; &gt; +    UNUSED_PARAM(realm);
&gt; &gt; +    UNUSED_PARAM(username);
&gt; &gt; +    UNUSED_PARAM(ulen);
&gt; &gt; +    UNUSED_PARAM(password);
&gt; &gt; +    UNUSED_PARAM(plen);
&gt; 
&gt; You can remove these arguments too?
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:394
&gt; &gt; +    UNUSED_PARAM(data);
&gt; &gt; +    UNUSED_PARAM(canvas);
&gt; &gt; +    UNUSED_PARAM(eventInfo);
&gt; 
&gt; Ditto.
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:402
&gt; &gt; +    UNUSED_PARAM(data);
&gt; &gt; +    UNUSED_PARAM(canvas);
&gt; &gt; +    UNUSED_PARAM(eventInfo);
&gt; 
&gt; Ditto.
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:410
&gt; &gt; +    UNUSED_PARAM(data);
&gt; &gt; +    UNUSED_PARAM(canvas);
&gt; &gt; +    UNUSED_PARAM(eventInfo);
&gt; 
&gt; Ditto.

Frankly I don&apos;t like removing arguments, especially in EFL port.
By removing those, we lose information. 

By using UNUSED_PARAM(), if someone want to extend PluginView::getAuthenticationInfo() in the future, it is easy. If I remove argument names, it is not obvious what the char* refer to and which one is the username, which one is the password.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731633</commentid>
    <comment_count>7</comment_count>
      <attachid>166459</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-01 06:16:31 -0700</bug_when>
    <thetext>Comment on attachment 166459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166459&amp;action=review

&gt;&gt;&gt; Source/WebCore/plugins/PluginView.cpp:1482
&gt;&gt;&gt; +    UNUSED_PARAM(plen);
&gt;&gt; 
&gt;&gt; You can remove these arguments too?
&gt; 
&gt; Frankly I don&apos;t like removing arguments, especially in EFL port.
&gt; By removing those, we lose information. 
&gt; 
&gt; By using UNUSED_PARAM(), if someone want to extend PluginView::getAuthenticationInfo() in the future, it is easy. If I remove argument names, it is not obvious what the char* refer to and which one is the username, which one is the password.

OK</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731637</commentid>
    <comment_count>8</comment_count>
      <attachid>166459</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-01 06:22:11 -0700</bug_when>
    <thetext>Comment on attachment 166459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166459&amp;action=review

&gt;&gt;&gt;&gt; Source/WebCore/plugins/PluginView.cpp:1482
&gt;&gt;&gt;&gt; +    UNUSED_PARAM(plen);
&gt;&gt;&gt; 
&gt;&gt;&gt; You can remove these arguments too?
&gt;&gt; 
&gt;&gt; Frankly I don&apos;t like removing arguments, especially in EFL port.
&gt;&gt; By removing those, we lose information. 
&gt;&gt; 
&gt;&gt; By using UNUSED_PARAM(), if someone want to extend PluginView::getAuthenticationInfo() in the future, it is easy. If I remove argument names, it is not obvious what the char* refer to and which one is the username, which one is the password.
&gt; 
&gt; OK

Previous patch used /* */ for fixing unused param build warning in primitive type. I don&apos;t like excessive UNUSED_PARAM is not good personally.

For example,
(const char* /*protocol*/, const char* /*host*/, int32_t /*port*/, const char* /*scheme*/, const char* /*realm*/, char** /*username*/, uint32_t* /*ulen*/, char** /*password*/, uint32_t* /*plen*/)

How do you think ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731639</commentid>
    <comment_count>9</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-01 06:26:09 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (From update of attachment 166459 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=166459&amp;action=review
&gt; Previous patch used /* */ for fixing unused param build warning in primitive type. I don&apos;t like excessive UNUSED_PARAM is not good personally.
&gt; 
&gt; For example,
&gt; (const char* /*protocol*/, const char* /*host*/, int32_t /*port*/, const char* /*scheme*/, const char* /*realm*/, char** /*username*/, uint32_t* /*ulen*/, char** /*password*/, uint32_t* /*plen*/)
&gt; 
&gt; How do you think ?

I think that both are used in WebKit. Also there is no coding style rule about it. So it would depend on the convention of the port/module/etc. Which one is used more in the EFL port?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731643</commentid>
    <comment_count>10</comment_count>
      <attachid>166459</attachid>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-01 06:29:27 -0700</bug_when>
    <thetext>Comment on attachment 166459
Patch

As gyuyoung pointed out, let&apos;s clarify the rule and make the patch consistent. At least we want to make the rule consistent within this patch. (This patch is inconsistent in a sense that the patch removes parameters in some places and uses UNUSED_PARAM() in other places.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731648</commentid>
    <comment_count>11</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-01 06:39:09 -0700</bug_when>
    <thetext>Well, if Gyuyoung wants to take over. I think UNUSED_PARAM() vs comment is a matter of taste...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731650</commentid>
    <comment_count>12</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-01 06:43:08 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; Well, if Gyuyoung wants to take over. I think UNUSED_PARAM() vs comment is a matter of taste...

IMO, let&apos;s just use the popular one in the EFL port. But at least let&apos;s use the same rule in one patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731651</commentid>
    <comment_count>13</comment_count>
    <who name="Kentaro Hara">haraken</who>
    <bug_when>2012-10-01 06:43:28 -0700</bug_when>
    <thetext>Sorry for the nit-picking.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731656</commentid>
    <comment_count>14</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-01 06:52:40 -0700</bug_when>
    <thetext>(In reply to comment #13)
&gt; Sorry for the nit-picking.

IMO, this is not important problem. But, as you feel, I also think it is good to check if which one is popular in WebKit folks. I just would be check this with you guys. I just sent an email to webkit-dev. So, let&apos;s decide a rule or implicit one ,if possible.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731800</commentid>
    <comment_count>15</comment_count>
      <attachid>166505</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-01 10:50:01 -0700</bug_when>
    <thetext>Created attachment 166505
Patch

Followed advice on mailing list thread.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731861</commentid>
    <comment_count>16</comment_count>
      <attachid>166505</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-01 11:53:33 -0700</bug_when>
    <thetext>Comment on attachment 166505
Patch

Looks fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731872</commentid>
    <comment_count>17</comment_count>
      <attachid>166505</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-01 12:05:13 -0700</bug_when>
    <thetext>Comment on attachment 166505
Patch

Clearing flags on attachment: 166505

Committed r130061: &lt;http://trac.webkit.org/changeset/130061&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>731873</commentid>
    <comment_count>18</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-01 12:05:19 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166455</attachid>
            <date>2012-10-01 05:17:16 -0700</date>
            <delta_ts>2012-10-01 06:04:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>98020_compilation_warnings.patch</filename>
            <type>text/plain</type>
            <size>6645</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBkZjhlNTJjLi5kMjI1YzgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg
QEAKKzIwMTItMTAtMDEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2FybmluZ3MKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDIwCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdhcm5pbmdz
IGluIFBsdWdpblZpZXcgY29kZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9y
IGNoYW5nZS4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpQbHVnaW5WaWV3OjpuZXdTdHJlYW0pOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2lu
Vmlldzo6d3JpdGUpOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6Z2V0QXV0aGVudGlj
YXRpb25JbmZvKToKKyAgICAgICAgKiBwbHVnaW5zL2VmbC9QbHVnaW5WaWV3RWZsLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldE5QV2luZG93UmVjdCk6CisgICAgICAgIChX
ZWJDb3JlOjpQbHVnaW5WaWV3OjppbnZhbGlkYXRlUmVnaW9uKToKKwogMjAxMi0wOS0yNyAgSm9j
ZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEuY29tPgogCiAgICAgICAgIE1h
a2Ugc3VyZSB0aGF0IHRoZSBoaXN0b3J5IHBvc2l0aW9uIGlzIGFwcGxpZWQgY29ycmVjdGx5IHdo
ZW4gdXNpbmcgZGVsZWdhdGVzU2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
bHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3
LmNwcAppbmRleCA5NjcyZTkxLi45MGMwYjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bHVnaW5zL1BsdWdpblZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2lu
Vmlldy5jcHAKQEAgLTU4OSw2ICs1ODksOSBAQCBOUEVycm9yIFBsdWdpblZpZXc6OnBvc3RVUkwo
Y29uc3QgY2hhciogdXJsLCBjb25zdCBjaGFyKiB0YXJnZXQsIHVpbnQzMl90IGxlbiwgYwogCiBO
UEVycm9yIFBsdWdpblZpZXc6Om5ld1N0cmVhbShOUE1JTUVUeXBlIHR5cGUsIGNvbnN0IGNoYXIq
IHRhcmdldCwgTlBTdHJlYW0qKiBzdHJlYW0pCiB7CisgICAgVU5VU0VEX1BBUkFNKHR5cGUpOwor
ICAgIFVOVVNFRF9QQVJBTSh0YXJnZXQpOworICAgIFVOVVNFRF9QQVJBTShzdHJlYW0pOwogICAg
IG5vdEltcGxlbWVudGVkKCk7CiAgICAgLy8gVW5zdXBwb3J0ZWQKICAgICByZXR1cm4gTlBFUlJf
R0VORVJJQ19FUlJPUjsKQEAgLTU5Niw2ICs1OTksOSBAQCBOUEVycm9yIFBsdWdpblZpZXc6Om5l
d1N0cmVhbShOUE1JTUVUeXBlIHR5cGUsIGNvbnN0IGNoYXIqIHRhcmdldCwgTlBTdHJlYW0qKiBz
dAogCiBpbnQzMl90IFBsdWdpblZpZXc6OndyaXRlKE5QU3RyZWFtKiBzdHJlYW0sIGludDMyX3Qg
bGVuLCB2b2lkKiBidWZmZXIpCiB7CisgICAgVU5VU0VEX1BBUkFNKHN0cmVhbSk7CisgICAgVU5V
U0VEX1BBUkFNKGxlbik7CisgICAgVU5VU0VEX1BBUkFNKGJ1ZmZlcik7CiAgICAgbm90SW1wbGVt
ZW50ZWQoKTsKICAgICAvLyBVbnN1cHBvcnRlZAogICAgIHJldHVybiAtMTsKQEAgLTE0NzQsNiAr
MTQ4MCwxMiBAQCBOUEVycm9yIFBsdWdpblZpZXc6OnNldFZhbHVlRm9yVVJMKE5QTlVSTFZhcmlh
YmxlIHZhcmlhYmxlLCBjb25zdCBjaGFyKiB1cmwsIGNvbgogCiBOUEVycm9yIFBsdWdpblZpZXc6
OmdldEF1dGhlbnRpY2F0aW9uSW5mbyhjb25zdCBjaGFyKiBwcm90b2NvbCwgY29uc3QgY2hhciog
aG9zdCwgaW50MzJfdCBwb3J0LCBjb25zdCBjaGFyKiBzY2hlbWUsIGNvbnN0IGNoYXIqIHJlYWxt
LCBjaGFyKiogdXNlcm5hbWUsIHVpbnQzMl90KiB1bGVuLCBjaGFyKiogcGFzc3dvcmQsIHVpbnQz
Ml90KiBwbGVuKQogeworICAgIFVOVVNFRF9QQVJBTShzY2hlbWUpOworICAgIFVOVVNFRF9QQVJB
TShyZWFsbSk7CisgICAgVU5VU0VEX1BBUkFNKHVzZXJuYW1lKTsKKyAgICBVTlVTRURfUEFSQU0o
dWxlbik7CisgICAgVU5VU0VEX1BBUkFNKHBhc3N3b3JkKTsKKyAgICBVTlVTRURfUEFSQU0ocGxl
bik7CiAgICAgTE9HKFBsdWdpbnMsICJQbHVnaW5WaWV3OjpnZXRBdXRoZW50aWNhdGlvbkluZm86
IHByb3RvY29sPSVzLCBob3N0PSVzLCBwb3J0PSVkIiwgcHJvdG9jb2wsIGhvc3QsIHBvcnQpOwog
ICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgcmV0dXJuIE5QRVJSX0dFTkVSSUNfRVJST1I7CmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2VmbC9QbHVnaW5WaWV3RWZsLmNwcCBi
L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZWZsL1BsdWdpblZpZXdFZmwuY3BwCmluZGV4IDYwMDY2
N2EuLjRlMTM2OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZWZsL1BsdWdp
blZpZXdFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZWZsL1BsdWdpblZpZXdF
ZmwuY3BwCkBAIC0xNTUsNyArMTU1LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXRQYXJlbnQoU2Ny
b2xsVmlldyogcGFyZW50KQogICAgICAgICBpbml0KCk7CiB9CiAKLXZvaWQgUGx1Z2luVmlldzo6
c2V0TlBXaW5kb3dSZWN0KGNvbnN0IEludFJlY3QmIHJlY3QpCit2b2lkIFBsdWdpblZpZXc6OnNl
dE5QV2luZG93UmVjdChjb25zdCBJbnRSZWN0JikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwog
fQpAQCAtMzE5LDcgKzMxOSw3IEBAIHZvaWQgUGx1Z2luVmlldzo6aW52YWxpZGF0ZVJlY3QoTlBS
ZWN0KiByZWN0KQogICAgIGludmFsaWRhdGVSZWN0KEludFJlY3QocmVjdC0+bGVmdCwgcmVjdC0+
dG9wLCByZWN0LT5yaWdodCAtIHJlY3QtPmxlZnQsIHJlY3QtPmJvdHRvbSAtIHJlY3QtPnRvcCkp
OwogfQogCi12b2lkIFBsdWdpblZpZXc6OmludmFsaWRhdGVSZWdpb24oTlBSZWdpb24gcmVnaW9u
KQordm9pZCBQbHVnaW5WaWV3OjppbnZhbGlkYXRlUmVnaW9uKE5QUmVnaW9uKQogewogICAgIG5v
dEltcGxlbWVudGVkKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg
Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGRhMTc0YS4uZmMzNzYxZCAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTAxICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hy
aXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdhcm5p
bmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODAy
MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBj
b21waWxhdGlvbiB3YXJuaW5ncyByZWxhdGVkIHRvIGV3a192aWV3LgorCisgICAgICAgICogVUlQ
cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X2ZlZWRfdG91
Y2hfZXZlbnRfdXNpbmdfdG91Y2hfcG9pbnRfbGlzdF9vZl9ldmFzKToKKyAgICAgICAgKF9ld2tf
dmlld19vbl90b3VjaF9kb3duKToKKyAgICAgICAgKF9ld2tfdmlld19vbl90b3VjaF91cCk6Cisg
ICAgICAgIChfZXdrX3ZpZXdfb25fdG91Y2hfbW92ZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQ
SS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcDoKKyAgICAgICAgKGV4Y2VlZGVkRGF0YWJhc2VR
dW90YSk6CisKIDIwMTItMDktMjcgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRl
QGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCB2aWV3cG9ydCBRTUwgYXV0byB0ZXN0cyBh
ZnRlciB0aGUgdmlld3BvcnQgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ
SS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDQxOTA1NjEuLmRkZDZkNzggMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTM4NCwyMSArMzg0LDMw
IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudF91c2luZ190
b3VjaF9wb2ludF9saXN0X29mX2V2YXMoRXZhCiAKICAgICB2b2lkKiBkYXRhOwogICAgIEVJTkFf
TElTVF9GUkVFKHBvaW50cywgZGF0YSkKLSAgICAgICAgZGVsZXRlIGRhdGE7CisgICAgICAgIGRl
bGV0ZSBzdGF0aWNfY2FzdDxFd2tfVG91Y2hfUG9pbnQqPihkYXRhKTsKIH0KIAogc3RhdGljIHZv
aWQgX2V3a192aWV3X29uX3RvdWNoX2Rvd24odm9pZCogZGF0YSwgRXZhcyogY2FudmFzLCBFdmFz
X09iamVjdCogZXdrVmlldywgdm9pZCogZXZlbnRJbmZvKQogeworICAgIFVOVVNFRF9QQVJBTShk
YXRhKTsKKyAgICBVTlVTRURfUEFSQU0oY2FudmFzKTsKKyAgICBVTlVTRURfUEFSQU0oZXZlbnRJ
bmZvKTsKICAgICBfZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudF91c2luZ190b3VjaF9wb2ludF9s
aXN0X29mX2V2YXMoZXdrVmlldywgRVdLX1RPVUNIX1NUQVJUKTsKIH0KIAogc3RhdGljIHZvaWQg
X2V3a192aWV3X29uX3RvdWNoX3VwKHZvaWQqIGRhdGEsIEV2YXMqIGNhbnZhcywgRXZhc19PYmpl
Y3QqIGV3a1ZpZXcsIHZvaWQqIGV2ZW50SW5mbykKIHsKKyAgICBVTlVTRURfUEFSQU0oZGF0YSk7
CisgICAgVU5VU0VEX1BBUkFNKGNhbnZhcyk7CisgICAgVU5VU0VEX1BBUkFNKGV2ZW50SW5mbyk7
CiAgICAgX2V3a192aWV3X2ZlZWRfdG91Y2hfZXZlbnRfdXNpbmdfdG91Y2hfcG9pbnRfbGlzdF9v
Zl9ldmFzKGV3a1ZpZXcsIEVXS19UT1VDSF9FTkQpOwogfQogCiBzdGF0aWMgdm9pZCBfZXdrX3Zp
ZXdfb25fdG91Y2hfbW92ZSh2b2lkKiBkYXRhLCBFdmFzKiBjYW52YXMsIEV2YXNfT2JqZWN0KiBl
d2tWaWV3LCB2b2lkKiBldmVudEluZm8pCiB7CisgICAgVU5VU0VEX1BBUkFNKGRhdGEpOworICAg
IFVOVVNFRF9QQVJBTShjYW52YXMpOworICAgIFVOVVNFRF9QQVJBTShldmVudEluZm8pOwogICAg
IF9ld2tfdmlld19mZWVkX3RvdWNoX2V2ZW50X3VzaW5nX3RvdWNoX3BvaW50X2xpc3Rfb2ZfZXZh
cyhld2tWaWV3LCBFV0tfVE9VQ0hfTU9WRSk7CiB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAgYi9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwCmluZGV4
IGYzYmZjZDguLjBiODQ5ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B
UEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcApAQCAtNzQsNyArNzQsNyBAQCBzdGF0
aWMgdm9pZCBoaWRlQ29sb3JQaWNrZXIoV0tQYWdlUmVmLCBjb25zdCB2b2lkKiBjbGllbnRJbmZv
KQogI2VuZGlmCiAKICNpZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQotc3RhdGljIHVuc2lnbmVkIGxv
bmcgbG9uZyBleGNlZWRlZERhdGFiYXNlUXVvdGEoV0tQYWdlUmVmLCBXS0ZyYW1lUmVmLCBXS1Nl
Y3VyaXR5T3JpZ2luUmVmIG9yaWdpbiwgV0tTdHJpbmdSZWYgZGF0YWJhc2VOYW1lLCBXS1N0cmlu
Z1JlZiBkaXNwbGF5TmFtZSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJlbnRRdW90YSwgdW5zaWdu
ZWQgbG9uZyBsb25nIGN1cnJlbnRPcmlnaW5Vc2FnZSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJl
bnREYXRhYmFzZVVzYWdlLCB1bnNpZ25lZCBsb25nIGxvbmcgZXhwZWN0ZWRVc2FnZSwgY29uc3Qg
dm9pZCogY2xpZW50SW5mbykKK3N0YXRpYyB1bnNpZ25lZCBsb25nIGxvbmcgZXhjZWVkZWREYXRh
YmFzZVF1b3RhKFdLUGFnZVJlZiwgV0tGcmFtZVJlZiwgV0tTZWN1cml0eU9yaWdpblJlZiwgV0tT
dHJpbmdSZWYgZGF0YWJhc2VOYW1lLCBXS1N0cmluZ1JlZiBkaXNwbGF5TmFtZSwgdW5zaWduZWQg
bG9uZyBsb25nIGN1cnJlbnRRdW90YSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJlbnRPcmlnaW5V
c2FnZSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJlbnREYXRhYmFzZVVzYWdlLCB1bnNpZ25lZCBs
b25nIGxvbmcgZXhwZWN0ZWRVc2FnZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIHsKICAgICBy
ZXR1cm4gZXdrX3ZpZXdfZGF0YWJhc2VfcXVvdGFfZXhjZWVkZWQodG9Fd2tWaWV3KGNsaWVudElu
Zm8pLCBXS0VpbmFTaGFyZWRTdHJpbmcoZGF0YWJhc2VOYW1lKSwgV0tFaW5hU2hhcmVkU3RyaW5n
KGRpc3BsYXlOYW1lKSwgY3VycmVudFF1b3RhLCBjdXJyZW50T3JpZ2luVXNhZ2UsIGN1cnJlbnRE
YXRhYmFzZVVzYWdlLCBleHBlY3RlZFVzYWdlKTsKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166459</attachid>
            <date>2012-10-01 06:04:41 -0700</date>
            <delta_ts>2012-10-01 10:50:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>98020_compilation_warnings.patch</filename>
            <type>text/plain</type>
            <size>6570</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBkZjhlNTJjLi5kMjI1YzgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg
QEAKKzIwMTItMTAtMDEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2FybmluZ3MKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDIwCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdhcm5pbmdz
IGluIFBsdWdpblZpZXcgY29kZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9y
IGNoYW5nZS4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpQbHVnaW5WaWV3OjpuZXdTdHJlYW0pOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2lu
Vmlldzo6d3JpdGUpOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6Z2V0QXV0aGVudGlj
YXRpb25JbmZvKToKKyAgICAgICAgKiBwbHVnaW5zL2VmbC9QbHVnaW5WaWV3RWZsLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldE5QV2luZG93UmVjdCk6CisgICAgICAgIChX
ZWJDb3JlOjpQbHVnaW5WaWV3OjppbnZhbGlkYXRlUmVnaW9uKToKKwogMjAxMi0wOS0yNyAgSm9j
ZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEuY29tPgogCiAgICAgICAgIE1h
a2Ugc3VyZSB0aGF0IHRoZSBoaXN0b3J5IHBvc2l0aW9uIGlzIGFwcGxpZWQgY29ycmVjdGx5IHdo
ZW4gdXNpbmcgZGVsZWdhdGVzU2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w
bHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3
LmNwcAppbmRleCA5NjcyZTkxLi43NzVjZWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w
bHVnaW5zL1BsdWdpblZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2lu
Vmlldy5jcHAKQEAgLTU4NywxNCArNTg3LDE0IEBAIE5QRXJyb3IgUGx1Z2luVmlldzo6cG9zdFVS
TChjb25zdCBjaGFyKiB1cmwsIGNvbnN0IGNoYXIqIHRhcmdldCwgdWludDMyX3QgbGVuLCBjCiAg
ICAgcmV0dXJuIGhhbmRsZVBvc3QodXJsLCB0YXJnZXQsIGxlbiwgYnVmLCBmaWxlLCAwLCBmYWxz
ZSwgZmlsZSk7CiB9CiAKLU5QRXJyb3IgUGx1Z2luVmlldzo6bmV3U3RyZWFtKE5QTUlNRVR5cGUg
dHlwZSwgY29uc3QgY2hhciogdGFyZ2V0LCBOUFN0cmVhbSoqIHN0cmVhbSkKK05QRXJyb3IgUGx1
Z2luVmlldzo6bmV3U3RyZWFtKE5QTUlNRVR5cGUsIGNvbnN0IGNoYXIqLCBOUFN0cmVhbSoqKQog
ewogICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgLy8gVW5zdXBwb3J0ZWQKICAgICByZXR1cm4g
TlBFUlJfR0VORVJJQ19FUlJPUjsKIH0KIAotaW50MzJfdCBQbHVnaW5WaWV3Ojp3cml0ZShOUFN0
cmVhbSogc3RyZWFtLCBpbnQzMl90IGxlbiwgdm9pZCogYnVmZmVyKQoraW50MzJfdCBQbHVnaW5W
aWV3Ojp3cml0ZShOUFN0cmVhbSosIGludDMyX3QsIHZvaWQqKQogewogICAgIG5vdEltcGxlbWVu
dGVkKCk7CiAgICAgLy8gVW5zdXBwb3J0ZWQKQEAgLTE0NzQsNiArMTQ3NCwxMiBAQCBOUEVycm9y
IFBsdWdpblZpZXc6OnNldFZhbHVlRm9yVVJMKE5QTlVSTFZhcmlhYmxlIHZhcmlhYmxlLCBjb25z
dCBjaGFyKiB1cmwsIGNvbgogCiBOUEVycm9yIFBsdWdpblZpZXc6OmdldEF1dGhlbnRpY2F0aW9u
SW5mbyhjb25zdCBjaGFyKiBwcm90b2NvbCwgY29uc3QgY2hhciogaG9zdCwgaW50MzJfdCBwb3J0
LCBjb25zdCBjaGFyKiBzY2hlbWUsIGNvbnN0IGNoYXIqIHJlYWxtLCBjaGFyKiogdXNlcm5hbWUs
IHVpbnQzMl90KiB1bGVuLCBjaGFyKiogcGFzc3dvcmQsIHVpbnQzMl90KiBwbGVuKQogeworICAg
IFVOVVNFRF9QQVJBTShzY2hlbWUpOworICAgIFVOVVNFRF9QQVJBTShyZWFsbSk7CisgICAgVU5V
U0VEX1BBUkFNKHVzZXJuYW1lKTsKKyAgICBVTlVTRURfUEFSQU0odWxlbik7CisgICAgVU5VU0VE
X1BBUkFNKHBhc3N3b3JkKTsKKyAgICBVTlVTRURfUEFSQU0ocGxlbik7CiAgICAgTE9HKFBsdWdp
bnMsICJQbHVnaW5WaWV3OjpnZXRBdXRoZW50aWNhdGlvbkluZm86IHByb3RvY29sPSVzLCBob3N0
PSVzLCBwb3J0PSVkIiwgcHJvdG9jb2wsIGhvc3QsIHBvcnQpOwogICAgIG5vdEltcGxlbWVudGVk
KCk7CiAgICAgcmV0dXJuIE5QRVJSX0dFTkVSSUNfRVJST1I7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9wbHVnaW5zL2VmbC9QbHVnaW5WaWV3RWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs
dWdpbnMvZWZsL1BsdWdpblZpZXdFZmwuY3BwCmluZGV4IDYwMDY2N2EuLjRlMTM2OGYgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZWZsL1BsdWdpblZpZXdFZmwuY3BwCisrKyBi
L1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZWZsL1BsdWdpblZpZXdFZmwuY3BwCkBAIC0xNTUsNyAr
MTU1LDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXRQYXJlbnQoU2Nyb2xsVmlldyogcGFyZW50KQog
ICAgICAgICBpbml0KCk7CiB9CiAKLXZvaWQgUGx1Z2luVmlldzo6c2V0TlBXaW5kb3dSZWN0KGNv
bnN0IEludFJlY3QmIHJlY3QpCit2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93UmVjdChjb25z
dCBJbnRSZWN0JikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQpAQCAtMzE5LDcgKzMxOSw3
IEBAIHZvaWQgUGx1Z2luVmlldzo6aW52YWxpZGF0ZVJlY3QoTlBSZWN0KiByZWN0KQogICAgIGlu
dmFsaWRhdGVSZWN0KEludFJlY3QocmVjdC0+bGVmdCwgcmVjdC0+dG9wLCByZWN0LT5yaWdodCAt
IHJlY3QtPmxlZnQsIHJlY3QtPmJvdHRvbSAtIHJlY3QtPnRvcCkpOwogfQogCi12b2lkIFBsdWdp
blZpZXc6OmludmFsaWRhdGVSZWdpb24oTlBSZWdpb24gcmVnaW9uKQordm9pZCBQbHVnaW5WaWV3
OjppbnZhbGlkYXRlUmVnaW9uKE5QUmVnaW9uKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cKaW5kZXggMGRhMTc0YS4uZmMzNzYxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp
dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw
IEBACisyMDEyLTEwLTAxICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRl
bC5jb20+CisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdhcm5pbmdzCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODAyMAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiB3YXJuaW5n
cyByZWxhdGVkIHRvIGV3a192aWV3LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdr
X3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192aWV3X2ZlZWRfdG91Y2hfZXZlbnRfdXNpbmdfdG91
Y2hfcG9pbnRfbGlzdF9vZl9ldmFzKToKKyAgICAgICAgKF9ld2tfdmlld19vbl90b3VjaF9kb3du
KToKKyAgICAgICAgKF9ld2tfdmlld19vbl90b3VjaF91cCk6CisgICAgICAgIChfZXdrX3ZpZXdf
b25fdG91Y2hfbW92ZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlf
Y2xpZW50LmNwcDoKKyAgICAgICAgKGV4Y2VlZGVkRGF0YWJhc2VRdW90YSk6CisKIDIwMTItMDkt
MjcgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KIAogICAg
ICAgICBbUXRdIEZpeCB2aWV3cG9ydCBRTUwgYXV0byB0ZXN0cyBhZnRlciB0aGUgdmlld3BvcnQg
Y2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdr
X3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3Bw
CmluZGV4IDQxOTA1NjEuLmRkZDZkNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv
QVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTM4NCwyMSArMzg0LDMwIEBAIHN0YXRpYyBpbmxpbmUg
dm9pZCBfZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudF91c2luZ190b3VjaF9wb2ludF9saXN0X29m
X2V2YXMoRXZhCiAKICAgICB2b2lkKiBkYXRhOwogICAgIEVJTkFfTElTVF9GUkVFKHBvaW50cywg
ZGF0YSkKLSAgICAgICAgZGVsZXRlIGRhdGE7CisgICAgICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxF
d2tfVG91Y2hfUG9pbnQqPihkYXRhKTsKIH0KIAogc3RhdGljIHZvaWQgX2V3a192aWV3X29uX3Rv
dWNoX2Rvd24odm9pZCogZGF0YSwgRXZhcyogY2FudmFzLCBFdmFzX09iamVjdCogZXdrVmlldywg
dm9pZCogZXZlbnRJbmZvKQogeworICAgIFVOVVNFRF9QQVJBTShkYXRhKTsKKyAgICBVTlVTRURf
UEFSQU0oY2FudmFzKTsKKyAgICBVTlVTRURfUEFSQU0oZXZlbnRJbmZvKTsKICAgICBfZXdrX3Zp
ZXdfZmVlZF90b3VjaF9ldmVudF91c2luZ190b3VjaF9wb2ludF9saXN0X29mX2V2YXMoZXdrVmll
dywgRVdLX1RPVUNIX1NUQVJUKTsKIH0KIAogc3RhdGljIHZvaWQgX2V3a192aWV3X29uX3RvdWNo
X3VwKHZvaWQqIGRhdGEsIEV2YXMqIGNhbnZhcywgRXZhc19PYmplY3QqIGV3a1ZpZXcsIHZvaWQq
IGV2ZW50SW5mbykKIHsKKyAgICBVTlVTRURfUEFSQU0oZGF0YSk7CisgICAgVU5VU0VEX1BBUkFN
KGNhbnZhcyk7CisgICAgVU5VU0VEX1BBUkFNKGV2ZW50SW5mbyk7CiAgICAgX2V3a192aWV3X2Zl
ZWRfdG91Y2hfZXZlbnRfdXNpbmdfdG91Y2hfcG9pbnRfbGlzdF9vZl9ldmFzKGV3a1ZpZXcsIEVX
S19UT1VDSF9FTkQpOwogfQogCiBzdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25fdG91Y2hfbW92ZSh2
b2lkKiBkYXRhLCBFdmFzKiBjYW52YXMsIEV2YXNfT2JqZWN0KiBld2tWaWV3LCB2b2lkKiBldmVu
dEluZm8pCiB7CisgICAgVU5VU0VEX1BBUkFNKGRhdGEpOworICAgIFVOVVNFRF9QQVJBTShjYW52
YXMpOworICAgIFVOVVNFRF9QQVJBTShldmVudEluZm8pOwogICAgIF9ld2tfdmlld19mZWVkX3Rv
dWNoX2V2ZW50X3VzaW5nX3RvdWNoX3BvaW50X2xpc3Rfb2ZfZXZhcyhld2tWaWV3LCBFV0tfVE9V
Q0hfTU9WRSk7CiB9CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwCmluZGV4IGYzYmZjZDguLjBiODQ5ZmEg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3Vp
X2NsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Zp
ZXdfdWlfY2xpZW50LmNwcApAQCAtNzQsNyArNzQsNyBAQCBzdGF0aWMgdm9pZCBoaWRlQ29sb3JQ
aWNrZXIoV0tQYWdlUmVmLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogI2VuZGlmCiAKICNpZiBF
TkFCTEUoU1FMX0RBVEFCQVNFKQotc3RhdGljIHVuc2lnbmVkIGxvbmcgbG9uZyBleGNlZWRlZERh
dGFiYXNlUXVvdGEoV0tQYWdlUmVmLCBXS0ZyYW1lUmVmLCBXS1NlY3VyaXR5T3JpZ2luUmVmIG9y
aWdpbiwgV0tTdHJpbmdSZWYgZGF0YWJhc2VOYW1lLCBXS1N0cmluZ1JlZiBkaXNwbGF5TmFtZSwg
dW5zaWduZWQgbG9uZyBsb25nIGN1cnJlbnRRdW90YSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJl
bnRPcmlnaW5Vc2FnZSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJlbnREYXRhYmFzZVVzYWdlLCB1
bnNpZ25lZCBsb25nIGxvbmcgZXhwZWN0ZWRVc2FnZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykK
K3N0YXRpYyB1bnNpZ25lZCBsb25nIGxvbmcgZXhjZWVkZWREYXRhYmFzZVF1b3RhKFdLUGFnZVJl
ZiwgV0tGcmFtZVJlZiwgV0tTZWN1cml0eU9yaWdpblJlZiwgV0tTdHJpbmdSZWYgZGF0YWJhc2VO
YW1lLCBXS1N0cmluZ1JlZiBkaXNwbGF5TmFtZSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJlbnRR
dW90YSwgdW5zaWduZWQgbG9uZyBsb25nIGN1cnJlbnRPcmlnaW5Vc2FnZSwgdW5zaWduZWQgbG9u
ZyBsb25nIGN1cnJlbnREYXRhYmFzZVVzYWdlLCB1bnNpZ25lZCBsb25nIGxvbmcgZXhwZWN0ZWRV
c2FnZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIHsKICAgICByZXR1cm4gZXdrX3ZpZXdfZGF0
YWJhc2VfcXVvdGFfZXhjZWVkZWQodG9Fd2tWaWV3KGNsaWVudEluZm8pLCBXS0VpbmFTaGFyZWRT
dHJpbmcoZGF0YWJhc2VOYW1lKSwgV0tFaW5hU2hhcmVkU3RyaW5nKGRpc3BsYXlOYW1lKSwgY3Vy
cmVudFF1b3RhLCBjdXJyZW50T3JpZ2luVXNhZ2UsIGN1cnJlbnREYXRhYmFzZVVzYWdlLCBleHBl
Y3RlZFVzYWdlKTsKIH0K
</data>
<flag name="review"
          id="178794"
          type_id="1"
          status="-"
          setter="haraken"
    />
    <flag name="commit-queue"
          id="178795"
          type_id="3"
          status="-"
          setter="haraken"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166505</attachid>
            <date>2012-10-01 10:50:01 -0700</date>
            <delta_ts>2012-10-01 12:05:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>98020_warnings.patch</filename>
            <type>text/plain</type>
            <size>6698</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAzNzlhNzJhLi5kM2Y1YWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg
QEAKKzIwMTItMTAtMDEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs
LmNvbT4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2FybmluZ3MKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4MDIwCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdhcm5pbmdz
IGluIFBsdWdpblZpZXcgY29kZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9y
IGNoYW5nZS4KKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpQbHVnaW5WaWV3OjpuZXdTdHJlYW0pOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2lu
Vmlldzo6d3JpdGUpOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6Z2V0QXV0aGVudGlj
YXRpb25JbmZvKToKKyAgICAgICAgKiBwbHVnaW5zL2VmbC9QbHVnaW5WaWV3RWZsLmNwcDoKKyAg
ICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldE5QV2luZG93UmVjdCk6CisgICAgICAgIChX
ZWJDb3JlOjpQbHVnaW5WaWV3OjppbnZhbGlkYXRlUmVnaW9uKToKKwogMjAxMi0xMC0wMSAgWXVy
eSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk
LiBDaHJvbWl1bSBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5z
L1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmNwcApp
bmRleCA5NjcyZTkxLi5mZGMxZWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5z
L1BsdWdpblZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5j
cHAKQEAgLTU4NywxNCArNTg3LDE0IEBAIE5QRXJyb3IgUGx1Z2luVmlldzo6cG9zdFVSTChjb25z
dCBjaGFyKiB1cmwsIGNvbnN0IGNoYXIqIHRhcmdldCwgdWludDMyX3QgbGVuLCBjCiAgICAgcmV0
dXJuIGhhbmRsZVBvc3QodXJsLCB0YXJnZXQsIGxlbiwgYnVmLCBmaWxlLCAwLCBmYWxzZSwgZmls
ZSk7CiB9CiAKLU5QRXJyb3IgUGx1Z2luVmlldzo6bmV3U3RyZWFtKE5QTUlNRVR5cGUgdHlwZSwg
Y29uc3QgY2hhciogdGFyZ2V0LCBOUFN0cmVhbSoqIHN0cmVhbSkKK05QRXJyb3IgUGx1Z2luVmll
dzo6bmV3U3RyZWFtKE5QTUlNRVR5cGUsIGNvbnN0IGNoYXIqIC8qIHRhcmdldCAqLywgTlBTdHJl
YW0qKikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogICAgIC8vIFVuc3VwcG9ydGVkCiAgICAg
cmV0dXJuIE5QRVJSX0dFTkVSSUNfRVJST1I7CiB9CiAKLWludDMyX3QgUGx1Z2luVmlldzo6d3Jp
dGUoTlBTdHJlYW0qIHN0cmVhbSwgaW50MzJfdCBsZW4sIHZvaWQqIGJ1ZmZlcikKK2ludDMyX3Qg
UGx1Z2luVmlldzo6d3JpdGUoTlBTdHJlYW0qLCBpbnQzMl90IC8qIGxlbiAqLywgdm9pZCogLyog
YnVmZmVyICovKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CiAgICAgLy8gVW5zdXBwb3J0ZWQK
QEAgLTE0NzIsNyArMTQ3Miw3IEBAIE5QRXJyb3IgUGx1Z2luVmlldzo6c2V0VmFsdWVGb3JVUkwo
TlBOVVJMVmFyaWFibGUgdmFyaWFibGUsIGNvbnN0IGNoYXIqIHVybCwgY29uCiAgICAgcmV0dXJu
IHJlc3VsdDsKIH0KIAotTlBFcnJvciBQbHVnaW5WaWV3OjpnZXRBdXRoZW50aWNhdGlvbkluZm8o
Y29uc3QgY2hhciogcHJvdG9jb2wsIGNvbnN0IGNoYXIqIGhvc3QsIGludDMyX3QgcG9ydCwgY29u
c3QgY2hhciogc2NoZW1lLCBjb25zdCBjaGFyKiByZWFsbSwgY2hhcioqIHVzZXJuYW1lLCB1aW50
MzJfdCogdWxlbiwgY2hhcioqIHBhc3N3b3JkLCB1aW50MzJfdCogcGxlbikKK05QRXJyb3IgUGx1
Z2luVmlldzo6Z2V0QXV0aGVudGljYXRpb25JbmZvKGNvbnN0IGNoYXIqIHByb3RvY29sLCBjb25z
dCBjaGFyKiBob3N0LCBpbnQzMl90IHBvcnQsIGNvbnN0IGNoYXIqIC8qIHNjaGVtZSAqLywgY29u
c3QgY2hhciogLyogcmVhbG0gKi8sIGNoYXIqKiAgLyogdXNlcm5hbWUgKi8sIHVpbnQzMl90KiAv
KiB1bGVuICovLCBjaGFyKiogLyogcGFzc3dvcmQgKi8sIHVpbnQzMl90KiAvKiBwbGVuICovKQog
ewogICAgIExPRyhQbHVnaW5zLCAiUGx1Z2luVmlldzo6Z2V0QXV0aGVudGljYXRpb25JbmZvOiBw
cm90b2NvbD0lcywgaG9zdD0lcywgcG9ydD0lZCIsIHByb3RvY29sLCBob3N0LCBwb3J0KTsKICAg
ICBub3RJbXBsZW1lbnRlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9l
ZmwvUGx1Z2luVmlld0VmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2VmbC9QbHVnaW5W
aWV3RWZsLmNwcAppbmRleCA2MDA2NjdhLi40ZTEzNjhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9wbHVnaW5zL2VmbC9QbHVnaW5WaWV3RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w
bHVnaW5zL2VmbC9QbHVnaW5WaWV3RWZsLmNwcApAQCAtMTU1LDcgKzE1NSw3IEBAIHZvaWQgUGx1
Z2luVmlldzo6c2V0UGFyZW50KFNjcm9sbFZpZXcqIHBhcmVudCkKICAgICAgICAgaW5pdCgpOwog
fQogCi12b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93UmVjdChjb25zdCBJbnRSZWN0JiByZWN0
KQordm9pZCBQbHVnaW5WaWV3OjpzZXROUFdpbmRvd1JlY3QoY29uc3QgSW50UmVjdCYpCiB7CiAg
ICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KQEAgLTMxOSw3ICszMTksNyBAQCB2b2lkIFBsdWdpblZp
ZXc6OmludmFsaWRhdGVSZWN0KE5QUmVjdCogcmVjdCkKICAgICBpbnZhbGlkYXRlUmVjdChJbnRS
ZWN0KHJlY3QtPmxlZnQsIHJlY3QtPnRvcCwgcmVjdC0+cmlnaHQgLSByZWN0LT5sZWZ0LCByZWN0
LT5ib3R0b20gLSByZWN0LT50b3ApKTsKIH0KIAotdm9pZCBQbHVnaW5WaWV3OjppbnZhbGlkYXRl
UmVnaW9uKE5QUmVnaW9uIHJlZ2lvbikKK3ZvaWQgUGx1Z2luVmlldzo6aW52YWxpZGF0ZVJlZ2lv
bihOUFJlZ2lvbikKIHsKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQpkaWZmIC0tZ2l0IGEvU291
cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGFj
MjU3M2IuLjA2ZDFlYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysg
Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMC0wMSAg
Q2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAg
IEZpeCBjb21waWxhdGlvbiB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9OTgwMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P
UFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2FybmluZ3MgcmVsYXRlZCB0byBld2tf
dmlldy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAg
ICAgKF9ld2tfdmlld19mZWVkX3RvdWNoX2V2ZW50X3VzaW5nX3RvdWNoX3BvaW50X2xpc3Rfb2Zf
ZXZhcyk6CisgICAgICAgIChfZXdrX3ZpZXdfb25fdG91Y2hfZG93bik6CisgICAgICAgIChfZXdr
X3ZpZXdfb25fdG91Y2hfdXApOgorICAgICAgICAoX2V3a192aWV3X29uX3RvdWNoX21vdmUpOgor
ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHA6CisgICAg
ICAgIChleGNlZWRlZERhdGFiYXNlUXVvdGEpOgorCiAyMDEyLTEwLTAxICBDbGF1ZGlvIFNhYXZl
ZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV0syXSBTYXZlIHRo
ZSBkb3dubG9hZCB1cmkgYXMgZmlsZSBtZXRhZGF0YQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDQxOTA1NjEuLjU1OGNkMjIgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9T
b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTM4NCwyMCAr
Mzg0LDIwIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBfZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudF91
c2luZ190b3VjaF9wb2ludF9saXN0X29mX2V2YXMoRXZhCiAKICAgICB2b2lkKiBkYXRhOwogICAg
IEVJTkFfTElTVF9GUkVFKHBvaW50cywgZGF0YSkKLSAgICAgICAgZGVsZXRlIGRhdGE7CisgICAg
ICAgIGRlbGV0ZSBzdGF0aWNfY2FzdDxFd2tfVG91Y2hfUG9pbnQqPihkYXRhKTsKIH0KIAotc3Rh
dGljIHZvaWQgX2V3a192aWV3X29uX3RvdWNoX2Rvd24odm9pZCogZGF0YSwgRXZhcyogY2FudmFz
LCBFdmFzX09iamVjdCogZXdrVmlldywgdm9pZCogZXZlbnRJbmZvKQorc3RhdGljIHZvaWQgX2V3
a192aWV3X29uX3RvdWNoX2Rvd24odm9pZCogLyogZGF0YSAqLywgRXZhcyogLyogY2FudmFzICov
LCBFdmFzX09iamVjdCogZXdrVmlldywgdm9pZCogLyogZXZlbnRJbmZvICovKQogewogICAgIF9l
d2tfdmlld19mZWVkX3RvdWNoX2V2ZW50X3VzaW5nX3RvdWNoX3BvaW50X2xpc3Rfb2ZfZXZhcyhl
d2tWaWV3LCBFV0tfVE9VQ0hfU1RBUlQpOwogfQogCi1zdGF0aWMgdm9pZCBfZXdrX3ZpZXdfb25f
dG91Y2hfdXAodm9pZCogZGF0YSwgRXZhcyogY2FudmFzLCBFdmFzX09iamVjdCogZXdrVmlldywg
dm9pZCogZXZlbnRJbmZvKQorc3RhdGljIHZvaWQgX2V3a192aWV3X29uX3RvdWNoX3VwKHZvaWQq
IC8qIGRhdGEgKi8sIEV2YXMqIC8qIGNhbnZhcyAqLywgRXZhc19PYmplY3QqIGV3a1ZpZXcsIHZv
aWQqIC8qIGV2ZW50SW5mbyAqLykKIHsKICAgICBfZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudF91
c2luZ190b3VjaF9wb2ludF9saXN0X29mX2V2YXMoZXdrVmlldywgRVdLX1RPVUNIX0VORCk7CiB9
CiAKLXN0YXRpYyB2b2lkIF9ld2tfdmlld19vbl90b3VjaF9tb3ZlKHZvaWQqIGRhdGEsIEV2YXMq
IGNhbnZhcywgRXZhc19PYmplY3QqIGV3a1ZpZXcsIHZvaWQqIGV2ZW50SW5mbykKK3N0YXRpYyB2
b2lkIF9ld2tfdmlld19vbl90b3VjaF9tb3ZlKHZvaWQqIC8qIGRhdGEgKi8sIEV2YXMqIC8qIGNh
bnZhcyAqLywgRXZhc19PYmplY3QqIGV3a1ZpZXcsIHZvaWQqIC8qIGV2ZW50SW5mbyAqLykKIHsK
ICAgICBfZXdrX3ZpZXdfZmVlZF90b3VjaF9ldmVudF91c2luZ190b3VjaF9wb2ludF9saXN0X29m
X2V2YXMoZXdrVmlldywgRVdLX1RPVUNIX01PVkUpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcCBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAKaW5kZXggZjNi
ZmNkOC4uMGI4NDlmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l
ZmwvZXdrX3ZpZXdfdWlfY2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv
QVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwCkBAIC03NCw3ICs3NCw3IEBAIHN0YXRpYyB2
b2lkIGhpZGVDb2xvclBpY2tlcihXS1BhZ2VSZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiAj
ZW5kaWYKIAogI2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCi1zdGF0aWMgdW5zaWduZWQgbG9uZyBs
b25nIGV4Y2VlZGVkRGF0YWJhc2VRdW90YShXS1BhZ2VSZWYsIFdLRnJhbWVSZWYsIFdLU2VjdXJp
dHlPcmlnaW5SZWYgb3JpZ2luLCBXS1N0cmluZ1JlZiBkYXRhYmFzZU5hbWUsIFdLU3RyaW5nUmVm
IGRpc3BsYXlOYW1lLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudFF1b3RhLCB1bnNpZ25lZCBs
b25nIGxvbmcgY3VycmVudE9yaWdpblVzYWdlLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudERh
dGFiYXNlVXNhZ2UsIHVuc2lnbmVkIGxvbmcgbG9uZyBleHBlY3RlZFVzYWdlLCBjb25zdCB2b2lk
KiBjbGllbnRJbmZvKQorc3RhdGljIHVuc2lnbmVkIGxvbmcgbG9uZyBleGNlZWRlZERhdGFiYXNl
UXVvdGEoV0tQYWdlUmVmLCBXS0ZyYW1lUmVmLCBXS1NlY3VyaXR5T3JpZ2luUmVmLCBXS1N0cmlu
Z1JlZiBkYXRhYmFzZU5hbWUsIFdLU3RyaW5nUmVmIGRpc3BsYXlOYW1lLCB1bnNpZ25lZCBsb25n
IGxvbmcgY3VycmVudFF1b3RhLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudE9yaWdpblVzYWdl
LCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudERhdGFiYXNlVXNhZ2UsIHVuc2lnbmVkIGxvbmcg
bG9uZyBleHBlY3RlZFVzYWdlLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQogewogICAgIHJldHVy
biBld2tfdmlld19kYXRhYmFzZV9xdW90YV9leGNlZWRlZCh0b0V3a1ZpZXcoY2xpZW50SW5mbyks
IFdLRWluYVNoYXJlZFN0cmluZyhkYXRhYmFzZU5hbWUpLCBXS0VpbmFTaGFyZWRTdHJpbmcoZGlz
cGxheU5hbWUpLCBjdXJyZW50UXVvdGEsIGN1cnJlbnRPcmlnaW5Vc2FnZSwgY3VycmVudERhdGFi
YXNlVXNhZ2UsIGV4cGVjdGVkVXNhZ2UpOwogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>