98015 2012-10-01 04:28:09 -0700 Check that __cplusplus is defined before comparing its value 2012-10-01 05:28:34 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 berto webkit-unassigned benjamin mrobinson webkit.review.bot oldest_to_newest 731572 0 berto 2012-10-01 04:28:09 -0700 There's this condition in WTF/wtf/Compiler.h: #if GCC_VERSION_AT_LEAST(4, 7, 0) && __cplusplus >= 201103L If __cplusplus is not defined is interpreted as having the value 0, but it produces a compilation warning with -Wundef. This is the case with some API tests that are written in C (JSNode.c, JSNodeList.c, minidom.c). 731577 1 166449 berto 2012-10-01 04:31:01 -0700 Created attachment 166449 Patch 731592 2 166449 xan.lopez 2012-10-01 05:04:41 -0700 Comment on attachment 166449 Patch LGTM. 731605 3 166449 webkit.review.bot 2012-10-01 05:28:31 -0700 Comment on attachment 166449 Patch Clearing flags on attachment: 166449 Committed r130039: <http://trac.webkit.org/changeset/130039> 731606 4 webkit.review.bot 2012-10-01 05:28:34 -0700 All reviewed patches have been landed. Closing bug. 166449 2012-10-01 04:31:01 -0700 2012-10-01 05:28:31 -0700 Patch cplusplus.diff text/plain 1325 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTRmOTg5ZS4uYTUwOGNlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMC0wMSAg QWxiZXJ0byBHYXJjaWEgIDxhZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgQ2hlY2sgdGhh dCBfX2NwbHVzcGx1cyBpcyBkZWZpbmVkIGJlZm9yZSBjb21wYXJpbmcgaXRzIHZhbHVlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODAxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIF9fY3BsdXNwbHVz IGlzIG5vdCBkZWZpbmVkIGlzIGludGVycHJldGVkIGFzIGhhdmluZyB0aGUgdmFsdWUKKyAgICAg ICAgMCwgYnV0IGl0IHByb2R1Y2VzIGEgY29tcGlsYXRpb24gd2FybmluZyB3aXRoIC1XdW5kZWYu CisKKyAgICAgICAgVGhpcyBpcyB0aGUgY2FzZSB3aXRoIHNvbWUgQVBJIHRlc3RzIHRoYXQgYXJl IHdyaXR0ZW4gaW4gQworICAgICAgICAoSlNOb2RlLmMsIEpTTm9kZUxpc3QuYywgbWluaWRvbS5j KS4KKworICAgICAgICAqIHd0Zi9Db21waWxlci5oOgorCiAyMDEyLTA5LTMwICBNYXJrIEhhaG5l bmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgSGFzVHJp dmlhbENvbnN0cnVjdG9yL0Rlc3RydWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Nv bXBpbGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCmluZGV4IGUzZTE4YTguLmE5ZWY0 MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmgKKysrIGIvU291cmNlL1dU Ri93dGYvQ29tcGlsZXIuaApAQCAtMTIyLDcgKzEyMiw3IEBACiAKIC8qIFNwZWNpZmljIGNvbXBp bGVyIGZlYXR1cmVzICovCiAjaWYgQ09NUElMRVIoR0NDKSAmJiAhQ09NUElMRVIoQ0xBTkcpCi0j aWYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgNywgMCkgJiYgX19jcGx1c3BsdXMgPj0gMjAxMTAz TAorI2lmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDcsIDApICYmIGRlZmluZWQoX19jcGx1c3Bs dXMpICYmIF9fY3BsdXNwbHVzID49IDIwMTEwM0wKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBP UlRTX0NYWF9SVkFMVUVfUkVGRVJFTkNFUyAxCiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQT1JU U19DWFhfREVMRVRFRF9GVU5DVElPTlMgMQogI2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNf Q1hYX05VTExQVFIgMQo=