97995 2012-10-01 00:00:48 -0700 Remove unused sys/mman.h include 2012-10-01 14:28:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 net147 webkit-unassigned barraclough darin ggaren haraken hausmann webkit.review.bot oldest_to_newest 731414 0 net147 2012-10-01 00:00:48 -0700 Source/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp contains an include for sys/mman.h that isn't used. As sys/mman.h is not available on all operating systems, this also improves portability. 731418 1 166415 net147 2012-10-01 00:05:40 -0700 Created attachment 166415 Patch 731462 2 166415 haraken 2012-10-01 01:15:11 -0700 Comment on attachment 166415 Patch ok 731471 3 166415 webkit.review.bot 2012-10-01 01:35:43 -0700 Comment on attachment 166415 Patch Clearing flags on attachment: 166415 Committed r130014: <http://trac.webkit.org/changeset/130014> 731472 4 webkit.review.bot 2012-10-01 01:35:46 -0700 All reviewed patches have been landed. Closing bug. 731984 5 166415 darin 2012-10-01 14:28:21 -0700 Comment on attachment 166415 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166415&action=review > Source/JavaScriptCore/ChangeLog:9 > + The sys/mman.h is not used and removing it improves portability as not > + all systems have sys/mman.h. Where did you get the information <sys/mman.h> is not used? On OS X the madvise function and MADV_FREE constant that are used in this file is from that header. The correct change would be to put this include inside #if OS(DARWIN). Unless there is some other reason that we don’t need the include on OS X that I am not aware of. 166415 2012-10-01 00:05:40 -0700 2012-10-01 14:28:20 -0700 Patch bug-97995.patch text/plain 1233 net147 SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMwMDA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTEwLTAxICBKb25hdGhhbiBMaXUgIDxuZXQxNDdAZ21haWwuY29tPgorCisgICAgICAg IFJlbW92ZSB1bnVzZWQgc3lzL21tYW4uaCBpbmNsdWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Nzk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzeXMvbW1hbi5oIGlzIG5vdCB1c2VkIGFuZCBy ZW1vdmluZyBpdCBpbXByb3ZlcyBwb3J0YWJpbGl0eSBhcyBub3QKKyAgICAgICAgYWxsIHN5c3Rl bXMgaGF2ZSBzeXMvbW1hbi5oLgorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JG aXhlZFZNUG9vbC5jcHA6CisKIDIwMTItMDktMjggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBBU1NFUlRJT04gaW4gbV9ncmFwaFt0YWlsTm9kZUluZGV4XS5vcCgp ID09IEZsdXNoIHx8IG1fZ3JhcGhbdGFpbE5vZGVJbmRleF0ub3AoKSA9PSBTZXRMb2NhbCBvbiBw bHVzLmdvb2dsZS5jb20KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJs ZUFsbG9jYXRvckZpeGVkVk1Qb29sLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9vbC5jcHAJKHJldmlzaW9uIDEz MDAwNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvckZp eGVkVk1Qb29sLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzEsNyArMzEsNiBAQAogCiAjaW5jbHVk ZSAiQ29kZVByb2ZpbGluZy5oIgogI2luY2x1ZGUgPGVycm5vLmg+Ci0jaW5jbHVkZSA8c3lzL21t YW4uaD4KICNpbmNsdWRlIDx1bmlzdGQuaD4KICNpbmNsdWRlIDx3dGYvTWV0YUFsbG9jYXRvci5o PgogI2luY2x1ZGUgPHd0Zi9QYWdlUmVzZXJ2YXRpb24uaD4K