97988 2012-09-30 19:02:04 -0700 Crash on FrameTree::scopedChildCount() 2012-09-30 22:56:39 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita rniwa tkent webkit.review.bot oldest_to_newest 731362 0 morrita 2012-09-30 19:02:04 -0700 This upstreams http://code.google.com/p/chromium/issues/detail?id=131646 731363 1 166398 morrita 2012-09-30 19:06:40 -0700 Created attachment 166398 Patch 731368 2 166398 tkent 2012-09-30 20:16:41 -0700 Comment on attachment 166398 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166398&action=review > Source/WebCore/page/FrameTree.cpp:211 > + Document* document = m_thisFrame->document(); > + if (!document) > + return 0; > + return scopedChild(index, document); Can you make scopedChild(unsigned, TreeScope*) and scopedChild(TreeScope*) accept null for TreeScope* ? 731379 3 166405 morrita 2012-09-30 21:46:31 -0700 Created attachment 166405 Patch 731380 4 morrita 2012-09-30 21:47:23 -0700 Kent-san, thanks for reviewing! (In reply to comment #2) > > Can you make scopedChild(unsigned, TreeScope*) and scopedChild(TreeScope*) accept null for TreeScope* ? Done. 731382 5 166405 tkent 2012-09-30 21:57:03 -0700 Comment on attachment 166405 Patch ok 731391 6 166405 webkit.review.bot 2012-09-30 22:56:36 -0700 Comment on attachment 166405 Patch Clearing flags on attachment: 166405 Committed r130006: <http://trac.webkit.org/changeset/130006> 731392 7 webkit.review.bot 2012-09-30 22:56:39 -0700 All reviewed patches have been landed. Closing bug. 166398 2012-09-30 19:06:40 -0700 2012-09-30 21:46:28 -0700 Patch bug-97988-20121001110553.patch text/plain 2283 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY2ZjQ1MjBmNDkzOGE5 MjRkMzVkNWFmOTQ2MWUyZDk4YWRhYWY0Zi4uZWQ1MTY1OGU1OGQ2Y2Y4YWZiMmRkZjk1NGEyNzQx MTA1NDM0YjBmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTMwICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Nzk4OAorICAgICAgICBDcmFzaCBvbiBGcmFtZVRy ZWU6OnNjb3BlZENoaWxkQ291bnQoKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBzZXJpZXMgb2YgY3Jhc2ggcmVwb3J0cyBzYXlzIHRoYXQgdGhl cmUgYXJlIHNvbWUgbnVsbCBwb2ludGVyCisgICAgICAgIGFjY2VzcyBpbiBzY29wZWRDaGlsZENv dW50KCkuIFRoaXMgY2hhbmdlIGFkZGVkIGEgbnVsbCBndWFyZAorICAgICAgICBhZ2FpbnN0IEZy YW1lOjpkb2N1bWVudCgpLCB0aGF0IGNhbiByZXR1cm4gbnVsbC4KKworICAgICAgICBObyBuZXcg dGVzdHMuIFRoaXMgaXMgdGllZCB0byBzb21lIHNwZWNpZmljIHRpbWluZyBhbmQgaXMgaGFyZCB0 byByZXByb2R1Y2UuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVHJlZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVRyZWU6OnNjb3BlZENoaWxkKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l VHJlZTo6c2NvcGVkQ2hpbGRDb3VudCk6CisKIDIwMTItMDktMzAgIEFuZHJlYXMgS2xpbmcgIDxr bGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFNwbGl0IEV2ZW50VGFyZ2V0RGF0YSBvdXQgb2Yg Tm9kZVJhcmVEYXRhIHRvIHJlZHVjZSBtZW1vcnkgdXNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVRyZWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVRyZWUu Y3BwCmluZGV4IDZmODE3MTQ1MDE5MjJmYjhhZGQ4ZTc2NGI5NTc4OTk0ZDBkODUwNWMuLjZiYmQ0 NDU2Mzg0MWFmZjEzZTdiYjkwMzNiMjM4NWJlNmI4MWNkNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVUcmVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l VHJlZS5jcHAKQEAgLTIwNSwxOCArMjA1LDI5IEBAIGlubGluZSB1bnNpZ25lZCBGcmFtZVRyZWU6 OnNjb3BlZENoaWxkQ291bnQoVHJlZVNjb3BlKiBzY29wZSkgY29uc3QKIAogRnJhbWUqIEZyYW1l VHJlZTo6c2NvcGVkQ2hpbGQodW5zaWduZWQgaW5kZXgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIHNj b3BlZENoaWxkKGluZGV4LCBtX3RoaXNGcmFtZS0+ZG9jdW1lbnQoKSk7CisgICAgRG9jdW1lbnQq IGRvY3VtZW50ID0gbV90aGlzRnJhbWUtPmRvY3VtZW50KCk7CisgICAgaWYgKCFkb2N1bWVudCkK KyAgICAgICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIHNjb3BlZENoaWxkKGluZGV4LCBkb2N1bWVu dCk7CiB9CiAKIEZyYW1lKiBGcmFtZVRyZWU6OnNjb3BlZENoaWxkKGNvbnN0IEF0b21pY1N0cmlu ZyYgbmFtZSkgY29uc3QKIHsKLSAgICByZXR1cm4gc2NvcGVkQ2hpbGQobmFtZSwgbV90aGlzRnJh bWUtPmRvY3VtZW50KCkpOworICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG1fdGhpc0ZyYW1lLT5k b2N1bWVudCgpOworICAgIGlmICghZG9jdW1lbnQpCisgICAgICAgIHJldHVybiAwOworICAgIHJl dHVybiBzY29wZWRDaGlsZChuYW1lLCBkb2N1bWVudCk7CiB9CiAKIHVuc2lnbmVkIEZyYW1lVHJl ZTo6c2NvcGVkQ2hpbGRDb3VudCgpIGNvbnN0CiB7Ci0gICAgaWYgKG1fc2NvcGVkQ2hpbGRDb3Vu dCA9PSBpbnZhbGlkQ291bnQpCi0gICAgICAgIG1fc2NvcGVkQ2hpbGRDb3VudCA9IHNjb3BlZENo aWxkQ291bnQobV90aGlzRnJhbWUtPmRvY3VtZW50KCkpOworICAgIGlmIChtX3Njb3BlZENoaWxk Q291bnQgPT0gaW52YWxpZENvdW50KSB7CisgICAgICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG1f dGhpc0ZyYW1lLT5kb2N1bWVudCgpOworICAgICAgICBpZiAoIWRvY3VtZW50KQorICAgICAgICAg ICAgcmV0dXJuIDA7CisgICAgICAgIG1fc2NvcGVkQ2hpbGRDb3VudCA9IHNjb3BlZENoaWxkQ291 bnQoZG9jdW1lbnQpOworICAgIH0KKwogICAgIHJldHVybiBtX3Njb3BlZENoaWxkQ291bnQ7CiB9 CiAK 166405 2012-09-30 21:46:31 -0700 2012-09-30 22:56:35 -0700 Patch bug-97988-20121001134545.patch text/plain 2450 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY2ZjQ1MjBmNDkzOGE5 MjRkMzVkNWFmOTQ2MWUyZDk4YWRhYWY0Zi4uYzg0ZjkyOTg0MTMwNjI1OTk0NjRhNWM3NTk1N2I0 OTFmMjJiMjQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTMwICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Nzk4OAorICAgICAgICBDcmFzaCBvbiBGcmFtZVRy ZWU6OnNjb3BlZENoaWxkQ291bnQoKQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBzZXJpZXMgb2YgY3Jhc2ggcmVwb3J0cyBzYXlzIHRoYXQgdGhl cmUgYXJlIHNvbWUgbnVsbCBwb2ludGVyCisgICAgICAgIGFjY2VzcyBpbiBzY29wZWRDaGlsZENv dW50KCkuIFRoaXMgY2hhbmdlIGFkZGVkIGEgbnVsbCBndWFyZAorICAgICAgICBhZ2FpbnN0IEZy YW1lOjpkb2N1bWVudCgpLCB0aGF0IGNhbiByZXR1cm4gbnVsbC4KKworICAgICAgICBObyBuZXcg dGVzdHMuIFRoaXMgaXMgdGllZCB0byBzb21lIHNwZWNpZmljIHRpbWluZyBhbmQgaXMgaGFyZCB0 byByZXByb2R1Y2UuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVHJlZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVRyZWU6OnNjb3BlZENoaWxkQ291bnQpOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVUcmVlOjpzY29wZWRDaGlsZCk6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0wOS0z MCAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU3BsaXQgRXZl bnRUYXJnZXREYXRhIG91dCBvZiBOb2RlUmFyZURhdGEgdG8gcmVkdWNlIG1lbW9yeSB1c2UuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVHJlZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVHJlZS5jcHAKaW5kZXggNmY4MTcxNDUwMTkyMmZiOGFkZDhlNzY0Yjk1 Nzg5OTRkMGQ4NTA1Yy4uMWUwYWZlMWRkYzdkODU0MTE3ZmFkODdkYmVjYzA5OWFkNGZlNjVlNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVRyZWUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVUcmVlLmNwcApAQCAtMTcyLDYgKzE3Miw5IEBAIEF0b21pY1N0 cmluZyBGcmFtZVRyZWU6OnVuaXF1ZUNoaWxkTmFtZShjb25zdCBBdG9taWNTdHJpbmcmIHJlcXVl c3RlZE5hbWUpIGNvbnN0CiAKIGlubGluZSBGcmFtZSogRnJhbWVUcmVlOjpzY29wZWRDaGlsZCh1 bnNpZ25lZCBpbmRleCwgVHJlZVNjb3BlKiBzY29wZSkgY29uc3QKIHsKKyAgICBpZiAoIXNjb3Bl KQorICAgICAgICByZXR1cm4gMDsKKwogICAgIHVuc2lnbmVkIHNjb3BlZEluZGV4ID0gMDsKICAg ICBmb3IgKEZyYW1lKiByZXN1bHQgPSBmaXJzdENoaWxkKCk7IHJlc3VsdDsgcmVzdWx0ID0gcmVz dWx0LT50cmVlKCktPm5leHRTaWJsaW5nKCkpIHsKICAgICAgICAgaWYgKHJlc3VsdC0+aW5TY29w ZShzY29wZSkpIHsKQEAgLTE4Niw2ICsxODksOSBAQCBpbmxpbmUgRnJhbWUqIEZyYW1lVHJlZTo6 c2NvcGVkQ2hpbGQodW5zaWduZWQgaW5kZXgsIFRyZWVTY29wZSogc2NvcGUpIGNvbnN0CiAKIGlu bGluZSBGcmFtZSogRnJhbWVUcmVlOjpzY29wZWRDaGlsZChjb25zdCBBdG9taWNTdHJpbmcmIG5h bWUsIFRyZWVTY29wZSogc2NvcGUpIGNvbnN0CiB7CisgICAgaWYgKCFzY29wZSkKKyAgICAgICAg cmV0dXJuIDA7CisKICAgICBmb3IgKEZyYW1lKiBjaGlsZCA9IGZpcnN0Q2hpbGQoKTsgY2hpbGQ7 IGNoaWxkID0gY2hpbGQtPnRyZWUoKS0+bmV4dFNpYmxpbmcoKSkKICAgICAgICAgaWYgKGNoaWxk LT50cmVlKCktPnVuaXF1ZU5hbWUoKSA9PSBuYW1lICYmIGNoaWxkLT5pblNjb3BlKHNjb3BlKSkK ICAgICAgICAgICAgIHJldHVybiBjaGlsZDsKQEAgLTE5NCw2ICsyMDAsOSBAQCBpbmxpbmUgRnJh bWUqIEZyYW1lVHJlZTo6c2NvcGVkQ2hpbGQoY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lLCBUcmVl U2NvcGUqIHNjb3BlKQogCiBpbmxpbmUgdW5zaWduZWQgRnJhbWVUcmVlOjpzY29wZWRDaGlsZENv dW50KFRyZWVTY29wZSogc2NvcGUpIGNvbnN0CiB7CisgICAgaWYgKCFzY29wZSkKKyAgICAgICAg cmV0dXJuIDA7CisKICAgICB1bnNpZ25lZCBzY29wZWRDb3VudCA9IDA7CiAgICAgZm9yIChGcmFt ZSogcmVzdWx0ID0gZmlyc3RDaGlsZCgpOyByZXN1bHQ7IHJlc3VsdCA9IHJlc3VsdC0+dHJlZSgp LT5uZXh0U2libGluZygpKSB7CiAgICAgICAgIGlmIChyZXN1bHQtPmluU2NvcGUoc2NvcGUpKQo=