97977 2012-09-30 11:40:15 -0700 Remove FIXME comments refering to non-existent code in JSDOMBinding.cpp 2012-09-30 12:35:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mkwst mkwst abarth fpizlo webkit.review.bot oldest_to_newest 731309 0 mkwst 2012-09-30 11:40:15 -0700 Remove FIXME comments refering to non-existent code in JSDOMBinding.cpp 731310 1 166387 mkwst 2012-09-30 11:42:02 -0700 Created attachment 166387 Patch 731311 2 mkwst 2012-09-30 11:44:28 -0700 Hi Filip and Adam. It looks like you two were the last to touch this code. Is removing these FIXMEs appropriate, or is there really a method somewhere that they're referring to? 731312 3 166387 abarth 2012-09-30 12:08:38 -0700 Comment on attachment 166387 Patch Yeah, sorry. I fixed that FIXME already. :) 731315 4 166387 webkit.review.bot 2012-09-30 12:35:39 -0700 Comment on attachment 166387 Patch Clearing flags on attachment: 166387 Committed r129995: <http://trac.webkit.org/changeset/129995> 731316 5 webkit.review.bot 2012-09-30 12:35:42 -0700 All reviewed patches have been landed. Closing bug. 166387 2012-09-30 11:42:02 -0700 2012-09-30 12:35:39 -0700 Patch bug-97977-20120930204116.patch text/plain 2292 mkwst U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE2N2FiOWJlNjRmMDVm OWZhMmM0MDkyZjMxMTRmYWFkM2E4Y2VhOS4uY2FlNzRkNjg3MTFhMzJkMDVmMDkzYTE3ZWFhNjI2 ODhkMzc0OTRkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTMwICBNaWtl IFdlc3QgIDxta3dzdEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIEZJWE1FIGNvbW1l bnRzIHJlZmVyaW5nIHRvIG5vbi1leGlzdGVudCBjb2RlIGluIEpTRE9NQmluZGluZy5jcHAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3OTc3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBkaWQgYSBxdWlj ayBncmVwIHRocm91Z2ggdGhlIGNvZGUgdG8gZGV0ZXJtaW5lIHdoZXJlIHRoZXNlIEZJWE1FCisg ICAgICAgIGNvbW1lbnRzIHdlcmUgc3VnZ2VzdGluZyB0aGF0IGNvZGUgc2hvdWxkIGJlIG1lcmdl ZC4gU28gZmFyIGFzIEkgY2FuCisgICAgICAgIHRlbGwsICdpbW1lZGlhdGVseVJlcG9ydFVuc2Fm ZUFjY2Vzc1RvJyBvbmx5IGV4aXN0cyBpbiB0aGVzZSBjb21tZW50cy4KKworICAgICAgICBKdXN0 IGNsZWFudXAsIG5vIGZ1bmN0aW9uYWwgY2hhbmdlLgorCisgICAgICAgICogYmluZGluZ3MvanMv SlNET01CaW5kaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNob3VsZEFsbG93QWNjZXNzVG9G cmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpzaG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KToK KwogMjAxMi0wOS0yOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IFtWOF0gVGhlIGNvbmNlcHQgb2YgZm9yY2VOZXdPYmplY3QgaXMgdW5uZWVkZWQgKGRvbS10cmF2 ZXJzZSBnZXRzIDMlIGZhc3RlcikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTRE9NQmluZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJp bmRpbmcuY3BwCmluZGV4IGZlMDg0ZWE0ZGZiNDAyMjU2N2QxNzY0YzY4M2Q3ZmM3Zjg1OTNmZmUu LmRkNmNkZmFkYjkyMmY5NjdkOGQ4NTNkMmU4MzYyNmI5YWQ4MmI5YmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcApAQCAtMjIzLDcgKzIyMyw2IEBAIGJv b2wgc2hvdWxkQWxsb3dBY2Nlc3NUb0ZyYW1lKEV4ZWNTdGF0ZSogZXhlYywgRnJhbWUqIGZyYW1l LCBTdHJpbmcmIG1lc3NhZ2UpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoQmluZGlu Z1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRnJhbWUoZXhlYywgZnJhbWUsIERvTm90UmVw b3J0U2VjdXJpdHlFcnJvcikpCiAgICAgICAgIHJldHVybiB0cnVlOwotICAgIC8vIEZJWE1FOiBU aGUgZm9sbG93aW5nIGxpbmUgb2YgY29kZSBzaG91bGQgbW92ZSBzb21ld2hlcmUgdGhhdCBpdCBj YW4gYmUgc2hhcmVkIHdpdGggaW1tZWRpYXRlbHlSZXBvcnRVbnNhZmVBY2Nlc3NUby4KICAgICBt ZXNzYWdlID0gZnJhbWUtPmRvY3VtZW50KCktPmRvbVdpbmRvdygpLT5jcm9zc0RvbWFpbkFjY2Vz c0Vycm9yTWVzc2FnZShhY3RpdmVET01XaW5kb3coZXhlYykpOwogICAgIHJldHVybiBmYWxzZTsK IH0KQEAgLTIzNCw3ICsyMzMsNiBAQCBib29sIHNob3VsZEFsbG93QWNjZXNzVG9ET01XaW5kb3co RXhlY1N0YXRlKiBleGVjLCBET01XaW5kb3cqIHRhcmdldCwgU3RyaW5nJiBtZQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgaWYgKEJpbmRpbmdTZWN1cml0eTo6c2hvdWxkQWxsb3dBY2Nlc3NU b0RPTVdpbmRvdyhleGVjLCB0YXJnZXQsIERvTm90UmVwb3J0U2VjdXJpdHlFcnJvcikpCiAgICAg ICAgIHJldHVybiB0cnVlOwotICAgIC8vIEZJWE1FOiBUaGUgZm9sbG93aW5nIGxpbmUgb2YgY29k ZSBzaG91bGQgbW92ZSBzb21ld2hlcmUgdGhhdCBpdCBjYW4gYmUgc2hhcmVkIHdpdGggaW1tZWRp YXRlbHlSZXBvcnRVbnNhZmVBY2Nlc3NUby4KICAgICBtZXNzYWdlID0gdGFyZ2V0LT5jcm9zc0Rv bWFpbkFjY2Vzc0Vycm9yTWVzc2FnZShhY3RpdmVET01XaW5kb3coZXhlYykpOwogICAgIHJldHVy biBmYWxzZTsKIH0K