97944 2012-09-28 15:20:07 -0700 Slightly improve clarity of the patch in bug 78595. 2012-09-29 02:21:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov cmarcelo kling koivisto macpherson menard webkit.review.bot oldest_to_newest 731024 0 dglazkov 2012-09-28 15:20:07 -0700 Slightly improve clarity of the patch in bug 78595. 731025 1 166323 dglazkov 2012-09-28 15:22:59 -0700 Created attachment 166323 Patch 731162 2 166323 webkit.review.bot 2012-09-29 02:20:56 -0700 Comment on attachment 166323 Patch Clearing flags on attachment: 166323 Committed r129974: <http://trac.webkit.org/changeset/129974> 731163 3 webkit.review.bot 2012-09-29 02:21:00 -0700 All reviewed patches have been landed. Closing bug. 166323 2012-09-28 15:22:59 -0700 2012-09-29 02:20:56 -0700 Patch bug-97944-20120928152216.patch text/plain 5620 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2YxZTQ4MGE2ZjUyMTI1 NWQ0MTExMzc1YmQyN2IxZmVjM2JkZTI1ZC4uYzExOGYxNzFlMTU5MTk2MzYzMjRjOTBlNmEyZGYw NDg3NDYzYTJhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTI4ICBEaW1p dHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU2xpZ2h0bHkg aW1wcm92ZSBjbGFyaXR5IG9mIHRoZSBwYXRjaCBpbiBidWcgNzg1OTUuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Nzk0NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIGFsbCB0eXBlcyBvZiByZWxh dGlvbnMsIGV4Y2VwdCBTdWJTZWxlY3RvciBhcmUgZWZmZWN0aXZlbHkgaWdub3JpbmcgdGhlIGNh bGN1bGF0ZWQgdmFsdWUgb2YgcHNldWRvSWQsIG1ha2UgdGhlIGNvZGUgcmVmbGVjdCB0aGF0IGEg Yml0IG1vcmUgY2xlYXJseS4gCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLCBjb3Zl cmVkIGJ5IHRlc3QgaW4gYnVnIDc4NTk1LgorCisgICAgICAgICogY3NzL1NlbGVjdG9yQ2hlY2tl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNoZWNrZXI6OmNoZWNrU2VsZWN0b3Ip OiBBZGRlZCBpZ25vcmVEeW5hbWljUHNldWRvIHZhbHVlIHRoYXQncyBnaXZlbiB0byBhbGwgY2Fs bHNpdGVzIHRoYXQgc2hvdWxkIGlnbm9yZSB0aGUgcmVzdWx0LgorCiAyMDEyLTA5LTI4ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRlZmluZSBDaHVua2VkUmVhZGVyIGludGVyZmFjZSBmb3IgY29tcGlsYXRpb24KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKaW5kZXggYzFmYzM2MWI0ZTU2ODA5Y2ZiZGM3 OTgxYWQ3MmQ1N2E0MjUyM2Y3ZS4uNDgxMDM5ZjQzZjg0NGRjODczNDg3NjQzYWE1OTQ2ZTJkNjJl MzczYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKQEAgLTQ1Niw2ICs0 NTYsNyBAQCBTZWxlY3RvckNoZWNrZXI6OlNlbGVjdG9yTWF0Y2ggU2VsZWN0b3JDaGVja2VyOjpj aGVja1NlbGVjdG9yKGNvbnN0IFNlbGVjdG9yQ2hlYwogICAgIFNlbGVjdG9yQ2hlY2tpbmdDb250 ZXh0IG5leHRDb250ZXh0KGNvbnRleHQpOwogICAgIG5leHRDb250ZXh0LnNlbGVjdG9yID0gaGlz dG9yeVNlbGVjdG9yOwogCisgICAgUHNldWRvSWQgaWdub3JlRHluYW1pY1BzZXVkbyA9IE5PUFNF VURPOwogICAgIGlmIChyZWxhdGlvbiAhPSBDU1NTZWxlY3Rvcjo6U3ViU2VsZWN0b3IpIHsKICAg ICAgICAgLy8gQWJvcnQgaWYgdGhlIG5leHQgc2VsZWN0b3Igd291bGQgZXhjZWVkIHRoZSBzY29w ZS4KICAgICAgICAgaWYgKGNvbnRleHQuZWxlbWVudCA9PSBjb250ZXh0LnNjb3BlKQpAQCAtNDcy LDkgKzQ3Myw2IEBAIFNlbGVjdG9yQ2hlY2tlcjo6U2VsZWN0b3JNYXRjaCBTZWxlY3RvckNoZWNr ZXI6OmNoZWNrU2VsZWN0b3IoY29uc3QgU2VsZWN0b3JDaGVjCiAgICAgICAgIG5leHRDb250ZXh0 LnBzZXVkb1N0eWxlID0gTk9QU0VVRE87CiAgICAgfQogCi0gICAgUHNldWRvSWQgbm9uU3ViU2Vs ZWN0b3JQc2V1ZG8oTk9QU0VVRE8pOwotICAgIFBzZXVkb0lkJiBjdXJyZW50RHluYW1pY1BzZXVk byA9IHJlbGF0aW9uID09IENTU1NlbGVjdG9yOjpTdWJTZWxlY3RvciA/IGR5bmFtaWNQc2V1ZG8g OiBub25TdWJTZWxlY3RvclBzZXVkbzsKLQogICAgIHN3aXRjaCAocmVsYXRpb24pIHsKICAgICBj YXNlIENTU1NlbGVjdG9yOjpEZXNjZW5kYW50OgogICAgICAgICBuZXh0Q29udGV4dC5lbGVtZW50 ID0gY29udGV4dC5lbGVtZW50LT5wYXJlbnRFbGVtZW50KCk7CkBAIC00ODIsNyArNDgwLDcgQEAg U2VsZWN0b3JDaGVja2VyOjpTZWxlY3Rvck1hdGNoIFNlbGVjdG9yQ2hlY2tlcjo6Y2hlY2tTZWxl Y3Rvcihjb25zdCBTZWxlY3RvckNoZWMKICAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudFN0eWxl ID0gMDsKICAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudFBhcmVudFN0eWxlID0gMDsKICAgICAg ICAgZm9yICg7IG5leHRDb250ZXh0LmVsZW1lbnQ7IG5leHRDb250ZXh0LmVsZW1lbnQgPSBuZXh0 Q29udGV4dC5lbGVtZW50LT5wYXJlbnRFbGVtZW50KCkpIHsKLSAgICAgICAgICAgIFNlbGVjdG9y TWF0Y2ggbWF0Y2ggPSBjaGVja1NlbGVjdG9yKG5leHRDb250ZXh0LCBjdXJyZW50RHluYW1pY1Bz ZXVkbywgaGFzVW5rbm93blBzZXVkb0VsZW1lbnRzKTsKKyAgICAgICAgICAgIFNlbGVjdG9yTWF0 Y2ggbWF0Y2ggPSBjaGVja1NlbGVjdG9yKG5leHRDb250ZXh0LCBpZ25vcmVEeW5hbWljUHNldWRv LCBoYXNVbmtub3duUHNldWRvRWxlbWVudHMpOwogICAgICAgICAgICAgaWYgKG1hdGNoID09IFNl bGVjdG9yTWF0Y2hlcyB8fCBtYXRjaCA9PSBTZWxlY3RvckZhaWxzQ29tcGxldGVseSkKICAgICAg ICAgICAgICAgICByZXR1cm4gbWF0Y2g7CiAgICAgICAgICAgICBpZiAobmV4dENvbnRleHQuZWxl bWVudCA9PSBuZXh0Q29udGV4dC5zY29wZSkKQEAgLTQ5Nyw3ICs0OTUsNyBAQCBTZWxlY3RvckNo ZWNrZXI6OlNlbGVjdG9yTWF0Y2ggU2VsZWN0b3JDaGVja2VyOjpjaGVja1NlbGVjdG9yKGNvbnN0 IFNlbGVjdG9yQ2hlYwogICAgICAgICBuZXh0Q29udGV4dC5pc1N1YlNlbGVjdG9yID0gZmFsc2U7 CiAgICAgICAgIG5leHRDb250ZXh0LmVsZW1lbnRTdHlsZSA9IDA7CiAgICAgICAgIG5leHRDb250 ZXh0LmVsZW1lbnRQYXJlbnRTdHlsZSA9IDA7Ci0gICAgICAgIHJldHVybiBjaGVja1NlbGVjdG9y KG5leHRDb250ZXh0LCBjdXJyZW50RHluYW1pY1BzZXVkbywgaGFzVW5rbm93blBzZXVkb0VsZW1l bnRzKTsKKyAgICAgICAgcmV0dXJuIGNoZWNrU2VsZWN0b3IobmV4dENvbnRleHQsIGlnbm9yZUR5 bmFtaWNQc2V1ZG8sIGhhc1Vua25vd25Qc2V1ZG9FbGVtZW50cyk7CiAKICAgICBjYXNlIENTU1Nl bGVjdG9yOjpEaXJlY3RBZGphY2VudDoKICAgICAgICAgaWYgKG1fbW9kZSA9PSBSZXNvbHZpbmdT dHlsZSAmJiBjb250ZXh0LmVsZW1lbnQtPnBhcmVudEVsZW1lbnQoKSkgewpAQCAtNTExLDcgKzUw OSw3IEBAIFNlbGVjdG9yQ2hlY2tlcjo6U2VsZWN0b3JNYXRjaCBTZWxlY3RvckNoZWNrZXI6OmNo ZWNrU2VsZWN0b3IoY29uc3QgU2VsZWN0b3JDaGVjCiAgICAgICAgIG5leHRDb250ZXh0LmlzU3Vi U2VsZWN0b3IgPSBmYWxzZTsKICAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudFN0eWxlID0gMDsK ICAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudFBhcmVudFN0eWxlID0gMDsKLSAgICAgICAgcmV0 dXJuIGNoZWNrU2VsZWN0b3IobmV4dENvbnRleHQsIGN1cnJlbnREeW5hbWljUHNldWRvLCBoYXNV bmtub3duUHNldWRvRWxlbWVudHMpOworICAgICAgICByZXR1cm4gY2hlY2tTZWxlY3RvcihuZXh0 Q29udGV4dCwgaWdub3JlRHluYW1pY1BzZXVkbywgaGFzVW5rbm93blBzZXVkb0VsZW1lbnRzKTsK IAogICAgIGNhc2UgQ1NTU2VsZWN0b3I6OkluZGlyZWN0QWRqYWNlbnQ6CiAgICAgICAgIGlmICht X21vZGUgPT0gUmVzb2x2aW5nU3R5bGUgJiYgY29udGV4dC5lbGVtZW50LT5wYXJlbnRFbGVtZW50 KCkpIHsKQEAgLTUyNCw3ICs1MjIsNyBAQCBTZWxlY3RvckNoZWNrZXI6OlNlbGVjdG9yTWF0Y2gg U2VsZWN0b3JDaGVja2VyOjpjaGVja1NlbGVjdG9yKGNvbnN0IFNlbGVjdG9yQ2hlYwogICAgICAg ICBuZXh0Q29udGV4dC5lbGVtZW50U3R5bGUgPSAwOwogICAgICAgICBuZXh0Q29udGV4dC5lbGVt ZW50UGFyZW50U3R5bGUgPSAwOwogICAgICAgICBmb3IgKDsgbmV4dENvbnRleHQuZWxlbWVudDsg bmV4dENvbnRleHQuZWxlbWVudCA9IG5leHRDb250ZXh0LmVsZW1lbnQtPnByZXZpb3VzRWxlbWVu dFNpYmxpbmcoKSkgewotICAgICAgICAgICAgU2VsZWN0b3JNYXRjaCBtYXRjaCA9IGNoZWNrU2Vs ZWN0b3IobmV4dENvbnRleHQsIGN1cnJlbnREeW5hbWljUHNldWRvLCBoYXNVbmtub3duUHNldWRv RWxlbWVudHMpOworICAgICAgICAgICAgU2VsZWN0b3JNYXRjaCBtYXRjaCA9IGNoZWNrU2VsZWN0 b3IobmV4dENvbnRleHQsIGlnbm9yZUR5bmFtaWNQc2V1ZG8sIGhhc1Vua25vd25Qc2V1ZG9FbGVt ZW50cyk7CiAgICAgICAgICAgICBpZiAobWF0Y2ggPT0gU2VsZWN0b3JNYXRjaGVzIHx8IG1hdGNo ID09IFNlbGVjdG9yRmFpbHNBbGxTaWJsaW5ncyB8fCBtYXRjaCA9PSBTZWxlY3RvckZhaWxzQ29t cGxldGVseSkKICAgICAgICAgICAgICAgICByZXR1cm4gbWF0Y2g7CiAgICAgICAgIH07CkBAIC01 MzgsNyArNTM2LDcgQEAgU2VsZWN0b3JDaGVja2VyOjpTZWxlY3Rvck1hdGNoIFNlbGVjdG9yQ2hl Y2tlcjo6Y2hlY2tTZWxlY3Rvcihjb25zdCBTZWxlY3RvckNoZWMKICAgICAgICAgICAgICAmJiAh KChSZW5kZXJTY3JvbGxiYXI6OnNjcm9sbGJhckZvclN0eWxlUmVzb2x2ZSgpIHx8IGR5bmFtaWNQ c2V1ZG8gPT0gU0NST0xMQkFSX0NPUk5FUiB8fCBkeW5hbWljUHNldWRvID09IFJFU0laRVIpICYm IG5leHRDb250ZXh0LnNlbGVjdG9yLT5tX21hdGNoID09IENTU1NlbGVjdG9yOjpQc2V1ZG9DbGFz cykpCiAgICAgICAgICAgICByZXR1cm4gU2VsZWN0b3JGYWlsc0NvbXBsZXRlbHk7CiAgICAgICAg IG5leHRDb250ZXh0LmlzU3ViU2VsZWN0b3IgPSB0cnVlOwotICAgICAgICByZXR1cm4gY2hlY2tT ZWxlY3RvcihuZXh0Q29udGV4dCwgY3VycmVudER5bmFtaWNQc2V1ZG8sIGhhc1Vua25vd25Qc2V1 ZG9FbGVtZW50cyk7CisgICAgICAgIHJldHVybiBjaGVja1NlbGVjdG9yKG5leHRDb250ZXh0LCBk eW5hbWljUHNldWRvLCBoYXNVbmtub3duUHNldWRvRWxlbWVudHMpOwogCiAgICAgY2FzZSBDU1NT ZWxlY3Rvcjo6U2hhZG93RGVzY2VuZGFudDoKICAgICAgICAgewpAQCAtNTUyLDcgKzU1MCw3IEBA IFNlbGVjdG9yQ2hlY2tlcjo6U2VsZWN0b3JNYXRjaCBTZWxlY3RvckNoZWNrZXI6OmNoZWNrU2Vs ZWN0b3IoY29uc3QgU2VsZWN0b3JDaGVjCiAgICAgICAgICAgICBuZXh0Q29udGV4dC5pc1N1YlNl bGVjdG9yID0gZmFsc2U7CiAgICAgICAgICAgICBuZXh0Q29udGV4dC5lbGVtZW50U3R5bGUgPSAw OwogICAgICAgICAgICAgbmV4dENvbnRleHQuZWxlbWVudFBhcmVudFN0eWxlID0gMDsKLSAgICAg ICAgICAgIHJldHVybiBjaGVja1NlbGVjdG9yKG5leHRDb250ZXh0LCBjdXJyZW50RHluYW1pY1Bz ZXVkbywgaGFzVW5rbm93blBzZXVkb0VsZW1lbnRzKTsKKyAgICAgICAgICAgIHJldHVybiBjaGVj a1NlbGVjdG9yKG5leHRDb250ZXh0LCBpZ25vcmVEeW5hbWljUHNldWRvLCBoYXNVbmtub3duUHNl dWRvRWxlbWVudHMpOwogICAgICAgICB9CiAgICAgfQogCg==