97942 2012-09-28 14:52:51 -0700 TextureMapperGL destructor crashes 2012-09-29 13:10:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 luiz luiz mrobinson noam webkit.review.bot oldest_to_newest 731009 0 luiz 2012-09-28 14:52:51 -0700 BitmapTextureGL destructor uses a TextureMapperGL instance on its destructor. The problem is that BitmapTextureGL objects are destroyed on TextureMapper destructor and at that time TextureMapperGL specific methods and data are not available any more. 731013 1 166317 luiz 2012-09-28 15:01:41 -0700 Created attachment 166317 patch 731042 2 166317 webkit.review.bot 2012-09-28 16:07:23 -0700 Comment on attachment 166317 patch Clearing flags on attachment: 166317 Committed r129956: <http://trac.webkit.org/changeset/129956> 731043 3 webkit.review.bot 2012-09-28 16:07:26 -0700 All reviewed patches have been landed. Closing bug. 731232 4 mrobinson 2012-09-29 13:10:28 -0700 (In reply to comment #0) > BitmapTextureGL destructor uses a TextureMapperGL instance on its destructor. The problem is that BitmapTextureGL objects are destroyed on TextureMapper destructor and at that time TextureMapperGL specific methods and data are not available any more. Nice fix! I've created a complimentary patch here that also handles the case where the TextureMapper is destroyed, but a backing store still have references to the textures: https://bugs.webkit.org/show_bug.cgi?id=97394 166317 2012-09-28 15:01:41 -0700 2012-09-28 16:07:23 -0700 patch 0001-TextureMapperGL-destructor-crashes.patch text/plain 3173 luiz RnJvbSA0OWE2M2U1M2MzZmU4MmZhNTkxZTJmMGRlNDg1NjhmZGU0ZmZjOGU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG5va2lhLmNv bT4KRGF0ZTogRnJpLCAyOCBTZXAgMjAxMiAxNDo1ODoxNiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hd IFRleHR1cmVNYXBwZXJHTCBkZXN0cnVjdG9yIGNyYXNoZXMKIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05Nzk0MgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpC aXRtYXBUZXh0dXJlR0wgZGVzdHJ1Y3RvciB1c2VzIGEgVGV4dHVyZU1hcHBlckdMIGluc3RhbmNl LiBUaGUgcHJvYmxlbSBpcyB0aGF0CkJpdG1hcFRleHR1cmVHTCBvYmplY3RzIGFyZSBkZXN0cm95 ZWQgb24gVGV4dHVyZU1hcHBlciBkZXN0cnVjdG9yIGFuZCBhdCB0aGF0CnRpbWUgVGV4dHVyZU1h cHBlckdMIHNwZWNpZmljIG1ldGhvZHMgYW5kIGRhdGEgYXJlIG5vdCBhdmFpbGFibGUgYW55IG1v cmUuCgpUaGlzIHBhdGNoIGNyZWF0ZXMgYSBuZXcgcHJvdGVjdGVkIG1ldGhvZCBUZXh0dXJlTWFw cGVyOjpjbGVhclRleHR1cmVQb29sKCkKdGhhdCBpcyBjYWxsZWQgaW4gVGV4dHVyZU1hcHBlckdM J3MgZGVzdHJ1Y3Rvci4KCiogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIu aDoKKFdlYkNvcmU6OlRleHR1cmVNYXBwZXI6OmNsZWFyVGV4dHVyZVBvb2wpOgoqIHBsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwOgooV2ViQ29yZTo6VGV4dHVyZU1h cHBlckdMOjp+VGV4dHVyZU1hcHBlckdMKToKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKysrKysrKysrKwogLi4u L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyLmggICAgICAgfCAgICAxICsK IC4uLi9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcCAgIHwgICAg MSArCiAzIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIy OGE1YS4uZTM3YTc0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTI4ICBM dWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBub2tpYS5jb20+CisKKyAgICAgICAgVGV4dHVy ZU1hcHBlckdMIGRlc3RydWN0b3IgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc5NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBCaXRtYXBUZXh0dXJlR0wgZGVzdHJ1Y3RvciB1c2VzIGEgVGV4 dHVyZU1hcHBlckdMIGluc3RhbmNlLiBUaGUgcHJvYmxlbSBpcyB0aGF0IAorICAgICAgICBCaXRt YXBUZXh0dXJlR0wgb2JqZWN0cyBhcmUgZGVzdHJveWVkIG9uIFRleHR1cmVNYXBwZXIgZGVzdHJ1 Y3RvciBhbmQgYXQgdGhhdCAKKyAgICAgICAgdGltZSBUZXh0dXJlTWFwcGVyR0wgc3BlY2lmaWMg bWV0aG9kcyBhbmQgZGF0YSBhcmUgbm90IGF2YWlsYWJsZSBhbnkgbW9yZS4KKworICAgICAgICBU aGlzIHBhdGNoIGNyZWF0ZXMgYSBuZXcgcHJvdGVjdGVkIG1ldGhvZCBUZXh0dXJlTWFwcGVyOjpj bGVhclRleHR1cmVQb29sKCkKKyAgICAgICAgdGhhdCBpcyBjYWxsZWQgaW4gVGV4dHVyZU1hcHBl ckdMJ3MgZGVzdHJ1Y3Rvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9U ZXh0dXJlTWFwcGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyOjpjbGVhclRl eHR1cmVQb29sKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJHTDo6flRleHR1cmVN YXBwZXJHTCk6CisKIDIwMTItMDktMjggIEJlbiBXYWduZXIgIDxidW5nZW1hbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgQ2hyb21pdW0gc2hvdWxkIHJlc3BlY3QgJ3RleHQtcmVuZGVyaW5nOmdl b21ldHJpY1ByZWNpc2lvbicgYnkgZGlzYWJsaW5nIGhpbnRpbmcuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXIuaAppbmRl eCBiNDUwNDY4Li40YTExMGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyLmgKQEAgLTE1MSw2ICsxNTEsNyBAQCBw cm90ZWN0ZWQ6CiAgICAgICAgICwgbV90ZXh0RHJhd2luZ01vZGUoVGV4dE1vZGVGaWxsKQogICAg ICAgICAsIG1fYWNjZWxlcmF0aW9uTW9kZShhY2NlbGVyYXRpb25Nb2RlKQogICAgIHt9CisgICAg dm9pZCBjbGVhclRleHR1cmVQb29sKCkgeyBtX3RleHR1cmVQb29sLmNsZWFyKCk7IH0KIAogcHJp dmF0ZToKICNpZiBVU0UoVEVYVFVSRV9NQVBQRVJfR0wpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwCmlu ZGV4IGUwZDNiMGEuLjc4M2RjYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwCkBAIC04NDQsNiAr ODQ0LDcgQEAgSW50U2l6ZSBCaXRtYXBUZXh0dXJlR0w6OnNpemUoKSBjb25zdAogCiBUZXh0dXJl TWFwcGVyR0w6On5UZXh0dXJlTWFwcGVyR0woKQogeworICAgIGNsZWFyVGV4dHVyZVBvb2woKTsK ICAgICBkZWxldGUgbV9kYXRhOwogfQogCi0tIAoxLjcuOS41Cgo=