97934 2012-09-28 13:23:28 -0700 [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver 2012-09-28 13:56:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov fishd jamesr leandrogracia webkit.review.bot oldest_to_newest 730932 0 abarth 2012-09-28 13:23:28 -0700 [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver 730937 1 166304 abarth 2012-09-28 13:25:22 -0700 Created attachment 166304 Patch 730964 2 166304 jamesr 2012-09-28 13:44:29 -0700 Comment on attachment 166304 Patch It's as if a thousand unexplainable m_frame crash reports from the past cried out, but were suddenly silenced. 730975 3 leandrogracia 2012-09-28 13:50:56 -0700 Thanks for this fix Adam. I'm very glad to see this simplified. 730978 4 abarth 2012-09-28 13:53:13 -0700 (In reply to comment #3) > Thanks for this fix Adam. I'm very glad to see this simplified. Thanks for the idea to add the base class! It's so obvious in retrospect. 730980 5 166304 webkit.review.bot 2012-09-28 13:56:54 -0700 Comment on attachment 166304 Patch Clearing flags on attachment: 166304 Committed r129947: <http://trac.webkit.org/changeset/129947> 730981 6 webkit.review.bot 2012-09-28 13:56:57 -0700 All reviewed patches have been landed. Closing bug. 166304 2012-09-28 13:25:22 -0700 2012-09-28 13:56:54 -0700 Patch bug-97934-20120928132439.patch text/plain 4783 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVkOWI5MjdhMWIzYTUzNDY0MzhiMDg1ZjUzYjUxNzBlYzUwYzYzYWMuLjA1OWFlMDg4NGNkYTBl YTg2NWRjOTBjZjcxODBmZjZiYWVjY2Q0MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDktMjggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYkZyYW1lSW1wbDo6bV9mcmFtZSBpcyByZWR1bmRh bnQgbm93IHRoYXQgV2ViRnJhbWVJbXBsIGluaGVyaXRzIGZyb20gRnJhbWVEZXN0cnVjdGlvbk9i c2VydmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NzkzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFm dGVyIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEyOTkxMCwgV2ViRnJhbWVJbXBs IGluaGVyaXRzCisgICAgICAgIGZyb20gRnJhbWVEZXN0cnVjdGlvbk9ic2VydmVyLCB3aGljaCBt ZWFucyBpdCBubyBsb25nZXIgbmVlZCB0byBtYW5hZ2UKKyAgICAgICAgaXRzIG93biB3ZWFrIHBv aW50ZXIgdG8gV2ViQ29yZTo6RnJhbWUuCisKKyAgICAgICAgKiBzcmMvRnJhbWVMb2FkZXJDbGll bnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnRJbXBsOjpmcmFt ZUxvYWRlckRlc3Ryb3llZCk6CisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6V2ViRnJhbWVJbXBsKToKKyAgICAgICAgKFdlYktp dDo6V2ViRnJhbWVJbXBsOjpzZXRXZWJDb3JlRnJhbWUpOgorICAgICAgICAqIHNyYy9XZWJGcmFt ZUltcGwuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpmcmFtZVZpZXcpOgorCiAy MDEyLTA5LTI4ICBTdGVwaGVuIENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBDaHJvbWl1bSBXaW4gYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAKaW5kZXggYjJl ODI1NmVlMzE0OGZjNmIzNDJlNTAwNTFlMDhhMzU4MDAyNDc2YS4uOGNhNmQyMzQ3YzMwNjcyZmI1 MjMyM2M1YWI3OTUwYWQyY2QxN2UwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCkBAIC0xMjUsNyArMTI1LDcgQEAgdm9p ZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OmZyYW1lTG9hZGVyRGVzdHJveWVkKCkKICAgICAvLyBz ZXJ2ZXMgdG8ga2VlcCB1cyBhbGl2ZSB1bnRpbCB0aGUgRnJhbWVMb2FkZXIgaXMgZG9uZSB3aXRo IHVzLiAgVGhlCiAgICAgLy8gRnJhbWVMb2FkZXIgY2FsbHMgdGhpcyBtZXRob2Qgd2hlbiBpdCdz IGdvaW5nIGF3YXkuICBUaGVyZWZvcmUsIHdlIGJhbGFuY2UKICAgICAvLyBvdXQgdGhhdCBleHRy YSByZWZlcmVuY2UsIHdoaWNoIG1heSBjYXVzZSAndGhpcycgdG8gYmUgZGVsZXRlZC4KLSAgICBt X3dlYkZyYW1lLT5jbG9zaW5nKCk7CisgICAgQVNTRVJUKCFtX3dlYkZyYW1lLT5mcmFtZSgpKTsK ICAgICBtX3dlYkZyYW1lLT5kZXJlZigpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCBjYzdmNDA3MzNhNjhlMjliYjMyNDJjNDc2ZmZkYTgx MWYyODBmMTViLi4yNWZhM2VmNGYzMTM5NDM3MTk0ZTcxNTA3YTUzYjk1ZjAxZDg4N2E1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTIxNzAsNyAr MjE3MCw2IEBAIFdlYkZyYW1lSW1wbDo6V2ViRnJhbWVJbXBsKFdlYkZyYW1lQ2xpZW50KiBjbGll bnQpCiAgICAgOiBGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIoMCkKICAgICAsIG1fZnJhbWVMb2Fk ZXJDbGllbnQodGhpcykKICAgICAsIG1fY2xpZW50KGNsaWVudCkKLSAgICAsIG1fZnJhbWUoMCkK ICAgICAsIG1fY3VycmVudEFjdGl2ZU1hdGNoRnJhbWUoMCkKICAgICAsIG1fYWN0aXZlTWF0Y2hJ bmRleEluQ3VycmVudEZyYW1lKC0xKQogICAgICwgbV9sb2NhdGluZ0FjdGl2ZVJlY3QoZmFsc2Up CkBAIC0yMjAzLDggKzIyMDIsNyBAQCBXZWJGcmFtZUltcGw6On5XZWJGcmFtZUltcGwoKQogdm9p ZCBXZWJGcmFtZUltcGw6OnNldFdlYkNvcmVGcmFtZShXZWJDb3JlOjpGcmFtZSogZnJhbWUpCiB7 CiAgICAgQVNTRVJUKGZyYW1lKTsKLSAgICBtX2ZyYW1lID0gZnJhbWU7Ci0gICAgb2JzZXJ2ZUZy YW1lKG1fZnJhbWUpOworICAgIG9ic2VydmVGcmFtZShmcmFtZSk7CiB9CiAKIHZvaWQgV2ViRnJh bWVJbXBsOjppbml0aWFsaXplQXNNYWluRnJhbWUoV2ViQ29yZTo6UGFnZSogcGFnZSkKQEAgLTIz OTYsMTEgKzIzOTQsNiBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6c2V0Q2FuSGF2ZVNjcm9sbGJhcnMo Ym9vbCBjYW5IYXZlU2Nyb2xsYmFycykKICAgICBmcmFtZSgpLT52aWV3KCktPnNldENhbkhhdmVT Y3JvbGxiYXJzKGNhbkhhdmVTY3JvbGxiYXJzKTsKIH0KIAotdm9pZCBXZWJGcmFtZUltcGw6OmNs b3NpbmcoKQotewotICAgIG1fZnJhbWUgPSAwOwotfQotCiB2b2lkIFdlYkZyYW1lSW1wbDo6aW52 YWxpZGF0ZUFyZWEoQXJlYVRvSW52YWxpZGF0ZSBhcmVhKQogewogICAgIEFTU0VSVChmcmFtZSgp ICYmIGZyYW1lKCktPnZpZXcoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJGcmFtZUltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5oCmluZGV4IGYyZWQzYzcwZDUwM2MyNGJkZTRkYjdjZWNkNGYzMGE1ODdhN2Y1OWMuLjI2 ODZhYWQxZGQzMWI5YmVhNjhlOTQ1YWJmNjg0MjUxYmIxNGZhOGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCkBAIC0yNjgsOCArMjY4LDcgQEAgcHVibGljOgog CiAgICAgV2ViVmlld0ltcGwqIHZpZXdJbXBsKCkgY29uc3Q7CiAKLSAgICBXZWJDb3JlOjpGcmFt ZSogZnJhbWUoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1lOyB9Ci0gICAgV2ViQ29yZTo6RnJhbWVW aWV3KiBmcmFtZVZpZXcoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1lID8gbV9mcmFtZS0+dmlldygp IDogMDsgfQorICAgIFdlYkNvcmU6OkZyYW1lVmlldyogZnJhbWVWaWV3KCkgY29uc3QgeyByZXR1 cm4gZnJhbWUoKSA/IGZyYW1lKCktPnZpZXcoKSA6IDA7IH0KIAogICAgIC8vIEdldHRlcnMgZm9y IHRoZSBpbXBscyBjb3JyZXNwb25kaW5nIHRvIEdldChQcm92aXNpb25hbClEYXRhU291cmNlLiBU aGV5CiAgICAgLy8gbWF5IHJldHVybiAwIGlmIHRoZXJlIGlzIG5vIGNvcnJlc3BvbmRpbmcgZGF0 YSBzb3VyY2UuCkBAIC0zMzEsMTEgKzMzMCw3IEBAIHByaXZhdGU6CiAgICAgICBJbnZhbGlkYXRl QWxsICAgICAgICAgIC8vIEJvdGggY29udGVudCBhcmVhIGFuZCB0aGUgc2Nyb2xsYmFyLgogICAg IH07CiAKLSAgICBXZWJGcmFtZUltcGwoV2ViRnJhbWVDbGllbnQqKTsKLQotICAgIC8vIEluZm9y bXMgdGhlIFdlYkZyYW1lIHRoYXQgdGhlIEZyYW1lIGlzIGJlaW5nIGNsb3NlZCwgY2FsbGVkIGJ5 IHRoZQotICAgIC8vIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ci0gICAgdm9pZCBjbG9zaW5nKCk7Cisg ICAgZXhwbGljaXQgV2ViRnJhbWVJbXBsKFdlYkZyYW1lQ2xpZW50Kik7CiAKICAgICAvLyBTZXRz IHRoZSBsb2NhbCBXZWJDb3JlIGZyYW1lIGFuZCByZWdpc3RlcnMgZGVzdHJ1Y3Rpb24gb2JzZXJ2 ZXJzLgogICAgIHZvaWQgc2V0V2ViQ29yZUZyYW1lKFdlYkNvcmU6OkZyYW1lKik7CkBAIC00MjEs MTEgKzQxNiw2IEBAIHByaXZhdGU6CiAKICAgICBXZWJGcmFtZUNsaWVudCogbV9jbGllbnQ7CiAK LSAgICAvLyBGSVhNRTogdGhpcyBpcyByZWR1bmRhbnQgYXMgd2UgYWxyZWFkeSBoYXZlIG1fZnJh bWUgZnJvbSBGcmFtZURlc3RydWN0aW9uT2JzZXJ2ZXIuCi0gICAgLy8gVGhpcyBpcyBhIHdlYWsg cG9pbnRlciB0byBvdXIgY29ycmVzcG9uZGluZyBXZWJDb3JlIGZyYW1lLiAgQSByZWZlcmVuY2Ug dG8KLSAgICAvLyBvdXJzZWx2ZXMgaXMgaGVsZCB3aGlsZSBmcmFtZV8gaXMgdmFsaWQuICBTZWUg b3VyIENsb3NpbmcgbWV0aG9kLgotICAgIFdlYkNvcmU6OkZyYW1lKiBtX2ZyYW1lOwotCiAgICAg Ly8gQSB3YXkgZm9yIHRoZSBtYWluIGZyYW1lIHRvIGtlZXAgdHJhY2sgb2Ygd2hpY2ggZnJhbWUg aGFzIGFuIGFjdGl2ZQogICAgIC8vIG1hdGNoLiBTaG91bGQgYmUgMCBmb3IgYWxsIG90aGVyIGZy YW1lcy4KICAgICBXZWJGcmFtZUltcGwqIG1fY3VycmVudEFjdGl2ZU1hdGNoRnJhbWU7Cg==