97930 2012-09-28 12:30:39 -0700 Missing initializer in WebKitLoaderClient 2012-09-28 13:03:24 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 0 berto webkit-unassigned mrobinson webkit.review.bot oldest_to_newest 730890 0 berto 2012-09-28 12:30:39 -0700 ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp: In function ‘void attachLoaderClientToView(WebKitWebView*)’: ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:155:5: warning: missing initializer for member ‘WKPageLoaderClient::didLayout’ [-Wmissing-field-initializers] There's a new didLayout field in WKPageLoaderClient, the instance in WebKitLoaderClient is missing the initializer. 730892 1 166293 berto 2012-09-28 12:31:31 -0700 Created attachment 166293 Patch 730918 2 166293 webkit.review.bot 2012-09-28 13:03:20 -0700 Comment on attachment 166293 Patch Clearing flags on attachment: 166293 Committed r129937: <http://trac.webkit.org/changeset/129937> 730919 3 webkit.review.bot 2012-09-28 13:03:24 -0700 All reviewed patches have been landed. Closing bug. 166293 2012-09-28 12:31:31 -0700 2012-09-28 13:03:20 -0700 Patch initializer.diff text/plain 1380 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjODI3ZWI2Li40Njc3ZDU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDktMjggIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFdlYktpdExvYWRlckNsaWVudDogYWRkIG1pc3NpbmcgaW5pdGlhbGl6ZXIuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzkzMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdLUGFnZUxvYWRlckNs aWVudCBpcyBtaXNzaW5nIHRoZSBpbml0aWFsaXplciBmb3IgdGhlIGRpZExheW91dAorICAgICAg ICBmaWVsZC4gRml4ZXMgLVdtaXNzaW5nLWZpZWxkLWluaXRpYWxpemVycy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChhdHRh Y2hMb2FkZXJDbGllbnRUb1ZpZXcpOgorCiAyMDEyLTA5LTI4ICBKaW53b28gU29uZyAgPGppbndv bzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFNvbWUgZXhwZWN0ZWQg YW5kIGFjdHVhbCBwYXJhbWV0ZXJzIGluIHVuaXQgdGVzdHMgYXJlIHJldmVyc2VkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50 LmNwcAppbmRleCA2YzNiZjkyLi40NTdjNDAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAKQEAgLTE1Miw2ICsx NTIsNyBAQCB2b2lkIGF0dGFjaExvYWRlckNsaWVudFRvVmlldyhXZWJLaXRXZWJWaWV3KiB3ZWJW aWV3KQogICAgICAgICAwLCAvLyBwbHVnaW5EaWRGYWlsCiAgICAgICAgIDAsIC8vIGRpZFJlY2Vp dmVJbnRlbnRGb3JGcmFtZQogICAgICAgICAwLCAvLyByZWdpc3RlckludGVudFNlcnZpY2VGb3JG cmFtZQorICAgICAgICAwLCAvLyBkaWRMYXlvdXQKICAgICB9OwogICAgIFdLUGFnZVJlZiB3a1Bh Z2UgPSB0b0FQSSh3ZWJraXRXZWJWaWV3QmFzZUdldFBhZ2UoV0VCS0lUX1dFQl9WSUVXX0JBU0Uo d2ViVmlldykpKTsKICAgICBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KHdrUGFnZSwgJndrTG9h ZGVyQ2xpZW50KTsK