97927 2012-09-28 12:04:06 -0700 Some non-scrollable elements are added to non-fast-scrollable region 2012-12-04 07:27:43 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://subtlepatterns.com P2 Normal --- 103999 1 skyostil skyostil eric jamesr simon.fraser tonikitoo webkit.review.bot oldest_to_newest 730861 0 skyostil 2012-09-28 12:04:06 -0700 For example, RenderBox::canBeScrolledAndHasScrollableArea() returns true if horizontal overflow is hidden, vertical overflow is auto, but the scrolling content only extends beyond the client box horizontally. In this case the RenderBox isn't actually scrollable (except by setting scrollLeft/Top from JavaScript) because overflow is hidden on the only free axis. An example site where this happens is http://subtlepatterns.com. The relevant bit of CSS is: @media only screen and (-webkit-min-device-pixel-ratio: 1.5), only screen and (-o-min-device-pixel-ratio: 3/2), only screen and (min--moz-device-pixel-ratio: 1.5), only screen and (min-device-pixel-ratio: 1.5) { html, body { width: 100%; overflow-x: hidden; } } 731696 1 skyostil 2012-10-01 08:03:02 -0700 Sorry, I wasn't very clear on what the actual problem is: we are sometimes adding non-scrollable things to the non-fast-scrollable region. For example the following page always falls back to slow scrolling: <!DOCTYPE html> <html> <head> <style> html, body { width: 100%; overflow-x: hidden; } </style> <head> <body> <p style="font-size: 500px">hello</p> </body> </html> 731785 2 166500 skyostil 2012-10-01 10:28:22 -0700 Created attachment 166500 Patch 735635 3 skyostil 2012-10-05 07:57:59 -0700 Seems like this is related to bug 17488. If we made overflow-x: hidden not imply overflow-y: auto then this issue would also be fixed. But is that a change we want to make? 737099 4 166500 jamesr 2012-10-08 15:06:44 -0700 Comment on attachment 166500 Patch R=me. 737111 5 166500 webkit.review.bot 2012-10-08 15:15:40 -0700 Comment on attachment 166500 Patch Clearing flags on attachment: 166500 Committed r130692: <http://trac.webkit.org/changeset/130692> 737112 6 webkit.review.bot 2012-10-08 15:15:43 -0700 All reviewed patches have been landed. Closing bug. 737880 7 tonikitoo 2012-10-09 09:47:44 -0700 RenderLayer::allowsScrolling is always false for the blackberry port, since we disable scrollbars creation at FrameView creation time. Not sure it is a valid fix. 737898 8 jamesr 2012-10-09 10:07:16 -0700 I think this patch is perfectly valid. You should patch allowsScrolling() for your non-standard scrollbar behavior. 738912 9 tonikitoo 2012-10-10 06:45:27 -0700 (In reply to comment #8) > I think this patch is perfectly valid. You should patch allowsScrolling() for your non-standard scrollbar behavior. "For example, RenderBox::canBeScrolledAndHasScrollableArea() returns true if horizontal overflow is hidden, vertical overflow is auto, but the scrolling content only extends beyond the client box horizontally. " Another possibility is fixing the above. I've fixed it for BlackBerry already long ago. Will give it a try in WebCore See http://trac.webkit.org/browser/trunk/Source/WebKit/blackberry/Api/WebPage.cpp?rev=120861#L4652 166500 2012-10-01 10:28:22 -0700 2012-10-08 15:15:40 -0700 Patch bug-97927-20121001182735.patch text/plain 5340 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzc5YTcyYTUwMjdlODkw ZWUwNjczNTVkZmRjZTI0YmE3MTBiZjI5OC4uNGNlMTg0NmU1MTc1MGU4ZDIyOTE1Y2IwZjYxNzkw NzI4YTBmMmI4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTAxICBTYW1p IEt5b3N0aWxhICA8c2t5b3N0aWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNvbWUgbm9uLXNj cm9sbGFibGUgZWxlbWVudHMgYXJlIGFkZGVkIHRvIG5vbi1mYXN0LXNjcm9sbGFibGUgcmVnaW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzkyNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgUmVu ZGVyTGF5ZXJzIHRoYXQgY2FuIGFjdHVhbGx5IGJlIHNjcm9sbGVkIHNob3VsZCBiZSBhZGRlZCB0 byB0aGUKKyAgICAgICAgU2Nyb2xsaW5nQ29vcmRpbmF0b3IncyBub24tZmFzdCBzY3JvbGxhYmxl IHJlZ2lvbi4gT3RoZXJ3aXNlIHdlIG1heQorICAgICAgICBuZWVkbGVzc2x5IGZhbGwgYmFjayB0 byBtYWluIHRocmVhZCBzY3JvbGxpbmcuCisKKyAgICAgICAgVGVzdDogU2Nyb2xsaW5nQ29vcmRp bmF0b3JDaHJvbWl1bVRlc3QuY2xpcHBlZEJvZHlUZXN0CisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnVwZGF0ZVNj cm9sbGJhcnNBZnRlckxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6dXBk YXRlU2Nyb2xsYmFyc0FmdGVyU3R5bGVDaGFuZ2UpOgorCiAyMDEyLTEwLTAxICBZdXJ5IFNlbWlr aGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIENocm9t aXVtIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZjMxNjNlMWVmNWFk ZDhmYWRiYWM5NDFkMTVjYmY4MGQ3NGMzNTkwNi4uMmRiYmFmNDAyMjljODQ0NTAwOGFmYzdlMjBj NjljZmE5NWY2ODhkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMCBA QAorMjAxMi0xMC0wMSAgU2FtaSBLeW9zdGlsYSAgPHNreW9zdGlsQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBTb21lIG5vbi1zY3JvbGxhYmxlIGVsZW1lbnRzIGFyZSBhZGRlZCB0byBub24tZmFz dC1zY3JvbGxhYmxlIHJlZ2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTc5MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUZXN0IHRoYXQgYSBub24tc2Nyb2xsYWJsZSBSZW5kZXJMYXllciBpc24ndCBh ZGRlZCB0byB0aGUgbm9uLWZhc3Qgc2Nyb2xsYWJsZQorICAgICAgICByZWdpb24uCisKKyAgICAg ICAgVGhlIHRlc3QgaW4gdGhpcyBwYXRjaCBjb25zaXN0cyBvZiBhIHdlYiBwYWdlIHdoZXJlIGJv dGggdGhlIGh0bWwgYW5kCisgICAgICAgIGJvZHkgZWxlbWVudHMgY2xpcCBob3Jpem9udGFsIG92 ZXJmbG93LiBUaGlzIHJlc3VsdHMgaW4gYSBoaWVyYXJjaHkKKyAgICAgICAgd2hlcmUgdGhlIGJv ZHkgZWxlbWVudCBnZXRzIGEgc2Nyb2xsYWJsZSBSZW5kZXJMYXllci4gSG93ZXZlciwgdGhhdAor ICAgICAgICBsYXllciBpc24ndCAoaW50ZXJhY3RpdmVseSkgc2Nyb2xsYWJsZSBiZWNhdXNlIHdo aWxlIHRoZSBzY3JvbGwgZ2VvbWV0cnkKKyAgICAgICAgaXMgY2FsY3VsYXRlZCBiYXNlZCBvbiB0 aGUgYW1vdW50IG9mIG92ZXJmbG93LCB0aGUgc2Nyb2xsIGJhcnMgYXJlCisgICAgICAgIGhpZGRl biBiZWNhdXNlIG9mIHRoZSAib3ZlcmZsb3cteDogaGlkZGVuIiBzdHlsZS4KKworICAgICAgICBQ cmV2aW91c2x5IHRoaXMgbGF5ZXIgd291bGQgaGF2ZSBtYWRlIHRoZSBlbnRpcmUgcGFnZSBwYXJ0 IG9mIHRoZQorICAgICAgICBub24tZmFzdCBzY3JvbGxhYmxlIHJlZ2lvbi4gV2l0aCB0aGlzIHBh dGNoLAorICAgICAgICBSZW5kZXJMYXllcjo6YWxsb3dTY3JvbGxpbmcoKSBpcyB1c2VkIGFzIGEg cHJlLXJlcXVpc2l0ZSBmb3IgZXhwYW5kaW5nCisgICAgICAgIHRoZSByZWdpb24sIHRodXMgYXZv aWRpbmcgdGhlIHByb2JsZW0uCisKKyAgICAgICAgKiB0ZXN0cy9TY3JvbGxpbmdDb29yZGluYXRv ckNocm9taXVtVGVzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlRFU1RfRik6CisgICAgICAgIChX ZWJLaXQpOgorICAgICAgICAqIHRlc3RzL2RhdGEvY2xpcHBlZC1ib2R5Lmh0bWw6IEFkZGVkLgor CiAyMDEyLTEwLTAxICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkIHNpbmdsZSBsaW5lIGNvbXBpbGF0aW9uIGZpeCBmb3IgQ2FuYXJ5 IERlYnVnIE1hYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4 IDc1OTg2MzM1ZWVmNDhiZjQ0YTQzMjcxNmQyYzc5NDE5OWJjNWEwZTcuLjI2MThmMmE1YTQ1YWI5 Zjk2Y2JlZWFmYjJjZGQwM2U2OGNjNjZlNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyLmNwcApAQCAtMjYyOSw3ICsyNjI5LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6dXBk YXRlU2Nyb2xsYmFyc0FmdGVyTGF5b3V0KCkKICAgICAgICAgbV92QmFyLT5zZXRQcm9wb3J0aW9u KGNsaWVudEhlaWdodCwgbV9zY3JvbGxTaXplLmhlaWdodCgpKTsKICAgICB9CiAKLSAgICB1cGRh dGVTY3JvbGxhYmxlQXJlYVNldCgoaGFzSG9yaXpvbnRhbE92ZXJmbG93IHx8IGhhc1ZlcnRpY2Fs T3ZlcmZsb3cpICYmIHNjcm9sbHNPdmVyZmxvdygpKTsKKyAgICB1cGRhdGVTY3JvbGxhYmxlQXJl YVNldCgoaGFzSG9yaXpvbnRhbE92ZXJmbG93IHx8IGhhc1ZlcnRpY2FsT3ZlcmZsb3cpICYmIHNj cm9sbHNPdmVyZmxvdygpICYmIGFsbG93c1Njcm9sbGluZygpKTsKIH0KIAogdm9pZCBSZW5kZXJM YXllcjo6dXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5b3V0KCkKQEAgLTQ4MzUsNyArNDgzNSw3IEBA IHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGJhcnNBZnRlclN0eWxlQ2hhbmdlKGNvbnN0 IFJlbmRlclN0eWxlKiBvbGRTdHlsZSkKICAgICB9CiAKICAgICBpZiAoIW1fc2Nyb2xsRGltZW5z aW9uc0RpcnR5KQotICAgICAgICB1cGRhdGVTY3JvbGxhYmxlQXJlYVNldCgoaGFzSG9yaXpvbnRh bE92ZXJmbG93KCkgfHwgaGFzVmVydGljYWxPdmVyZmxvdygpKSAmJiBzY3JvbGxzT3ZlcmZsb3co KSk7CisgICAgICAgIHVwZGF0ZVNjcm9sbGFibGVBcmVhU2V0KChoYXNIb3Jpem9udGFsT3ZlcmZs b3coKSB8fCBoYXNWZXJ0aWNhbE92ZXJmbG93KCkpICYmIHNjcm9sbHNPdmVyZmxvdygpICYmIGFs bG93c1Njcm9sbGluZygpKTsKIH0KIAogdm9pZCBSZW5kZXJMYXllcjo6c3R5bGVDaGFuZ2VkKFN0 eWxlRGlmZmVyZW5jZSwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9TY3JvbGxpbmdDb29yZGluYXRvckNocm9taXVt VGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1Njcm9sbGluZ0Nvb3JkaW5h dG9yQ2hyb21pdW1UZXN0LmNwcAppbmRleCBiNGZhNGExZGJmNzQ0NTBiNTJhMjE4YWNjYzI5YTkz ZDg4MzQzMjFmLi5kNzA1NzAxMTQxOWYwMGViZWIwMDJiZjJmODliZmFmMGVkYzk4YzEzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1Njcm9sbGluZ0Nvb3JkaW5hdG9y Q2hyb21pdW1UZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1Njcm9s bGluZ0Nvb3JkaW5hdG9yQ2hyb21pdW1UZXN0LmNwcApAQCAtMTgzLDYgKzE4MywxNSBAQCBURVNU X0YoU2Nyb2xsaW5nQ29vcmRpbmF0b3JDaHJvbWl1bVRlc3QsIHdoZWVsRXZlbnRIYW5kbGVyKQog ICAgIEFTU0VSVF9UUlVFKHJvb3RTY3JvbGxMYXllci0+aGF2ZVdoZWVsRXZlbnRIYW5kbGVycygp KTsKIH0KIAorVEVTVF9GKFNjcm9sbGluZ0Nvb3JkaW5hdG9yQ2hyb21pdW1UZXN0LCBjbGlwcGVk Qm9keVRlc3QpCit7CisgICAgcmVnaXN0ZXJNb2NrZWRIdHRwVVJMTG9hZCgiY2xpcHBlZC1ib2R5 Lmh0bWwiKTsKKyAgICBuYXZpZ2F0ZVRvKG1fYmFzZVVSTCArICJjbGlwcGVkLWJvZHkuaHRtbCIp OworCisgICAgV2ViTGF5ZXIqIHJvb3RTY3JvbGxMYXllciA9IGdldFJvb3RTY3JvbGxMYXllcigp OworICAgIEFTU0VSVF9FUSgwdSwgcm9vdFNjcm9sbExheWVyLT5ub25GYXN0U2Nyb2xsYWJsZVJl Z2lvbigpLnNpemUoKSk7Cit9CisKICNpZiBFTkFCTEUoQUNDRUxFUkFURURfT1ZFUkZMT1dfU0NS T0xMSU5HKQogVEVTVF9GKFNjcm9sbGluZ0Nvb3JkaW5hdG9yQ2hyb21pdW1UZXN0LCB0b3VjaE92 ZXJmbG93U2Nyb2xsaW5nKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9kYXRhL2NsaXBwZWQtYm9keS5odG1sIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9kYXRhL2NsaXBwZWQtYm9keS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRlYmYxNjlhZDY5ZGJiNWUwNmM3 NDEwZWExYTZlYWU4Nzg4NmExOTIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL2RhdGEvY2xpcHBlZC1ib2R5Lmh0bWwKQEAgLTAsMCArMSwyMSBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKworPGhlYWQ+CisgIDxzdHlsZT4KKyAgICBodG1sLCBib2R5 IHsKKyAgICAgIG92ZXJmbG93LXg6IGhpZGRlbjsKKyAgICB9CisgICAgI2NvbnRlbnQgeworICAg ICAgYmFja2dyb3VuZDogc2lsdmVyOworICAgICAgd2lkdGg6IDEwMDBweDsKKyAgICAgIGhlaWdo dDogMTAwMHB4OworICAgIH0KKyAgPC9zdHlsZT4KKzxoZWFkPgorCis8Ym9keT4KKyAgPGRpdiBp ZD0iY29udGVudCI+PC9kaXY+Cis8L2JvZHk+CisKKzwvaHRtbD4K