97926 2012-09-28 11:30:13 -0700 Garden-o-matic sometimes thinks buildbot warnings are failures 2012-09-28 12:17:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth adamk dglazkov dpranke schenney tony oldest_to_newest 730833 0 ojan 2012-09-28 11:30:13 -0700 Garden-o-matic sometimes things buildbot warnings are failures 730835 1 166284 ojan 2012-09-28 11:31:00 -0700 Created attachment 166284 Patch 730870 2 166289 ojan 2012-09-28 12:12:40 -0700 Created attachment 166289 Patch 730871 3 166289 tony 2012-09-28 12:15:03 -0700 Comment on attachment 166289 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166289&action=review > Tools/ChangeLog:3 > + Garden-o-matic sometimes things buildbot warnings are failures things -> thinks > Tools/ChangeLog:9 > + It turns out the JSON clearly tells us if it's a failure. We don't need to > + search the text for the word "warning" and hope it's right. I would reword this to make it clear that we want to ignore all warnings. 730872 4 166289 tony 2012-09-28 12:15:27 -0700 Comment on attachment 166289 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166289&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:59 > - return step.results[0] > 0 && !step.text.some(isWarning); > + return step.results[0] == 2; This could use a comment about the different values. 730874 5 ojan 2012-09-28 12:17:50 -0700 Committed r129930: <http://trac.webkit.org/changeset/129930> 166284 2012-09-28 11:31:00 -0700 2012-09-28 12:12:38 -0700 Patch bug-97926-20120928113017.patch text/plain 3567 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmFmZjY5OWI5NmNjZDBjNjU0YTkyOTc3ZTEwZGQ1YzMw YTI3NTU2NS4uNWI0MGFhZDcyNmVlMTQ4OWEwYjQwOGNlMTFjMjBjNzk3MGQxYmNhMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA5LTI4ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgR2FyZGVuLW8tbWF0aWMgc29tZXRpbWVzIHRoaW5ncyBidWlsZGJvdCB3YXJuaW5ncyBhcmUg ZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk3OTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SXQgdHVybnMgb3V0IHRoZSBKU09OIGNsZWFybHkgdGVsbHMgdXMgaWYgaXQncyBhIGZhaWx1cmUu IFdlIGRvbid0IG5lZWQgdG8KKyAgICAgICAgc2VhcmNoIHRoZSB0ZXh0IGZvciB0aGUgd29yZCAi d2FybmluZyIgYW5kIGhvcGUgaXQncyByaWdodC4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0 cy9idWlsZGVycy5qczoKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVyc191bml0 dGVzdHMuanM6CisgICAgICAgICguKToKKwogMjAxMi0wOS0yOCAgSGFyYWxkIFR2ZWl0IEFsdmVz dHJhbmQgIDxoYXJhbGRAYWx2ZXN0cmFuZC5ubz4KIAogICAgICAgICBJbXBsZW1lbnQgdGhlIEdl dFN0YXRzIGludGVyZmFjZSBvbiBQZWVyQ29ubmVjdGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZh aWx1cmVzL3NjcmlwdHMvYnVpbGRlcnMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWls ZGVycy5qcwppbmRleCA4MjIxMjk3YjY2M2MzODVmNmJiNjljZjg4MzNkZTY5M2JjNzI4MmZjLi4y YmIyNmJiM2M1NTA0NzJmMTZhZDA1NWJiMjFlYmEwNGYxMGE5YTVjIDEwMDY0NAotLS0gYS9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVycy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2Ny aXB0cy9idWlsZGVycy5qcwpAQCAtNTEsMTMgKzUxLDkgQEAgZnVuY3Rpb24gdXJsRm9yQnVpbGRJ bmZvKHBsYXRmb3JtLCBidWlsZGVyTmFtZSwgYnVpbGROdW1iZXIpCiAKIGZ1bmN0aW9uIGRpZEZh aWwoc3RlcCkKIHsKLSAgICBpZiAoa1dlYktpdFRlc3RzU3RlcE5hbWVzLmluZGV4T2Yoc3RlcC5u YW1lKSAhPSAtMSkgewotICAgICAgICAvLyBydW4td2Via2l0LXRlc3RzIGZhaWxzIHRvIGdlbmVy YXRlIHRlc3QgY292ZXJhZ2Ugd2hlbiBpdCBjcmFzaGVzIG9yIGhhbmdzLgotICAgICAgICAvLyBG SVhNRTogRG8gYnVpbGQud2Via2l0Lm9yZyBib3RzIG91dHB1dCB0aGlzIG1hcmtlciB3aGVuIHRo ZSB0ZXN0cyBmYWlsIHRvIHJ1bj8KLSAgICAgICAgcmV0dXJuIHN0ZXAudGV4dC5pbmRleE9mKGtD cmFzaGVkT3JIdW5nT3V0cHV0TWFya2VyKSAhPSAtMTsKLSAgICB9Ci0gICAgZnVuY3Rpb24gaXNX YXJuaW5nKHRleHQpIHsgcmV0dXJuIHRleHQuaW5kZXhPZignd2FybmluZycpICE9IC0xOyB9Ci0g ICAgcmV0dXJuIHN0ZXAucmVzdWx0c1swXSA+IDAgJiYgIXN0ZXAudGV4dC5zb21lKGlzV2Fybmlu Zyk7CisgICAgLy8gVGhlIGZpcnN0IGl0ZW0gaW4gc3RlcC5yZXN1bHRzIGlzIHRoZSBzdWNjZXNz IG9mIHRoZSBzdGVwOgorICAgIC8vIDAgPT0gcGFzcywgMSA9PSB3YXJuaW5nLCAyID09IGZhaWwK KyAgICByZXR1cm4gc3RlcC5yZXN1bHRzWzBdID09IDI7CiB9CiAKIGZ1bmN0aW9uIGZhaWxpbmdT dGVwcyhidWlsZEluZm8pCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWls ZGVyc191bml0dGVzdHMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVyc191bml0 dGVzdHMuanMKaW5kZXggZTc3NDY5YmZhODVkZmRmNDM3YTllMzNjOGYyOGU3YzVhOGJmYjIwYy4u YmNhNzRjZjU0YTUyZGQ2YmI5ZDE4NzdiNjQ0MjI0ZmY2MDBiNDA3YSAxMDA2NDQKLS0tIGEvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv VGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnNfdW5pdHRlc3RzLmpzCisrKyBiL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RG YWlsdXJlcy9zY3JpcHRzL2J1aWxkZXJzX3VuaXR0ZXN0cy5qcwpAQCAtMTAwNiwxMCArMTAwNiwx MSBAQCB0ZXN0KCJidWlsZGVyc0ZhaWxpbmciLCAzLCBmdW5jdGlvbigpIHsKICAgICAgICAgYnVp bGRlcnMuYnVpbGRlcnNGYWlsaW5nTm9uTGF5b3V0VGVzdHMoZnVuY3Rpb24oYnVpbGRlck5hbWVM aXN0KSB7CiAgICAgICAgICAgICBkZWVwRXF1YWwoYnVpbGRlck5hbWVMaXN0LCB7CiAgICAgICAg ICAgICAgICAgIldlYmtpdCBMaW51eCI6IFsKKyAgICAgICAgICAgICAgICAgICAgIndlYmtpdF90 ZXN0cyIsCiAgICAgICAgICAgICAgICAgICAgICJ3ZWJraXRfZ3B1X3Rlc3RzIgogICAgICAgICAg ICAgICAgIF0sCiAgICAgICAgICAgICAgICAgIldlYmtpdCBNYWMxMC42IjogWwotICAgICAgICAg ICAgICAgICAgICAiY29tcGlsZSIsCisgICAgICAgICAgICAgICAgICAgICJ3ZWJraXRfdGVzdHMi LAogICAgICAgICAgICAgICAgICAgICAid2Via2l0X2dwdV90ZXN0cyIKICAgICAgICAgICAgICAg ICBdCiAgICAgICAgICAgICB9KTsKQEAgLTEwNTMsNiArMTA1NCw3IEBAIHRlc3QoImJ1aWxkZXJz RmFpbGluZyAoQXBwbGUpIiwgMywgZnVuY3Rpb24oKSB7CiAgICAgICAgIGJ1aWxkZXJzLmJ1aWxk ZXJzRmFpbGluZ05vbkxheW91dFRlc3RzKGZ1bmN0aW9uKGJ1aWxkZXJOYW1lTGlzdCkgewogICAg ICAgICAgICAgZGVlcEVxdWFsKGJ1aWxkZXJOYW1lTGlzdCwgewogICAgICAgICAgICAgICAgICJB cHBsZSBMaW9uIFJlbGVhc2UgV0syIChUZXN0cykiOiBbCisgICAgICAgICAgICAgICAgICAgICJ3 ZWJraXRfdGVzdHMiLAogICAgICAgICAgICAgICAgICAgICAid2Via2l0X2dwdV90ZXN0cyIKICAg ICAgICAgICAgICAgICBdCiAgICAgICAgICAgICB9KTsK 166289 2012-09-28 12:12:40 -0700 2012-09-28 12:15:27 -0700 Patch bug-97926-20120928121157.patch text/plain 2646 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmFmZjY5OWI5NmNjZDBjNjU0YTkyOTc3ZTEwZGQ1YzMw YTI3NTU2NS4uYWQ0MzQ4MWNiOGM2M2YxMmUwNDQ3Nzk4Y2Q2ZWZjOWRiYzY5ZjNlMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA5LTI4ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgR2FyZGVuLW8tbWF0aWMgc29tZXRpbWVzIHRoaW5ncyBidWlsZGJvdCB3YXJuaW5ncyBhcmUg ZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk3OTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SXQgdHVybnMgb3V0IHRoZSBKU09OIGNsZWFybHkgdGVsbHMgdXMgaWYgaXQncyBhIGZhaWx1cmUu IFdlIGRvbid0IG5lZWQgdG8KKyAgICAgICAgc2VhcmNoIHRoZSB0ZXh0IGZvciB0aGUgd29yZCAi d2FybmluZyIgYW5kIGhvcGUgaXQncyByaWdodC4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0 cy9idWlsZGVycy5qczoKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVyc191bml0 dGVzdHMuanM6CisKIDIwMTItMDktMjggIEhhcmFsZCBUdmVpdCBBbHZlc3RyYW5kICA8aGFyYWxk QGFsdmVzdHJhbmQubm8+CiAKICAgICAgICAgSW1wbGVtZW50IHRoZSBHZXRTdGF0cyBpbnRlcmZh Y2Ugb24gUGVlckNvbm5lY3Rpb24KZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRz L2J1aWxkZXJzLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnMuanMKaW5kZXgg ODIyMTI5N2I2NjNjMzg1ZjZiYjY5Y2Y4ODMzZGU2OTNiYzcyODJmYy4uMzc4ZDZiNjAwMWI4MzE0 MzU1ZDRmZWNiZTJlZTMzODExYzFmNGFjZSAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3Nj cmlwdHMvYnVpbGRlcnMuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnMu anMKQEAgLTU2LDggKzU2LDcgQEAgZnVuY3Rpb24gZGlkRmFpbChzdGVwKQogICAgICAgICAvLyBG SVhNRTogRG8gYnVpbGQud2Via2l0Lm9yZyBib3RzIG91dHB1dCB0aGlzIG1hcmtlciB3aGVuIHRo ZSB0ZXN0cyBmYWlsIHRvIHJ1bj8KICAgICAgICAgcmV0dXJuIHN0ZXAudGV4dC5pbmRleE9mKGtD cmFzaGVkT3JIdW5nT3V0cHV0TWFya2VyKSAhPSAtMTsKICAgICB9Ci0gICAgZnVuY3Rpb24gaXNX YXJuaW5nKHRleHQpIHsgcmV0dXJuIHRleHQuaW5kZXhPZignd2FybmluZycpICE9IC0xOyB9Ci0g ICAgcmV0dXJuIHN0ZXAucmVzdWx0c1swXSA+IDAgJiYgIXN0ZXAudGV4dC5zb21lKGlzV2Fybmlu Zyk7CisgICAgcmV0dXJuIHN0ZXAucmVzdWx0c1swXSA9PSAyOwogfQogCiBmdW5jdGlvbiBmYWls aW5nU3RlcHMoYnVpbGRJbmZvKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMv YnVpbGRlcnNfdW5pdHRlc3RzLmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnNf dW5pdHRlc3RzLmpzCmluZGV4IGU3NzQ2OWJmYTg1ZGZkZjQzN2E5ZTMzYzhmMjhlN2M1YThiZmIy MGMuLjljNTA2ZDUzMTE1MDU4MzE5OWQzOGQ4NGJmM2JlN2Y1Zjk3OTdiNTAgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19o dG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2J1aWxkZXJzX3VuaXR0ZXN0cy5qcworKysgYi9Ub29s cy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9U ZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVyc191bml0dGVzdHMuanMKQEAgLTEwMDksNyArMTAw OSw2IEBAIHRlc3QoImJ1aWxkZXJzRmFpbGluZyIsIDMsIGZ1bmN0aW9uKCkgewogICAgICAgICAg ICAgICAgICAgICAid2Via2l0X2dwdV90ZXN0cyIKICAgICAgICAgICAgICAgICBdLAogICAgICAg ICAgICAgICAgICJXZWJraXQgTWFjMTAuNiI6IFsKLSAgICAgICAgICAgICAgICAgICAgImNvbXBp bGUiLAogICAgICAgICAgICAgICAgICAgICAid2Via2l0X2dwdV90ZXN0cyIKICAgICAgICAgICAg ICAgICBdCiAgICAgICAgICAgICB9KTsK