97919 2012-09-28 08:59:43 -0700 [chromium] Add fields to WebRenderingStats to track frequency of impl-thread vs. main-thread scrolling 2012-10-02 09:49:39 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tdanderson tdanderson abarth dglazkov fishd jamesr tkent+wkapi vollick webkit.review.bot oldest_to_newest 730712 0 tdanderson 2012-09-28 08:59:43 -0700 Add |bool didImplThreadScroll| to WebRenderingStats.h which will be true if and only if we have impl-thread scrolled. 730713 1 166261 tdanderson 2012-09-28 09:01:11 -0700 Created attachment 166261 Patch 730716 2 webkit.review.bot 2012-09-28 09:03:58 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 730731 3 tdanderson 2012-09-28 09:20:08 -0700 Corresponding chromium patch: https://codereview.chromium.org/10985082/ 730889 4 166261 jamesr 2012-09-28 12:30:36 -0700 Comment on attachment 166261 Patch A bool isn't a good way to capture this. What's the use case? What about keeping counts of how many scroll-type input events resulted in scrolling vs ignoring vs sending to the main thread? 731902 5 166526 tdanderson 2012-10-01 12:28:32 -0700 Created attachment 166526 Patch 731905 6 tdanderson 2012-10-01 12:31:28 -0700 (In reply to comment #4) > (From update of attachment 166261 [details]) > A bool isn't a good way to capture this. What's the use case? What about keeping counts of how many scroll-type input events resulted in scrolling vs ignoring vs sending to the main thread? We want to use this data to be able to track the frequency of impl-thread vs. main-thread scrolling, so I have added two counters instead of using a bool. The cumulative total of both counters will be reported each time renderingStats() is called. 732075 7 166526 jamesr 2012-10-01 15:49:10 -0700 Comment on attachment 166526 Patch R=me We should figure out a way to route stats like this without involving WebKit patches 732742 8 166526 webkit.review.bot 2012-10-02 09:49:36 -0700 Comment on attachment 166526 Patch Clearing flags on attachment: 166526 Committed r130180: <http://trac.webkit.org/changeset/130180> 732743 9 webkit.review.bot 2012-10-02 09:49:39 -0700 All reviewed patches have been landed. Closing bug. 166261 2012-09-28 09:01:11 -0700 2012-10-01 12:28:29 -0700 Patch bug-97919-20120928120028.patch text/plain 2499 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBiZWI5MmZmYmFlYWU2 MDc4MWFkZjEwODdhZmU5MTdiZDY1ZjliYjJhLi4xYjBiZDM1ZThmYzA2YjIwYTExMGJlNTk2ZThl ZWEyZDY3MjVhYzI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wOS0yOCAg VGVycnkgQW5kZXJzb24gIDx0ZGFuZGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hy b21pdW1dIEFkZCBmaWVsZCB0byBXZWJSZW5kZXJpbmdTdGF0cyB0byB0cmFjayBpZiB3ZSBoYXZl IGltcGwtdGhyZWFkIHNjcm9sbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NzkxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCB8Ym9vbCBkaWRJbXBsVGhyZWFkU2Nyb2xsfCB0byBXZWJSZW5kZXJp bmdTdGF0cy5oIHdoaWNoIHdpbGwgYmUgdHJ1ZSBpZiBhbmQgCisgICAgICAgIG9ubHkgaWYgd2Ug aGF2ZSBpbXBsLXRocmVhZCBzY3JvbGxlZC4KKworICAgICAgICAqIGNocm9taXVtL3B1YmxpYy9X ZWJSZW5kZXJpbmdTdGF0cy5oOgorICAgICAgICAoV2ViUmVuZGVyaW5nU3RhdHMpOgorICAgICAg ICAoV2ViS2l0OjpXZWJSZW5kZXJpbmdTdGF0czo6V2ViUmVuZGVyaW5nU3RhdHMpOgorICAgICAg ICAoRW51bWVyYXRvcik6CisgICAgICAgIChXZWJLaXQ6OldlYlJlbmRlcmluZ1N0YXRzOjplbnVt ZXJhdGVGaWVsZHMpOgorCiAyMDEyLTA5LTI3ICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bn b29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQSTogRW5oYW5jZSBNZWRpYUNvbnN0 cmFpbnRzIHRvIG1ha2UgaXQgZWFzaWVyIHRvIGdldCB0aGUgY29uc3RyYWludCBkYXRhCmRpZmYg LS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlbmRlcmluZ1N0YXRz LmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlbmRlcmluZ1N0YXRzLmgK aW5kZXggYWJkMTBhMGE5OGUxYWM5M2E1NGQ2OTgwNzA1ZDI2M2M3NmYzMGE4My4uZmE1YTcwN2Y2 ZmNmNjIzYjcyYzVjMzg2MzI1OWZiNTY3Yjg5NzcwOSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRm b3JtL2Nocm9taXVtL3B1YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oCisrKyBiL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUmVuZGVyaW5nU3RhdHMuaApAQCAtMzYsNiArMzYsNyBA QCBzdHJ1Y3QgV2ViUmVuZGVyaW5nU3RhdHMgewogICAgIGRvdWJsZSB0b3RhbFJhc3Rlcml6ZVRp bWVJblNlY29uZHM7CiAgICAgZG91YmxlIHRvdGFsQ29tbWl0VGltZUluU2Vjb25kczsKICAgICBz aXplX3QgdG90YWxDb21taXRDb3VudDsKKyAgICBib29sIGRpZEltcGxUaHJlYWRTY3JvbGw7CiAK ICAgICBXZWJSZW5kZXJpbmdTdGF0cygpCiAgICAgICAgIDogbnVtQW5pbWF0aW9uRnJhbWVzKDAp CkBAIC00NSw2ICs0Niw3IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7CiAgICAgICAgICwg dG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKDApCiAgICAgICAgICwgdG90YWxDb21taXRUaW1l SW5TZWNvbmRzKDApCiAgICAgICAgICwgdG90YWxDb21taXRDb3VudCgwKQorICAgICAgICAsIGRp ZEltcGxUaHJlYWRTY3JvbGwoZmFsc2UpCiAgICAgewogICAgIH0KIApAQCAtNTYsNiArNTgsNyBA QCBzdHJ1Y3QgV2ViUmVuZGVyaW5nU3RhdHMgewogICAgIHB1YmxpYzoKICAgICAgICAgdmlydHVh bCB2b2lkIGFkZEludChjb25zdCBjaGFyKiBuYW1lLCBpbnQgdmFsdWUpID0gMDsKICAgICAgICAg dmlydHVhbCB2b2lkIGFkZERvdWJsZShjb25zdCBjaGFyKiBuYW1lLCBkb3VibGUgdmFsdWUpID0g MDsKKyAgICAgICAgdmlydHVhbCB2b2lkIGFkZEJvb2woY29uc3QgY2hhciogbmFtZSwgYm9vbCB2 YWx1ZSkgPSAwOwogICAgIHByb3RlY3RlZDoKICAgICAgICAgdmlydHVhbCB+RW51bWVyYXRvcigp IHsgfQogICAgIH07CkBAIC03MCw2ICs3Myw3IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7 CiAgICAgICAgIGVudW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxSYXN0ZXJpemVUaW1lSW5TZWNv bmRzIiwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKTsKICAgICAgICAgZW51bWVyYXRvci0+ YWRkRG91YmxlKCJ0b3RhbENvbW1pdFRpbWVJblNlY29uZHMiLCB0b3RhbENvbW1pdFRpbWVJblNl Y29uZHMpOwogICAgICAgICBlbnVtZXJhdG9yLT5hZGRJbnQoInRvdGFsQ29tbWl0Q291bnQiLCB0 b3RhbENvbW1pdENvdW50KTsKKyAgICAgICAgZW51bWVyYXRvci0+YWRkQm9vbCgiZGlkSW1wbFRo cmVhZFNjcm9sbCIsIGRpZEltcGxUaHJlYWRTY3JvbGwpOwogICAgIH0KIH07CiAK 166526 2012-10-01 12:28:32 -0700 2012-10-02 09:49:35 -0700 Patch bug-97919-20121001152745.patch text/plain 2344 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAyMGYwMWEyNjc2MGQ2 NzY0YjY0OTBiNDJmMTg4NjU1NGY0NjU1NzE3Li5kMmNlZGIyNmE5ZGI3ZjRlMjU1MjVmZTdkNzgw OTg1ZDYzMDc3OWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0wMSAg VGVycnkgQW5kZXJzb24gIDx0ZGFuZGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hy b21pdW1dIEFkZCBmaWVsZCB0byBXZWJSZW5kZXJpbmdTdGF0cyB0byB0cmFjayBpZiB3ZSBoYXZl IGltcGwtdGhyZWFkIHNjcm9sbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NzkxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZCB0d28gbmV3IG1lbWJlcnMgfG51bUltcGxUaHJlYWRTY3JvbGxzfCBh bmQgfG51bU1haW5UaHJlYWRTY3JvbGxzfCB0byB0cmFjaworICAgICAgICB0aGUgdG90YWwgbnVt YmVyIG9mIHRpbWVzIHdlIGhhdmUgaW1wbC10aHJlYWQgc2Nyb2xsZWQgYW5kIG1haW4tdGhyZWFk IHNjcm9sbGVkLAorICAgICAgICByZXNwZWN0aXZlbHkuCisKKyAgICAgICAgKiBjaHJvbWl1bS9w dWJsaWMvV2ViUmVuZGVyaW5nU3RhdHMuaDoKKyAgICAgICAgKFdlYlJlbmRlcmluZ1N0YXRzKToK KyAgICAgICAgKFdlYktpdDo6V2ViUmVuZGVyaW5nU3RhdHM6OldlYlJlbmRlcmluZ1N0YXRzKToK KyAgICAgICAgKFdlYktpdDo6V2ViUmVuZGVyaW5nU3RhdHM6OmVudW1lcmF0ZUZpZWxkcyk6CisK IDIwMTItMDktMjggIEhhcmFsZCBUdmVpdCBBbHZlc3RyYW5kICA8aGFyYWxkQGFsdmVzdHJhbmQu bm8+CiAKICAgICAgICAgSW1wbGVtZW50IHRoZSBHZXRTdGF0cyBpbnRlcmZhY2Ugb24gUGVlckNv bm5lY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi UmVuZGVyaW5nU3RhdHMuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUmVu ZGVyaW5nU3RhdHMuaAppbmRleCBhYmQxMGEwYTk4ZTFhYzkzYTU0ZDY5ODA3MDVkMjYzYzc2ZjMw YTgzLi5iYjliOTliZjFhM2Q4MDk3YmZjZTFiYTEwMGFiYTlhNGE1YTI4MDg0IDEwMDY0NAotLS0g YS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlbmRlcmluZ1N0YXRzLmgKKysr IGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oCkBA IC0zNiw2ICszNiw4IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7CiAgICAgZG91YmxlIHRv dGFsUmFzdGVyaXplVGltZUluU2Vjb25kczsKICAgICBkb3VibGUgdG90YWxDb21taXRUaW1lSW5T ZWNvbmRzOwogICAgIHNpemVfdCB0b3RhbENvbW1pdENvdW50OworICAgIHNpemVfdCBudW1JbXBs VGhyZWFkU2Nyb2xsczsKKyAgICBzaXplX3QgbnVtTWFpblRocmVhZFNjcm9sbHM7CiAKICAgICBX ZWJSZW5kZXJpbmdTdGF0cygpCiAgICAgICAgIDogbnVtQW5pbWF0aW9uRnJhbWVzKDApCkBAIC00 NSw2ICs0Nyw4IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7CiAgICAgICAgICwgdG90YWxS YXN0ZXJpemVUaW1lSW5TZWNvbmRzKDApCiAgICAgICAgICwgdG90YWxDb21taXRUaW1lSW5TZWNv bmRzKDApCiAgICAgICAgICwgdG90YWxDb21taXRDb3VudCgwKQorICAgICAgICAsIG51bUltcGxU aHJlYWRTY3JvbGxzKDApCisgICAgICAgICwgbnVtTWFpblRocmVhZFNjcm9sbHMoMCkKICAgICB7 CiAgICAgfQogCkBAIC03MCw2ICs3NCw4IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7CiAg ICAgICAgIGVudW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRz IiwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKTsKICAgICAgICAgZW51bWVyYXRvci0+YWRk RG91YmxlKCJ0b3RhbENvbW1pdFRpbWVJblNlY29uZHMiLCB0b3RhbENvbW1pdFRpbWVJblNlY29u ZHMpOwogICAgICAgICBlbnVtZXJhdG9yLT5hZGRJbnQoInRvdGFsQ29tbWl0Q291bnQiLCB0b3Rh bENvbW1pdENvdW50KTsKKyAgICAgICAgZW51bWVyYXRvci0+YWRkSW50KCJudW1JbXBsVGhyZWFk U2Nyb2xscyIsIG51bUltcGxUaHJlYWRTY3JvbGxzKTsKKyAgICAgICAgZW51bWVyYXRvci0+YWRk SW50KCJudW1NYWluVGhyZWFkU2Nyb2xscyIsIG51bU1haW5UaHJlYWRTY3JvbGxzKTsKICAgICB9 CiB9OwogCg==