97909 2012-09-28 07:03:46 -0700 [chromium] REGRESSION(r129825): Page popup don't open any more 2012-10-01 14:41:48 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi dglazkov keishi pilgrim tkent webkit.review.bot oldest_to_newest 730623 0 keishi 2012-09-28 07:03:46 -0700 PagePopupChromeClient doesn't implement platformPageClient() so screen rect is zero. And it is causing DOMWindow.resizeTo to always resize to zero. 730633 1 pilgrim 2012-09-28 07:18:49 -0700 Rolled out: https://bugs.webkit.org/show_bug.cgi?id=97474#c20 730638 2 keishi 2012-09-28 07:22:03 -0700 Reopening to attach new patch. 730639 3 166248 keishi 2012-09-28 07:22:05 -0700 Created attachment 166248 Patch 730641 4 pilgrim 2012-09-28 07:24:39 -0700 (In reply to comment #3) > Created an attachment (id=166248) [details] > Patch This won't work anymore because we rolled out the original patch already. 730649 5 166248 webkit.review.bot 2012-09-28 07:47:56 -0700 Comment on attachment 166248 Patch Attachment 166248 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14065284 166248 2012-09-28 07:22:05 -0700 2012-10-01 14:41:48 -0700 Patch bug-97909-20120928232122.patch text/plain 2062 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDQ5ZTU4OTVkMTU1MGI1MzZiYzQyZjViZGU2ZDI3M2YwZTdmZWY3NDkuLjhlMDI0MzIxZTBlMjI0 NmY4MDlmYTA2OTQzNGM5NzBlNjk4ZDY2ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDktMjggIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTI5ODI1KTogUGFnZSBwb3B1cCBkb24ndCBv cGVuIGFueSBtb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NzkwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIERPTVdpbmRvdy5yZXNpemVUbyB3YXNuJ3Qgd29ya2luZyBiZWNhdXNlIDB4MCB3YXMgYmVp bmcgcmV0dXJuZWQgZm9yIHNjcmVlbiBzaXplLgorICAgICAgICBUaGlzIG1vZGlmaWVzIFBhZ2VQ b3B1cENocm9tZUNsaWVudCBzbyBpdCByZXR1cm5zIHRoZSBwcm9wZXIgc2NyZWVuIHNpemUuCisK KyAgICAgICAgKiBzcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHA6CisKIDIwMTItMDktMjggIFl1cnkg U2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogbWFrZSBIYXNoU2V0IG1lbW9yeSBpbnN0cnVtZW50YXRpb24gbm9uLWludHJ1c2l2ZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVwSW1wbC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAppbmRleCAx ZTBmY2ViYjUyOWZmMDJlMWEwMDlhYWY1Yjc0ODFlY2VmMTBjYzY3Li42NWUwODJmN2NmZDM3MzU2 ZDQ5YjkzNzhlZjlkYjJlY2I0ZmE1NWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcApAQCAtNDQsNiArNDQsNyBAQAogI2luY2x1ZGUgIlNl dHRpbmdzLmgiCiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudENvbnZlcnNpb24uaCIKICNpbmNsdWRl ICJXZWJQYWdlUG9wdXAuaCIKKyNpbmNsdWRlICJXZWJWaWV3Q2xpZW50LmgiCiAjaW5jbHVkZSAi V2ViVmlld0ltcGwuaCIKICNpbmNsdWRlICJXZWJXaWRnZXRDbGllbnQuaCIKIApAQCAtNTQsNyAr NTUsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogI2lmIEVOQUJMRShQQUdFX1BPUFVQKQogCi1j bGFzcyBQYWdlUG9wdXBDaHJvbWVDbGllbnQgOiBwdWJsaWMgRW1wdHlDaHJvbWVDbGllbnQgewor Y2xhc3MgUGFnZVBvcHVwQ2hyb21lQ2xpZW50IDogcHVibGljIEVtcHR5Q2hyb21lQ2xpZW50LCBw dWJsaWMgV2ViQ29yZTo6UGFnZUNsaWVudENocm9taXVtIHsKICAgICBXVEZfTUFLRV9OT05DT1BZ QUJMRShQYWdlUG9wdXBDaHJvbWVDbGllbnQpOwogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVE OwogCkBAIC0xMjQsNiArMTI1LDE3IEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiBGbG9hdFNp emUoMCwgMCk7CiAgICAgfQogCisgICAgdmlydHVhbCBQbGF0Zm9ybVBhZ2VDbGllbnQgcGxhdGZv cm1QYWdlQ2xpZW50KCkgY29uc3QgT1ZFUlJJREUKKyAgICB7CisgICAgICAgIHJldHVybiBQbGF0 Zm9ybVBhZ2VDbGllbnQodGhpcyk7CisgICAgfQorCisgICAgLy8gUGFnZUNsaWVudENocm9taXVt IG1ldGhvZHM6CisgICAgdmlydHVhbCBXZWJLaXQ6OldlYlNjcmVlbkluZm8gc2NyZWVuSW5mbygp IE9WRVJSSURFCisgICAgeworICAgICAgICByZXR1cm4gbV9wb3B1cC0+bV93ZWJWaWV3LT5jbGll bnQoKS0+c2NyZWVuSW5mbygpOworICAgIH0KKwogICAgIFdlYlBhZ2VQb3B1cEltcGwqIG1fcG9w dXA7CiB9OwogCg==