97908 2012-09-28 06:47:08 -0700 [Qt][WK2] Device pixel ratio lost upon relaunch of the web process 2012-10-01 07:12:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abecsi abecsi bdakin cmarcelo jturcotte menard webkit.review.bot zoltan oldest_to_newest 730610 0 abecsi 2012-09-28 06:47:08 -0700 [Qt][WK2] Custom device scale factor lost upon relaunch of the web process 730612 1 166243 abecsi 2012-09-28 06:47:45 -0700 Created attachment 166243 Patch 731506 2 jturcotte 2012-10-01 02:21:36 -0700 By looking at bug #67150 it seems that the issue is that the custom scale factor was designed to only be used temporary. Could you try using setIntrinsicDeviceScaleFactor instead of setCustomDeviceScaleFactor and see if that solves the issue? It seems like we ended up using it after bug #89272 but should have been using the intrinsic one at this point. 731596 3 abecsi 2012-10-01 05:14:57 -0700 (In reply to comment #2) > By looking at bug #67150 it seems that the issue is that the custom scale factor was designed to only be used temporary. > Could you try using setIntrinsicDeviceScaleFactor instead of setCustomDeviceScaleFactor and see if that solves the issue? > > It seems like we ended up using it after bug #89272 but should have been using the intrinsic one at this point. Indeed, for the QML use-case using setIntrinsicDeviceScaleFactor seems to be the correct solution. Although, as a side note, nonetheless of the custom scale factor being a temporal value, it still feels odd that when set it is not restored when the web process crashes. 731597 4 166454 abecsi 2012-10-01 05:15:59 -0700 Created attachment 166454 Patch 731672 5 166454 abecsi 2012-10-01 07:12:43 -0700 Comment on attachment 166454 Patch Clearing flags on attachment: 166454 Committed r130045: <http://trac.webkit.org/changeset/130045> 731673 6 abecsi 2012-10-01 07:12:48 -0700 All reviewed patches have been landed. Closing bug. 166243 2012-09-28 06:47:45 -0700 2012-10-01 05:15:54 -0700 Patch bug-97908-20120928154728.patch text/plain 2740 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGMwN2IxY2M0YWViMTM4 N2UyZGYzOWQxODhkOWQ3OTQ5YTVlN2RmMS4uMTg0ZDI5MjFmNTMyNzhmNGI2YWM4NzM5OWJjNWNh ZGUzNjc0MjcwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTI4ICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBD dXN0b20gZGV2aWNlIHNjYWxlIGZhY3RvciBsb3N0IHVwb24gcmVsYXVuY2ggb2YgdGhlIHdlYiBw cm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NzkwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFm dGVyIGEgY3Jhc2ggb2YgdGhlIHdlYiBwcm9jZXNzIHRoZSBjdXN0b20gZGV2aWNlIHNjYWxlIGZh Y3RvciBpbml0aWFsbHkKKyAgICAgICAgc2V0IGJ5IHRoZSBVSSBpcyBub3QgcmVzdG9yZWQgaW4g dGhlIHdlYiBwcm9jZXNzIHdoZW4gaXQgaXMgcmVsYXVuY2hlZC4KKyAgICAgICAgVXNlIFdlYlBh Z2VQcm94eTo6ZGV2aWNlU2NhbGVGYWN0b3IoKSB3aGVuIGNvbnN0cnVjdGluZyB0aGUgY3JlYXRp b24KKyAgICAgICAgcGFyYW1ldGVycyBvZiB0aGUgd2ViIHBhZ2Ugd2hpY2ggcmV0dXJucyB0aGUg aW50cmluc2ljIGRldmljZSBzY2FsZQorICAgICAgICBmYWN0b3IgaWYgbm8gY3VzdG9tIG9uZSBo YXMgYmVlbiBzZXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcu Y3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld1ByaXZhdGU6OmRpZFJlbGF1bmNoUHJvY2Vzcyk6 CisgICAgICAgIFJlbW92ZSBlcnJvbmVvdXMgcmVzZXQgYWZ0ZXIgcjEyOTUwMC4KKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVBy b3h5OjpjcmVhdGlvblBhcmFtZXRlcnMpOgorCiAyMDEyLTA5LTI4ICBFdW5taSBMZWUgIDxldW5t aTE1LmxlZUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFJlZmFjdG9yaW5nIGlu aXRpYWxpemF0aW9uIGFuZCBzaHV0ZG93biBjb2RlcyBvZiBFRkwgbGlicmFyaWVzLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXgg Yjc4Y2FlMGYzZWRiOTEyYmVmMDJjMTdmM2E2MmU4YWQ4NjVlNTZkMC4uNDRiMTZiNTU2MzY2ZDI4 MDEyYjc5ZjZkM2IzYzVmOTA0YzcxN2Y4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC00NzgsOCArNDc4LDYgQEAgdm9pZCBR UXVpY2tXZWJWaWV3UHJpdmF0ZTo6ZGlkUmVsYXVuY2hQcm9jZXNzKCkKIHsKICAgICBxV2Fybmlu ZygiV0FSTklORzogVGhlIHdlYiBwcm9jZXNzIGhhcyBiZWVuIHN1Y2Nlc3NmdWxseSByZXN0YXJ0 ZWQuIik7CiAKLSAgICAvLyBSZXNldCB0byBkZWZhdWx0IHNvIHRoYXQgdGhlIGxhdGVyIHVwZGF0 ZSBjYW4gcmVhY2ggdGhlIHdlYiBwcm9jZXNzLgotICAgIHdlYlBhZ2VQcm94eS0+c2V0Q3VzdG9t RGV2aWNlU2NhbGVGYWN0b3IoMCk7CiAgICAgd2ViUGFnZVByb3h5LT5kcmF3aW5nQXJlYSgpLT5z ZXRTaXplKHZpZXdTaXplKCksIEludFNpemUoKSk7CiAKICAgICB1cGRhdGVWaWV3cG9ydFNpemUo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggMDViMjFi N2M4NjY1NTBjZjk2MGFiYjA4Y2E5NmE5YjM4ZDMzMDRhYS4uOWRjYTI1YzFhODcwODVjZGYwNDIx NGFjODc1MjA4NDg3MmI4M2Y3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAKQEAgLTM3MDUsNyArMzcwNSw3IEBAIFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMg V2ViUGFnZVByb3h5OjpjcmVhdGlvblBhcmFtZXRlcnMoKSBjb25zdAogICAgIHBhcmFtZXRlcnMu aGlnaGVzdFVzZWRCYWNrRm9yd2FyZEl0ZW1JRCA9IFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW06Omhp Z2hlZFVzZWRJdGVtSUQoKTsKICAgICBwYXJhbWV0ZXJzLmNhblJ1bkJlZm9yZVVubG9hZENvbmZp cm1QYW5lbCA9IG1fdWlDbGllbnQuY2FuUnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVsKCk7CiAg ICAgcGFyYW1ldGVycy5jYW5SdW5Nb2RhbCA9IG1fY2FuUnVuTW9kYWw7Ci0gICAgcGFyYW1ldGVy cy5kZXZpY2VTY2FsZUZhY3RvciA9IG1faW50cmluc2ljRGV2aWNlU2NhbGVGYWN0b3I7CisgICAg cGFyYW1ldGVycy5kZXZpY2VTY2FsZUZhY3RvciA9IGRldmljZVNjYWxlRmFjdG9yKCk7CiAgICAg cGFyYW1ldGVycy5tZWRpYVZvbHVtZSA9IG1fbWVkaWFWb2x1bWU7CiAKICNpZiBQTEFURk9STShN QUMpCg== 166454 2012-10-01 05:15:59 -0700 2012-10-01 07:12:42 -0700 Patch bug-97908-20121001141548.patch text/plain 2017 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwMDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGRhMTc0YWRmZjVkOWQz ODM2NGQ4ZTRiYjFlM2M4Y2QxYzg5NjFlZi4uYmRiZDU3MjhhMjcxOTFlZTcxYWY0ZWI0MjkyMDYw NjA4ZjkwYzIyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTAxICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBE ZXZpY2UgcGl4ZWwgcmF0aW8gbG9zdCB1cG9uIHJlbGF1bmNoIG9mIHRoZSB3ZWIgcHJvY2Vzcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc5MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2Ugc2V0SW50 cmluc2ljRGV2aWNlU2NhbGVGYWN0b3IgaW5zdGVhZCBvZiBzZXRDdXN0b21EZXZpY2VTY2FsZUZh Y3RvcgorICAgICAgICB3aGVuIHNldHRpbmcgdGhlIGRldmljZSBwaXhlbCByYXRpbyB0byBtYWtl IHRoZSBzZXR0aW5nIHBlcm1hbmVudC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6ZGlkUmVsYXVu Y2hQcm9jZXNzKToKKyAgICAgICAgKFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw6OnNldERldmlj ZVBpeGVsUmF0aW8pOgorCiAyMDEyLTA5LTI3ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50 dXJjb3R0ZUBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBGaXggdmlld3BvcnQgUU1MIGF1dG8g dGVzdHMgYWZ0ZXIgdGhlIHZpZXdwb3J0IGNoYW5nZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IGExMGI2MTEyNjFmNGJjN2Rj MTQyYTllOTU0NDJkNDZmNDA4M2UyMjcuLjFjYTI1OTFiZGE2YmI2NTFiNjA5NzllZmJlZWYzYTgy YTU2NzhjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1 aWNrd2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVp Y2t3ZWJ2aWV3LmNwcApAQCAtNDg0LDggKzQ4NCw2IEBAIHZvaWQgUVF1aWNrV2ViVmlld1ByaXZh dGU6OmRpZFJlbGF1bmNoUHJvY2VzcygpCiB7CiAgICAgcVdhcm5pbmcoIldBUk5JTkc6IFRoZSB3 ZWIgcHJvY2VzcyBoYXMgYmVlbiBzdWNjZXNzZnVsbHkgcmVzdGFydGVkLiIpOwogCi0gICAgLy8g UmVzZXQgdG8gZGVmYXVsdCBzbyB0aGF0IHRoZSBsYXRlciB1cGRhdGUgY2FuIHJlYWNoIHRoZSB3 ZWIgcHJvY2Vzcy4KLSAgICB3ZWJQYWdlUHJveHktPnNldEN1c3RvbURldmljZVNjYWxlRmFjdG9y KDApOwogICAgIHdlYlBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKS0+c2V0U2l6ZSh2aWV3U2l6ZSgp LCBJbnRTaXplKCkpOwogCiAgICAgdXBkYXRlVmlld3BvcnRTaXplKCk7CkBAIC0xMjMyLDcgKzEy MzAsNyBAQCB2b2lkIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw6OnNldERldmljZVBpeGVsUmF0 aW8ocXJlYWwgZGV2aWNlUGl4ZWxSYXRpbykKICAgICBpZiAoMCA+PSBkZXZpY2VQaXhlbFJhdGlv IHx8IGRldmljZVBpeGVsUmF0aW8gPT0gdGhpcy0+ZGV2aWNlUGl4ZWxSYXRpbygpKQogICAgICAg ICByZXR1cm47CiAKLSAgICBkLT53ZWJQYWdlUHJveHktPnNldEN1c3RvbURldmljZVNjYWxlRmFj dG9yKGRldmljZVBpeGVsUmF0aW8pOworICAgIGQtPndlYlBhZ2VQcm94eS0+c2V0SW50cmluc2lj RGV2aWNlU2NhbGVGYWN0b3IoZGV2aWNlUGl4ZWxSYXRpbyk7CiAgICAgZW1pdCBkZXZpY2VQaXhl bFJhdGlvQ2hhbmdlZCgpOwogfQogCg==