97896 2012-09-28 05:12:54 -0700 YYDEBUG doesn't print token values 2012-10-01 14:31:23 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 glenn glenn cmarcelo kling koivisto macpherson menard seikwon.kim webkit.review.bot oldest_to_newest 730526 0 glenn 2012-09-28 05:12:54 -0700 When debugging CSS lexer/parser with YYDEBUG set to 1, token values are not output because YYPRINT macro is a NO-OP. 730535 1 166222 glenn 2012-09-28 05:21:47 -0700 Created attachment 166222 Patch 731275 2 166222 simon.fraser 2012-09-29 22:03:38 -0700 Comment on attachment 166222 Patch Does this have any behavior or performance implications? 731278 3 glenn 2012-09-29 22:10:57 -0700 (In reply to comment #2) > (From update of attachment 166222 [details]) > Does this have any behavior or performance implications? no; YYDEBUG is defined as 0 in CSSGrammar.y and CSSParser.cpp at present; in order to use YYDEBUG feature, e.g., for special debugging, one has to explicitly change the setting of YYDEBUG to 1 in these two files; if one does define as 1, then normal YYDEBUG functions work as expected except that token values aren't printed; this patch simply enables output of token values when one sets YYDEBUG to 1; 731879 4 166222 webkit.review.bot 2012-10-01 12:09:16 -0700 Comment on attachment 166222 Patch Clearing flags on attachment: 166222 Committed r130063: <http://trac.webkit.org/changeset/130063> 731880 5 webkit.review.bot 2012-10-01 12:09:20 -0700 All reviewed patches have been landed. Closing bug. 731992 6 166222 darin 2012-10-01 14:31:23 -0700 Comment on attachment 166222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166222&action=review > Source/WebCore/css/CSSGrammar.y:1744 > + YYFPRINTF(yyoutput, "%s", ((String)yyvalue.string).utf8().data()); I suggest function-call-style casting rather than C-style casting. String(yyvalue.string).utf8().data(). 166222 2012-09-28 05:21:47 -0700 2012-10-01 14:31:23 -0700 Patch bug-97896-20120928202058.patch text/plain 1749 glenn U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQwMTFlOWRkY2NkNWFl ZDczYWRlYzcxNDE4OWFlN2EzNTg3YjM3Zi4uYTIwY2RjZGYxZDc0MjZjNjViOGQ1NGVhZTUyNzYy NzdhOTAwZDI0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTI4ICBHbGVu biBBZGFtcyAgPGdsZW5uQHNreW5hdi5jb20+CisKKyAgICAgICAgWVlERUJVRyBkb2Vzbid0IHBy aW50IHRva2VuIHZhbHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTc4OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBEZWZpbmUgWVlQUklOVCBtYWNybyB0byBwcmludCB0b2tlbiB2YWx1ZXMgd2hlbiBZ WURFQlVHIGlzIHNldC4KKworICAgICAgICBObyBuZXcgdGVzdHMuIEZvciBDU1MgbGV4ZXIvcGFy c2VyIGRlYnVnIHVzYWdlIG9ubHkuCisKKyAgICAgICAgKiBjc3MvQ1NTR3JhbW1hci55OgorICAg ICAgICBEZWZpbmUgWVlQUklOVCBtYWNybyB0byBvdXRwdXQgSURFTlQgYW5kIFNUUklORyB0eXBl ZCB0b2tlbnMuIE90aGVycyBjYW4gYmUgYWRkZWQKKyAgICAgICAgaW4gdGhlIGZ1dHVyZS4KKwog MjAxMi0wOS0yMyAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAg ICBBZGQgc3VnZ2VzdGlvblBpY2tlciB0byBDYWxlbmRhclBpY2tlcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueSBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NHcmFt bWFyLnkKaW5kZXggNTE2NzUzN2Y3MWI3ZTQ5ZTU4NGQ3OTgyZGM0NWMwNTVkODkzODUwOS4uNTgw NThlY2IzMmZlNzhlODc2YmY4OWE5OTIyNDgyOWJhY2Q1ZDc2NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTR3Jh bW1hci55CkBAIC04OCw2ICs4OCwxMSBAQCB1c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCiAl ewogCisjaWYgWVlERUJVRyA+IDAKKyNkZWZpbmUgWVlQUklOVChGaWxlLFR5cGUsVmFsdWUpIHBy aW50X3Rva2VuX3ZhbHVlKEZpbGUsVHlwZSxWYWx1ZSkKK3N0YXRpYyB2b2lkIHByaW50X3Rva2Vu X3ZhbHVlKEZJTEUgKiB5eW91dHB1dCwgaW50IHl5dHlwZSwgWVlTVFlQRSBjb25zdCAmeXl2YWx1 ZSk7CisjZW5kaWYKKwogc3RhdGljIGlubGluZSBpbnQgY3NzeXllcnJvcih2b2lkKiwgY29uc3Qg Y2hhciopCiB7CiAgICAgcmV0dXJuIDE7CkBAIC0xNzI5LDMgKzE3MzQsMTcgQEAgaW52YWxpZF9i bG9ja19saXN0OgogOwogCiAlJQorCisjaWYgWVlERUJVRyA+IDAKK3N0YXRpYyB2b2lkIHByaW50 X3Rva2VuX3ZhbHVlKEZJTEUgKiB5eW91dHB1dCwgaW50IHl5dHlwZSwgWVlTVFlQRSBjb25zdCAm eXl2YWx1ZSkKK3sKKyAgICBzd2l0Y2ggKHl5dHlwZSkgeworICAgIGNhc2UgSURFTlQ6CisgICAg Y2FzZSBTVFJJTkc6CisgICAgICAgIFlZRlBSSU5URih5eW91dHB1dCwgIiVzIiwgKChTdHJpbmcp eXl2YWx1ZS5zdHJpbmcpLnV0ZjgoKS5kYXRhKCkpOworICAgICAgICBicmVhazsKKyAgICBkZWZh dWx0OgorICAgICAgICBicmVhazsKKyAgICB9Cit9CisjZW5kaWYK