97882 2012-09-28 03:12:37 -0700 [EFL][WK2] exceededDatabaseQuota event is not handled 2012-09-28 03:39:42 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco ryuan.choi s.choi webkit.review.bot oldest_to_newest 730431 0 cdumez 2012-09-28 03:12:37 -0700 We currently don't handle the exceededDatabaseQuota callback from WKPageUIClient, causing WebDatabase requests to fail since 0 is currently used as database quota. We need to handle this callback and let the browser decide what to do. If the browser does not handle the event, then we should return a realistic default quota (5MB is recommended by the spec). 730433 1 166190 cdumez 2012-09-28 03:16:03 -0700 Created attachment 166190 Patch 730452 2 166190 webkit.review.bot 2012-09-28 03:39:38 -0700 Comment on attachment 166190 Patch Clearing flags on attachment: 166190 Committed r129871: <http://trac.webkit.org/changeset/129871> 730454 3 webkit.review.bot 2012-09-28 03:39:42 -0700 All reviewed patches have been landed. Closing bug. 166190 2012-09-28 03:16:03 -0700 2012-09-28 03:39:38 -0700 Patch 97882_database_quota.patch text/plain 6162 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNGQ1ZGZiLi44ZTJhZTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMDktMjggIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIGV4Y2VlZGVkRGF0YWJhc2VRdW90YSBldmVudCBp cyBub3QgaGFuZGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTc4ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBIYW5kbGUgZXhjZWVkZWREYXRhYmFzZVF1b3RhIGNhbGxiYWNrIGZyb20gV0tQYWdlVUlD bGllbnQgc28KKyAgICAgICAgdGhhdCB3ZSBsZXQgdGhlIGJyb3dzZXIgYSBjaGFuY2UgdG8gZGVj aWRlIHdoYXQgdG8gZG8gd2hlbgorICAgICAgICB0aGUgZGF0YWJhc2UgcXVvdGEgaXMgcmVhY2hl ZC4gSWYgdGhlIGJyb3dzZXIgZG9lcyBub3QgaGFuZGxlCisgICAgICAgIHRoaXMsIHRoZW4gd2Ug cmV0dXJuIGEgcmVhbGlzdGljIGRlZmF1bHQgcXVvdGEgKDVNQiBhcworICAgICAgICByZWNvbW1l bmRlZCBieSB0aGUgc3BlYykuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmll dy5jcHA6CisgICAgICAgIChld2tfdmlld19kYXRhYmFzZV9xdW90YV9leGNlZWRlZCk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlld19wcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXdfdWlfY2xpZW50LmNwcDoKKyAgICAgICAgKGV4Y2VlZGVkRGF0YWJhc2VRdW90YSk6 CisgICAgICAgIChld2tfdmlld191aV9jbGllbnRfYXR0YWNoKToKKwogMjAxMi0wOS0yNyAgQmV0 aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk3ODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggNTE3NWY3OS4uNDE5MDU2MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcApAQCAtMTI1NCw2ICsxMjU0 LDIyIEBAIHZvaWQgZXdrX3ZpZXdfZnVsbF9zY3JlZW5fZXhpdChFdmFzX09iamVjdCogZXdrVmll dykKIH0KICNlbmRpZgogCisjaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKKy8qKgorICogQGludGVy bmFsCisgKiBDYWxscyBleGNlZWRlZF9kYXRhYmFzZV9xdW90YSBjYWxsYmFjayBvciBmYWxscyBi YWNrIHRvIGRlZmF1bHQgYmVoYXZpb3IgcmV0dXJucyBkZWZhdWx0IGRhdGFiYXNlIHF1b3RhLgor ICovCit1bnNpZ25lZCBsb25nIGxvbmcgZXdrX3ZpZXdfZGF0YWJhc2VfcXVvdGFfZXhjZWVkZWQo RXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0IGNoYXIqIGRhdGFiYXNlTmFtZSwgY29uc3QgY2hh ciogZGlzcGxheU5hbWUsIHVuc2lnbmVkIGxvbmcgbG9uZyBjdXJyZW50UXVvdGEsIHVuc2lnbmVk IGxvbmcgbG9uZyBjdXJyZW50T3JpZ2luVXNhZ2UsIHVuc2lnbmVkIGxvbmcgbG9uZyBjdXJyZW50 RGF0YWJhc2VVc2FnZSwgdW5zaWduZWQgbG9uZyBsb25nIGV4cGVjdGVkVXNhZ2UpCit7CisgICAg RVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihld2tWaWV3LCBzbWFydERhdGEsIDApOworCisgICAg c3RhdGljIGNvbnN0IHVuc2lnbmVkIGxvbmcgbG9uZyBkZWZhdWx0UXVvdGEgPSA1ICogMTAyNCAq IDEyMDQ7IC8vIDUgTUIKKyAgICBpZiAoc21hcnREYXRhLT5hcGktPmV4Y2VlZGVkX2RhdGFiYXNl X3F1b3RhKQorICAgICAgICByZXR1cm4gc21hcnREYXRhLT5hcGktPmV4Y2VlZGVkX2RhdGFiYXNl X3F1b3RhKHNtYXJ0RGF0YSwgZGF0YWJhc2VOYW1lLCBkaXNwbGF5TmFtZSwgY3VycmVudFF1b3Rh LCBjdXJyZW50T3JpZ2luVXNhZ2UsIGN1cnJlbnREYXRhYmFzZVVzYWdlLCBleHBlY3RlZFVzYWdl KTsKKworICAgIHJldHVybiBkZWZhdWx0UXVvdGE7Cit9CisjZW5kaWYKIAogLyoqCiAgKiBAaW50 ZXJuYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192 aWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5oCmluZGV4 IGNjZmE2MzYuLmU5ODk1YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXcuaApAQCAtMTI3LDEzICsxMjcsMTcgQEAgc3RydWN0IF9Fd2tfVmlld19TbWFydF9D bGFzcyB7CiAgICAgLy8gICAtIFNob3dzIGFuZCBoaWRlcyBjb2xvciBwaWNrZXIuCiAgICAgRWlu YV9Cb29sICgqaW5wdXRfcGlja2VyX2NvbG9yX3JlcXVlc3QpKEV3a19WaWV3X1NtYXJ0X0RhdGEg KnNkLCBpbnQgciwgaW50IGcsIGludCBiLCBpbnQgYSk7CiAgICAgRWluYV9Cb29sICgqaW5wdXRf cGlja2VyX2NvbG9yX2Rpc21pc3MpKEV3a19WaWV3X1NtYXJ0X0RhdGEgKnNkKTsKKworICAgIC8v IHN0b3JhZ2U6CisgICAgLy8gICAtIFdlYiBkYXRhYmFzZS4KKyAgICB1bnNpZ25lZCBsb25nIGxv bmcgKCpleGNlZWRlZF9kYXRhYmFzZV9xdW90YSkoRXdrX1ZpZXdfU21hcnRfRGF0YSAqc2QsIGNv bnN0IGNoYXIgKmRhdGFiYXNlTmFtZSwgY29uc3QgY2hhciAqZGlzcGxheU5hbWUsIHVuc2lnbmVk IGxvbmcgbG9uZyBjdXJyZW50UXVvdGEsIHVuc2lnbmVkIGxvbmcgbG9uZyBjdXJyZW50T3JpZ2lu VXNhZ2UsIHVuc2lnbmVkIGxvbmcgbG9uZyBjdXJyZW50RGF0YWJhc2VVc2FnZSwgdW5zaWduZWQg bG9uZyBsb25nIGV4cGVjdGVkVXNhZ2UpOwogfTsKIAogLyoqCiAgKiBUaGUgdmVyc2lvbiB5b3Ug aGF2ZSB0byBwdXQgaW50byB0aGUgdmVyc2lvbiBmaWVsZAogICogaW4gdGhlIEBhIEV3a19WaWV3 X1NtYXJ0X0NsYXNzIHN0cnVjdHVyZS4KICAqLwotI2RlZmluZSBFV0tfVklFV19TTUFSVF9DTEFT U19WRVJTSU9OIDVVTAorI2RlZmluZSBFV0tfVklFV19TTUFSVF9DTEFTU19WRVJTSU9OIDZVTAog CiAvKioKICAqIEluaXRpYWxpemVyIGZvciB3aG9sZSBFd2tfVmlld19TbWFydF9DbGFzcyBzdHJ1 Y3R1cmUuCkBAIC0xNDUsNyArMTQ5LDcgQEAgc3RydWN0IF9Fd2tfVmlld19TbWFydF9DbGFzcyB7 CiAgKiBAc2VlIEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfVkVSU0lPTgogICogQHNlZSBFV0tf VklFV19TTUFSVF9DTEFTU19JTklUX05BTUVfVkVSU0lPTgogICovCi0jZGVmaW5lIEVXS19WSUVX X1NNQVJUX0NMQVNTX0lOSVQoc21hcnRfY2xhc3NfaW5pdCkge3NtYXJ0X2NsYXNzX2luaXQsIEVX S19WSUVXX1NNQVJUX0NMQVNTX1ZFUlNJT04sIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAs IDAsIDAsIDAsIDAsIDAsIDAsIDB9CisjZGVmaW5lIEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVQo c21hcnRfY2xhc3NfaW5pdCkge3NtYXJ0X2NsYXNzX2luaXQsIEVXS19WSUVXX1NNQVJUX0NMQVNT X1ZFUlNJT04sIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAsIDAs IDAsIDB9CiAKIC8qKgogICogSW5pdGlhbGl6ZXIgdG8gemVybyBhIHdob2xlIEV3a19WaWV3X1Nt YXJ0X0NsYXNzIHN0cnVjdHVyZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3X3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3X3ByaXZhdGUuaAppbmRleCA0Y2JhMjJkLi4yZmU4YmFkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld19wcml2YXRlLmgK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfcHJpdmF0ZS5o CkBAIC0xMTQsNCArMTE0LDggQEAgdm9pZCBld2tfdmlld19jb2xvcl9waWNrZXJfcmVxdWVzdChF dmFzX09iamVjdCogZXdrVmlldywgaW50IHIsIGludCBnLCBpbnQgYiwgaW4KIHZvaWQgZXdrX3Zp ZXdfY29sb3JfcGlja2VyX2Rpc21pc3MoRXZhc19PYmplY3QqIGV3a1ZpZXcpOwogI2VuZGlmCiAK KyNpZiBFTkFCTEUoU1FMX0RBVEFCQVNFKQordW5zaWduZWQgbG9uZyBsb25nIGV3a192aWV3X2Rh dGFiYXNlX3F1b3RhX2V4Y2VlZGVkKEV2YXNfT2JqZWN0KiBld2tWaWV3LCBjb25zdCBjaGFyKiBk YXRhYmFzZU5hbWUsIGNvbnN0IGNoYXIqIGRpc3BsYXlOYW1lLCB1bnNpZ25lZCBsb25nIGxvbmcg Y3VycmVudFF1b3RhLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudE9yaWdpblVzYWdlLCB1bnNp Z25lZCBsb25nIGxvbmcgY3VycmVudERhdGFiYXNlVXNhZ2UsIHVuc2lnbmVkIGxvbmcgbG9uZyBl eHBlY3RlZFVzYWdlKTsKKyNlbmRpZgorCiAjZW5kaWYgLy8gZXdrX3ZpZXdfcHJpdmF0ZV9oCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9j bGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXdfdWlf Y2xpZW50LmNwcAppbmRleCA2YmJmODk1Li5mM2JmY2Q4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld191aV9jbGllbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3VpX2NsaWVudC5jcHAKQEAgLTcz LDYgKzczLDEzIEBAIHN0YXRpYyB2b2lkIGhpZGVDb2xvclBpY2tlcihXS1BhZ2VSZWYsIGNvbnN0 IHZvaWQqIGNsaWVudEluZm8pCiB9CiAjZW5kaWYKIAorI2lmIEVOQUJMRShTUUxfREFUQUJBU0Up CitzdGF0aWMgdW5zaWduZWQgbG9uZyBsb25nIGV4Y2VlZGVkRGF0YWJhc2VRdW90YShXS1BhZ2VS ZWYsIFdLRnJhbWVSZWYsIFdLU2VjdXJpdHlPcmlnaW5SZWYgb3JpZ2luLCBXS1N0cmluZ1JlZiBk YXRhYmFzZU5hbWUsIFdLU3RyaW5nUmVmIGRpc3BsYXlOYW1lLCB1bnNpZ25lZCBsb25nIGxvbmcg Y3VycmVudFF1b3RhLCB1bnNpZ25lZCBsb25nIGxvbmcgY3VycmVudE9yaWdpblVzYWdlLCB1bnNp Z25lZCBsb25nIGxvbmcgY3VycmVudERhdGFiYXNlVXNhZ2UsIHVuc2lnbmVkIGxvbmcgbG9uZyBl eHBlY3RlZFVzYWdlLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKQoreworICAgIHJldHVybiBld2tf dmlld19kYXRhYmFzZV9xdW90YV9leGNlZWRlZCh0b0V3a1ZpZXcoY2xpZW50SW5mbyksIFdLRWlu YVNoYXJlZFN0cmluZyhkYXRhYmFzZU5hbWUpLCBXS0VpbmFTaGFyZWRTdHJpbmcoZGlzcGxheU5h bWUpLCBjdXJyZW50UXVvdGEsIGN1cnJlbnRPcmlnaW5Vc2FnZSwgY3VycmVudERhdGFiYXNlVXNh Z2UsIGV4cGVjdGVkVXNhZ2UpOworfQorI2VuZGlmCisKIHZvaWQgZXdrX3ZpZXdfdWlfY2xpZW50 X2F0dGFjaChXS1BhZ2VSZWYgcGFnZVJlZiwgRXZhc19PYmplY3QqIGV3a1ZpZXcpCiB7CiAgICAg V0tQYWdlVUlDbGllbnQgdWlDbGllbnQ7CkBAIC04NCw2ICs5MSw5IEBAIHZvaWQgZXdrX3ZpZXdf dWlfY2xpZW50X2F0dGFjaChXS1BhZ2VSZWYgcGFnZVJlZiwgRXZhc19PYmplY3QqIGV3a1ZpZXcp CiAgICAgdWlDbGllbnQucnVuSmF2YVNjcmlwdEFsZXJ0ID0gcnVuSmF2YVNjcmlwdEFsZXJ0Owog ICAgIHVpQ2xpZW50LnJ1bkphdmFTY3JpcHRDb25maXJtID0gcnVuSmF2YVNjcmlwdENvbmZpcm07 CiAgICAgdWlDbGllbnQucnVuSmF2YVNjcmlwdFByb21wdCA9IHJ1bkphdmFTY3JpcHRQcm9tcHQ7 CisjaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKKyAgICB1aUNsaWVudC5leGNlZWRlZERhdGFiYXNl UXVvdGEgPSBleGNlZWRlZERhdGFiYXNlUXVvdGE7CisjZW5kaWYKIAogI2lmIEVOQUJMRShJTlBV VF9UWVBFX0NPTE9SKQogICAgIHVpQ2xpZW50LnNob3dDb2xvclBpY2tlciA9IHNob3dDb2xvclBp Y2tlcjsK