97878 2012-09-28 02:51:30 -0700 [Forms] Add localized strings for multiple fields date/time input UI 2012-09-28 03:59:17 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin abarth dglazkov fishd jamesr keishi tkent tkent+wkapi webkit.review.bot oldest_to_newest 730418 0 yosin 2012-09-28 02:51:30 -0700 We need to have following localization strings: - "This month" button label for month picker - "This week" button label for week picker - "Other month" label in suggestion popup list - "Other time" label in suggestion popup list - "Other week" label in suggestion popup list 730424 1 166188 yosin 2012-09-28 03:05:55 -0700 Created attachment 166188 Patch 1 730426 2 166188 yosin 2012-09-28 03:06:23 -0700 Comment on attachment 166188 Patch 1 Could you review this patch? Thanks in advance. 730427 3 webkit.review.bot 2012-09-28 03:08:02 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 730436 4 166188 tkent 2012-09-28 03:18:22 -0700 Comment on attachment 166188 Patch 1 ok 730438 5 yosin 2012-09-28 03:19:32 -0700 See http://crbug.com/152632 for Chromium side changes. 730463 6 166188 yosin 2012-09-28 03:59:12 -0700 Comment on attachment 166188 Patch 1 Clearing flags on attachment: 166188 Committed r129873: <http://trac.webkit.org/changeset/129873> 730464 7 yosin 2012-09-28 03:59:17 -0700 All reviewed patches have been landed. Closing bug. 166188 2012-09-28 03:05:55 -0700 2012-09-28 03:59:12 -0700 Patch 1 bug-97878-20120928190511.patch text/plain 2140 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAyNjI5ODcwOWNjMzY3 NDExM2E5YzNmNWE4M2YyNzEzN2YzYTJhYTFhLi4xZmZhNzM3ODI1ZTcyNDcyMjdmM2ZhMTAyMjY1 MTdmZjI3ZGU0MjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0wOS0yOCAg WW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtGb3Jtc10g QWRkIGxvY2FsaXplZCBzdHJpbmdzIGZvciBtdWx0aXBsZSBmaWVsZHMgZGF0ZS90aW1lIGlucHV0 IFVJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Nzg3 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg cGF0Y2ggaW50cm9kdWNlcyBmb2xsb3dpbmcgbG9jYWxpemVkIHN0cmluZyBpZGVudGlmaWVyIGZv cgorICAgICAgICBtb250aCwgdGltZSBhbmQgd2VlayBwaWNrZXJzOgorICAgICAgICAgICAgLSBP dGhlck1vbnRoTGFiZWwgLSBhcHBlYXJlZCBhdCB0aGUgbGFzdCBlbnRyeSBpbiBzdWdnZXN0aW9u IGxpc3QuCisgICAgICAgICAgICAtIE90aGVyVGltZUxhYmVsIC0gZGl0dG8KKyAgICAgICAgICAg IC0gT3RoZXJXZWVrTGFiZWwgLSBkaXR0bworICAgICAgICAgICAgLSBUaGlzTW9udGhCdXR0b25M YWJlbCAtIHVzZWQgaW4gbW9udGggcGlja2VyCisgICAgICAgICAgICAtIFRoaXNXZWVrQnV0dG9u TGFiZWwgLSB1c2VkIGluIHdlZWsgcGlja2VyCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMv V2ViTG9jYWxpemVkU3RyaW5nLmg6IEFkZGVkIE90aGVyTW9udGhMYWJlbCwgT3RoZXJUaW1lTGFi ZWwsIE90aGVyV2Vla0xhYmVsLCBUaGlNb250aGtCdXR0b25MYWJlbCwgYW5kIFRoaXNXZWVrQnV0 dG9uTGFiZWwuCisKIDIwMTItMDktMjcgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gUmVtb3ZlIHNjcmVlbi1yZWxhdGVkIGZ1bmN0aW9u cyBmcm9tIFBsYXRmb3JtU3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJMb2NhbGl6ZWRTdHJpbmcuaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1 bS9wdWJsaWMvV2ViTG9jYWxpemVkU3RyaW5nLmgKaW5kZXggODAxN2JkOTI0NzdjNmRkNzA4YmQ2 YzM4NDMxZWMzZDgzOTVhZGZiMi4uMjA2MTI0NzZjODY4M2MxODc0MjBlZjkwZjhjOGU5NDUwNWU2 NGZkYSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMb2Nh bGl6ZWRTdHJpbmcuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxv Y2FsaXplZFN0cmluZy5oCkBAIC03Myw2ICs3Myw5IEBAIHN0cnVjdCBXZWJMb2NhbGl6ZWRTdHJp bmcgewogICAgICAgICBNdWx0aXBsZUZpbGVVcGxvYWRUZXh0LAogICAgICAgICBPdGhlckNvbG9y TGFiZWwsCiAgICAgICAgIE90aGVyRGF0ZUxhYmVsLAorICAgICAgICBPdGhlck1vbnRoTGFiZWws CisgICAgICAgIE90aGVyVGltZUxhYmVsLAorICAgICAgICBPdGhlcldlZWtMYWJlbCwKICAgICAg ICAgUGxhY2Vob2xkZXJGb3JEYXlPZk1vbnRoRmllbGQsCiAgICAgICAgIFBsYWNlaG9sZGVyRm9y TW9udGhGaWVsZCwKICAgICAgICAgUGxhY2Vob2xkZXJGb3JZZWFyRmllbGQsCkBAIC04Miw2ICs4 NSw4IEBAIHN0cnVjdCBXZWJMb2NhbGl6ZWRTdHJpbmcgewogICAgICAgICBTZWFyY2hNZW51Tm9S ZWNlbnRTZWFyY2hlc1RleHQsCiAgICAgICAgIFNlYXJjaE1lbnVSZWNlbnRTZWFyY2hlc1RleHQs CiAgICAgICAgIFN1Ym1pdEJ1dHRvbkRlZmF1bHRMYWJlbCwKKyAgICAgICAgVGhpc01vbnRoQnV0 dG9uTGFiZWwsCisgICAgICAgIFRoaXNXZWVrQnV0dG9uTGFiZWwsCiAgICAgICAgIFZhbGlkYXRp b25QYXR0ZXJuTWlzbWF0Y2gsCiAgICAgICAgIFZhbGlkYXRpb25SYW5nZU92ZXJmbG93LAogICAg ICAgICBWYWxpZGF0aW9uUmFuZ2VVbmRlcmZsb3csCg==