97863 2012-09-27 22:33:46 -0700 [Forms] Adding placeholder feature to DateTimeNumericElement, and update its existing subclasses. 2012-09-27 23:17:58 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97299 1 yosin yosin tkent oldest_to_newest 730249 0 yosin 2012-09-27 22:33:46 -0700 To display date format guide in multiple fields date/time UI, we would like to have placeholder feature in DateTimeNumbericElement and derived classes. 730257 1 166145 yosin 2012-09-27 22:57:17 -0700 Created attachment 166145 Patch 1 730258 2 166145 yosin 2012-09-27 22:57:59 -0700 Comment on attachment 166145 Patch 1 Could you review this patch? Thanks in advance. 730260 3 166145 tkent 2012-09-27 23:00:53 -0700 Comment on attachment 166145 Patch 1 ok 730275 4 166145 yosin 2012-09-27 23:17:55 -0700 Comment on attachment 166145 Patch 1 Clearing flags on attachment: 166145 Committed r129854: <http://trac.webkit.org/changeset/129854> 730276 5 yosin 2012-09-27 23:17:58 -0700 All reviewed patches have been landed. Closing bug. 166145 2012-09-27 22:57:17 -0700 2012-09-27 23:17:54 -0700 Patch 1 bug-97863-20120928145634.patch text/plain 6956 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZmODc5NjI4YmQyMTky NGU3ZDNjZWVkYWFhNGNhMGI3MjU3OTA3Yy4uMTkzNzFmM2Y2NmI3NmRhOTkxOWIxZTM2NWMwZWYy ZGExY2FiYzYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA5LTI3ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBBZGRp bmcgcGxhY2Vob2xkZXIgZmVhdHVyZSB0byBEYXRlVGltZU51bWVyaWNFbGVtZW50LCBhbmQgdXBk YXRlIGl0cyBleGlzdGluZyBzdWJjbGFzc2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGlzIGEgcGFydCBvZiBwcmVwYXJhdGlvbiBv ZiBpbXBsZW1lbnRpbmcgbXVsdGlwbGUgZmllbGRzCisgICAgICAgIGRhdGUvdGltZSBpbnB1dCBV SS4KKworICAgICAgICBUaGlzIHBhdGNoIGludHJvZHVjZXMgcGxhY2Vob2xkZXIgZmVhdHVyZSB0 byBEYXRlVGltZU51bWVyaWNFbGVtZW50CisgICAgICAgIHRvIGRpc3BsYXkgZGF0ZSBmb3JtYXQg Z3VpZGUgaW4gZmllbGQsIGUuZy4gZGlzcGxheWluZyAiZGQvbW0veXl5eSIuCisKKyAgICAgICAg Tm90ZTogVGhpcyBwYXRjaCBhZmZlY3RzIHBvcnRzIHdoaWNoIGVuYWJsZSBib3RoIEVOQUJMRV9J TlBVVF9UWVBFX1RJTUUgYW5kCisgICAgICAgIEVOQUJMRV9JTlBVVF9NVUxUSVBMRV9GSUVMRFNf VUkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIGJl aGF2aW9yLgorCisgICAgICAgICogaHRtbC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVsZW1lbnRzLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVUaW1lSG91ckZpZWxkRWxlbWVudDo6RGF0ZVRpbWVI b3VyRmllbGRFbGVtZW50KTogQ2hhbmdlZCB0byBwYXNzIHBsYWNlaG9sZGVyIGNsYXNzIHRvIGJh c2UgY2xhc3MuCisgICAgICAgIChXZWJDb3JlOjpEYXRlVGltZU1pbGxpc2Vjb25kRmllbGRFbGVt ZW50OjpEYXRlVGltZU1pbGxpc2Vjb25kRmllbGRFbGVtZW50KTogZGl0dG8KKyAgICAgICAgKFdl YkNvcmU6OkRhdGVUaW1lTWludXRlRmllbGRFbGVtZW50OjpEYXRlVGltZU1pbnV0ZUZpZWxkRWxl bWVudCk6IGRpdHRvCisgICAgICAgIChXZWJDb3JlOjpEYXRlVGltZVNlY29uZEZpZWxkRWxlbWVu dDo6RGF0ZVRpbWVTZWNvbmRGaWVsZEVsZW1lbnQpOiBkaXR0bworICAgICAgICAqIGh0bWwvc2hh ZG93L0RhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudC5jcHA6IFJlbW92ZWQgbm8gbW9yZSBuZWVk ZWQgc3RhdGljIGZ1bmN0aW9uIGRpc3BsYXlTaXplT2ZOdW1icmUoKS4KKyAgICAgICAgKFdlYkNv cmU6OkRhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudDo6RGF0ZVRpbWVOdW1lcmljRmllbGRFbGVt ZW50KTogQ2hhbmdlZCB0byBhZGQgbmV3IHBhcmFtZXRlciB0byB0YWtlIHBsYWNlaG9sZGVyLgor ICAgICAgICAoV2ViQ29yZTo6RGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50Ojp2aXNpYmxlVmFs dWUpOiBDaGFuZ2VkIHRvIHVzZSBtX3BsYWNob2xkZXIuCisgICAgICAgICogaHRtbC9zaGFkb3cv RGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50Lmg6CisgICAgICAgIChEYXRlVGltZU51bWVyaWNG aWVsZEVsZW1lbnQpOiBDaGFuZ2VkIHRvIGFkZCBhIG1lbWJlciB2YXJpYWJsZSBtX3BsYWNob2xk ZXIgdG8gaG9sZCBwbGFjaG9sZGVyIHRvIERhdGVUaW1lTnVtYmVyaWNFbGVtZW50IGNsYXNzLgor CiAyMDEyLTA5LTI3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBNYWtlIHN1cmUgTG9jYWxpemVyIGNsYXNzIGlzIG5vdCBjb3B5YWJsZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVsZW1lbnRzLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0RhdGVUaW1lRmllbGRFbGVtZW50cy5jcHAKaW5kZXgg YTFmYzg3YTNjNmQ0NWNmNjMwMDMzOWRkYWMxZmUwMWE0MDJiNGQwMy4uNGE3OWViOTIyOWFmZWQ3 NGYyYWYyNzdmYmEzMzI2ZDUxM2E4YzVmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9zaGFkb3cvRGF0ZVRpbWVGaWVsZEVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL3NoYWRvdy9EYXRlVGltZUZpZWxkRWxlbWVudHMuY3BwCkBAIC03MCw3ICs3MCw3IEBAIHZv aWQgRGF0ZVRpbWVBTVBNRmllbGRFbGVtZW50OjpzZXRWYWx1ZUFzRGF0ZVRpbWVGaWVsZHNTdGF0 ZShjb25zdCBEYXRlVGltZUZpZWxkCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAK IERhdGVUaW1lSG91ckZpZWxkRWxlbWVudDo6RGF0ZVRpbWVIb3VyRmllbGRFbGVtZW50KERvY3Vt ZW50KiBkb2N1bWVudCwgRmllbGRPd25lciYgZmllbGRPd25lciwgaW50IG1pbmltdW0sIGludCBt YXhpbXVtKQotICAgIDogRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50KGRvY3VtZW50LCBmaWVs ZE93bmVyLCBtaW5pbXVtLCBtYXhpbXVtKQorICAgIDogRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVt ZW50KGRvY3VtZW50LCBmaWVsZE93bmVyLCBtaW5pbXVtLCBtYXhpbXVtLCAiLS0iKQogICAgICwg bV9hbGlnbm1lbnQobWF4aW11bSArIG1heGltdW0gJSAyKQogewogICAgIEFTU0VSVCgoIW1pbmlt dW0gJiYgKG1heGltdW0gPT0gMTEgfHwgbWF4aW11bSA9PSAyMykpIHx8IChtaW5pbXVtID09IDEg JiYgKG1heGltdW0gPT0gMTIgfHwgbWF4aW11bSA9PSAyNCkpKTsKQEAgLTE3NSw3ICsxNzUsNyBA QCBpbnQgRGF0ZVRpbWVIb3VyRmllbGRFbGVtZW50Ojp2YWx1ZUFzSW50ZWdlcigpIGNvbnN0CiAv LyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKIERhdGVUaW1lTWlsbGlzZWNvbmRGaWVs ZEVsZW1lbnQ6OkRhdGVUaW1lTWlsbGlzZWNvbmRGaWVsZEVsZW1lbnQoRG9jdW1lbnQqIGRvY3Vt ZW50LCBGaWVsZE93bmVyJiBmaWVsZE93bmVyKQotICAgIDogRGF0ZVRpbWVOdW1lcmljRmllbGRF bGVtZW50KGRvY3VtZW50LCBmaWVsZE93bmVyLCAwLCA5OTkpCisgICAgOiBEYXRlVGltZU51bWVy aWNGaWVsZEVsZW1lbnQoZG9jdW1lbnQsIGZpZWxkT3duZXIsIDAsIDk5OSwgIi0tLSIpCiB7CiB9 CiAKQEAgLTIxNiw3ICsyMTYsNyBAQCB2b2lkIERhdGVUaW1lTWlsbGlzZWNvbmRGaWVsZEVsZW1l bnQ6OnNldFZhbHVlQXNEYXRlVGltZUZpZWxkc1N0YXRlKGNvbnN0IERhdGVUaQogLy8gLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiBEYXRlVGltZU1pbnV0ZUZpZWxkRWxlbWVudDo6RGF0 ZVRpbWVNaW51dGVGaWVsZEVsZW1lbnQoRG9jdW1lbnQqIGRvY3VtZW50LCBGaWVsZE93bmVyJiBm aWVsZE93bmVyKQotICAgIDogRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50KGRvY3VtZW50LCBm aWVsZE93bmVyLCAwLCA1OSkKKyAgICA6IERhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudChkb2N1 bWVudCwgZmllbGRPd25lciwgMCwgNTksICItLSIpCiB7CiB9CiAKQEAgLTI1Nyw3ICsyNTcsNyBA QCB2b2lkIERhdGVUaW1lTWludXRlRmllbGRFbGVtZW50OjpzZXRWYWx1ZUFzRGF0ZVRpbWVGaWVs ZHNTdGF0ZShjb25zdCBEYXRlVGltZUZpZQogLy8gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogCiBEYXRlVGltZVNlY29uZEZpZWxkRWxlbWVudDo6RGF0ZVRpbWVTZWNvbmRGaWVsZEVsZW1l bnQoRG9jdW1lbnQqIGRvY3VtZW50LCBGaWVsZE93bmVyJiBmaWVsZE93bmVyKQotICAgIDogRGF0 ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50KGRvY3VtZW50LCBmaWVsZE93bmVyLCAwLCA1OSkKKyAg ICA6IERhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudChkb2N1bWVudCwgZmllbGRPd25lciwgMCwg NTksICItLSIpCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93 L0RhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3No YWRvdy9EYXRlVGltZU51bWVyaWNGaWVsZEVsZW1lbnQuY3BwCmluZGV4IDZkNzA3MjU1YzNlZTNk NjY0NDMwMWJiM2Q1ZWU1Yjc5OGExYzUwYzYuLjIyMjhjZmE0MzlhNmYwOTU0MDg3YmNhMDBiZGYx NWY1ZWU5YzIwZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L0RhdGVU aW1lTnVtZXJpY0ZpZWxkRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFk b3cvRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50LmNwcApAQCAtMzUsMjIgKzM1LDYgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0aWMgY29uc3QgRE9NVGltZVN0YW1wIHR5cGVBaGVhZFRp bWVvdXQgPSAxMDAwOwogCi1zdGF0aWMgc2l6ZV90IGRpc3BsYXlTaXplT2ZOdW1iZXIoaW50IHZh bHVlKQotewotICAgIEFTU0VSVCh2YWx1ZSA+PSAwKTsKLQotICAgIGlmICghdmFsdWUpCi0gICAg ICAgIHJldHVybiAxOwotCi0gICAgaW50IG51bWJlck9mRGlnaXRzID0gMDsKLSAgICB3aGlsZSAo dmFsdWUpIHsKLSAgICAgICAgdmFsdWUgLz0gMTA7Ci0gICAgICAgICsrbnVtYmVyT2ZEaWdpdHM7 Ci0gICAgfQotCi0gICAgcmV0dXJuIG51bWJlck9mRGlnaXRzOwotfQotCiBEYXRlVGltZU51bWVy aWNGaWVsZEVsZW1lbnQ6OlJhbmdlOjpSYW5nZShpbnQgbWluaW11bSwgaW50IG1heGltdW0pCiAg ICAgOiBtYXhpbXVtKG1heGltdW0pCiAgICAgLCBtaW5pbXVtKG1pbmltdW0pCkBAIC02Myw5ICs0 NywxMCBAQCBpbnQgRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50OjpSYW5nZTo6Y2xhbXBWYWx1 ZShpbnQgdmFsdWUpIGNvbnN0CiAgICAgcmV0dXJuIHN0ZDo6bWluKHN0ZDo6bWF4KHZhbHVlLCBt aW5pbXVtKSwgbWF4aW11bSk7CiB9CiAKLURhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudDo6RGF0 ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50KERvY3VtZW50KiBkb2N1bWVudCwgRmllbGRPd25lciYg ZmllbGRPd25lciwgaW50IG1pbmltdW0sIGludCBtYXhpbXVtKQorRGF0ZVRpbWVOdW1lcmljRmll bGRFbGVtZW50OjpEYXRlVGltZU51bWVyaWNGaWVsZEVsZW1lbnQoRG9jdW1lbnQqIGRvY3VtZW50 LCBGaWVsZE93bmVyJiBmaWVsZE93bmVyLCBpbnQgbWluaW11bSwgaW50IG1heGltdW0sIGNvbnN0 IFN0cmluZyYgcGxhY2Vob2xkZXIpCiAgICAgOiBEYXRlVGltZUZpZWxkRWxlbWVudChkb2N1bWVu dCwgZmllbGRPd25lcikKICAgICAsIG1fbGFzdERpZ2l0Q2hhclRpbWUoMCkKKyAgICAsIG1fcGxh Y2Vob2xkZXIocGxhY2Vob2xkZXIpCiAgICAgLCBtX3JhbmdlKG1pbmltdW0sIG1heGltdW0pCiAg ICAgLCBtX3ZhbHVlKDApCiAgICAgLCBtX2hhc1ZhbHVlKGZhbHNlKQpAQCAtMTg2LDEzICsxNzEs NyBAQCBpbnQgRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50Ojp2YWx1ZUFzSW50ZWdlcigpIGNv bnN0CiAKIFN0cmluZyBEYXRlVGltZU51bWVyaWNGaWVsZEVsZW1lbnQ6OnZpc2libGVWYWx1ZSgp IGNvbnN0CiB7Ci0gICAgaWYgKG1faGFzVmFsdWUpCi0gICAgICAgIHJldHVybiB2YWx1ZSgpOwot Ci0gICAgU3RyaW5nQnVpbGRlciBidWlsZGVyOwotICAgIGZvciAoaW50IG51bWJlck9mRGFzaHMg PSBzdGQ6Om1heChkaXNwbGF5U2l6ZU9mTnVtYmVyKG1fcmFuZ2UubWF4aW11bSksIGRpc3BsYXlT aXplT2ZOdW1iZXIobV9yYW5nZS5taW5pbXVtKSk7IG51bWJlck9mRGFzaHM7IC0tbnVtYmVyT2ZE YXNocykKLSAgICAgICAgYnVpbGRlci5hcHBlbmQoJy0nKTsKLSAgICByZXR1cm4gYnVpbGRlci50 b1N0cmluZygpOworICAgIHJldHVybiBtX2hhc1ZhbHVlID8gdmFsdWUoKSA6IG1fcGxhY2Vob2xk ZXI7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvc2hhZG93L0RhdGVUaW1lTnVtZXJpY0ZpZWxkRWxlbWVudC5oIGIvU291cmNlL1dl YkNvcmUvaHRtbC9zaGFkb3cvRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50LmgKaW5kZXggY2Ix ZDAyMmY2Y2ExYzk3NjFiMjFmODQ1ZGY0ZjliZjU4ZWI0MmJlMC4uNDBiNjI4Y2ZhYmY5MjZjYmY0 MjNmMWRmMzdlZjE0NGY1OGVmZTE2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9z aGFkb3cvRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUv aHRtbC9zaGFkb3cvRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50LmgKQEAgLTUwLDcgKzUwLDcg QEAgcHJvdGVjdGVkOgogICAgICAgICBpbnQgbWluaW11bTsKICAgICB9OwogCi0gICAgRGF0ZVRp bWVOdW1lcmljRmllbGRFbGVtZW50KERvY3VtZW50KiwgRmllbGRPd25lciYsIGludCBtaW5pbXVt LCBpbnQgbWF4aW11bSk7CisgICAgRGF0ZVRpbWVOdW1lcmljRmllbGRFbGVtZW50KERvY3VtZW50 KiwgRmllbGRPd25lciYsIGludCBtaW5pbXVtLCBpbnQgbWF4aW11bSwgY29uc3QgU3RyaW5nJiBw bGFjZWhvbGRlcik7CiAKICAgICBpbnQgY2xhbXBWYWx1ZShpbnQgdmFsdWUpIGNvbnN0IHsgcmV0 dXJuIG1fcmFuZ2UuY2xhbXBWYWx1ZSh2YWx1ZSk7IH0KICAgICBjb25zdCBSYW5nZSYgcmFuZ2Uo KSBjb25zdCB7IHJldHVybiBtX3JhbmdlOyB9CkBAIC03NSw2ICs3NSw3IEBAIHByaXZhdGU6CiAg ICAgTG9jYWxpemVyJiBsb2NhbGl6ZXIoKSBjb25zdDsKIAogICAgIERPTVRpbWVTdGFtcCBtX2xh c3REaWdpdENoYXJUaW1lOworICAgIGNvbnN0IFN0cmluZyBtX3BsYWNlaG9sZGVyOwogICAgIGNv bnN0IFJhbmdlIG1fcmFuZ2U7CiAgICAgaW50IG1fdmFsdWU7CiAgICAgYm9vbCBtX2hhc1ZhbHVl Owo=