97821 2012-09-27 13:56:26 -0700 [GTK] Enable CSS Shaders layout LayoutTests on GTK+ 2012-09-28 06:49:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dongseong.hwang webkit-unassigned mrobinson webkit.review.bot oldest_to_newest 729832 0 dongseong.hwang 2012-09-27 13:56:26 -0700 Enable CSS Shaders layout LayoutTests on GTK+ 729841 1 166061 dongseong.hwang 2012-09-27 14:03:33 -0700 Created attachment 166061 Patch 729843 2 dongseong.hwang 2012-09-27 14:05:21 -0700 All custom filter layout tests pass in WebKit1: css3/filters/custom One test fails in WebKit2: css3/filters/custom/filter-fallback-to-software.html 729847 3 166061 mrobinson 2012-09-27 14:09:58 -0700 Comment on attachment 166061 Patch Perhaps this patch could also unskip the tests? 730364 4 dongseong.hwang 2012-09-28 01:56:13 -0700 (In reply to comment #3) > (From update of attachment 166061 [details]) > Perhaps this patch could also unskip the tests? GTK skipped css3/filters, so I hesitated to unskip css3/filters/custom. Could I unskip css3/filters/custom although css3/filters are skipped? In addition, Nvidia machine can not run the layout tests using GraphicsContext3D because of Xvfb issues. 730603 5 mrobinson 2012-09-28 06:43:56 -0700 Makes sense! 730614 6 166061 webkit.review.bot 2012-09-28 06:49:30 -0700 Comment on attachment 166061 Patch Clearing flags on attachment: 166061 Committed r129888: <http://trac.webkit.org/changeset/129888> 730615 7 webkit.review.bot 2012-09-28 06:49:33 -0700 All reviewed patches have been landed. Closing bug. 166061 2012-09-27 14:03:33 -0700 2012-09-28 06:49:30 -0700 Patch bug-97821-20120928060241.patch text/plain 5225 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggOGViNjdhYmNj ZTBkZmM0YzBiM2VmNTc5MjI0ZTNlNTYxNDE0NTE4YS4uMzVmMjEzMmE3YmJlMjBiOTY1ZTNhOWY3 YmM4N2ZkZGVjZDdmZjA2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEy LTA5LTI3ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAg ICAgIFtHVEtdIEVuYWJsZSBDU1MgU2hhZGVycyBsYXlvdXQgTGF5b3V0VGVzdHMgb24gR1RLKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc4MjEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVT dXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHA6CisgICAgICAgIChEdW1wUmVuZGVy VHJlZVN1cHBvcnRHdGs6OnNldENTU0N1c3RvbUZpbHRlckVuYWJsZWQpOiBQYXNzIHRocm91Z2gg dG8gU2V0dGluZ3Mgb2JqZWN0LgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJU cmVlU3VwcG9ydEd0ay5oOgorICAgICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrKToKKwog MjAxMi0wOS0yNiAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeCBhZnRlciAxMjk3MDcuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3Bw IGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0 R3RrLmNwcAppbmRleCBiYTUwNTM0NTJmZWYzZjhjMmVmNzUxZTRlMjEwYWQzODE4NDU1MDQyLi4w MjIzMTBlNTZkNTdjNjg0MTcyY2NiMzA3NjViNjY5ZDQxMTVjNTUyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3Vw cG9ydEd0ay5jcHAKQEAgLTY5MSw2ICs2OTEsMTMgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBv cnRHdGs6OnNldENTU1JlZ2lvbnNFbmFibGVkKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIGJvb2wK ICAgICBjb3JlKHdlYlZpZXcpLT5zZXR0aW5ncygpLT5zZXRDU1NSZWdpb25zRW5hYmxlZChlbmFi bGVkKTsKIH0KIAordm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNldENTU0N1c3RvbUZp bHRlckVuYWJsZWQoV2ViS2l0V2ViVmlldyogd2ViVmlldywgYm9vbCBlbmFibGVkKQoreworI2lm IEVOQUJMRShDU1NfU0hBREVSUykKKyAgICBjb3JlKHdlYlZpZXcpLT5zZXR0aW5ncygpLT5zZXRD U1NDdXN0b21GaWx0ZXJFbmFibGVkKGVuYWJsZWQpOworI2VuZGlmCit9CisKIHZvaWQgRHVtcFJl bmRlclRyZWVTdXBwb3J0R3RrOjpzZXRTaGFkb3dET01FbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsK ICNpZiBFTkFCTEUoU0hBRE9XX0RPTSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oIGIvU291cmNlL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKaW5kZXggM2Y3MDg3 Y2Q0MDVmZTdkZTRkOTUzZjFiN2E3ZDhkYmFiN2I0NzcyZS4uZDE0MmJkOWMxOGRhZTU2OGE5MGM0 MjJjOTRmZTdjNDAyOGY1YjI3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvV2ViQ29y ZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKKysrIGIvU291cmNlL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmgKQEAgLTExOCw2ICsx MTgsNyBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgc2V0UGFnZUNhY2hlU3VwcG9ydHNQbHVn aW5zKFdlYktpdFdlYlZpZXcqLCBib29sIGVuYWJsZWQpOwogICAgIHN0YXRpYyB2b2lkIHNldENT U0dyaWRMYXlvdXRFbmFibGVkKFdlYktpdFdlYlZpZXcqLCBib29sIGVuYWJsZWQpOwogICAgIHN0 YXRpYyB2b2lkIHNldENTU1JlZ2lvbnNFbmFibGVkKFdlYktpdFdlYlZpZXcqLCBib29sIGVuYWJs ZWQpOworICAgIHN0YXRpYyB2b2lkIHNldENTU0N1c3RvbUZpbHRlckVuYWJsZWQoV2ViS2l0V2Vi VmlldyosIGJvb2wgZW5hYmxlZCk7CiAgICAgc3RhdGljIHZvaWQgc2V0U2hhZG93RE9NRW5hYmxl ZChib29sKTsKICAgICBzdGF0aWMgdm9pZCBzZXRTdHlsZVNjb3BlZEVuYWJsZWQoYm9vbCk7CiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyZWMz ZTQ3NjY3OTNhNDlhYzNmZTI3NGZhOGFhMzE5ZGE4ZTY3YTNiLi5kY2Y5MGJkMTFlODdlMjMyNWI0 MzUxZDgzMTljMDRhYzE5OWYyMDEzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDktMjcgIEh1YW5nIERvbmdz dW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW0dUS10gRW5hYmxlIENT UyBTaGFkZXJzIGxheW91dCBMYXlvdXRUZXN0cyBvbiBHVEsrCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzgyMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZmVhdHVyZSBpcyBkaXNhYmxlZCB2aWEg U2V0dGluZ3MgYnkgZGVmYXVsdCwgYnV0IGZvciB0ZXN0aW5nLAorICAgICAgICB3ZSBlbmFibGUg aXQgdXNpbmcgbGF5b3V0VGVzdENvbnRyb2xsZXIub3ZlcnJpZGVQcmVmZXJlbmNlcy4gQWRkIHRo ZQorICAgICAgICBuZWNlc3NhcnkgcGx1bWJpbmcgZm9yIERSVC4KKworICAgICAgICBXVFIgYWxy ZWFkeSB3b3JrcyBiZWNhdXNlIHN1cHBvcnQgd2FzIGFkZGVkIGZvciBBcHBsZSBNYWMgZWFybGll ci4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHA6Cisg ICAgICAgIChyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKTogRmVhdHVyZSBpcyBvZmYg YnkgZGVmYXVsdC4KKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvVGVzdFJ1bm5lckd0ay5j cHA6CisgICAgICAgIChUZXN0UnVubmVyOjpvdmVycmlkZVByZWZlcmVuY2UpOiBBZGQgaGFuZGxp bmcgb2YgV2ViS2l0Q1NTQ3VzdG9tRmlsdGVyRW5hYmxlZC4KKwogMjAxMi0wOS0yNiAgTGFzemxv IEdvbWJvcyAgPGwuZ29tYm9zQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVw ZGF0ZSBteSBlLW1haWwgYWRkcmVzcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJl bmRlclRyZWUuY3BwCmluZGV4IDFmOTY2MjJiYjU5MjVlZDFmZWZkZWI5YzQyMDU4NGZkZTVmNDYw YzIuLmY1NzRjMTFlOGU4YTQ2Y2E3NDZhM2E2NGJiZWQ2OTA4YjA0OGQ2NmYgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtNTE2LDYgKzUxNiw3IEBA IHN0YXRpYyB2b2lkIHJlc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZXMoKQogCiAgICAgRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzZXRDU1NHcmlkTGF5b3V0RW5hYmxlZCh3ZWJWaWV3LCBm YWxzZSk7CiAgICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzZXRDU1NSZWdpb25zRW5hYmxl ZCh3ZWJWaWV3LCB0cnVlKTsKKyAgICBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OnNldENTU0N1 c3RvbUZpbHRlckVuYWJsZWQod2ViVmlldywgZmFsc2UpOwogICAgIER1bXBSZW5kZXJUcmVlU3Vw cG9ydEd0azo6c2V0U2hhZG93RE9NRW5hYmxlZCh0cnVlKTsKICAgICBEdW1wUmVuZGVyVHJlZVN1 cHBvcnRHdGs6OnNldFN0eWxlU2NvcGVkRW5hYmxlZCh0cnVlKTsKIH0KZGlmZiAtLWdpdCBhL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9UZXN0UnVubmVyR3RrLmNwcCBiL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2d0ay9UZXN0UnVubmVyR3RrLmNwcAppbmRleCBkYjk2Mjg5MjcwYjc3NDgxMjgzNWMw ZjgwNDliMTQ2OTM0ZmJjMDJlLi4xZGM4MTk5Mzg1ZWVjYWEyNTUxMWYzN2Q5MTM3N2RjMjljODEz ZmExIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsvVGVzdFJ1bm5lckd0ay5j cHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3RSdW5uZXJHdGsuY3BwCkBAIC03 OTAsNiArNzkwLDkgQEAgdm9pZCBUZXN0UnVubmVyOjpvdmVycmlkZVByZWZlcmVuY2UoSlNTdHJp bmdSZWYga2V5LCBKU1N0cmluZ1JlZiB2YWx1ZSkKICAgICB9IGVsc2UgaWYgKGdfc3RyX2VxdWFs KG9yaWdpbmFsTmFtZS5nZXQoKSwgIldlYktpdENTU1JlZ2lvbnNFbmFibGVkIikpIHsKICAgICAg ICAgRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrOjpzZXRDU1NSZWdpb25zRW5hYmxlZCh3ZWJraXRf d2ViX2ZyYW1lX2dldF93ZWJfdmlldyhtYWluRnJhbWUpLCBib29sZWFuRnJvbVZhbHVlKHZhbHVl QXNTdHJpbmcuZ2V0KCkpKTsKICAgICAgICAgcmV0dXJuOworICAgIH0gZWxzZSBpZiAoZ19zdHJf ZXF1YWwob3JpZ2luYWxOYW1lLmdldCgpLCAiV2ViS2l0Q1NTQ3VzdG9tRmlsdGVyRW5hYmxlZCIp KSB7CisgICAgICAgIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6c2V0Q1NTQ3VzdG9tRmlsdGVy RW5hYmxlZCh3ZWJraXRfd2ViX2ZyYW1lX2dldF93ZWJfdmlldyhtYWluRnJhbWUpLCBib29sZWFu RnJvbVZhbHVlKHZhbHVlQXNTdHJpbmcuZ2V0KCkpKTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0g ZWxzZSB7CiAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiVGVzdFJ1bm5lcjo6b3ZlcnJpZGVQcmVm ZXJlbmNlIHRyaWVkIHRvIG92ZXJyaWRlICIKICAgICAgICAgICAgICAgICAidW5rbm93biBwcmVm ZXJlbmNlICclcycuXG4iLCBvcmlnaW5hbE5hbWUuZ2V0KCkpOwo=