97820 2012-09-27 13:29:35 -0700 Fix issue with ClassList which was hitting an assert in debug mode 2012-10-08 16:15:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv oldest_to_newest 729814 0 arv 2012-09-27 13:29:35 -0700 Fix issue with ClassList which was hitting an assert in debug mode 729817 1 166056 arv 2012-09-27 13:31:16 -0700 Created attachment 166056 Patch 729836 2 166060 arv 2012-09-27 14:00:55 -0700 Created attachment 166060 Patch 729840 3 arv 2012-09-27 14:03:28 -0700 Committed r129798: <http://trac.webkit.org/changeset/129798> 729842 4 166060 arv 2012-09-27 14:03:55 -0700 Comment on attachment 166060 Patch I landed manually 729992 5 166060 darin 2012-09-27 16:38:11 -0700 Comment on attachment 166060 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166060&action=review > Source/WebCore/bindings/v8/V8Binding.h:232 > - Vector<T> toNativeArguments(const v8::Arguments& args, size_t startIndex) > + Vector<T> toNativeArguments(const v8::Arguments& args, int startIndex) > { > ASSERT(startIndex <= args.Length()); > Vector<T> result; > typedef NativeValueTraits<T> TraitsType; > - size_t length = args.Length(); > - for (size_t i = startIndex; i < length; ++i) > + int length = args.Length(); > + for (int i = startIndex; i < length; ++i) > result.append(TraitsType::nativeValue(args[i])); Did you include this change intentionally, or by accident? Why doesn’t the change log mention this change? 730630 6 arv 2012-09-28 07:15:26 -0700 (In reply to comment #5) > Did you include this change intentionally, or by accident? Why doesn’t the change log mention this change? That was an intended change. Sorry for not pointing it out in the changelog. The reason was that, in debug mode, the code fails to compile due to comparison between int and size_t. 737188 7 166060 eric 2012-10-08 16:15:37 -0700 Comment on attachment 166060 Patch Cleared review? from attachment 166060 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 166056 2012-09-27 13:31:16 -0700 2012-09-27 14:00:52 -0700 Patch bug-97820-20120927163034.patch text/plain 1534 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5Nzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEyYjYyM2Q5ZGZiOTk5 YzJjYzQ4MmNlNWM3NmI4MmJhZGRmMGE5Yi4uZGE2NDk5MTQzODQyMjBjMDlkNWEwMjQxOTg1MTEw YWRiZTVhM2I1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTA5LTI3ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgRml4IGlzc3VlIHdpdGgg Q2xhc3NMaXN0IHdoaWNoIHdhcyBoaXR0aW5nIGFuIGFzc2VydCBpbiBkZWJ1ZyBtb2RlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzgyMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCisKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvMTI5Nzc5IGhpdHMgYW4gYXNzZXJ0IGluIGRlYnVnIG1vZGUgd2hlbiB0 cnlpbmcgdG8gdXNlIGZhc3RHZXRBdHRyaWJ1dGUgb24gYW4gU1ZHIGVsZW1lbnQuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBodG1s L0NsYXNzTGlzdC5oOgorCisyMDEyLTA5LTI3ICBFcmlrIEFydmlkc3NvbiAgPGFydkBjaHJvbWl1 bS5vcmc+CisKICAgICAgICAgRE9NNDogQWRkIHN1cHBvcnQgZm9yIHJlc3QgcGFyYW1ldGVycyB0 byBET01Ub2tlbkxpc3QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk3MzM1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ2xhc3NMaXN0 LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NsYXNzTGlzdC5oCmluZGV4IDc2NGViZjUyZTgxYWE5 YzBiZjg1ZWFmYzRlMGM3NTdiZDZjZmU0OWEuLjVlMzM5YzA0NWIyNDVmOWU2NTRiZGFkZDNkNmZl NDBjOTk2ZjBlZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ2xhc3NMaXN0LmgK KysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9DbGFzc0xpc3QuaApAQCAtNjUsNyArNjUsNyBAQCBw cml2YXRlOgogCiAgICAgY29uc3QgU3BhY2VTcGxpdFN0cmluZyYgY2xhc3NOYW1lcygpIGNvbnN0 OwogCi0gICAgdmlydHVhbCBBdG9taWNTdHJpbmcgdmFsdWUoKSBjb25zdCBPVkVSUklERSB7IHJl dHVybiBtX2VsZW1lbnQtPmZhc3RHZXRBdHRyaWJ1dGUoY2xhc3NBdHRyKTsgfQorICAgIHZpcnR1 YWwgQXRvbWljU3RyaW5nIHZhbHVlKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gbV9lbGVtZW50 LT5nZXRBdHRyaWJ1dGUoY2xhc3NBdHRyKTsgfQogICAgIHZpcnR1YWwgdm9pZCBzZXRWYWx1ZShj b25zdCBBdG9taWNTdHJpbmcmIHZhbHVlKSBPVkVSUklERSB7IG1fZWxlbWVudC0+c2V0QXR0cmli dXRlKGNsYXNzQXR0ciwgdmFsdWUpOyB9CiAKICAgICBFbGVtZW50KiBtX2VsZW1lbnQ7Cg== 166060 2012-09-27 14:00:55 -0700 2012-10-08 16:15:37 -0700 Patch bug-97820-20120927170013.patch text/plain 2520 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5Nzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEyYjYyM2Q5ZGZiOTk5 YzJjYzQ4MmNlNWM3NmI4MmJhZGRmMGE5Yi4uMjRiMWI0NzdhN2NkZTZlNjViYWZjYjM4NzViN2I1 Y2QwY2MzMzFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA5LTI3ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgRml4IGlzc3VlIHdpdGgg Q2xhc3NMaXN0IHdoaWNoIHdhcyBoaXR0aW5nIGFuIGFzc2VydCBpbiBkZWJ1ZyBtb2RlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzgyMAorCisgICAg ICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCisKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvMTI5Nzc5IGhpdCBhc3NlcnRzIGluIGRlYnVnIG1vZGUgd2hlbiB0cnlp bmcgdG8gdXNlIGZhc3RHZXRBdHRyaWJ1dGUgb24gYW4gU1ZHIGVsZW1lbnQuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5n cy92OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OnRvTmF0aXZlQXJndW1lbnRzKToK KyAgICAgICAgKiBodG1sL0NsYXNzTGlzdC5oOgorCisyMDEyLTA5LTI3ICBFcmlrIEFydmlkc3Nv biAgPGFydkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgRE9NNDogQWRkIHN1cHBvcnQgZm9yIHJl c3QgcGFyYW1ldGVycyB0byBET01Ub2tlbkxpc3QKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk3MzM1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhC aW5kaW5nLmgKaW5kZXggNTU2ZjY4NjY0MjZkMjdkZTY2YzZkNzE4N2JhYzEzMjhlMWNhM2Q1MS4u YTQwZTc1YWFlZjMzNzUzZDM0ODdkMzU0NmQzYzUwZTVkZDcwNGU4NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTIyMiwxMyArMjIyLDEzIEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICB9CiAKICAgICB0ZW1wbGF0ZSA8Y2xhc3MgVD4KLSAgICBWZWN0b3I8VD4g dG9OYXRpdmVBcmd1bWVudHMoY29uc3Qgdjg6OkFyZ3VtZW50cyYgYXJncywgc2l6ZV90IHN0YXJ0 SW5kZXgpCisgICAgVmVjdG9yPFQ+IHRvTmF0aXZlQXJndW1lbnRzKGNvbnN0IHY4OjpBcmd1bWVu dHMmIGFyZ3MsIGludCBzdGFydEluZGV4KQogICAgIHsKICAgICAgICAgQVNTRVJUKHN0YXJ0SW5k ZXggPD0gYXJncy5MZW5ndGgoKSk7CiAgICAgICAgIFZlY3RvcjxUPiByZXN1bHQ7CiAgICAgICAg IHR5cGVkZWYgTmF0aXZlVmFsdWVUcmFpdHM8VD4gVHJhaXRzVHlwZTsKLSAgICAgICAgc2l6ZV90 IGxlbmd0aCA9IGFyZ3MuTGVuZ3RoKCk7Ci0gICAgICAgIGZvciAoc2l6ZV90IGkgPSBzdGFydElu ZGV4OyBpIDwgbGVuZ3RoOyArK2kpCisgICAgICAgIGludCBsZW5ndGggPSBhcmdzLkxlbmd0aCgp OworICAgICAgICBmb3IgKGludCBpID0gc3RhcnRJbmRleDsgaSA8IGxlbmd0aDsgKytpKQogICAg ICAgICAgICAgcmVzdWx0LmFwcGVuZChUcmFpdHNUeXBlOjpuYXRpdmVWYWx1ZShhcmdzW2ldKSk7 CiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9DbGFzc0xpc3QuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ2xhc3NMaXN0LmgKaW5k ZXggNzY0ZWJmNTJlODFhYTljMGJmODVlYWZjNGUwYzc1N2JkNmNmZTQ5YS4uNWUzMzljMDQ1YjI0 NWY5ZTY1NGJkYWRkM2Q2ZmU0MGM5OTZmMGVmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9DbGFzc0xpc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NsYXNzTGlzdC5oCkBA IC02NSw3ICs2NSw3IEBAIHByaXZhdGU6CiAKICAgICBjb25zdCBTcGFjZVNwbGl0U3RyaW5nJiBj bGFzc05hbWVzKCkgY29uc3Q7CiAKLSAgICB2aXJ0dWFsIEF0b21pY1N0cmluZyB2YWx1ZSgpIGNv bnN0IE9WRVJSSURFIHsgcmV0dXJuIG1fZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShjbGFzc0F0 dHIpOyB9CisgICAgdmlydHVhbCBBdG9taWNTdHJpbmcgdmFsdWUoKSBjb25zdCBPVkVSUklERSB7 IHJldHVybiBtX2VsZW1lbnQtPmdldEF0dHJpYnV0ZShjbGFzc0F0dHIpOyB9CiAgICAgdmlydHVh bCB2b2lkIHNldFZhbHVlKGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWUpIE9WRVJSSURFIHsgbV9l bGVtZW50LT5zZXRBdHRyaWJ1dGUoY2xhc3NBdHRyLCB2YWx1ZSk7IH0KIAogICAgIEVsZW1lbnQq IG1fZWxlbWVudDsK