<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>97814</bug_id>
          
          <creation_ts>2012-09-27 13:19:03 -0700</creation_ts>
          <short_desc>Add webkit_unit_tests to the flakiness dashboard</short_desc>
          <delta_ts>2012-09-27 15:02:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Julie Parent">jparent</reporter>
          <assigned_to name="Julie Parent">jparent</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>729800</commentid>
    <comment_count>0</comment_count>
    <who name="Julie Parent">jparent</who>
    <bug_when>2012-09-27 13:19:03 -0700</bug_when>
    <thetext>Add webkit_unit_tests to the flakiness dashboard</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729802</commentid>
    <comment_count>1</comment_count>
      <attachid>166049</attachid>
    <who name="Julie Parent">jparent</who>
    <bug_when>2012-09-27 13:20:17 -0700</bug_when>
    <thetext>Created attachment 166049
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729865</commentid>
    <comment_count>2</comment_count>
      <attachid>166063</attachid>
    <who name="Julie Parent">jparent</who>
    <bug_when>2012-09-27 14:28:56 -0700</bug_when>
    <thetext>Created attachment 166063
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729885</commentid>
    <comment_count>3</comment_count>
      <attachid>166063</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-27 14:56:50 -0700</bug_when>
    <thetext>Comment on attachment 166063
Patch for landing

Rejecting attachment 166063 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/mac/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://queues.webkit.org/results/13967089</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729889</commentid>
    <comment_count>4</comment_count>
      <attachid>166063</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-27 14:58:11 -0700</bug_when>
    <thetext>Comment on attachment 166063
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=166063&amp;action=review

&gt; Tools/ChangeLog:6
&gt; +        Reviewed by Dirk Pranke.

This line looks right.  I&apos;m not sure why the bot complained.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729897</commentid>
    <comment_count>5</comment_count>
      <attachid>166063</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-27 15:00:50 -0700</bug_when>
    <thetext>Comment on attachment 166063
Patch for landing

Clearing flags on attachment: 166063

Committed r129805: &lt;http://trac.webkit.org/changeset/129805&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729898</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-27 15:00:53 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>729899</commentid>
    <comment_count>7</comment_count>
    <who name="Julie Parent">jparent</who>
    <bug_when>2012-09-27 15:02:02 -0700</bug_when>
    <thetext>I just used webkit-patch land-safely, not sure why the changelog would have been incorrect. Thanks Adam!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166049</attachid>
            <date>2012-09-27 13:20:17 -0700</date>
            <delta_ts>2012-09-27 14:28:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-97814-20120927131935.patch</filename>
            <type>text/plain</type>
            <size>2331</size>
            <attacher name="Julie Parent">jparent</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5Nzg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODhmMTRlOTE2ZmU1YmE5ZDg5MWQ5YWYxM2IxM2RmZGI2
ZTkwMmViYy4uNjk5NGRhMmNjMjMyZjIyMmMyZGRmNmNjYTFlOGM1NjljNThiZjc5MSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDEyLTA5LTI3ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor
ICAgICAgICBBZGQgd2Via2l0X3VuaXRfdGVzdHMgdG8gdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3ODE0CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Via2l0X3Vu
aXRfdGVzdHMgcnVuIG9uIHRoZSBzYW1lIGJvdHMgYXMgdGVzdF9zaGVsbF90ZXN0cy4KKworICAg
ICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanM6Cisg
ICAgICAgIChsb2FkQnVpbGRlcnNMaXN0KToKKyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0
YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpzOgorICAgICAgICAoY3VycmVudEJ1aWxk
ZXJHcm91cENhdGVnb3J5KToKKwogMjAxMi0wOS0yNyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNo
cm9taXVtLm9yZz4KIAogICAgICAgICB3ZWJraXRweTogbWFrZSB3YXJuaW5nIGFib3V0IG1pc3Np
bmcgQlVHIGlkZW50aWZpZXJzIHBlci1wb3J0IGNvbmZpZ3VyYWJsZQpkaWZmIC0tZ2l0IGEvVG9v
bHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcyBiL1Rvb2xz
L1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMKaW5kZXggY2Mz
YWE5MjcyMWQ4MmUzOGQwNDhiMjYyMTNhMmFjZTQ4MWI0ZTIwZi4uMjQzYmRiNDA4NGQ0MDIyY2U2
NmI3M2U3N2NmZmRlOGNkYWNjYmRmOSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZl
ci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0U2Vy
dmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCkBAIC0yODEsNiArMjgxLDcgQEAgZnVu
Y3Rpb24gbG9hZEJ1aWxkZXJzTGlzdChncm91cE5hbWUsIHRlc3RUeXBlKSB7CiAgICAgICAgIGJy
ZWFrOwogICAgCiAgICAgY2FzZSAndGVzdF9zaGVsbF90ZXN0cyc6CisgICAgY2FzZSAnd2Via2l0
X3VuaXRfdGVzdHMnOgogICAgICAgICBzd2l0Y2goZ3JvdXBOYW1lKSB7CiAgICAgICAgIGNhc2Ug
J0BUb1QgLSBjaHJvbWl1bS5vcmcnOgogICAgICAgICAgICAgdmFyIGJ1aWxkZXJHcm91cCA9IG5l
dyBCdWlsZGVyR3JvdXAoQnVpbGRlckdyb3VwLlRPVF9XRUJLSVQpOwpkaWZmIC0tZ2l0IGEvVG9v
bHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcyBi
L1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2Uu
anMKaW5kZXggZDg2YWEwOWNhOTNiMjQ1ZjIzNWI1ZjkwYjFlMTdiYTkyZjM0OWJlZi4uMzFhZGZh
YmEzNzcyYWNjMDVlZTIxYWJiMDM5MjdjMzAyOThlMjk5NSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz
dFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcworKysgYi9U
b29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpz
CkBAIC0xNDcsNiArMTQ3LDcgQEAgdmFyIFRFU1RfVFlQRVMgPSBbCiAgICAgJ3VpX3Rlc3RzJywK
ICAgICAndW5pdF90ZXN0cycsCiAgICAgJ3ZpZXdzX3VuaXR0ZXN0cycsCisgICAgJ3dlYmtpdF91
bml0X3Rlc3RzJywKIF07CiAKIHZhciBSRUxPQURfUkVRVUlSSU5HX1BBUkFNRVRFUlMgPSBbJ3No
b3dBbGxSdW5zJywgJ2dyb3VwJywgJ3Rlc3RUeXBlJ107CkBAIC00NTcsNiArNDU4LDcgQEAgZnVu
Y3Rpb24gY3VycmVudEJ1aWxkZXJHcm91cENhdGVnb3J5KCkKICAgICBjYXNlICdsYXlvdXQtdGVz
dHMnOgogICAgICAgICByZXR1cm4gTEFZT1VUX1RFU1RTX0JVSUxERVJfR1JPVVBTOwogICAgIGNh
c2UgJ3Rlc3Rfc2hlbGxfdGVzdHMnOgorICAgIGNhc2UgJ3dlYmtpdF91bml0X3Rlc3RzJzoKICAg
ICAgICAgcmV0dXJuIFRFU1RfU0hFTExfVEVTVFNfQlVJTERFUl9HUk9VUFM7CiAgICAgZGVmYXVs
dDoKICAgICAgICAgcmV0dXJuIENIUk9NSVVNX0dURVNUU19CVUlMREVSX0dST1VQUzsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>166063</attachid>
            <date>2012-09-27 14:28:56 -0700</date>
            <delta_ts>2012-09-27 15:00:50 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-97814-20120927142814.patch</filename>
            <type>text/plain</type>
            <size>2328</size>
            <attacher name="Julie Parent">jparent</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5Nzg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODhmMTRlOTE2ZmU1YmE5ZDg5MWQ5YWYxM2IxM2RmZGI2
ZTkwMmViYy4uMjQyZmFhNWMxNTI2N2UyNWI0MjJlZjA5M2QxOTdmOTBiMTExMWU1ZiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDEyLTA5LTI3ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KKwor
ICAgICAgICBBZGQgd2Via2l0X3VuaXRfdGVzdHMgdG8gdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3ODE0CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBQcmFua2UuCisKKyAgICAgICAgd2Via2l0X3VuaXRf
dGVzdHMgcnVuIG9uIHRoZSBzYW1lIGJvdHMgYXMgdGVzdF9zaGVsbF90ZXN0cy4KKworICAgICAg
ICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanM6CisgICAg
ICAgIChsb2FkQnVpbGRlcnNMaXN0KToKKyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0YXRp
Yy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpzOgorICAgICAgICAoY3VycmVudEJ1aWxkZXJH
cm91cENhdGVnb3J5KToKKwogMjAxMi0wOS0yNyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9t
aXVtLm9yZz4KIAogICAgICAgICB3ZWJraXRweTogbWFrZSB3YXJuaW5nIGFib3V0IG1pc3Npbmcg
QlVHIGlkZW50aWZpZXJzIHBlci1wb3J0IGNvbmZpZ3VyYWJsZQpkaWZmIC0tZ2l0IGEvVG9vbHMv
VGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcyBiL1Rvb2xzL1Rl
c3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMKaW5kZXggY2MzYWE5
MjcyMWQ4MmUzOGQwNDhiMjYyMTNhMmFjZTQ4MWI0ZTIwZi4uMjQzYmRiNDA4NGQ0MDIyY2U2NmI3
M2U3N2NmZmRlOGNkYWNjYmRmOSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9z
dGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcworKysgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVy
L3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCkBAIC0yODEsNiArMjgxLDcgQEAgZnVuY3Rp
b24gbG9hZEJ1aWxkZXJzTGlzdChncm91cE5hbWUsIHRlc3RUeXBlKSB7CiAgICAgICAgIGJyZWFr
OwogICAgCiAgICAgY2FzZSAndGVzdF9zaGVsbF90ZXN0cyc6CisgICAgY2FzZSAnd2Via2l0X3Vu
aXRfdGVzdHMnOgogICAgICAgICBzd2l0Y2goZ3JvdXBOYW1lKSB7CiAgICAgICAgIGNhc2UgJ0BU
b1QgLSBjaHJvbWl1bS5vcmcnOgogICAgICAgICAgICAgdmFyIGJ1aWxkZXJHcm91cCA9IG5ldyBC
dWlsZGVyR3JvdXAoQnVpbGRlckdyb3VwLlRPVF9XRUJLSVQpOwpkaWZmIC0tZ2l0IGEvVG9vbHMv
VGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcyBiL1Rv
b2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZGFzaGJvYXJkX2Jhc2UuanMK
aW5kZXggZDg2YWEwOWNhOTNiMjQ1ZjIzNWI1ZjkwYjFlMTdiYTkyZjM0OWJlZi4uMzFhZGZhYmEz
NzcyYWNjMDVlZTIxYWJiMDM5MjdjMzAyOThlMjk5NSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFJl
c3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9kYXNoYm9hcmRfYmFzZS5qcworKysgYi9Ub29s
cy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2Rhc2hib2FyZF9iYXNlLmpzCkBA
IC0xNDcsNiArMTQ3LDcgQEAgdmFyIFRFU1RfVFlQRVMgPSBbCiAgICAgJ3VpX3Rlc3RzJywKICAg
ICAndW5pdF90ZXN0cycsCiAgICAgJ3ZpZXdzX3VuaXR0ZXN0cycsCisgICAgJ3dlYmtpdF91bml0
X3Rlc3RzJywKIF07CiAKIHZhciBSRUxPQURfUkVRVUlSSU5HX1BBUkFNRVRFUlMgPSBbJ3Nob3dB
bGxSdW5zJywgJ2dyb3VwJywgJ3Rlc3RUeXBlJ107CkBAIC00NTcsNiArNDU4LDcgQEAgZnVuY3Rp
b24gY3VycmVudEJ1aWxkZXJHcm91cENhdGVnb3J5KCkKICAgICBjYXNlICdsYXlvdXQtdGVzdHMn
OgogICAgICAgICByZXR1cm4gTEFZT1VUX1RFU1RTX0JVSUxERVJfR1JPVVBTOwogICAgIGNhc2Ug
J3Rlc3Rfc2hlbGxfdGVzdHMnOgorICAgIGNhc2UgJ3dlYmtpdF91bml0X3Rlc3RzJzoKICAgICAg
ICAgcmV0dXJuIFRFU1RfU0hFTExfVEVTVFNfQlVJTERFUl9HUk9VUFM7CiAgICAgZGVmYXVsdDoK
ICAgICAgICAgcmV0dXJuIENIUk9NSVVNX0dURVNUU19CVUlMREVSX0dST1VQUzsK
</data>

          </attachment>
      

    </bug>

</bugzilla>