97805 2012-09-27 11:23:06 -0700 [Mac][DRT] Add support to allow non-array modifier arguments in keyDown() 2012-09-27 14:43:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis ap webkit.review.bot oldest_to_newest 729724 0 naginenis 2012-09-27 11:23:06 -0700 Support for non-array modifier arguments to DRT's keydown has been added by other ports. So, implement this on Mac too, to be consistent with the other ports. 729739 1 166038 naginenis 2012-09-27 11:43:54 -0700 Created attachment 166038 Patch 729765 2 166038 ap 2012-09-27 12:23:18 -0700 Comment on attachment 166038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166038&action=review > Tools/DumpRenderTree/mac/EventSendingController.mm:302 > +static int applyKeyModifierFlags(const NSString* modifierName) Why is this function called "apply..."? It doesn't seem to apply them to anything. 729792 3 166047 naginenis 2012-09-27 13:10:08 -0700 Created attachment 166047 Patch Taken Alexey's feedback into consideration. 729879 4 166047 webkit.review.bot 2012-09-27 14:43:46 -0700 Comment on attachment 166047 Patch Clearing flags on attachment: 166047 Committed r129802: <http://trac.webkit.org/changeset/129802> 729880 5 webkit.review.bot 2012-09-27 14:43:49 -0700 All reviewed patches have been landed. Closing bug. 166038 2012-09-27 11:43:54 -0700 2012-09-27 13:10:08 -0700 Patch 97805.patch text/plain 2875 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZGQ1 NWUyLi5hNDEyOGE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDktMjcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW01hY11bRFJUXSBBZGQg c3VwcG9ydCB0byBhbGxvdyBub24tYXJyYXkgbW9kaWZpZXIgYXJndW1lbnRzIGluIGtleURvd24o KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc4MDUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3Vw cG9ydCBmb3IgaGFuZGxpbmcgYSBzdHJpbmcgYXMgbW9kaWZpZXIgYXJndW1lbnQgdG8ga2V5RG93 bigpLgorICAgICAgICBUaGlzIHN1cHBvcnQgaGFzIGFscmVhZHkgYmVlbiBhZGRlZCB0byBvdGhl ciBwb3J0cywgc28gaW1wbGVtZW50aW5nCisgICAgICAgIHRoaXMgb24gTWFjIHRvbywgdG8gYmUg Y29uc2lzdGVudCB3aXRoIHRoZSBvdGhlciBwb3J0cy4KKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL21hYy9FdmVudFNlbmRpbmdDb250cm9sbGVyLm1tOgorICAgICAgICAoYXBwbHlLZXlNb2Rp ZmllckZsYWdzKToKKyAgICAgICAgKGJ1aWxkTW9kaWZpZXJGbGFncyk6CisKIDIwMTItMDktMjcg IFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgTWVkaWFT dHJlYW0gQVBJOiBVcGRhdGUgZ2V0VXNlck1lZGlhIHRvIG1hdGNoIHRoZSBsYXRlc3Qgc3BlY2lm aWNhdGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0V2ZW50U2VuZGlu Z0NvbnRyb2xsZXIubW0gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRXZlbnRTZW5kaW5nQ29u dHJvbGxlci5tbQppbmRleCBkYzhiMjY2Li4zNzljOTU5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbQorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9tYWMvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5tbQpAQCAtMjk5LDIxICsyOTks MzEgQEAgc3RhdGljIE5TRXZlbnRUeXBlIGV2ZW50VHlwZUZvck1vdXNlQnV0dG9uQW5kQWN0aW9u KGludCBidXR0b24sIE1vdXNlQWN0aW9uIGFjdGkKICAgICAgICAgY2xpY2tDb3VudCsrOwogfQog CitzdGF0aWMgaW50IGFwcGx5S2V5TW9kaWZpZXJGbGFncyhjb25zdCBOU1N0cmluZyogbW9kaWZp ZXJOYW1lKQoreworICAgIGludCBmbGFncyA9IDA7CisgICAgaWYgKFttb2RpZmllck5hbWUgaXNF cXVhbDpAImN0cmxLZXkiXSkKKyAgICAgICAgZmxhZ3MgfD0gTlNDb250cm9sS2V5TWFzazsKKyAg ICBlbHNlIGlmIChbbW9kaWZpZXJOYW1lIGlzRXF1YWw6QCJzaGlmdEtleSJdIHx8IFttb2RpZmll ck5hbWUgaXNFcXVhbDpAInJhbmdlU2VsZWN0aW9uS2V5Il0pCisgICAgICAgIGZsYWdzIHw9IE5T U2hpZnRLZXlNYXNrOworICAgIGVsc2UgaWYgKFttb2RpZmllck5hbWUgaXNFcXVhbDpAImFsdEtl eSJdKQorICAgICAgICBmbGFncyB8PSBOU0FsdGVybmF0ZUtleU1hc2s7CisgICAgZWxzZSBpZiAo W21vZGlmaWVyTmFtZSBpc0VxdWFsOkAibWV0YUtleSJdIHx8IFttb2RpZmllck5hbWUgaXNFcXVh bDpAImFkZFNlbGVjdGlvbktleSJdKQorICAgICAgICBmbGFncyB8PSBOU0NvbW1hbmRLZXlNYXNr OworCisgICAgcmV0dXJuIGZsYWdzOworfQorCiBzdGF0aWMgaW50IGJ1aWxkTW9kaWZpZXJGbGFn cyhjb25zdCBXZWJTY3JpcHRPYmplY3QqIG1vZGlmaWVycykKIHsKICAgICBpbnQgZmxhZ3MgPSAw OwotICAgIGlmICghW21vZGlmaWVycyBpc0tpbmRPZkNsYXNzOltXZWJTY3JpcHRPYmplY3QgY2xh c3NdXSkKKyAgICBpZiAoW21vZGlmaWVycyBpc0tpbmRPZkNsYXNzOltOU1N0cmluZyBjbGFzc11d KQorICAgICAgICByZXR1cm4gYXBwbHlLZXlNb2RpZmllckZsYWdzKChOU1N0cmluZyopbW9kaWZp ZXJzKTsKKyAgICBlbHNlIGlmICghW21vZGlmaWVycyBpc0tpbmRPZkNsYXNzOltXZWJTY3JpcHRP YmplY3QgY2xhc3NdXSkKICAgICAgICAgcmV0dXJuIGZsYWdzOwogICAgIGZvciAodW5zaWduZWQg aSA9IDA7IFtbbW9kaWZpZXJzIHdlYlNjcmlwdFZhbHVlQXRJbmRleDppXSBpc0tpbmRPZkNsYXNz OltOU1N0cmluZyBjbGFzc11dOyBpKyspIHsKICAgICAgICAgTlNTdHJpbmcqIG1vZGlmaWVyTmFt ZSA9IChOU1N0cmluZyopW21vZGlmaWVycyB3ZWJTY3JpcHRWYWx1ZUF0SW5kZXg6aV07Ci0gICAg ICAgIGlmIChbbW9kaWZpZXJOYW1lIGlzRXF1YWw6QCJjdHJsS2V5Il0pCi0gICAgICAgICAgICBm bGFncyB8PSBOU0NvbnRyb2xLZXlNYXNrOwotICAgICAgICBlbHNlIGlmIChbbW9kaWZpZXJOYW1l IGlzRXF1YWw6QCJzaGlmdEtleSJdIHx8IFttb2RpZmllck5hbWUgaXNFcXVhbDpAInJhbmdlU2Vs ZWN0aW9uS2V5Il0pCi0gICAgICAgICAgICBmbGFncyB8PSBOU1NoaWZ0S2V5TWFzazsKLSAgICAg ICAgZWxzZSBpZiAoW21vZGlmaWVyTmFtZSBpc0VxdWFsOkAiYWx0S2V5Il0pCi0gICAgICAgICAg ICBmbGFncyB8PSBOU0FsdGVybmF0ZUtleU1hc2s7Ci0gICAgICAgIGVsc2UgaWYgKFttb2RpZmll ck5hbWUgaXNFcXVhbDpAIm1ldGFLZXkiXSB8fCBbbW9kaWZpZXJOYW1lIGlzRXF1YWw6QCJhZGRT ZWxlY3Rpb25LZXkiXSkKLSAgICAgICAgICAgIGZsYWdzIHw9IE5TQ29tbWFuZEtleU1hc2s7Cisg ICAgICAgIGZsYWdzIHw9IGFwcGx5S2V5TW9kaWZpZXJGbGFncyhtb2RpZmllck5hbWUpOwogICAg IH0KICAgICByZXR1cm4gZmxhZ3M7CiB9Cg== 166047 2012-09-27 13:10:08 -0700 2012-09-27 14:43:45 -0700 Patch 97805.patch text/plain 2843 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4ZGQ1 NWUyLi5hMzc3NTM2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDktMjcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW01hY11bRFJUXSBBZGQg c3VwcG9ydCB0byBhbGxvdyBub24tYXJyYXkgbW9kaWZpZXIgYXJndW1lbnRzIGluIGtleURvd24o KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc4MDUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3Vw cG9ydCBmb3IgaGFuZGxpbmcgYSBzdHJpbmcgYXMgbW9kaWZpZXIgYXJndW1lbnQgdG8ga2V5RG93 bigpLgorICAgICAgICBUaGlzIHN1cHBvcnQgaGFzIGFscmVhZHkgYmVlbiBhZGRlZCB0byBvdGhl ciBwb3J0cywgc28gaW1wbGVtZW50aW5nCisgICAgICAgIHRoaXMgb24gTWFjIHRvbywgdG8gYmUg Y29uc2lzdGVudCB3aXRoIHRoZSBvdGhlciBwb3J0cy4KKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL21hYy9FdmVudFNlbmRpbmdDb250cm9sbGVyLm1tOgorICAgICAgICAobW9kaWZpZXJGbGFn cyk6CisgICAgICAgIChidWlsZE1vZGlmaWVyRmxhZ3MpOgorCiAyMDEyLTA5LTI3ICBUb21teSBX aWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1lZGlhU3RyZWFtIEFQ STogVXBkYXRlIGdldFVzZXJNZWRpYSB0byBtYXRjaCB0aGUgbGF0ZXN0IHNwZWNpZmljYXRpb24K ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9FdmVudFNlbmRpbmdDb250cm9s bGVyLm1tIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIu bW0KaW5kZXggZGM4YjI2Ni4uNDgyYmY5MyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvbWFjL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIubW0KKysrIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvbWFjL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIubW0KQEAgLTI5OSwyMSArMjk5LDMxIEBAIHN0 YXRpYyBOU0V2ZW50VHlwZSBldmVudFR5cGVGb3JNb3VzZUJ1dHRvbkFuZEFjdGlvbihpbnQgYnV0 dG9uLCBNb3VzZUFjdGlvbiBhY3RpCiAgICAgICAgIGNsaWNrQ291bnQrKzsKIH0KIAorc3RhdGlj IGludCBtb2RpZmllckZsYWdzKGNvbnN0IE5TU3RyaW5nKiBtb2RpZmllck5hbWUpCit7CisgICAg aW50IGZsYWdzID0gMDsKKyAgICBpZiAoW21vZGlmaWVyTmFtZSBpc0VxdWFsOkAiY3RybEtleSJd KQorICAgICAgICBmbGFncyB8PSBOU0NvbnRyb2xLZXlNYXNrOworICAgIGVsc2UgaWYgKFttb2Rp Zmllck5hbWUgaXNFcXVhbDpAInNoaWZ0S2V5Il0gfHwgW21vZGlmaWVyTmFtZSBpc0VxdWFsOkAi cmFuZ2VTZWxlY3Rpb25LZXkiXSkKKyAgICAgICAgZmxhZ3MgfD0gTlNTaGlmdEtleU1hc2s7Cisg ICAgZWxzZSBpZiAoW21vZGlmaWVyTmFtZSBpc0VxdWFsOkAiYWx0S2V5Il0pCisgICAgICAgIGZs YWdzIHw9IE5TQWx0ZXJuYXRlS2V5TWFzazsKKyAgICBlbHNlIGlmIChbbW9kaWZpZXJOYW1lIGlz RXF1YWw6QCJtZXRhS2V5Il0gfHwgW21vZGlmaWVyTmFtZSBpc0VxdWFsOkAiYWRkU2VsZWN0aW9u S2V5Il0pCisgICAgICAgIGZsYWdzIHw9IE5TQ29tbWFuZEtleU1hc2s7CisKKyAgICByZXR1cm4g ZmxhZ3M7Cit9CisKIHN0YXRpYyBpbnQgYnVpbGRNb2RpZmllckZsYWdzKGNvbnN0IFdlYlNjcmlw dE9iamVjdCogbW9kaWZpZXJzKQogewogICAgIGludCBmbGFncyA9IDA7Ci0gICAgaWYgKCFbbW9k aWZpZXJzIGlzS2luZE9mQ2xhc3M6W1dlYlNjcmlwdE9iamVjdCBjbGFzc11dKQorICAgIGlmIChb bW9kaWZpZXJzIGlzS2luZE9mQ2xhc3M6W05TU3RyaW5nIGNsYXNzXV0pCisgICAgICAgIHJldHVy biBtb2RpZmllckZsYWdzKChOU1N0cmluZyopbW9kaWZpZXJzKTsKKyAgICBlbHNlIGlmICghW21v ZGlmaWVycyBpc0tpbmRPZkNsYXNzOltXZWJTY3JpcHRPYmplY3QgY2xhc3NdXSkKICAgICAgICAg cmV0dXJuIGZsYWdzOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IFtbbW9kaWZpZXJzIHdlYlNj cmlwdFZhbHVlQXRJbmRleDppXSBpc0tpbmRPZkNsYXNzOltOU1N0cmluZyBjbGFzc11dOyBpKysp IHsKICAgICAgICAgTlNTdHJpbmcqIG1vZGlmaWVyTmFtZSA9IChOU1N0cmluZyopW21vZGlmaWVy cyB3ZWJTY3JpcHRWYWx1ZUF0SW5kZXg6aV07Ci0gICAgICAgIGlmIChbbW9kaWZpZXJOYW1lIGlz RXF1YWw6QCJjdHJsS2V5Il0pCi0gICAgICAgICAgICBmbGFncyB8PSBOU0NvbnRyb2xLZXlNYXNr OwotICAgICAgICBlbHNlIGlmIChbbW9kaWZpZXJOYW1lIGlzRXF1YWw6QCJzaGlmdEtleSJdIHx8 IFttb2RpZmllck5hbWUgaXNFcXVhbDpAInJhbmdlU2VsZWN0aW9uS2V5Il0pCi0gICAgICAgICAg ICBmbGFncyB8PSBOU1NoaWZ0S2V5TWFzazsKLSAgICAgICAgZWxzZSBpZiAoW21vZGlmaWVyTmFt ZSBpc0VxdWFsOkAiYWx0S2V5Il0pCi0gICAgICAgICAgICBmbGFncyB8PSBOU0FsdGVybmF0ZUtl eU1hc2s7Ci0gICAgICAgIGVsc2UgaWYgKFttb2RpZmllck5hbWUgaXNFcXVhbDpAIm1ldGFLZXki XSB8fCBbbW9kaWZpZXJOYW1lIGlzRXF1YWw6QCJhZGRTZWxlY3Rpb25LZXkiXSkKLSAgICAgICAg ICAgIGZsYWdzIHw9IE5TQ29tbWFuZEtleU1hc2s7CisgICAgICAgIGZsYWdzIHw9IG1vZGlmaWVy RmxhZ3MobW9kaWZpZXJOYW1lKTsKICAgICB9CiAgICAgcmV0dXJuIGZsYWdzOwogfQo=