97796 2012-09-27 09:23:44 -0700 [Perftest] PerfTestRunner exception when using nested git checkouts 2012-09-27 14:55:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 fmalita fmalita abarth dpranke ojan rniwa webkit.review.bot oldest_to_newest 729601 0 fmalita 2012-09-27 09:23:44 -0700 I'm using separate Chromium and WebKit git trees, and run-perf-tests bombs when attempting to collect revision info: Traceback (most recent call last): File "Tools/Scripts/run-perf-tests", line 40, in <module> sys.exit(PerfTestsRunner().run()) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 167, in run exit_code = self._generate_and_show_results() File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 182, in _generate_and_show_results output = self._generate_results_dict(self._timestamp, options.description, options.platform, options.builder_name, options.build_number) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py", line 208, in _generate_results_dict contents[name + '-revision'] = self._host.scm().svn_revision(path) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 255, in svn_revision git_log = self._run_git(['log', '-25', path]) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 106, in _run_git return self.run(full_command_args, **full_kwargs) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 76, in run decode_output=decode_output) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 423, in run_command (error_handler or self.default_error_handler)(script_error) File "/mnt/screamin/src/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 340, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "[u'git', u'log', u'-25', u'/mnt/screamin/src/chromium/src/build']" exit_code: 128 cwd: /mnt/screamin/src/chromium/src/third_party/WebKit It boils down to git not supporting querying resources outside its current tree: fmalita@fmalita-linux2:~/wk$ git log /mnt/screamin/src/chromium/src/build fatal: '/mnt/screamin/src/chromium/src/build' is outside repository 729602 1 166018 fmalita 2012-09-27 09:26:01 -0700 Created attachment 166018 Patch 729661 2 rniwa 2012-09-27 10:13:47 -0700 Let me verify that it works correctly in svn checkouts. 729883 3 166018 webkit.review.bot 2012-09-27 14:55:32 -0700 Comment on attachment 166018 Patch Clearing flags on attachment: 166018 Committed r129804: <http://trac.webkit.org/changeset/129804> 729884 4 webkit.review.bot 2012-09-27 14:55:35 -0700 All reviewed patches have been landed. Closing bug. 166018 2012-09-27 09:26:01 -0700 2012-09-27 14:55:31 -0700 Patch bug-97796-20120927122519.patch text/plain 2206 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGRkNTVlMjFlMzdiNGYyMDRhZDU4ZmI1OGRlMGQ3YzBj NTY0ZTJhYy4uZDdhMTg3MTZlODFmMjM1OTQ5NmI2YzUxMjI4MTM4N2I4MWVmMDMyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA5LTI3ICBGbG9yaW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW1BlcmZ0ZXN0XSBQZXJmVGVzdFJ1bm5lciBleGNlcHRpb24gd2hlbiB1c2luZyBu ZXN0ZWQgZ2l0IGNoZWNrb3V0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTc3OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbiBvcmRlciB0byBzdXBwb3J0IHNlcGFyYXRlIENocm9taXVtIHZzLiBXZWJL aXQgZ2l0IHRyZWVzLCBQZXJmVGVzdHNSdW5uZXIgbmVlZHMgdG8KKyAgICAgICAgaW5zdGFudGlh dGUgcGVyLXJlcG9zaXRvcnkgU0NNIG9iamVjdHMgd2hlbiBjb2xsZWN0aW5nIHJldmlzaW9uIGlu Zm9ybWF0aW9uLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0 cy9wZXJmdGVzdHNydW5uZXIucHk6CisgICAgICAgIChQZXJmVGVzdHNSdW5uZXIuX2dlbmVyYXRl X3Jlc3VsdHNfZGljdCk6CisKIDIwMTItMDktMjcgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3 QGdvb2dsZS5jb20+CiAKICAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBVcGRhdGUgZ2V0VXNlck1l ZGlhIHRvIG1hdGNoIHRoZSBsYXRlc3Qgc3BlY2lmaWNhdGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5w eQppbmRleCBkMGJmNzc1NDM3NGY3NWE2OWIwZmU2MWI5MWE4MmY4MDFmOWRlMTUwLi42M2I1Yzhl NWE4NzIwMDI3OWMxODkwNzIzNjRhYTU0OGQ4YWMyMjU5IDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5w eQpAQCAtMzYsNiArMzYsNyBAQCBpbXBvcnQgb3B0cGFyc2UKIGltcG9ydCB0aW1lCiAKIGZyb20g d2Via2l0cHkuY29tbW9uIGltcG9ydCBmaW5kX2ZpbGVzCitmcm9tIHdlYmtpdHB5LmNvbW1vbi5j aGVja291dC5zY20uZGV0ZWN0aW9uIGltcG9ydCBTQ01EZXRlY3RvcgogZnJvbSB3ZWJraXRweS5j b21tb24uaG9zdCBpbXBvcnQgSG9zdAogZnJvbSB3ZWJraXRweS5jb21tb24ubmV0LmZpbGVfdXBs b2FkZXIgaW1wb3J0IEZpbGVVcGxvYWRlcgogZnJvbSB3ZWJraXRweS5wZXJmb3JtYW5jZV90ZXN0 cy5wZXJmdGVzdCBpbXBvcnQgUGVyZlRlc3RGYWN0b3J5CkBAIC0yMDUsNyArMjA2LDggQEAgY2xh c3MgUGVyZlRlc3RzUnVubmVyKG9iamVjdCk6CiAgICAgICAgIGlmIGRlc2NyaXB0aW9uOgogICAg ICAgICAgICAgY29udGVudHNbJ2Rlc2NyaXB0aW9uJ10gPSBkZXNjcmlwdGlvbgogICAgICAgICBm b3IgKG5hbWUsIHBhdGgpIGluIHNlbGYuX3BvcnQucmVwb3NpdG9yeV9wYXRocygpOgotICAgICAg ICAgICAgY29udGVudHNbbmFtZSArICctcmV2aXNpb24nXSA9IHNlbGYuX2hvc3Quc2NtKCkuc3Zu X3JldmlzaW9uKHBhdGgpCisgICAgICAgICAgICBzY20gPSBTQ01EZXRlY3RvcihzZWxmLl9ob3N0 LmZpbGVzeXN0ZW0sIHNlbGYuX2hvc3QuZXhlY3V0aXZlKS5kZXRlY3Rfc2NtX3N5c3RlbShwYXRo KSBvciBzZWxmLl9ob3N0LnNjbSgpCisgICAgICAgICAgICBjb250ZW50c1tuYW1lICsgJy1yZXZp c2lvbiddID0gc2NtLnN2bl9yZXZpc2lvbihwYXRoKQogCiAgICAgICAgICMgRklYTUU6IEFkZCAt LWJyYW5jaCBvciBhdXRvLWRldGVjdCB0aGUgYnJhbmNoIHdlJ3JlIGluCiAgICAgICAgIGZvciBr ZXksIHZhbHVlIGluIHsndGltZXN0YW1wJzogaW50KHRpbWVzdGFtcCksICdicmFuY2gnOiBzZWxm Ll9kZWZhdWx0X2JyYW5jaCwgJ3BsYXRmb3JtJzogcGxhdGZvcm0sCg==