97783 2012-09-27 07:26:57 -0700 Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane. 2012-09-27 10:09:30 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 729509 0 vsevik 2012-09-27 07:26:57 -0700 This happens because BreakpointsSidebarPane is now created lazily and it does not add all uiLocations that are already available when it is created. Patch to follow. 729515 1 165996 vsevik 2012-09-27 07:36:50 -0700 Created attachment 165996 Patch 729653 2 165996 webkit.review.bot 2012-09-27 10:09:26 -0700 Comment on attachment 165996 Patch Clearing flags on attachment: 165996 Committed r129775: <http://trac.webkit.org/changeset/129775> 729654 3 webkit.review.bot 2012-09-27 10:09:30 -0700 All reviewed patches have been landed. Closing bug. 165996 2012-09-27 07:36:50 -0700 2012-09-27 10:09:26 -0700 Patch bug-97783-20120927183607.patch text/plain 5429 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGU4ZTYwMWE0YTFkNDUx YmRkMzRhYjBjNWU4NTUwNTI4ODMzOGZiZi4uYzk4OTQwOGE2ZGNjMmY1ODQyMDBkYjJkN2U4ZmEy ZTZiYWUzMzg5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI3ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtSRUdSRVNTSU9OXSBCcmVha3BvaW50cyBhcmUgbm90IGFsd2F5cyBzaG93biBpbiBicmVh a3BvaW50cyBzaWRlYmFyIHBhbmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05Nzc4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEJyZWFrcG9pbnRTaWRlYmFyUGFuZSBub3cgZXhwbGljaXRseSBhZGRzIGFs bCBicmVha3BvaW50cyB0aGF0IGFyZSBhdmFpbGFibGUgYXQgdGhlIG1vbWVudCBvZiBpdHMgY3Jl YXRpb24uCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnRNYW5hZ2Vy LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRNYW5hZ2VyLnByb3RvdHlwZS5f ZmlsdGVyZWRCcmVha3BvaW50TG9jYXRpb25zKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5CcmVh a3BvaW50TWFuYWdlci5wcm90b3R5cGUuYnJlYWtwb2ludExvY2F0aW9uc0ZvclVJU291cmNlQ29k ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludE1hbmFnZXIucHJvdG90eXBlLmFs bEJyZWFrcG9pbnRMb2NhdGlvbnMpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvQnJl YWtwb2ludHNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5KYXZhU2NyaXB0 QnJlYWtwb2ludHNTaWRlYmFyUGFuZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSmF2YVNjcmlw dEJyZWFrcG9pbnRzU2lkZWJhclBhbmUucHJvdG90eXBlLl9icmVha3BvaW50QWRkZWQpOgorCiAy MDEyLTA5LTI3ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbQ01BS0VdIFJlbW92ZSB1bm5lY2Vzc2FyeSBoZWFkZXIgZmlsZXMgZnJvbSBDTWFrZUxp c3RzLnR4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9C cmVha3BvaW50TWFuYWdlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv QnJlYWtwb2ludE1hbmFnZXIuanMKaW5kZXggOGU5ZDRiNjU1YzIyMGEyNGEyNDkwMGY5ZTgwMzc0 NmI5ZDZkODM0OS4uNzEzM2U3NTBiYjU0YWJhZjZkYzVkMjM0OTgyZTU1NDRiZjdkMzQyOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50TWFu YWdlci5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9p bnRNYW5hZ2VyLmpzCkBAIC0xMzMsMTcgKzEzMywxNyBAQCBXZWJJbnNwZWN0b3IuQnJlYWtwb2lu dE1hbmFnZXIucHJvdG90eXBlID0gewogICAgIH0sCiAKICAgICAvKioKLSAgICAgKiBAcGFyYW0g e1dlYkluc3BlY3Rvci5VSVNvdXJjZUNvZGV9IHVpU291cmNlQ29kZQotICAgICAqIEByZXR1cm4g e0FycmF5LjxPYmplY3Q+fQorICAgICAqIEBwYXJhbSB7ZnVuY3Rpb24oV2ViSW5zcGVjdG9yLkJy ZWFrcG9pbnRNYW5hZ2VyLkJyZWFrcG9pbnQsIFdlYkluc3BlY3Rvci5VSUxvY2F0aW9uKX0gZmls dGVyCisgICAgICogQHJldHVybiB7QXJyYXkuPHticmVha3BvaW50OiBXZWJJbnNwZWN0b3IuQnJl YWtwb2ludE1hbmFnZXIuQnJlYWtwb2ludCwgdWlMb2NhdGlvbjogV2ViSW5zcGVjdG9yLlVJTG9j YXRpb259Pn0KICAgICAgKi8KLSAgICBicmVha3BvaW50TG9jYXRpb25zRm9yVUlTb3VyY2VDb2Rl OiBmdW5jdGlvbih1aVNvdXJjZUNvZGUpCisgICAgX2ZpbHRlcmVkQnJlYWtwb2ludExvY2F0aW9u czogZnVuY3Rpb24oZmlsdGVyKQogICAgIHsKICAgICAgICAgdmFyIHJlc3VsdCA9IFtdOwogICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX2JyZWFrcG9pbnRzLmxlbmd0aDsgKytpKSB7 CiAgICAgICAgICAgICB2YXIgYnJlYWtwb2ludCA9IHRoaXMuX2JyZWFrcG9pbnRzW2ldOwogICAg ICAgICAgICAgZm9yICh2YXIgc3RyaW5naWZpZWRMb2NhdGlvbiBpbiBicmVha3BvaW50Ll91aUxv Y2F0aW9ucykgewogICAgICAgICAgICAgICAgIHZhciB1aUxvY2F0aW9uID0gYnJlYWtwb2ludC5f dWlMb2NhdGlvbnNbc3RyaW5naWZpZWRMb2NhdGlvbl07Ci0gICAgICAgICAgICAgICAgaWYgKHVp TG9jYXRpb24udWlTb3VyY2VDb2RlID09PSB1aVNvdXJjZUNvZGUpCisgICAgICAgICAgICAgICAg aWYgKGZpbHRlcihicmVha3BvaW50LCB1aUxvY2F0aW9uKSkKICAgICAgICAgICAgICAgICAgICAg cmVzdWx0LnB1c2goe2JyZWFrcG9pbnQ6IGJyZWFrcG9pbnQsIHVpTG9jYXRpb246IHVpTG9jYXRp b259KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQpAQCAtMTUxLDYgKzE1MSwyOCBAQCBXZWJJ bnNwZWN0b3IuQnJlYWtwb2ludE1hbmFnZXIucHJvdG90eXBlID0gewogICAgIH0sCiAKICAgICAv KioKKyAgICAgKiBAcGFyYW0ge1dlYkluc3BlY3Rvci5VSVNvdXJjZUNvZGV9IHVpU291cmNlQ29k ZQorICAgICAqIEByZXR1cm4ge0FycmF5Ljx7YnJlYWtwb2ludDogV2ViSW5zcGVjdG9yLkJyZWFr cG9pbnRNYW5hZ2VyLkJyZWFrcG9pbnQsIHVpTG9jYXRpb246IFdlYkluc3BlY3Rvci5VSUxvY2F0 aW9ufT59CisgICAgICovCisgICAgYnJlYWtwb2ludExvY2F0aW9uc0ZvclVJU291cmNlQ29kZTog ZnVuY3Rpb24odWlTb3VyY2VDb2RlKQorICAgIHsKKyAgICAgICAgZnVuY3Rpb24gZmlsdGVyKGJy ZWFrcG9pbnQsIHVpTG9jYXRpb24pCisgICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiB1aUxv Y2F0aW9uLnVpU291cmNlQ29kZSA9PT0gdWlTb3VyY2VDb2RlOyAgIAorICAgICAgICB9CisgICAg ICAgIAorICAgICAgICByZXR1cm4gdGhpcy5fZmlsdGVyZWRCcmVha3BvaW50TG9jYXRpb25zKGZp bHRlcik7CisgICAgfSwKKworICAgIC8qKgorICAgICAqIEByZXR1cm4ge0FycmF5Ljx7YnJlYWtw b2ludDogV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRNYW5hZ2VyLkJyZWFrcG9pbnQsIHVpTG9jYXRp b246IFdlYkluc3BlY3Rvci5VSUxvY2F0aW9ufT59CisgICAgICovCisgICAgYWxsQnJlYWtwb2lu dExvY2F0aW9uczogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMuX2ZpbHRl cmVkQnJlYWtwb2ludExvY2F0aW9ucyhmdW5jdGlvbihicmVha3BvaW50LCB1aUxvY2F0aW9uKSB7 IHJldHVybiB0cnVlOyB9KTsKKyAgICB9LAorCisgICAgLyoqCiAgICAgICogQHBhcmFtIHtib29s ZWFufSB0b2dnbGVTdGF0ZQogICAgICAqLwogICAgIHRvZ2dsZUFsbEJyZWFrcG9pbnRzOiBmdW5j dGlvbih0b2dnbGVTdGF0ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvQnJlYWtwb2ludHNTaWRlYmFyUGFuZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvQnJlYWtwb2ludHNTaWRlYmFyUGFuZS5qcwppbmRleCA0YmRkNGFmN2Jh YjAyMjU5Yjk4ZjhmMDc1NTkyZWQxYTNkMWNlOTk0Li4wZTY4YjAzZWE4M2YxYmFlMDNmZjdkMjJl NTI1NzI1YTM5NjZjYTViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0JyZWFrcG9pbnRzU2lkZWJhclBhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9CcmVha3BvaW50c1NpZGViYXJQYW5lLmpzCkBAIC00NSw2ICs0NSwx MSBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdEJyZWFrcG9pbnRzU2lkZWJhclBhbmUgPSBmdW5j dGlvbihicmVha3BvaW50TWFuYWdlciwgc2hvdwogICAgIHRoaXMuYm9keUVsZW1lbnQuYXBwZW5k Q2hpbGQodGhpcy5lbXB0eUVsZW1lbnQpOwogCiAgICAgdGhpcy5faXRlbXMgPSBuZXcgTWFwKCk7 CisgICAgCisgICAgdmFyIGJyZWFrcG9pbnRMb2NhdGlvbnMgPSB0aGlzLl9icmVha3BvaW50TWFu YWdlci5hbGxCcmVha3BvaW50TG9jYXRpb25zKCk7CisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBi cmVha3BvaW50TG9jYXRpb25zLmxlbmd0aDsgKytpKQorICAgICAgICB0aGlzLl9hZGRCcmVha3Bv aW50KGJyZWFrcG9pbnRMb2NhdGlvbnNbaV0uYnJlYWtwb2ludCwgYnJlYWtwb2ludExvY2F0aW9u c1tpXS51aUxvY2F0aW9uKTsKKwogICAgIHRoaXMuX2JyZWFrcG9pbnRNYW5hZ2VyLmFkZEV2ZW50 TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkJyZWFrcG9pbnRNYW5hZ2VyLkV2ZW50cy5CcmVha3BvaW50 QWRkZWQsIHRoaXMuX2JyZWFrcG9pbnRBZGRlZCwgdGhpcyk7CiAgICAgdGhpcy5fYnJlYWtwb2lu dE1hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuQnJlYWtwb2ludE1hbmFnZXIu RXZlbnRzLkJyZWFrcG9pbnRSZW1vdmVkLCB0aGlzLl9icmVha3BvaW50UmVtb3ZlZCwgdGhpcyk7 CiB9CkBAIC01OSw3ICs2NCwxNSBAQCBXZWJJbnNwZWN0b3IuSmF2YVNjcmlwdEJyZWFrcG9pbnRz U2lkZWJhclBhbmUucHJvdG90eXBlID0gewogCiAgICAgICAgIHZhciBicmVha3BvaW50ID0gLyoq IEB0eXBlIHtXZWJJbnNwZWN0b3IuQnJlYWtwb2ludE1hbmFnZXIuQnJlYWtwb2ludH0gKi8gZXZl bnQuZGF0YS5icmVha3BvaW50OwogICAgICAgICB2YXIgdWlMb2NhdGlvbiA9IC8qKiBAdHlwZSB7 V2ViSW5zcGVjdG9yLlVJTG9jYXRpb259ICovIGV2ZW50LmRhdGEudWlMb2NhdGlvbjsKKyAgICAg ICAgdGhpcy5fYWRkQnJlYWtwb2ludChicmVha3BvaW50LCB1aUxvY2F0aW9uKTsKKyAgICB9LAog CisgICAgLyoqCisgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuQnJlYWtwb2ludE1hbmFnZXIu QnJlYWtwb2ludH0gYnJlYWtwb2ludAorICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLlVJTG9j YXRpb259IHVpTG9jYXRpb24KKyAgICAgKi8KKyAgICBfYWRkQnJlYWtwb2ludDogZnVuY3Rpb24o YnJlYWtwb2ludCwgdWlMb2NhdGlvbikKKyAgICB7CiAgICAgICAgIHZhciBlbGVtZW50ID0gZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgibGkiKTsKICAgICAgICAgZWxlbWVudC5hZGRTdHlsZUNsYXNz KCJjdXJzb3ItcG9pbnRlciIpOwogICAgICAgICBlbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNv bnRleHRtZW51IiwgdGhpcy5fYnJlYWtwb2ludENvbnRleHRNZW51LmJpbmQodGhpcywgYnJlYWtw b2ludCksIHRydWUpOwo=