97772 2012-09-27 04:12:48 -0700 Compilation failure on Windows-64 because of enabled YARR_JIT 2012-10-01 01:59:30 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 kai.koehne webkit-unassigned barraclough benjamin hausmann mark.lam net147 roger_fong webkit.review.bot oldest_to_newest 729404 0 kai.koehne 2012-09-27 04:12:48 -0700 Compiling latest qtwebkit with Mingw-w64 compiler results in: jit\ExecutableAllocatorFixedVMPool.cpp:34:22: fatal error: sys/mman.h: No such file or directory This is because of change https://bugs.webkit.org/show_bug.cgi?id=91052 , where YARR_JIT gets now defined to 1 . This results in ASSEMBLER to be defined to 1, too, which causes ENABLE_EXECUTABLE_ALLOCATOR_FIXED to be defined to 1 .... Following the reasoning in https://bugs.webkit.org/process_bug.cgi we shouldn't enable any JIT for WIndows-64. 729413 1 165973 kai.koehne 2012-09-27 04:23:55 -0700 Created attachment 165973 Disables YARR_JIT for Windows 64. 729418 2 165973 hausmann 2012-09-27 04:30:45 -0700 Comment on attachment 165973 Disables YARR_JIT for Windows 64. View in context: https://bugs.webkit.org/attachment.cgi?id=165973&action=review > Source/WTF/ChangeLog:8 > + JIT has to be disabled in general on Windows-64. I think this could be explained with more than one sentence :) 729426 3 kai.koehne 2012-09-27 04:47:10 -0700 I'd actually wanted to link to https://bugs.webkit.org/show_bug.cgi?id=65313 as the bug/commit disabling JIT for WIndows 64 in general. 730519 4 166216 kai.koehne 2012-09-28 05:05:57 -0700 Created attachment 166216 Disables YARR_JIT for Windows 64 It's still a sentence, though a longer one ;) I'm not sure whether Assembler/JIT is not available on Windows 64 bit in principle, or if it's just the mmap.h dependency that breaks it. However, the enabling of yarr_jit on Windows was done most probably by accident by the patch enabling llint, and this patch just reverts to the original behavior (no jit, no yarr_jit, no assembler on windows 64 bit) . 730520 5 webkit.review.bot 2012-09-28 05:07:41 -0700 Attachment 166216 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Pl..." exit_code: 1 Source/WTF/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WTF/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 730524 6 166218 kai.koehne 2012-09-28 05:09:11 -0700 Created attachment 166218 Disables YARR_JIT for Windows 64 This time with spaces instead of tabs ... 730625 7 166218 webkit.review.bot 2012-09-28 07:12:32 -0700 Comment on attachment 166218 Disables YARR_JIT for Windows 64 Clearing flags on attachment: 166218 Committed r129893: <http://trac.webkit.org/changeset/129893> 730626 8 webkit.review.bot 2012-09-28 07:12:36 -0700 All reviewed patches have been landed. Closing bug. 731492 9 net147 2012-10-01 01:59:30 -0700 A problem we have now is that the classic interpreter has been removed from WebKit so either JIT or LLINT must be enabled. Disabling JIT causes LLINT to be enabled but LLINT doesn't build properly on Windows yet: llint\LowLevelInterpreter.cpp:329:35: fatal error: LLIntAssembly.h: No such file or directory 165973 2012-09-27 04:23:55 -0700 2012-09-28 06:46:22 -0700 Disables YARR_JIT for Windows 64. disable_yarr_jit_on_windows64.patch text/plain 948 kai.koehne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMTRjYzQyMi4uODJmZTQzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOS0yNyAg S2FpIEtvZWhuZSAgPGthaS5rb2VobmVAZGlnaWEuY29tPgorCisgICAgICAgIERpc2FibGUgWUFS Ul9KSVQgZm9yIFdpbmRvd3MgNjQgYml0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05Nzc3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEpJVCBoYXMgdG8gYmUgZGlzYWJsZWQgaW4gZ2VuZXJhbCBvbiBXaW5k b3dzLTY0LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTItMDktMjYgIEdhdmlu IEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFN0cmluZy5s b2NhbGVDb21wYXJlIHNob3VsZCBub3JtYWxpemUgaW5wdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDg4M2I0 N2IuLmNkZjk5ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIv U291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtODc2LDYgKzg3Niw3IEBACiAvKiBKSVQgaXMg bm90IGltcGxlbWVudGVkIGZvciBXaW5kb3dzIDY0LWJpdCAqLwogI2lmICFkZWZpbmVkKEVOQUJM RV9KSVQpICYmIE9TKFdJTkRPV1MpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIEVOQUJMRV9KSVQg MAorI2RlZmluZSBFTkFCTEVfWUFSUl9KSVQgMAogI2VuZGlmCiAKICNpZiAhZGVmaW5lZChFTkFC TEVfSklUKSAmJiBDUFUoU0g0KSAmJiBQTEFURk9STShRVCkK 166216 2012-09-28 05:05:57 -0700 2012-09-28 05:09:11 -0700 Disables YARR_JIT for Windows 64 disable_yarr_jit_on_windows64.patch text/plain 1057 kai.koehne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZmYzNDI1MS4uZmUyOTE4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0yOCAg S2FpIEtvZWhuZSAgPGthaS5rb2VobmVAZGlnaWEuY29tPgorCisgICAgICAgIERpc2FibGUgWUFS Ul9KSVQgZm9yIFdpbmRvd3MgNjQgYml0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05Nzc3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzaW5nIFlBUlJfSklUIHJlcXVpcmVzIEFTU0VNQkxFUiwgd2hpY2gg aW4gdHVybiBlbmFibGVzIHRoZQorCWV4ZWN1dGFibGUgZml4ZWQgYWxsb2NhdG9yLCB3aGljaCBp cyBtbWFwIGJhc2VkIChub3QgYXZhaWxhYmxlIG9uCisJV2luZG93cykuCisKKyAgICAgICAgKiB3 dGYvUGxhdGZvcm0uaDoKKwogMjAxMi0wOS0yOCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBtYWtlIEhhc2hTZXQgbWVtb3J5 IGluc3RydW1lbnRhdGlvbiBub24taW50cnVzaXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCAxMjgwOGUzLi5i MThmZjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1NvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTg3Niw2ICs4NzYsNyBAQAogLyogSklUIGlzIG5vdCBp bXBsZW1lbnRlZCBmb3IgV2luZG93cyA2NC1iaXQgKi8KICNpZiAhZGVmaW5lZChFTkFCTEVfSklU KSAmJiBPUyhXSU5ET1dTKSAmJiBDUFUoWDg2XzY0KQogI2RlZmluZSBFTkFCTEVfSklUIDAKKyNk ZWZpbmUgRU5BQkxFX1lBUlJfSklUIDAKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoRU5BQkxFX0pJ VCkgJiYgQ1BVKFNINCkgJiYgUExBVEZPUk0oUVQpCg== 166218 2012-09-28 05:09:11 -0700 2012-09-28 07:12:32 -0700 Disables YARR_JIT for Windows 64 disable_yarr_jit_on_windows64.patch text/plain 1071 kai.koehne ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZmYzNDI1MS4uZmUyOTE4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0yOCAg S2FpIEtvZWhuZSAgPGthaS5rb2VobmVAZGlnaWEuY29tPgorCisgICAgICAgIERpc2FibGUgWUFS Ul9KSVQgZm9yIFdpbmRvd3MgNjQgYml0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05Nzc3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzaW5nIFlBUlJfSklUIHJlcXVpcmVzIEFTU0VNQkxFUiwgd2hpY2gg aW4gdHVybiBlbmFibGVzIHRoZQorICAgICAgICBleGVjdXRhYmxlIGZpeGVkIGFsbG9jYXRvciwg d2hpY2ggaXMgbW1hcCBiYXNlZCAobm90IGF2YWlsYWJsZSBvbgorICAgICAgICBXaW5kb3dzKS4K KworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDEyLTA5LTI4ICBZdXJ5IFNlbWlraGF0 c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1ha2Ug SGFzaFNldCBtZW1vcnkgaW5zdHJ1bWVudGF0aW9uIG5vbi1pbnRydXNpdmUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmlu ZGV4IDEyODA4ZTMuLmIxOGZmOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt LmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtODc2LDYgKzg3Niw3IEBACiAv KiBKSVQgaXMgbm90IGltcGxlbWVudGVkIGZvciBXaW5kb3dzIDY0LWJpdCAqLwogI2lmICFkZWZp bmVkKEVOQUJMRV9KSVQpICYmIE9TKFdJTkRPV1MpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIEVO QUJMRV9KSVQgMAorI2RlZmluZSBFTkFCTEVfWUFSUl9KSVQgMAogI2VuZGlmCiAKICNpZiAhZGVm aW5lZChFTkFCTEVfSklUKSAmJiBDUFUoU0g0KSAmJiBQTEFURk9STShRVCkK