97770 2012-09-27 03:36:24 -0700 [EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css 2012-09-27 04:45:50 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cmarcelo eric.carlson feature-media-reviews gyuyoung.kim kenneth lucas.de.marchi macpherson menard webkit.review.bot oldest_to_newest 729391 0 cdumez 2012-09-27 03:36:24 -0700 Some CSS rules are duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in sync with what is in mediaControlsEfl.css. We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to fullscreen mode, that is to say, the hiding of some controls. 729392 1 165968 cdumez 2012-09-27 03:41:02 -0700 Created attachment 165968 Patch 729424 2 165968 webkit.review.bot 2012-09-27 04:45:46 -0700 Comment on attachment 165968 Patch Clearing flags on attachment: 165968 Committed r129754: <http://trac.webkit.org/changeset/129754> 729425 3 webkit.review.bot 2012-09-27 04:45:50 -0700 All reviewed patches have been landed. Closing bug. 165968 2012-09-27 03:41:02 -0700 2012-09-27 04:45:46 -0700 Patch 97770_media_fullscreen_css.patch text/plain 3644 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MTVlYTM0Li5kNDQ4MTVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDktMjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBSZW1vdmUgZHVwbGljYXRlZCBDU1MgYmV0d2VlbiBtZWRp YUNvbnRyb2xzRWZsLmNzcyBhbmQgbWVkaWFDb250cm9sc0VmbEZ1bGxzY3JlZW4uY3NzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Nzc3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgQ1NTIHJ1bGVz IHdlcmUgZHVwbGljYXRlZCBiZXR3ZWVuIG1lZGlhQ29udHJvbHNFZmwuY3NzIGFuZCBtZWRpYUNv bnRyb2xzRWZsRnVsbHNjcmVlbi5jc3MKKyAgICAgICAgZm9yIG5vIHJlYXNvbi4gVGhpcyBpcyBh biBpc3N1ZSBiZWNhdXNlIGl0IGlzIGVhc3kgdG8gdXBkYXRlIG1lZGlhQ29udHJvbHNFZmwuY3Nz IGFuZCBmb3JnZXQKKyAgICAgICAgdG8gbWFrZSB0aGUgc2FtZSB1cGRhdGUgdG8gbWVkaWFDb250 cm9sc0VmbEZ1bGxzY3JlZW4uY3NzLiBBcyBhIG1hdHRlciBvZiBmYWN0LCB0aGUgdGltZWxpbmUK KyAgICAgICAgZGlzcGxheSBpbiBmdWxsc2NyZWVuIGlzIGN1cnJlbnRseSBvZmYgYnkgYSBmZXcg cGl4ZWxzIGJlY2F1c2UgaXRzIGZ1bGxzY3JlZW4gQ1NTIGlzIG5vdCBpbgorICAgICAgICBzeW5j IHdpdGggd2hhdCBpcyBpbiBtZWRpYUNvbnRyb2xzRWZsLmNzcy4KKworICAgICAgICBXZSBuZWVk IHRvIGluY2x1ZGUgaW4gbWVkaWFDb250cm9sc0VmbEZ1bGxzY3JlZW4uY3NzIG9ubHkgdGhlIENT UyBydWxlcyB0aGF0IGFyZSBzcGVjaWZpYyB0bworICAgICAgICBmdWxsc2NyZWVuIG1vZGUsIHRo YXQgaXMgdG8gc2F5LCB0aGUgaGlkaW5nIG9mIHNvbWUgY29udHJvbHMuCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UgZm9yIGxheW91dCB0ZXN0cy4KKworICAgICAg ICAqIGNzcy9tZWRpYUNvbnRyb2xzRWZsRnVsbHNjcmVlbi5jc3M6CisKIDIwMTItMDktMjUgIEFs ZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDb2xsZWN0 aW5nUnVsZXMgYW5kIFF1ZXJ5aW5nUnVsZXMgbW9kZXMgb2YgU2VsZWN0b3JDaGVja2VyIG1pc3Mg c29tZSBjb21wbGV4IHNlbGVjdG9ycyB3aXRoIHBzZXVkbyBlbGVtZW50cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNFZmxGdWxsc2NyZWVuLmNzcyBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzRWZsRnVsbHNjcmVlbi5jc3MKaW5kZXggMGNmMWQ1 YS4uNmIzYTUxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNF ZmxGdWxsc2NyZWVuLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc0Vm bEZ1bGxzY3JlZW4uY3NzCkBAIC0yNCwyMCArMjQsNiBAQAogCiAvKiBFRkxXZWJLaXQgbWVkaWEg Y29udHJvbHMgZm9yIGZ1bGxzY3JlZW4uICovCiAKLXZpZGVvOi13ZWJraXQtZnVsbC1zY3JlZW46 Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwgewotICAgIGRpc3BsYXk6IC13ZWJraXQtYm94 OwotICAgIC13ZWJraXQtYm94LW9yaWVudDogaG9yaXpvbnRhbDsKLSAgICAtd2Via2l0LWJveC1h bGlnbjogY2VudGVyOwotICAgIC13ZWJraXQtdXNlci1zZWxlY3Q6IG5vbmU7Ci0gICAgcG9zaXRp b246IHJlbGF0aXZlOwotICAgIGJvdHRvbTogMDsKLSAgICB3aWR0aDogMTAwJTsKLSAgICB6LWlu ZGV4OiAwOwotICAgIG92ZXJmbG93OiBoaWRkZW47Ci0gICAgaGVpZ2h0OiAyMHB4OwotICAgIHRl eHQtYWxpZ246IHJpZ2h0OwotfQotCiB2aWRlbzotd2Via2l0LWZ1bGwtc2NyZWVuOi13ZWJraXQt ZnVsbC1wYWdlLW1lZGlhOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXBhbmVsIHsKICAgICBkaXNw bGF5OiBub25lOwogfQpAQCAtNDYsNTMgKzMyLDEwIEBAIHZpZGVvOi13ZWJraXQtZnVsbC1zY3Jl ZW46Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtbXV0ZS1idXR0b24gewogICAgIGRpc3BsYXk6IG5v bmU7CiB9CiAKLXZpZGVvOi13ZWJraXQtZnVsbC1zY3JlZW46Oi13ZWJraXQtbWVkaWEtY29udHJv bHMtcGxheS1idXR0b24gewotICAgIC13ZWJraXQtYXBwZWFyYW5jZTogbWVkaWEtcGxheS1idXR0 b247Ci0gICAgZGlzcGxheTogLXdlYmtpdC1ib3g7Ci0gICAgd2lkdGg6IDIwcHg7Ci0gICAgaGVp Z2h0OiAyMHB4OwotICAgIGJhY2tncm91bmQtY29sb3I6IGluaXRpYWw7Ci0gICAgYm9yZGVyOiBp bml0aWFsOwotICAgIGNvbG9yOiBpbmhlcml0OwotfQotCi12aWRlbzotd2Via2l0LWZ1bGwtc2Ny ZWVuOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVsaW5lLWNvbnRhaW5lciB7Ci0gICAgLXdl YmtpdC1hcHBlYXJhbmNlOiBtZWRpYS1jb250cm9scy1iYWNrZ3JvdW5kOwotICAgIGRpc3BsYXk6 IC13ZWJraXQtYm94OwotICAgIC13ZWJraXQtYm94LW9yaWVudDogaG9yaXpvbnRhbDsKLSAgICAt d2Via2l0LWJveC1hbGlnbjogY2VudGVyOwotICAgIC13ZWJraXQtYm94LXBhY2s6IGVuZDsKLSAg ICAtd2Via2l0LWJveC1mbGV4OiAxOwotICAgIC13ZWJraXQtdXNlci1zZWxlY3Q6IG5vbmU7Ci0g ICAgaGVpZ2h0OiAyMHB4OwotfQotCi12aWRlbzotd2Via2l0LWZ1bGwtc2NyZWVuOjotd2Via2l0 LW1lZGlhLWNvbnRyb2xzLWN1cnJlbnQtdGltZS1kaXNwbGF5IHsKLSAgICAtd2Via2l0LWFwcGVh cmFuY2U6IG1lZGlhLWN1cnJlbnQtdGltZS1kaXNwbGF5OwotICAgIC13ZWJraXQtdXNlci1zZWxl Y3Q6IG5vbmU7Ci0gICAgZGlzcGxheTogaW5saW5lLWJsb2NrOwotICAgIGhlaWdodDogMjBweDsK LSAgICBwYWRkaW5nOiA0cHg7Ci0gICAgdGV4dC1hbGlnbjogY2VudGVyOwotICAgIGZvbnQtc2l6 ZTogMTBweDsKLX0KLQogdmlkZW86LXdlYmtpdC1mdWxsLXNjcmVlbjo6LXdlYmtpdC1tZWRpYS1j b250cm9scy10aW1lLXJlbWFpbmluZy1kaXNwbGF5IHsKICAgICBkaXNwbGF5OiBub25lOwogfQog Ci12aWRlbzotd2Via2l0LWZ1bGwtc2NyZWVuOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXRpbWVs aW5lIHsKLSAgICAtd2Via2l0LWFwcGVhcmFuY2U6IG1lZGlhLXNsaWRlcjsKLSAgICBkaXNwbGF5 OiAtd2Via2l0LWJveDsKLSAgICAtd2Via2l0LWJveC1mbGV4OiAxOwotICAgIGhlaWdodDogMjBw eDsKLSAgICBwYWRkaW5nOiAwcHggMnB4OwotICAgIGJhY2tncm91bmQtY29sb3I6IGluaXRpYWw7 Ci0gICAgYm9yZGVyOiBpbml0aWFsOwotICAgIGNvbG9yOiBpbmhlcml0OwotICAgIG1hcmdpbjog aW5pdGlhbDsKLX0KLQogdmlkZW86LXdlYmtpdC1mdWxsLXNjcmVlbjo6LXdlYmtpdC1tZWRpYS1j b250cm9scy12b2x1bWUtc2xpZGVyLWNvbnRhaW5lciB7CiAgICAgLXdlYmtpdC1hcHBlYXJhbmNl OiBtZWRpYS12b2x1bWUtc2xpZGVyLWNvbnRhaW5lcjsKICAgICBkaXNwbGF5OiBub25lOwo=