97751 2012-09-26 19:20:17 -0700 webkitpy: make warning about missing BUG identifiers per-port configurable 2012-09-27 11:59:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 97750 1 dpranke dpranke abarth ap ojan rniwa simon.fraser oldest_to_newest 729144 0 dpranke 2012-09-26 19:20:17 -0700 webkitpy: make warning about missing BUG identifiers per-port configurable 729147 1 165917 dpranke 2012-09-26 19:23:24 -0700 Created attachment 165917 Patch 729191 2 165917 ojan 2012-09-26 21:31:05 -0700 Comment on attachment 165917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165917&action=review Seems like a reasonable path forward. > Tools/Scripts/webkitpy/layout_tests/port/base.py:1005 > + def warn_if_bug_missing_in_test_expectations(self): > + return False > + I assume this copy-paste was accidental? 729660 3 165917 dpranke 2012-09-27 10:13:42 -0700 Comment on attachment 165917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165917&action=review >> Tools/Scripts/webkitpy/layout_tests/port/base.py:1005 >> + > > I assume this copy-paste was accidental? whoops. Yes :). 729755 4 dpranke 2012-09-27 11:59:53 -0700 Committed r129784: <http://trac.webkit.org/changeset/129784> 165917 2012-09-26 19:23:24 -0700 2012-09-27 10:13:42 -0700 Patch bug-97751-20120926192243.patch text/plain 6055 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NzE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjljMDM2ZGQ4NjZhODZhNDgxMWM3ZmZiZTZjYTc4YzJi MjcwZTNhNS4uZjZiMWQ4MDhlZThkYjViOGY1ZDkwYzMwMTVkNDdiZjIxYzU2MzAyMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMz IEBACiAyMDEyLTA5LTI2ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHdlYmtpdHB5OiBtYWtlIHdhcm5pbmcgYWJvdXQgbWlzc2luZyBCVUcgaWRlbnRpZmll cnMgcGVyLXBvcnQgY29uZmlndXJhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05Nzc1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFByaW9yIHRvIHRoaXMgY2hhbmdlIGxpbnRpbmcgVGVzdEV4cGVjdGF0 aW9ucyBmaWxlcyAoY2hlY2tpbmcgdGhlaXIgc3R5bGUpCisgICAgICAgIHdvdWxkIHJhaXNlIHdh cm5pbmdzIGlmIGxpbmVzIHdlcmUgbWlzc2luZyBhIEJVRyBtb2RpZmllciwgZXZlbgorICAgICAg ICB0aG91Z2ggc3VjaCBhIG1vZGlmaWVyIGlzIGFjdHVhbGx5IG9wdGlvbmFsIGluIHRoZSBzeW50 YXguIEFzIHdlCisgICAgICAgIG1pZ3JhdGUgdGhlIGVudHJpZXMgb3ZlciBmcm9tIHRoZSBTa2lw cGVkIGZpbGVzLCB0aGVzZSB3YXJuaW5ncworICAgICAgICB3aWxsIGdlbmVyYXRlIGEgbG90IG9m IG5vaXNlLCBhbmQgaXQncyBub3QgeWV0IGNsZWFyIHRoYXQgd2UKKyAgICAgICAgYWN0dWFsbHkg d2FudCB0byByZXF1aXJlIHRoZSBtb2RpZmllcnMgb24gYWxsIHBvcnRzLgorCisgICAgICAgIFNv LCB0aGlzIGNoYW5nZSBtYWtlcyB0aGlzIHBlci1wb3J0IGNvbmZpZ3VyYWJsZSBzbyB0aGF0IHRo ZXkKKyAgICAgICAgd2lsbCBnZW5lcmF0ZSB3YXJuaW5ncyBpbiB0aGUgQ2hyb21pdW0gVGVzdEV4 cGVjdGF0aW9ucyBhbmQgbm90CisgICAgICAgIGFueXdoZXJlIGVsc2UuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHk6 CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25QYXJzZXIuX3BhcnNlX21vZGlmaWVycyk6CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRp b25zX3VuaXR0ZXN0LnB5OgorICAgICAgICAoTWlzY1Rlc3RzLnRlc3RfcGFyc2Vfd2FybmluZyk6 CisgICAgICAgIChTZW1hbnRpY1Rlc3RzLnRlc3RfbWlzc2luZ19idWdpZCk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9y dC53YXJuX2lmX2J1Z19taXNzaW5nX2luX3Rlc3RfZXhwZWN0YXRpb25zKToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5OgorICAgICAgICAo Q2hyb21pdW1Qb3J0Lndhcm5faWZfYnVnX21pc3NpbmdfaW5fdGVzdF9leHBlY3RhdGlvbnMpOgor CisyMDEyLTA5LTI2ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAg ICAgIG1vZGlmeSBvbGQtcnVuLXdlYmtpdC10ZXN0cyB0byBzdXBwb3J0IFRlc3RFeHBlY3RhdGlv bnMgZmlsZXMgYSBsaXR0bGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk3Mjc2CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQppbmRleCA0MmI1 MThmN2ZiODk1MzczNzc2YzRiYTVkM2NiZGFiYTMzNTgzMGRiLi5hNjExM2ZjZjA4YTRiMjZlYTZh ODk2ZDc0NTBjNGYwYTU3NmIwMjY3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CkBA IC0xNTUsNyArMTU1LDcgQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9uUGFyc2VyKG9iamVjdCk6CiAg ICAgICAgICAgICBlbHNlOgogICAgICAgICAgICAgICAgIHBhcnNlZF9zcGVjaWZpZXJzLmFkZCht b2RpZmllcikKIAotICAgICAgICBpZiBub3QgZXhwZWN0YXRpb25fbGluZS5wYXJzZWRfYnVnX21v ZGlmaWVycyBhbmQgbm90IGhhc193b250Zml4IGFuZCBub3QgaGFzX2J1Z2lkOgorICAgICAgICBp ZiBub3QgZXhwZWN0YXRpb25fbGluZS5wYXJzZWRfYnVnX21vZGlmaWVycyBhbmQgbm90IGhhc193 b250Zml4IGFuZCBub3QgaGFzX2J1Z2lkIGFuZCBzZWxmLl9wb3J0Lndhcm5faWZfYnVnX21pc3Np bmdfaW5fdGVzdF9leHBlY3RhdGlvbnMoKToKICAgICAgICAgICAgIGV4cGVjdGF0aW9uX2xpbmUu d2FybmluZ3MuYXBwZW5kKHNlbGYuTUlTU0lOR19CVUdfV0FSTklORykKIAogICAgICAgICBpZiBz ZWxmLl9hbGxvd19yZWJhc2VsaW5lX21vZGlmaWVyIGFuZCBzZWxmLlJFQkFTRUxJTkVfTU9ESUZJ RVIgaW4gbW9kaWZpZXJzOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zX3VuaXR0 ZXN0LnB5CmluZGV4IGM1NjA2MDcxZDY5MWIzMGZmMDQyYzFiMTIyMzVjMDFmYWYyYzVhY2QuLjUx NGNhZDA2OTEyN2FkODUxNjRjOTExODAyYWVlZjNkZjFkN2I2YjggMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2Rl bHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkKQEAgLTE3OSw4ICsxNzksNyBAQCBjbGFz cyBNaXNjVGVzdHMoQmFzZSk6CiAgICAgICAgICAgICAgICAgIkJ1Zyhybml3YSkgZGlzYWJsZWQt dGVzdC5odG1sLWRpc2FibGVkIFsgSW1hZ2VPbmx5RmFpbHVyZSBdIiwgaXNfbGludF9tb2RlPVRy dWUpCiAgICAgICAgICAgICBzZWxmLmFzc2VydEZhbHNlKFRydWUsICJQYXJzZUVycm9yIHdhc24n dCByYWlzZWQiKQogICAgICAgICBleGNlcHQgUGFyc2VFcnJvciwgZToKLSAgICAgICAgICAgIHdh cm5pbmdzID0gKCJleHBlY3RhdGlvbnM6MSBUZXN0IGxhY2tzIEJVRyBtb2RpZmllci4gZmFpbHVy ZXMvZXhwZWN0ZWQvdGV4dC5odG1sXG4iCi0gICAgICAgICAgICAgICAgICAgICAgICAiZXhwZWN0 YXRpb25zOjEgVW5yZWNvZ25pemVkIG1vZGlmaWVyICdmb28nIGZhaWx1cmVzL2V4cGVjdGVkL3Rl eHQuaHRtbFxuIgorICAgICAgICAgICAgd2FybmluZ3MgPSAoImV4cGVjdGF0aW9uczoxIFVucmVj b2duaXplZCBtb2RpZmllciAnZm9vJyBmYWlsdXJlcy9leHBlY3RlZC90ZXh0Lmh0bWxcbiIKICAg ICAgICAgICAgICAgICAgICAgICAgICJleHBlY3RhdGlvbnM6MiBQYXRoIGRvZXMgbm90IGV4aXN0 LiBub24tZXhpc3RlbnQtdGVzdC5odG1sIikKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo c3RyKGUpLCB3YXJuaW5ncykKIApAQCAtMzcyLDcgKzM3MSw5IEBAIGNsYXNzIFNlbWFudGljVGVz dHMoQmFzZSk6CiAKICAgICBkZWYgdGVzdF9taXNzaW5nX2J1Z2lkKHNlbGYpOgogICAgICAgICBz ZWxmLnBhcnNlX2V4cCgnZmFpbHVyZXMvZXhwZWN0ZWQvdGV4dC5odG1sIFsgRmFpbHVyZSBdJykK LSAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHNlbGYuX2V4cC5oYXNfd2FybmluZ3MoKSkKKyAgICAg ICAgc2VsZi5hc3NlcnRGYWxzZShzZWxmLl9leHAuaGFzX3dhcm5pbmdzKCkpCisKKyAgICAgICAg c2VsZi5fcG9ydC53YXJuX2lmX2J1Z19taXNzaW5nX2luX3Rlc3RfZXhwZWN0YXRpb25zID0gbGFt YmRhOiBUcnVlCiAKICAgICAgICAgc2VsZi5wYXJzZV9leHAoJ2ZhaWx1cmVzL2V4cGVjdGVkL3Rl eHQuaHRtbCBbIEZhaWx1cmUgXScpCiAgICAgICAgIGxpbmUgPSBzZWxmLl9leHAuX21vZGVsLmdl dF9leHBlY3RhdGlvbl9saW5lKCdmYWlsdXJlcy9leHBlY3RlZC90ZXh0Lmh0bWwnKQpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CmluZGV4IGNk NTcwMzJlOTQyYTYxYzE0NzFlYWIwOTdkYTQyNWE0NzIyNDgyZTUuLjhjYmFmNTNlOTQ3Yzg2NDY1 NjA3MGVmMGE2MzdhZWM4YWU4NDQ1MTMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKQEAgLTE0NSw2ICsxNDUsOSBAQCBjbGFzcyBQb3J0 KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX3Jlc3VsdHNfZGlyZWN0b3J5ID0gTm9uZQogICAgICAg ICBzZWxmLl9yb290X3dhc19zZXQgPSBoYXNhdHRyKG9wdGlvbnMsICdyb290JykgYW5kIG9wdGlv bnMucm9vdAogCisgICAgZGVmIHdhcm5faWZfYnVnX21pc3NpbmdfaW5fdGVzdF9leHBlY3RhdGlv bnMoc2VsZik6CisgICAgICAgIHJldHVybiBGYWxzZQorCiAgICAgZGVmIGFkZGl0aW9uYWxfZHJ0 X2ZsYWcoc2VsZik6CiAgICAgICAgIHJldHVybiBbXQogCkBAIC05OTcsNiArMTAwMCw5IEBAIGNs YXNzIFBvcnQob2JqZWN0KToKICAgICAgICAgIyBzb21lIHBvcnRzIGhhdmUgU2tpcHBlZCBmaWxl cyB3aGljaCBhcmUgcmV0dXJuZWQgYXMgcGFydCBvZiB0ZXN0X2V4cGVjdGF0aW9ucygpLgogICAg ICAgICByZXR1cm4gc2VsZi5fZmlsZXN5c3RlbS5leGlzdHMoc2VsZi5wYXRoX3RvX3Rlc3RfZXhw ZWN0YXRpb25zX2ZpbGUoKSkKIAorICAgIGRlZiB3YXJuX2lmX2J1Z19taXNzaW5nX2luX3Rlc3Rf ZXhwZWN0YXRpb25zKHNlbGYpOgorICAgICAgICByZXR1cm4gRmFsc2UKKwogICAgIGRlZiBleHBl Y3RhdGlvbnNfZGljdChzZWxmKToKICAgICAgICAgIiIiUmV0dXJucyBhbiBPcmRlcmVkRGljdCBv ZiBuYW1lIC0+IGV4cGVjdGF0aW9ucyBzdHJpbmdzLgogICAgICAgICBUaGUgbmFtZXMgYXJlIGV4 cGVjdGVkIHRvIGJlIChidXQgbm90IHJlcXVpcmVkIHRvIGJlKSBwYXRocyBpbiB0aGUgZmlsZXN5 c3RlbS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvY2hyb21pdW0ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Nocm9taXVtLnB5CmluZGV4IDlmODA4MDdlNzA1MDU1Y2JiMWUwZjY4ZWFlOTAwNTBjZjgxZTMz MDAuLjBhMDAzZTVlN2JhYjNkNTRlZGI5ZGQ4OTY0MDRlM2E5ZDJiYjEwZGYgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQpA QCAtMzMyLDYgKzMzMiw5IEBAIGNsYXNzIENocm9taXVtUG9ydChQb3J0KToKICAgICAgICAgJ3dp bl9sYXlvdXRfcmVsJywKICAgICBdKQogCisgICAgZGVmIHdhcm5faWZfYnVnX21pc3NpbmdfaW5f dGVzdF9leHBlY3RhdGlvbnMoc2VsZik6CisgICAgICAgIHJldHVybiBUcnVlCisKICAgICBkZWYg ZXhwZWN0YXRpb25zX2ZpbGVzKHNlbGYpOgogICAgICAgICBwYXRocyA9IFtzZWxmLnBhdGhfdG9f dGVzdF9leHBlY3RhdGlvbnNfZmlsZSgpXQogICAgICAgICBza2lhX2V4cGVjdGF0aW9uc19wYXRo ID0gc2VsZi5wYXRoX2Zyb21fY2hyb21pdW1fYmFzZSgnc2tpYScsICdza2lhX3Rlc3RfZXhwZWN0 YXRpb25zLnR4dCcpCg==