97748 2012-09-26 18:31:12 -0700 testRunner.setFrameFlatteningEnabled only affects the main frame, not nested frames 2012-09-27 19:15:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 simon.fraser webkit-unassigned abarth kenneth simon.fraser oldest_to_newest 729124 0 simon.fraser 2012-09-26 18:31:12 -0700 I was trying to figure out why a frame flattening test didn't behave as I expected. It turns out that testRunner.setFrameFlatteningEnabled(true); only affects the main frame, not nested frames. This makes it impossible to use to compare with mobile devices which set that everywhere. Maybe testRunner.settings should always "go deep"? 729187 1 abarth 2012-09-26 21:25:12 -0700 testRunner.settings should change WebCore::Settings, which is per-page. I haven't looked into setFrameFlatteningEnabled, so I don't know what that does. 729294 2 kenneth 2012-09-27 00:55:22 -0700 frame flattening kind of only makes sense if it is applied everywhere, thus also for nested frames, so it makes sense that that setting goes deep. Is it already inherited by new frames after the setting has been set? 729574 3 simon.fraser 2012-09-27 09:01:03 -0700 I may have made a hasty assumption here. Will debug more this afternoon. 729605 4 ap 2012-09-27 09:28:40 -0700 Renaming to match bug description for now. I agree with Adam, original title does not seem accurate. 729780 5 simon.fraser 2012-09-27 12:45:51 -0700 I'm debugging a test that navigates. m_frameFlatteningEnabled is false on the Page's Settings, but I'm not sure how it gets that way. 730120 6 simon.fraser 2012-09-27 19:15:17 -0700 I was confused. See bug 97841 for what I was investigating.