97745 2012-09-26 17:52:08 -0700 [Cairo] Unnecessary creation of ShareableBitmap's for directly composited images 2012-09-27 12:44:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 helder.correia webkit-unassigned mrobinson noam webkit.review.bot oldest_to_newest 729105 0 helder.correia 2012-09-26 17:52:08 -0700 In LayerTreeCoordinator::adoptImageBackingStore(), there is a PLATFORM(QT) code path to check for identical images, but nothing is done for Cairo, which results in the occurrence of avoidable resource allocations. The issue happens in e.g. http://www.webkit.org/blog-files/leaves/, where there are many leaves flying around while they're produced out of only four bitmaps. 729113 1 165908 helder.correia 2012-09-26 18:12:13 -0700 Created attachment 165908 Patch 729777 2 165908 webkit.review.bot 2012-09-27 12:44:14 -0700 Comment on attachment 165908 Patch Clearing flags on attachment: 165908 Committed r129791: <http://trac.webkit.org/changeset/129791> 729778 3 webkit.review.bot 2012-09-27 12:44:17 -0700 All reviewed patches have been landed. Closing bug. 165908 2012-09-26 18:12:13 -0700 2012-09-27 12:44:14 -0700 Patch bug-97745-20120926181132.patch text/plain 3215 helder.correia U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2JjODVkY2RhNDJkYjVm OWFmMzUwYzYwOWRlMWY4ODJiYmNhNjFhNS4uMTExYjZhNmU1ZDQ4ZTNhMjVhOWZkYmY3OGU0ODYw ZTMzMTdhYjkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTA5LTI2ICBIZWxk ZXIgQ29ycmVpYSAgPGhlbGRlci5jb3JyZWlhQG5va2lhLmNvbT4KKworICAgICAgICBbQ2Fpcm9d IFVubmVjZXNzYXJ5IGNyZWF0aW9uIG9mIFNoYXJlYWJsZUJpdG1hcCdzIGZvciBkaXJlY3RseSBj b21wb3NpdGVkIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTc3NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJbiBMYXllclRyZWVDb29yZGluYXRvcjo6YWRvcHRJbWFnZUJhY2tpbmdTdG9yZSgp LCB0aGVyZSBpcyBhCisgICAgICAgIFBMQVRGT1JNKFFUKSBjb2RlIHBhdGggdG8gY2hlY2sgZm9y IGlkZW50aWNhbCBpbWFnZXMsIGJ1dCBub3RoaW5nIGlzCisgICAgICAgIGRvbmUgZm9yIENhaXJv LCB3aGljaCByZXN1bHRzIGluIHRoZSBvY2N1cnJlbmNlIG9mIGF2b2lkYWJsZSByZXNvdXJjZQor ICAgICAgICBhbGxvY2F0aW9ucy4KKworICAgICAgICBUaGUgaXNzdWUgaGFwcGVucyBpbiBlLmcu IGh0dHA6Ly93d3cud2Via2l0Lm9yZy9ibG9nLWZpbGVzL2xlYXZlcy8sCisgICAgICAgIHdoZXJl IHRoZXJlIGFyZSBtYW55IGxlYXZlcyBmbHlpbmcgYXJvdW5kIHdoaWxlIHRoZXkncmUgcHJvZHVj ZWQgb3V0IG9mCisgICAgICAgIG9ubHkgZm91ciBiaXRtYXBzLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggdXNlcyBwb2ludGVycyB0byBjYWlyb19zdXJmYWNlX3QncyBhcyB0aGUga2V5IHRvIHRoZSBo YXNobWFwCisgICAgICAgIHRoYXQgY2FjaGVzIGJpdG1hcHMuIFRoaXMgY2FuIGJlIHNhZmVseSBk b25lIHNpbmNlIHdlIG93biB0aGUgcmVmZXJlbmNlcy4KKyAgICAgICAgV2UgYXJ0aWZpY2lhbGx5 IGluY3JlbWVudCB0aGUgc3VyZmFjZSByZWZlcmVuY2VzIGluIGFkb3B0SW1hZ2VCYWNraW5nU3Rv cmUoKQorICAgICAgICBhbmQgZGVjcmVtZW50IHRoZW0gaW4gcmVsZWFzZUltYWdlQmFja2luZ1N0 b3JlKCkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGlj cy9MYXllclRyZWVDb29yZGluYXRvci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZUNv b3JkaW5hdG9yOjphZG9wdEltYWdlQmFja2luZ1N0b3JlKToKKyAgICAgICAgKFdlYktpdDo6TGF5 ZXJUcmVlQ29vcmRpbmF0b3I6OnJlbGVhc2VJbWFnZUJhY2tpbmdTdG9yZSk6CisKIDIwMTItMDkt MjQgIEJ5dW5nd29vIExlZSAgPGJ3ODAubGVlQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxd W1dLMl0gQ2hhbmdlIHRoZSBpbnN0YWxsIHBhdGggZm9yIGxpYmV3azJVbml0VGVzdEluamVjdGVk QnVuZGxlU2FtcGxlLnNvLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuY3BwIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJU cmVlQ29vcmRpbmF0b3IuY3BwCmluZGV4IGQ5NzlhZDcxYzlhMGU1ZGM4NGM0ZmZlZDc4MTAxYjZm MmY5MDdjMjguLmIwYzhjZTNjNDEyZDQ4YmM0MjEwMGMwYzliOTk1YjI1OThhMWRhZDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBo aWNzL0xheWVyVHJlZUNvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVDb29yZGluYXRvci5jcHAK QEAgLTQ1NCw2ICs0NTQsMTQgQEAgaW50NjRfdCBMYXllclRyZWVDb29yZGluYXRvcjo6YWRvcHRJ bWFnZUJhY2tpbmdTdG9yZShJbWFnZSogaW1hZ2UpCiAgICAgICAgIHJldHVybiBJbnZhbGlkV2Vi TGF5ZXJJRDsKIAogICAgIGtleSA9IG5hdGl2ZUltYWdlLT5jYWNoZUtleSgpOworI2VsaWYgVVNF KENBSVJPKQorICAgIE5hdGl2ZUltYWdlQ2Fpcm8qIG5hdGl2ZUltYWdlID0gaW1hZ2UtPm5hdGl2 ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7CisgICAgaWYgKCFuYXRpdmVJbWFnZSkKKyAgICAgICAg cmV0dXJuIEludmFsaWRXZWJMYXllcklEOworICAgIC8vIFRoaXMgY2FuIGJlIHNhZmVseSBkb25l IHNpbmNlIHdlIG93biB0aGUgcmVmZXJlbmNlLgorICAgIC8vIEEgY29ycmVzcG9uZGluZyBjYWly b19zdXJmYWNlX2Rlc3Ryb3koKSBpcyBlbnN1cmVkIGluIHJlbGVhc2VJbWFnZUJhY2tpbmdTdG9y ZSgpLgorICAgIGNhaXJvX3N1cmZhY2VfdCogY2Fpcm9TdXJmYWNlID0gY2Fpcm9fc3VyZmFjZV9y ZWZlcmVuY2UobmF0aXZlSW1hZ2UtPnN1cmZhY2UoKSk7CisgICAga2V5ID0gcmVpbnRlcnByZXRf Y2FzdDxpbnQ2NF90PihjYWlyb1N1cmZhY2UpOwogI2VuZGlmCiAKICAgICBIYXNoTWFwPGludDY0 X3QsIGludD46Oml0ZXJhdG9yIGl0ID0gbV9kaXJlY3RseUNvbXBvc2l0ZWRJbWFnZVJlZkNvdW50 cy5maW5kKGtleSk7CkBAIC00OTAsNiArNDk4LDExIEBAIHZvaWQgTGF5ZXJUcmVlQ29vcmRpbmF0 b3I6OnJlbGVhc2VJbWFnZUJhY2tpbmdTdG9yZShpbnQ2NF90IGtleSkKICAgICAgICAgcmV0dXJu OwogCiAgICAgbV9kaXJlY3RseUNvbXBvc2l0ZWRJbWFnZVJlZkNvdW50cy5yZW1vdmUoaXQpOwor I2lmIFVTRShDQUlSTykKKyAgICAvLyBDb21wbGVtZW50IHRoZSByZWZlcmVuY2luZyBpbiBhZG9w dEltYWdlQmFja2luZ1N0b3JlKCkuCisgICAgY2Fpcm9fc3VyZmFjZV90KiBjYWlyb1N1cmZhY2Ug PSByZWludGVycHJldF9jYXN0PGNhaXJvX3N1cmZhY2VfdCo+KGtleSk7CisgICAgY2Fpcm9fc3Vy ZmFjZV9kZXN0cm95KGNhaXJvU3VyZmFjZSk7CisjZW5kaWYKICAgICBtX3dlYlBhZ2UtPnNlbmQo TWVzc2FnZXM6OkxheWVyVHJlZUNvb3JkaW5hdG9yUHJveHk6OkRlc3Ryb3lEaXJlY3RseUNvbXBv c2l0ZWRJbWFnZShrZXkpKTsKIH0KIAo=