97734 2012-09-26 15:35:54 -0700 Proxy all the things! 2012-09-26 17:25:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough bdakin oliver oldest_to_newest 729022 0 barraclough 2012-09-26 15:35:54 -0700 To match WebCore's window shell. 729026 1 165886 barraclough 2012-09-26 15:39:15 -0700 Created attachment 165886 Fix 729032 2 barraclough 2012-09-26 15:50:13 -0700 Fixed in r129711 729095 3 bdakin 2012-09-26 17:25:26 -0700 It looks like this change broke the Windows build. Here is the relevant output: 14>####### COMPILING 1 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ########### 14>jsc.cpp 14>Performing Pre-Link Event... 14> 1 file(s) copied. 14> 1 file(s) copied. 14> 1 file(s) copied. 14> 1 file(s) copied. 14>Linking... 14>jsc.obj : error LNK2019: unresolved external symbol "protected: void __thiscall JSC::JSGlobalObject::setGlobalThis(class JSC::JSGlobalData &,class JSC::JSObject *)" (?setGlobalThis@JSGlobalObject@JSC@@IAEXAAVJSGlobalData@2@PAVJSObject@2@@Z) referenced in function "public: static class GlobalObject * __cdecl GlobalObject::create(class JSC::JSGlobalData &,class JSC::Structure *,class WTF::Vector<class WTF::String,0> const &)" (?create@GlobalObject@@SAPAV1@AAVJSGlobalData@JSC@@PAVStructure@3@ABV?$Vector@VString@WTF@@$0A@@WTF@@@Z) 14>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\jsc.exe : fatal error LNK1120: 1 unresolved externals 14>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj\jsc\BuildLog.htm" 14>jsc - 2 error(s), 0 warning(s) 165886 2012-09-26 15:39:15 -0700 2012-09-26 15:42:37 -0700 Fix 97734.patch text/plain 4648 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI5NzEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDEyLTA5LTI2ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBQcm94eSB0aGUgZ2xvYmFsIHRoaXMgaW4gSlNDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzczNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmluZyBqc2MgZGl2ZXJnZSBmcm9tIFdl YkNvcmUgaGVyZSBpcyBub3QgYmVuZWZpY2lhbDsgaXQgcG90ZW50aWFsbHkgbWFza3MgYnVncyBh bmQvb3IgcGVyZm9ybWFuY2UKKyAgICAgICAgcHJvYmxlbXMgZnJvbSBjb21tYW5kIGxpbmUgdGVz dGluZy4KKworICAgICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFuZ2Ugc3Vj aCBhcyBhcHByb2FjaCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1mdW5jdGlvbiBkZXNjcmlw dGlvbnMgYmVsb3cgKE9PUFMhKS4KKworICAgICAgICAqIGpzYy5jcHA6CisgICAgICAgIChHbG9i YWxPYmplY3Q6OmNyZWF0ZSk6CisgICAgICAgICAgICAtIENyZWF0ZSBhIHRoaXMgdmFsdWUgcHJv eHkgZm9yIHRoZSBnbG9iYWwgb2JqZWN0LgorICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxPYmpl Y3QuaDoKKyAgICAgICAgKEpTR2xvYmFsT2JqZWN0KToKKyAgICAgICAgICAgIC0gTWFrZSBzZXRH bG9iYWxUaGlzIHByb3RlY3RlZC4KKyAgICAgICAgKiBydW50aW1lL0pTUHJveHkuaDoKKyAgICAg ICAgKEpTQzo6SlNQcm94eTo6Y3JlYXRlKToKKyAgICAgICAgKEpTQzo6SlNQcm94eTo6dGFyZ2V0 KToKKyAgICAgICAgKEpTQzo6SlNQcm94eTo6ZmluaXNoQ3JlYXRpb24pOgorICAgICAgICAoSlNQ cm94eSk6CisgICAgICAgICAgICAtIEFsbG93IHByb3h5IHRhcmdldCB0byBiZSBhIEpTT2JqZWN0 LCBhZGQgdGFyZ2V0IHRvIGNyZWF0ZSBtZXRob2QuCisKIDIwMTItMDktMjYgIEdhdmluIEJhcnJh Y2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFNwZWN1bGF0aXZlIFdp bmRvd3MgYnVpbGQgZml4LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlzaW9uIDEyOTY5 NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z Myw2ICszMyw3IEBACiAjaW5jbHVkZSAiSlNDVHlwZWRBcnJheVN0dWJzLmgiCiAjaW5jbHVkZSAi SlNGdW5jdGlvbi5oIgogI2luY2x1ZGUgIkpTTG9jay5oIgorI2luY2x1ZGUgIkpTUHJveHkuaCIK ICNpbmNsdWRlICJKU1N0cmluZy5oIgogI2luY2x1ZGUgIlNhbXBsaW5nVG9vbC5oIgogI2luY2x1 ZGUgPG1hdGguaD4KQEAgLTE3Niw2ICsxNzcsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBH bG9iYWxPYmplY3QqIG9iamVjdCA9IG5ldyAoTm90TnVsbCwgYWxsb2NhdGVDZWxsPEdsb2JhbE9i amVjdD4oZ2xvYmFsRGF0YS5oZWFwKSkgR2xvYmFsT2JqZWN0KGdsb2JhbERhdGEsIHN0cnVjdHVy ZSk7CiAgICAgICAgIG9iamVjdC0+ZmluaXNoQ3JlYXRpb24oZ2xvYmFsRGF0YSwgYXJndW1lbnRz KTsKKyAgICAgICAgb2JqZWN0LT5zZXRHbG9iYWxUaGlzKGdsb2JhbERhdGEsIEpTUHJveHk6OmNy ZWF0ZShnbG9iYWxEYXRhLCBKU1Byb3h5OjpjcmVhdGVTdHJ1Y3R1cmUoZ2xvYmFsRGF0YSwgb2Jq ZWN0KSwgb2JqZWN0KSk7CiAgICAgICAgIHJldHVybiBvYmplY3Q7CiAgICAgfQogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmgJKHJldmlz aW9uIDEyOTY5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2Jq ZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTM2NywxMyArMzY3LDE0IEBAIG5hbWVzcGFjZSBKU0Mg ewogCiAgICAgICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyBKU0M6OkpTT2JqZWN0KiB0b1Ro aXNPYmplY3QoSlNDOjpKU0NlbGwqLCBKU0M6OkV4ZWNTdGF0ZSopOwogCisgICAgICAgIEpTX0VY UE9SVF9QUklWQVRFIHZvaWQgc2V0R2xvYmFsVGhpcyhKU0dsb2JhbERhdGEmLCBKU09iamVjdCog Z2xvYmFsVGhpcyk7CisKICAgICBwcml2YXRlOgogICAgICAgICBmcmllbmQgY2xhc3MgTExJbnRP ZmZzZXRzRXh0cmFjdG9yOwogICAgICAgICAKICAgICAgICAgLy8gRklYTUU6IEZvbGQgcmVzZXQg aW50byBpbml0LgogICAgICAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGluaXQoSlNPYmplY3Qq IHRoaXNWYWx1ZSk7CiAgICAgICAgIHZvaWQgcmVzZXQoSlNWYWx1ZSBwcm90b3R5cGUpOwotICAg ICAgICB2b2lkIHNldEdsb2JhbFRoaXMoSlNHbG9iYWxEYXRhJiwgSlNPYmplY3QqIGdsb2JhbFRo aXMpOwogCiAgICAgICAgIHZvaWQgY3JlYXRlVGhyb3dUeXBlRXJyb3IoRXhlY1N0YXRlKik7CiAK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTUHJveHkuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb3h5LmgJKHJldmlzaW9uIDEy OTY5NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTUHJveHkuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzQsMTAgKzM0LDEwIEBAIGNsYXNzIEpTUHJveHkgOiBwdWJsaWMgSlNOb25G aW5hbE9iamVjdCAKIHB1YmxpYzoKICAgICB0eXBlZGVmIEpTTm9uRmluYWxPYmplY3QgQmFzZTsK IAotICAgIHN0YXRpYyBKU1Byb3h5KiBjcmVhdGUoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBT dHJ1Y3R1cmUqIHN0cnVjdHVyZSkKKyAgICBzdGF0aWMgSlNQcm94eSogY3JlYXRlKEpTR2xvYmFs RGF0YSYgZ2xvYmFsRGF0YSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIEpTT2JqZWN0KiB0YXJnZXQp CiAgICAgewogICAgICAgICBKU1Byb3h5KiBwcm94eSA9IG5ldyAoTm90TnVsbCwgYWxsb2NhdGVD ZWxsPEpTUHJveHk+KGdsb2JhbERhdGEuaGVhcCkpIEpTUHJveHkoZ2xvYmFsRGF0YSwgc3RydWN0 dXJlKTsKLSAgICAgICAgcHJveHktPmZpbmlzaENyZWF0aW9uKGdsb2JhbERhdGEpOworICAgICAg ICBwcm94eS0+ZmluaXNoQ3JlYXRpb24oZ2xvYmFsRGF0YSwgdGFyZ2V0KTsKICAgICAgICAgcmV0 dXJuIHByb3h5OwogICAgIH0KIApAQCAtNDgsNyArNDgsNyBAQCBwdWJsaWM6CiAKICAgICBzdGF0 aWMgSlNfRVhQT1JUREFUQSBjb25zdCBDbGFzc0luZm8gc19pbmZvOwogCi0gICAgSlNHbG9iYWxP YmplY3QqIHRhcmdldCgpIGNvbnN0IHsgcmV0dXJuIG1fdGFyZ2V0LmdldCgpOyB9CisgICAgSlNP YmplY3QqIHRhcmdldCgpIGNvbnN0IHsgcmV0dXJuIG1fdGFyZ2V0LmdldCgpOyB9CiAKIHByb3Rl Y3RlZDoKICAgICBKU1Byb3h5KEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgU3RydWN0dXJlKiBz dHJ1Y3R1cmUpCkBAIC02MSw2ICs2MSwxMiBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIEJhc2U6OmZp bmlzaENyZWF0aW9uKGdsb2JhbERhdGEpOwogICAgIH0KIAorICAgIHZvaWQgZmluaXNoQ3JlYXRp b24oSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBKU09iamVjdCogdGFyZ2V0KQorICAgIHsKKyAg ICAgICAgQmFzZTo6ZmluaXNoQ3JlYXRpb24oZ2xvYmFsRGF0YSk7CisgICAgICAgIG1fdGFyZ2V0 LnNldChnbG9iYWxEYXRhLCB0aGlzLCB0YXJnZXQpOworICAgIH0KKwogICAgIHN0YXRpYyBjb25z dCB1bnNpZ25lZCBTdHJ1Y3R1cmVGbGFncyA9IE92ZXJyaWRlc1Zpc2l0Q2hpbGRyZW4gfCBPdmVy cmlkZXNHZXRPd25Qcm9wZXJ0eVNsb3QgfCBPdmVycmlkZXNHZXRQcm9wZXJ0eU5hbWVzIHwgQmFz ZTo6U3RydWN0dXJlRmxhZ3M7CiAKICAgICBKU19FWFBPUlRfUFJJVkFURSBzdGF0aWMgdm9pZCB2 aXNpdENoaWxkcmVuKEpTQ2VsbCosIFNsb3RWaXNpdG9yJik7CkBAIC04MSw3ICs4Nyw3IEBAIHBy b3RlY3RlZDoKICAgICBKU19FWFBPUlRfUFJJVkFURSBzdGF0aWMgYm9vbCBkZWZpbmVPd25Qcm9w ZXJ0eShKU09iamVjdCosIEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgUHJvcGVydHlEZXNjcmlw dG9yJiwgYm9vbCBzaG91bGRUaHJvdyk7CiAKIHByaXZhdGU6Ci0gICAgV3JpdGVCYXJyaWVyPEpT R2xvYmFsT2JqZWN0PiBtX3RhcmdldDsKKyAgICBXcml0ZUJhcnJpZXI8SlNPYmplY3Q+IG1fdGFy Z2V0OwogfTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==