97733 2012-09-26 15:19:39 -0700 ApplicationCacheStorage does not optimilay handle 8 bit strings 2022-02-28 03:43:24 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff japhet webkit.review.bot oldest_to_newest 729013 0 msaboff 2012-09-26 15:19:39 -0700 I several places, ApplicationCacheStorage calls characters() on strings, which will up convert an 8 bit string to 16 bits. 729038 1 165890 msaboff 2012-09-26 16:02:07 -0700 Created attachment 165890 Patch 729696 2 165890 darin 2012-09-27 10:51:37 -0700 Comment on attachment 165890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165890&action=review > Source/WebCore/ChangeLog:3 > + ApplicationCacheStorage does not properly handle 8 bit strings In the future for patches like this I suggest more precise phrasing, because the code did correctly work if passed 8 bit strings before. I’d say something more like “converts 8-bit strings into 16-bit unnecessarily” or mention performance. The phrase “does not properly handle” sounds like we’ll get incorrect results, but this patch is about performance optimization, not correctness. 729759 3 msaboff 2012-09-27 12:04:44 -0700 Committed r129786: <http://trac.webkit.org/changeset/129786> 165890 2012-09-26 16:02:07 -0700 2022-02-28 03:43:24 -0800 Patch 97733.patch text/plain 3928 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTcxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI2ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEFwcGxpY2F0aW9uQ2FjaGVT dG9yYWdlIGRvZXMgbm90IHByb3Blcmx5IGhhbmRsZSA4IGJpdCBzdHJpbmdzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzczMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIDggYml0IHN0cmluZyBw YXRocy4KKworICAgICAgICBObyBmdW5jdGlvbmFsIGNoYW5nZSwgdGhlcmVmb3JlIG5vIG5ldyB0 ZXN0cy4KKworICAgICAgICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlU3RvcmFn ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp1cmxIb3N0SGFzaCk6CisgICAgICAgIChXZWJDb3Jl OjpBcHBsaWNhdGlvbkNhY2hlU3RvcmFnZTo6c3RvcmUpOgorICAgICAgICAoV2ViQ29yZTo6cGFy c2VIZWFkZXIpOgorICAgICAgICAoV2ViQ29yZTo6cGFyc2VIZWFkZXJzKToKKwogMjAxMi0wOS0y NiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5h bWUgUGFnZTo6ZnJhbWVDb3VudCgpIHRvIHN1YmZyYW1lQ291bnQoKSwgYW5kIHJlbGF0ZWQKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlU3RvcmFn ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxp Y2F0aW9uQ2FjaGVTdG9yYWdlLmNwcAkocmV2aXNpb24gMTI5Njc2KQorKysgU291cmNlL1dlYkNv cmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtOTEsOCArOTEsMTMgQEAgc3RhdGljIHVuc2lnbmVkIHVybEhvc3RIYXNoKGNvbnN0 IEtVUkwmIAogewogICAgIHVuc2lnbmVkIGhvc3RTdGFydCA9IHVybC5ob3N0U3RhcnQoKTsKICAg ICB1bnNpZ25lZCBob3N0RW5kID0gdXJsLmhvc3RFbmQoKTsKKworICAgIGNvbnN0IFN0cmluZyYg dXJsU3RyaW5nID0gdXJsLnN0cmluZygpOworCisgICAgaWYgKHVybFN0cmluZy5pczhCaXQoKSkK KyAgICAgICAgcmV0dXJuIEFscmVhZHlIYXNoZWQ6OmF2b2lkRGVsZXRlZFZhbHVlKFN0cmluZ0hh c2hlcjo6Y29tcHV0ZUhhc2hBbmRNYXNrVG9wOEJpdHModXJsU3RyaW5nLmNoYXJhY3RlcnM4KCkg KyBob3N0U3RhcnQsIGhvc3RFbmQgLSBob3N0U3RhcnQpKTsKICAgICAKLSAgICByZXR1cm4gQWxy ZWFkeUhhc2hlZDo6YXZvaWREZWxldGVkVmFsdWUoU3RyaW5nSGFzaGVyOjpjb21wdXRlSGFzaEFu ZE1hc2tUb3A4Qml0cyh1cmwuc3RyaW5nKCkuY2hhcmFjdGVycygpICsgaG9zdFN0YXJ0LCBob3N0 RW5kIC0gaG9zdFN0YXJ0KSk7CisgICAgcmV0dXJuIEFscmVhZHlIYXNoZWQ6OmF2b2lkRGVsZXRl ZFZhbHVlKFN0cmluZ0hhc2hlcjo6Y29tcHV0ZUhhc2hBbmRNYXNrVG9wOEJpdHModXJsU3RyaW5n LmNoYXJhY3RlcnMxNigpICsgaG9zdFN0YXJ0LCBob3N0RW5kIC0gaG9zdFN0YXJ0KSk7CiB9CiAK IEFwcGxpY2F0aW9uQ2FjaGVHcm91cCogQXBwbGljYXRpb25DYWNoZVN0b3JhZ2U6OmxvYWRDYWNo ZUdyb3VwKGNvbnN0IEtVUkwmIG1hbmlmZXN0VVJMKQpAQCAtODQwLDkgKzg0NSw5IEBAIGJvb2wg QXBwbGljYXRpb25DYWNoZVN0b3JhZ2U6OnN0b3JlKEFwcGwKICAgICBIVFRQSGVhZGVyTWFwOjpj b25zdF9pdGVyYXRvciBlbmQgPSByZXNvdXJjZS0+cmVzcG9uc2UoKS5odHRwSGVhZGVyRmllbGRz KCkuZW5kKCk7CiAgICAgZm9yIChIVFRQSGVhZGVyTWFwOjpjb25zdF9pdGVyYXRvciBpdCA9IHJl c291cmNlLT5yZXNwb25zZSgpLmh0dHBIZWFkZXJGaWVsZHMoKS5iZWdpbigpOyBpdCE9IGVuZDsg KytpdCkgewogICAgICAgICBzdHJpbmdCdWlsZGVyLmFwcGVuZChpdC0+Zmlyc3QpOwotICAgICAg ICBzdHJpbmdCdWlsZGVyLmFwcGVuZCgoVUNoYXIpJzonKTsKKyAgICAgICAgc3RyaW5nQnVpbGRl ci5hcHBlbmQoJzonKTsKICAgICAgICAgc3RyaW5nQnVpbGRlci5hcHBlbmQoaXQtPnNlY29uZCk7 Ci0gICAgICAgIHN0cmluZ0J1aWxkZXIuYXBwZW5kKChVQ2hhciknXG4nKTsKKyAgICAgICAgc3Ry aW5nQnVpbGRlci5hcHBlbmQoJ1xuJyk7CiAgICAgfQogICAgIAogICAgIFN0cmluZyBoZWFkZXJz ID0gc3RyaW5nQnVpbGRlci50b1N0cmluZygpOwpAQCAtMTA1Miw3ICsxMDU3LDggQEAgYm9vbCBB cHBsaWNhdGlvbkNhY2hlU3RvcmFnZTo6c3RvcmVOZXdlcwogICAgIHJldHVybiBzdG9yZU5ld2Vz dENhY2hlKGdyb3VwLCAwLCBpZ25vcmVkRmFpbHVyZVJlYXNvbik7CiB9CiAKLXN0YXRpYyBpbmxp bmUgdm9pZCBwYXJzZUhlYWRlcihjb25zdCBVQ2hhciogaGVhZGVyLCBzaXplX3QgaGVhZGVyTGVu Z3RoLCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKK3RlbXBsYXRlIDx0eXBlbmFtZSBDaGFy YWN0ZXJUeXBlPgorc3RhdGljIGlubGluZSB2b2lkIHBhcnNlSGVhZGVyKGNvbnN0IENoYXJhY3Rl clR5cGUqIGhlYWRlciwgc2l6ZV90IGhlYWRlckxlbmd0aCwgUmVzb3VyY2VSZXNwb25zZSYgcmVz cG9uc2UpCiB7CiAgICAgc2l6ZV90IHBvcyA9IGZpbmQoaGVhZGVyLCBoZWFkZXJMZW5ndGgsICc6 Jyk7CiAgICAgQVNTRVJUKHBvcyAhPSBub3RGb3VuZCk7CkBAIC0xMDcwLDEzICsxMDc2LDIwIEBA IHN0YXRpYyBpbmxpbmUgdm9pZCBwYXJzZUhlYWRlcnMoY29uc3QgU3QKICAgICB3aGlsZSAoKGVu ZFBvcyA9IGhlYWRlcnMuZmluZCgnXG4nLCBzdGFydFBvcykpICE9IG5vdEZvdW5kKSB7CiAgICAg ICAgIEFTU0VSVChzdGFydFBvcyAhPSBlbmRQb3MpOwogCi0gICAgICAgIHBhcnNlSGVhZGVyKGhl YWRlcnMuY2hhcmFjdGVycygpICsgc3RhcnRQb3MsIGVuZFBvcyAtIHN0YXJ0UG9zLCByZXNwb25z ZSk7CisgICAgICAgIGlmIChoZWFkZXJzLmlzOEJpdCgpKQorICAgICAgICAgICAgcGFyc2VIZWFk ZXIoaGVhZGVycy5jaGFyYWN0ZXJzOCgpICsgc3RhcnRQb3MsIGVuZFBvcyAtIHN0YXJ0UG9zLCBy ZXNwb25zZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHBhcnNlSGVhZGVyKGhlYWRlcnMu Y2hhcmFjdGVyczE2KCkgKyBzdGFydFBvcywgZW5kUG9zIC0gc3RhcnRQb3MsIHJlc3BvbnNlKTsK ICAgICAgICAgCiAgICAgICAgIHN0YXJ0UG9zID0gZW5kUG9zICsgMTsKICAgICB9CiAgICAgCi0g ICAgaWYgKHN0YXJ0UG9zICE9IGhlYWRlcnMubGVuZ3RoKCkpCi0gICAgICAgIHBhcnNlSGVhZGVy KGhlYWRlcnMuY2hhcmFjdGVycygpLCBoZWFkZXJzLmxlbmd0aCgpLCByZXNwb25zZSk7CisgICAg aWYgKHN0YXJ0UG9zICE9IGhlYWRlcnMubGVuZ3RoKCkpIHsKKyAgICAgICAgaWYgKGhlYWRlcnMu aXM4Qml0KCkpCisgICAgICAgICAgICBwYXJzZUhlYWRlcihoZWFkZXJzLmNoYXJhY3RlcnM4KCks IGhlYWRlcnMubGVuZ3RoKCksIHJlc3BvbnNlKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAg cGFyc2VIZWFkZXIoaGVhZGVycy5jaGFyYWN0ZXJzMTYoKSwgaGVhZGVycy5sZW5ndGgoKSwgcmVz cG9uc2UpOworICAgIH0KIH0KICAgICAKIFBhc3NSZWZQdHI8QXBwbGljYXRpb25DYWNoZT4gQXBw bGljYXRpb25DYWNoZVN0b3JhZ2U6OmxvYWRDYWNoZSh1bnNpZ25lZCBzdG9yYWdlSUQpCg==