97726 2012-09-26 13:41:07 -0700 [WK2] Update WebPageProxy::reattachToWebProcess() for multi-web process mode 2012-09-26 13:54:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap oldest_to_newest 728937 0 ap 2012-09-26 13:41:07 -0700 Currently, it crashes. 728942 1 165871 ap 2012-09-26 13:52:22 -0700 Created attachment 165871 proposed fix 728944 2 ap 2012-09-26 13:53:37 -0700 <rdar://problem/12378445> 728946 3 ap 2012-09-26 13:54:13 -0700 Committed <http://trac.webkit.org/changeset/129701>. 165871 2012-09-26 13:52:22 -0700 2012-09-26 13:53:11 -0700 proposed fix Reattach.txt text/plain 7311 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyOTY5OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBACisyMDEyLTA5LTI2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFVwZGF0ZSBXZWJQ YWdlUHJveHk6OnJlYXR0YWNoVG9XZWJQcm9jZXNzKCkgZm9yIG11bHRpLXdlYiBwcm9jZXNzIG1v ZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NzI2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OmVuc3Vy ZVNoYXJlZFdlYlByb2Nlc3MpOiBjcmVhdGVOZXdXZWJQcm9jZXNzKCkgbm93IHRha2VzIGNhcmUK KyAgICAgICAgb2YgYWRkaW5nIHRoZSBuZXcgcHJvY2VzcyB0byBtX3Byb2Nlc3Nlcy4KKyAgICAg ICAgKFdlYktpdDo6V2ViQ29udGV4dDo6Y3JlYXRlTmV3V2ViUHJvY2Vzcyk6IEV2ZXJ5IHRpbWUg d2UgY2FsbCB0aGlzIGZ1bmN0aW9uLCB3ZSBuZWVkCisgICAgICAgIHRvIGFkZCB0aGUgcmVzdWx0 IHRvIG1fcHJvY2Vzc2VzLiBCZXR0ZXIgZG8gaXQgaW50ZXJuYWxseSB0byBhdm9pZCBtaXN0YWtl cy4KKyAgICAgICAgKFdlYktpdDo6V2ViQ29udGV4dDo6d2FybUluaXRpYWxQcm9jZXNzKTogVXBk YXRlZCBmb3IgdGhlIGFib3ZlLgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0OjpjcmVhdGVX ZWJQYWdlKTogRGl0dG8uCisgICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6OnJlbGF1bmNoUHJv Y2Vzc0lmTmVjZXNzYXJ5KTogVGhpcyBmdW5jdGlvbiBtYWtlcyBubyBzZW5zZSBpbgorICAgICAg ICBtdWx0aS13ZWIgcHJvY2VzcyBtb2RlLiBBc3NlcnQgdGhhdCB3ZSBkaWRudCBnZXQgaGVyZSBh Y2NpZGVudGFsbHkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5oOiAoV2ViS2l0 OjpXZWJDb250ZXh0OjpzZW5kVG9BbGxQcm9jZXNzZXNSZWxhdW5jaGluZ1RoZW1JZk5lY2Vzc2Fy eSk6CisgICAgICAgIE9ubHkgY2FsbCByZWxhdW5jaFByb2Nlc3NJZk5lY2Vzc2FyeSBpbiBzaW5n bGUgcHJvY2VzcyBtb2RlLiBUaGUgZnVuY3Rpb25hbGl0eSB0aGF0CisgICAgICAgIG5lZWRzIHRo aXMgYmVoYXZpb3Igd2lsbCBiZSBncmVhdGx5IHJlZmFjdG9yZWQgZm9yIG11bHRpLXdlYiBwcm9j ZXNzLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6IChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6cmVhdHRhY2hUb1dlYlByb2Nlc3MpOgorICAgICAgICBXZSBhbHJlYWR5IGtu b3cgdGhhdCB3ZSBuZWVkIGEgbmV3IHByb2Nlc3MsICJyZWxhdW5jaCBpZiBuZWNlc3NhcnkiIGlz IG5vdCB0aGUKKyAgICAgICAgcmlnaHQgbG9naWMuIEFsc28gYWRkZWQgYSBmZXcgbW9yZSBhc3Nl cnRpb25zIGNoZWNraW5nIHRoYXQgcHJvY2VzcyBzdGF0ZSBpcworICAgICAgICBhcyBleHBlY3Rl ZC4KKyAgICAgICAgCisgICAgICAgICogVUlQcm9jZXNzL1dlYlJlc291cmNlQ2FjaGVNYW5hZ2Vy UHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZUNhY2hlTWFuYWdlclByb3h5 OjpnZXRDYWNoZU9yaWdpbnMpOiBSZW1vdmVkIHJlbGF1bmNoUHJvY2Vzc0lmTmVjZXNzYXJ5KCku CisgICAgICAgIEl0IHdpbGwgYmUgY2FsbGVkIGluc2lkZSBzZW5kVG9BbGxQcm9jZXNzZXNSZWxh dW5jaGluZ1RoZW1JZk5lY2Vzc2FyeSgpLgorCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdpbnMv V2ViUGx1Z2luU2l0ZURhdGFNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z2lu U2l0ZURhdGFNYW5hZ2VyOjpnZXRTaXRlc1dpdGhEYXRhKTogRGl0dG8uCisgICAgICAgIChXZWJL aXQ6OldlYlBsdWdpblNpdGVEYXRhTWFuYWdlcjo6Y2xlYXJTaXRlRGF0YSk6IERpdHRvLgorCiAy MDEyLTA5LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBEb24ndCB1c2UgdGhlIEMgQVBJIGludGVybmFsbHkgaW4gV2ViS2l0SmF2 YXNjcmlwdFJlc3VsdApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNw cAkocmV2aXNpb24gMTI5Njc1KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRl eHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDQsNyArMzA0LDcgQEAgdm9pZCBXZWJDb250ZXh0 Ojp0ZXh0Q2hlY2tlclN0YXRlQ2hhbmdlZAogdm9pZCBXZWJDb250ZXh0OjplbnN1cmVTaGFyZWRX ZWJQcm9jZXNzKCkKIHsKICAgICBpZiAobV9wcm9jZXNzZXMuaXNFbXB0eSgpKQotICAgICAgICBt X3Byb2Nlc3Nlcy5hcHBlbmQoY3JlYXRlTmV3V2ViUHJvY2VzcygpKTsKKyAgICAgICAgY3JlYXRl TmV3V2ViUHJvY2VzcygpOwogfQogCiBQYXNzUmVmUHRyPFdlYlByb2Nlc3NQcm94eT4gV2ViQ29u dGV4dDo6Y3JlYXRlTmV3V2ViUHJvY2VzcygpCkBAIC0zNjYsNiArMzY2LDggQEAgUGFzc1JlZlB0 cjxXZWJQcm9jZXNzUHJveHk+IFdlYkNvbnRleHQ6OgogICAgICAgICBpbmplY3RlZEJ1bmRsZUlu aXRpYWxpemF0aW9uVXNlckRhdGEgPSBtX2luamVjdGVkQnVuZGxlSW5pdGlhbGl6YXRpb25Vc2Vy RGF0YTsKICAgICBwcm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpXZWJQcm9jZXNzOjpJbml0aWFsaXpl V2ViUHJvY2VzcyhwYXJhbWV0ZXJzLCBXZWJDb250ZXh0VXNlck1lc3NhZ2VFbmNvZGVyKGluamVj dGVkQnVuZGxlSW5pdGlhbGl6YXRpb25Vc2VyRGF0YS5nZXQoKSkpLCAwKTsKIAorICAgIG1fcHJv Y2Vzc2VzLmFwcGVuZChwcm9jZXNzKTsKKwogICAgIHJldHVybiBwcm9jZXNzLnJlbGVhc2UoKTsK IH0KIApAQCAtMzc2LDcgKzM3OCw3IEBAIHZvaWQgV2ViQ29udGV4dDo6d2FybUluaXRpYWxQcm9j ZXNzKCkgIAogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9wcm9jZXNzZXMuYXBwZW5k KGNyZWF0ZU5ld1dlYlByb2Nlc3MoKSk7CisgICAgY3JlYXRlTmV3V2ViUHJvY2VzcygpOwogICAg IG1faGF2ZUluaXRpYWxFbXB0eVByb2Nlc3MgPSB0cnVlOwogfQogCkBAIC01MTQsNyArNTE2LDYg QEAgUGFzc1JlZlB0cjxXZWJQYWdlUHJveHk+IFdlYkNvbnRleHQ6OmNyZQogICAgICAgICB9IGVs c2UgewogICAgICAgICAgICAgLy8gRklYTUUgKE11bHRpLVdlYlByb2Nlc3MpOiA8cmRhcjovL3By b2JsZW0vMTIyMzk2NjE+IENvbnNpZGVyIGxpbWl0aW5nIHRoZSBudW1iZXIgb2Ygd2ViIHByb2Nl c3NlcyBpbiBwZXItdGFiIHByb2Nlc3MgbW9kZWwuCiAgICAgICAgICAgICBwcm9jZXNzID0gY3Jl YXRlTmV3V2ViUHJvY2VzcygpOwotICAgICAgICAgICAgbV9wcm9jZXNzZXMuYXBwZW5kKHByb2Nl c3MpOwogICAgICAgICB9CiAgICAgfQogCkBAIC01MjksMTAgKzUzMCwxMCBAQCBXZWJQcm9jZXNz UHJveHkqIFdlYkNvbnRleHQ6OnJlbGF1bmNoUHJvCiAgICAgaWYgKG1fcHJvY2Vzc01vZGVsID09 IFByb2Nlc3NNb2RlbFNoYXJlZFNlY29uZGFyeVByb2Nlc3MpIHsKICAgICAgICAgZW5zdXJlU2hh cmVkV2ViUHJvY2VzcygpOwogICAgICAgICByZXR1cm4gbV9wcm9jZXNzZXNbMF0uZ2V0KCk7Ci0g ICAgfSBlbHNlIHsKLSAgICAgICAgLy8gRklYTUUgKE11bHRpLVdlYlByb2Nlc3MpOiBXaGF0IHNo b3VsZCB0aGlzIGRvIGluIHRoaXMgbW9kZWw/Ci0gICAgICAgIHJldHVybiAwOwogICAgIH0KKwor ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiAwOwogfQogCiBEb3dubG9hZFBy b3h5KiBXZWJDb250ZXh0Ojpkb3dubG9hZChXZWJQYWdlUHJveHkqIGluaXRpYXRpbmdQYWdlLCBj b25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvV2ViQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJDb250ZXh0LmgJKHJldmlzaW9uIDEyOTY3NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJDb250ZXh0LmgJKHdvcmtpbmcgY29weSkKQEAgLTM3MCw3ICszNzAsOSBAQCB0ZW1w bGF0ZTx0eXBlbmFtZSBVPiBpbmxpbmUgdm9pZCBXZWJDb250CiAKIHRlbXBsYXRlPHR5cGVuYW1l IFU+IHZvaWQgV2ViQ29udGV4dDo6c2VuZFRvQWxsUHJvY2Vzc2VzUmVsYXVuY2hpbmdUaGVtSWZO ZWNlc3NhcnkoY29uc3QgVSYgbWVzc2FnZSkKIHsKLSAgICByZWxhdW5jaFByb2Nlc3NJZk5lY2Vz c2FyeSgpOworLy8gRklYTUUgKE11bHRpLVdlYlByb2Nlc3MpOiBXZWJDb250ZXh0IGRvZXNuJ3Qg dHJhY2sgcHJvY2Vzc2VzIHRoYXQgaGF2ZSBleGl0ZWQsIHNvIGl0IGNhbm5vdCByZWxhdW5jaCB0 aGVzZS4gUGVyaGFwcyB0aGlzIGZ1bmN0aW9uYWxpdHkgd29uJ3QgYmUgbmVlZGVkIGluIHRoaXMg bW9kZS4KKyAgICBpZiAobV9wcm9jZXNzTW9kZWwgPT0gUHJvY2Vzc01vZGVsU2hhcmVkU2Vjb25k YXJ5UHJvY2VzcykKKyAgICAgICAgcmVsYXVuY2hQcm9jZXNzSWZOZWNlc3NhcnkoKTsKICAgICBz ZW5kVG9BbGxQcm9jZXNzZXMobWVzc2FnZSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAxMjk2NzUpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQyLDEw ICszNDIsMTMgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmluaXRpYWxpemVDb250ZXh0TWVudQogdm9p ZCBXZWJQYWdlUHJveHk6OnJlYXR0YWNoVG9XZWJQcm9jZXNzKCkKIHsKICAgICBBU1NFUlQoIWlz VmFsaWQoKSk7CisgICAgQVNTRVJUKG1fcHJvY2Vzcyk7CisgICAgQVNTRVJUKCFtX3Byb2Nlc3Mt PmlzVmFsaWQoKSk7CisgICAgQVNTRVJUKCFtX3Byb2Nlc3MtPmlzTGF1bmNoaW5nKCkpOwogCiAg ICAgbV9pc1ZhbGlkID0gdHJ1ZTsKIAotICAgIG1fcHJvY2VzcyA9IG1fcHJvY2Vzcy0+Y29udGV4 dCgpLT5yZWxhdW5jaFByb2Nlc3NJZk5lY2Vzc2FyeSgpOworICAgIG1fcHJvY2VzcyA9IG1fcHJv Y2Vzcy0+Y29udGV4dCgpLT5jcmVhdGVOZXdXZWJQcm9jZXNzKCk7CiAgICAgbV9wcm9jZXNzLT5h ZGRFeGlzdGluZ1dlYlBhZ2UodGhpcywgbV9wYWdlSUQpOwogCiAgICAgaW5pdGlhbGl6ZVdlYlBh Z2UoKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUNhY2hlTWFu YWdlclByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UmVzb3VyY2VDYWNoZU1hbmFnZXJQcm94eS5jcHAJKHJldmlzaW9uIDEyOTY3NSkKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUNhY2hlTWFuYWdlclByb3h5LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjQsNyArNjQsNiBAQCBib29sIFdlYlJlc291cmNlQ2FjaGVNYW5hZ2Vy UHJveHk6OnNob3VsCiB2b2lkIFdlYlJlc291cmNlQ2FjaGVNYW5hZ2VyUHJveHk6OmdldENhY2hl T3JpZ2lucyhQYXNzUmVmUHRyPEFycmF5Q2FsbGJhY2s+IHBycENhbGxiYWNrKQogewogICAgIFJl ZlB0cjxBcnJheUNhbGxiYWNrPiBjYWxsYmFjayA9IHBycENhbGxiYWNrOwotICAgIG1fd2ViQ29u dGV4dC0+cmVsYXVuY2hQcm9jZXNzSWZOZWNlc3NhcnkoKTsKICAgICB1aW50NjRfdCBjYWxsYmFj a0lEID0gY2FsbGJhY2stPmNhbGxiYWNrSUQoKTsKICAgICBtX2FycmF5Q2FsbGJhY2tzLnNldChj YWxsYmFja0lELCBjYWxsYmFjay5yZWxlYXNlKCkpOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvUGx1Z2lucy9XZWJQbHVnaW5TaXRlRGF0YU1hbmFnZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL1dlYlBsdWdpblNpdGVEYXRhTWFu YWdlci5jcHAJKHJldmlzaW9uIDEyOTY3NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Q bHVnaW5zL1dlYlBsdWdpblNpdGVEYXRhTWFuYWdlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2 Myw4ICsxNjMsNiBAQCB2b2lkIFdlYlBsdWdpblNpdGVEYXRhTWFuYWdlcjo6Z2V0U2l0ZXNXCiAg ICAgbV9wZW5kaW5nR2V0U2l0ZXNXaXRoRGF0YS5zZXQoY2FsbGJhY2tJRCwgc3RhdGUpOwogICAg IHN0YXRlLT5nZXRTaXRlc1dpdGhEYXRhRm9yTmV4dFBsdWdpbigpOwogI2Vsc2UKLSAgICBtX3dl YkNvbnRleHQtPnJlbGF1bmNoUHJvY2Vzc0lmTmVjZXNzYXJ5KCk7Ci0KICAgICBWZWN0b3I8UGx1 Z2luTW9kdWxlSW5mbz4gcGx1Z2lucyA9IG1fd2ViQ29udGV4dC0+cGx1Z2luSW5mb1N0b3JlKCku cGx1Z2lucygpOwogICAgIFZlY3RvcjxTdHJpbmc+IHBsdWdpblBhdGhzOwogICAgIGZvciAoc2l6 ZV90IGkgPSAwOyBpIDwgcGx1Z2lucy5zaXplKCk7ICsraSkKQEAgLTIyNSw4ICsyMjMsNiBAQCB2 b2lkIFdlYlBsdWdpblNpdGVEYXRhTWFuYWdlcjo6Y2xlYXJTaXRlCiAgICAgbV9wZW5kaW5nQ2xl YXJTaXRlRGF0YS5zZXQoY2FsbGJhY2tJRCwgc3RhdGUpOwogICAgIHN0YXRlLT5jbGVhclNpdGVE YXRhRm9yTmV4dFBsdWdpbigpOwogI2Vsc2UKLSAgICBtX3dlYkNvbnRleHQtPnJlbGF1bmNoUHJv Y2Vzc0lmTmVjZXNzYXJ5KCk7Ci0KICAgICBWZWN0b3I8UGx1Z2luTW9kdWxlSW5mbz4gcGx1Z2lu cyA9IG1fd2ViQ29udGV4dC0+cGx1Z2luSW5mb1N0b3JlKCkucGx1Z2lucygpOwogICAgIFZlY3Rv cjxTdHJpbmc+IHBsdWdpblBhdGhzOwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcGx1Z2lu cy5zaXplKCk7ICsraSkK