97721 2012-09-26 13:11:04 -0700 [CSS Exclusions] Test that dynamically setting shape-inside causes relayout in child elements 2012-10-31 18:21:50 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89256 97704 1 betravis betravis donggwan.kim webkit.review.bot oldest_to_newest 728903 0 betravis 2012-09-26 13:11:04 -0700 Make sure setting shape-inside causes relayout when children contain inline content <div style="shape-inside:..."> <div> I am inline content </div> </div> 753890 1 171342 betravis 2012-10-29 17:14:06 -0700 Created attachment 171342 Initial patch 755218 2 171342 krit 2012-10-31 06:23:56 -0700 Comment on attachment 171342 Initial patch View in context: https://bugs.webkit.org/attachment.cgi?id=171342&action=review > LayoutTests/fast/exclusions/resources/simple-rectangle.js:29 > + if (content) > + elem.innerHTML = content; This seems more then a restriction then an addition. Can you explain it in more detail what you aim to do and why you did it? 755441 3 betravis 2012-10-31 10:33:07 -0700 The goal for this test is to add a shape-inside dynamically to an element with block children, and make sure it lays out correctly. The previous tests all added shape-inside and content at the same time, via the script. The added conditional allows us to skip passing in a content argument, leaving the element's existing innerHTML in place. Does this make sense? Deserve a comment in the changelog or js file? 755775 4 171342 webkit.review.bot 2012-10-31 18:21:46 -0700 Comment on attachment 171342 Initial patch Clearing flags on attachment: 171342 Committed r133106: <http://trac.webkit.org/changeset/133106> 755776 5 webkit.review.bot 2012-10-31 18:21:50 -0700 All reviewed patches have been landed. Closing bug. 171342 2012-10-29 17:14:06 -0700 2012-10-31 18:21:46 -0700 Initial patch bug-97721-20121029171232.patch text/plain 5062 betravis U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODUyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTkxMmU0M2EzYTNlY2YyNDE4NzI2 Zjc4MThlZmIzMjEwOThlNjhjMC4uMzA3ZDcyMTFkM2VjMmJhYTM0Mjc1N2IyZWRhNmNlNjBiOGU0 NmNhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTI5ICBCZWFyIFRyYXZpcyAgPGJl dHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIEV4Y2x1c2lvbnNdIFRlc3QgdGhhdCBk eW5hbWljYWxseSBzZXR0aW5nIHNoYXBlLWluc2lkZSBjYXVzZXMgcmVsYXlvdXQgaW4gY2hpbGQg ZWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk3NzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkaW5nIGEgdGVzdCB0aGF0IGR5bmFtaWNhbGx5IHNldHMgc2hhcGUtaW5zaWRlIG9uIGEgYmxv Y2sgY29udGFpbmluZyBtdWx0aXBsZSBibG9jayBjaGlsZHJlbi4KKworICAgICAgICAqIGZhc3Qv ZXhjbHVzaW9ucy9yZXNvdXJjZXMvc2ltcGxlLXJlY3RhbmdsZS5qczoKKyAgICAgICAgKGNyZWF0 ZVJlY3RhbmdsZVRlc3QpOiBNb2RpZnlpbmcgdGVzdCB0byB3b3JrIHdpdGggZWxlbWVudHMgd2l0 aCBleGlzdGluZyBjb250ZW50LgorICAgICAgICAoY3JlYXRlUmVjdGFuZ2xlVGVzdFJlc3VsdCk6 IE1vZGlmeWluZyB0ZXN0IGV4cGVjdGF0aW9uIHRvIHdvcmsgd2l0aCBlbGVtZW50cyB3aXRoIGV4 aXN0aW5nIGNvbnRlbnQuCisgICAgICAgICogZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9z aGFwZS1pbnNpZGUtbXVsdGlwbGUtYmxvY2tzLWR5bmFtaWMtZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9zaGFwZS1pbnNpZGUtbXVs dGlwbGUtYmxvY2tzLWR5bmFtaWMuaHRtbDogQWRkZWQuCisKIDIwMTItMTAtMjkgIFJvZ2VyIEZv bmcgIDxyb2dlcl9mb25nQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGZWF0dXJl IGludHJvZHVjZWQgaW4gcjEzMjcwOCBpcyBjaHJvbWl1bSBvbmx5LiBTa2lwcGluZyByZWxhdGVk IHRlc3RzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3Jlc291cmNl cy9zaW1wbGUtcmVjdGFuZ2xlLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3Jlc291 cmNlcy9zaW1wbGUtcmVjdGFuZ2xlLmpzCmluZGV4IDI0MzQwMGE2ZWRhOTJiMDc1Y2U4MTg1ZmQ5 NzcxMGI0OTdhOWVhNWEuLjcxYjA3OWZiMzZkNTBjMDJmYmE1ZGM0YTVjNjU3MjQ0NzJkYzE1MGEg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9yZXNvdXJjZXMvc2ltcGxl LXJlY3RhbmdsZS5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMvcmVzb3VyY2Vz L3NpbXBsZS1yZWN0YW5nbGUuanMKQEAgLTI1LDcgKzI1LDggQEAgZnVuY3Rpb24gY3JlYXRlUmVj dGFuZ2xlVGVzdChlbGVtZW50SWQsIHN0eWxlc2hlZXRJZCwgYm91bmRzLCBzaGFwZUJvdW5kcywg dW5pdHMKICAgICBydWxlcy5wdXNoKCdwb3NpdGlvbjogYWJzb2x1dGUnLCAnZGlzcGxheTogYmxv Y2snLCAnY29udGVudDogXCcgXCcnKTsKICAgICBydWxlcy5wdXNoKCdib3JkZXI6IDFweCBzb2xp ZCBibHVlJyk7CiAgICAgc3R5bGVzaGVldC5pbnNlcnRSdWxlKCcjJyArIGVsZW1lbnRJZCArICc6 OmJlZm9yZXsnICsgcnVsZXMuam9pbignOycpICsgJ30nKTsKLSAgICBlbGVtLmlubmVySFRNTCA9 IGNvbnRlbnQ7CisgICAgaWYgKGNvbnRlbnQpCisgICAgICAgIGVsZW0uaW5uZXJIVE1MID0gY29u dGVudDsKIH0KIAogZnVuY3Rpb24gY3JlYXRlUmVjdGFuZ2xlVGVzdFJlc3VsdChlbGVtZW50SWQs IHN0eWxlc2hlZXRJZCwgYm91bmRzLCBzaGFwZUJvdW5kcywgdW5pdHMsIGNvbnRlbnQpIHsKQEAg LTUxLDUgKzUyLDYgQEAgZnVuY3Rpb24gY3JlYXRlUmVjdGFuZ2xlVGVzdFJlc3VsdChlbGVtZW50 SWQsIHN0eWxlc2hlZXRJZCwgYm91bmRzLCBzaGFwZUJvdW5kcywKICAgICBydWxlcy5wdXNoKCdw b3NpdGlvbjogYWJzb2x1dGUnLCAnZGlzcGxheTogYmxvY2snLCAnY29udGVudDogXCcgXCcnKTsK ICAgICBydWxlcy5wdXNoKCdib3JkZXI6IDFweCBzb2xpZCBibHVlJyk7CiAgICAgc3R5bGVzaGVl dC5pbnNlcnRSdWxlKCcjJyArIGVsZW1lbnRJZCArICc6OmJlZm9yZXsnICsgcnVsZXMuam9pbign OycpICsgJ30nKTsKLSAgICBlbGVtLmlubmVySFRNTCA9IGNvbnRlbnQ7CisgICAgaWYgKGNvbnRl bnQpCisgICAgICAgIGVsZW0uaW5uZXJIVE1MID0gY29udGVudDsKIH0KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLW11bHRp cGxlLWJsb2Nrcy1keW5hbWljLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1 c2lvbnMvc2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1tdWx0aXBsZS1ibG9ja3MtZHluYW1pYy1l eHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJiOWZhNzRmMjZmMDg1ODVhZWI4MzZhOTcyYzY2YjVm MGZkYWFkMDMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V4Y2x1c2lvbnMv c2hhcGUtaW5zaWRlL3NoYXBlLWluc2lkZS1tdWx0aXBsZS1ibG9ja3MtZHluYW1pYy1leHBlY3Rl ZC5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzxzdHlsZSBpZD0nc3R5bGVzaGVldCc+CitkaXYgeworICAgIGZvbnQ6IDUwcHgvMSBBaGVtLCBz YW5zLXNlcmlmOworICAgIGNvbG9yOiBncmVlbjsKK30KK3AgeworICAgIG1hcmdpbjogMDsKK30K Kzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0nLi4vcmVzb3VyY2VzL3NpbXBsZS1yZWN0YW5nbGUuanMn Pjwvc2NyaXB0PgorPHNjcmlwdD4KKyAgICB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKSB7Cisg ICAgICAgIGNyZWF0ZVJlY3RhbmdsZVRlc3RSZXN1bHQoJ3NoYXBlLWluc2lkZTEnLCAnc3R5bGVz aGVldCcsIHsgd2lkdGg6IDIwMCwgaGVpZ2h0OiAyMDAgfSwgeyB4OiA1MCwgeTogNTAsIHdpZHRo OiAxMDAsIGhlaWdodDogMTAwIH0sICdweCcsICc8cD5YWDwvcD48cD5YWDwvcD4nKTsKKyAgICAg ICAgY3JlYXRlUmVjdGFuZ2xlVGVzdFJlc3VsdCgnc2hhcGUtaW5zaWRlMicsICdzdHlsZXNoZWV0 JywgeyB3aWR0aDogMjAwLCBoZWlnaHQ6IDIwMCB9LCB7IHg6IDUwLCB5OiA1MCwgd2lkdGg6IDEw MCwgaGVpZ2h0OiAxMDAgfSwgJ3B4JywgJzxwPlhYPC9wPjxwPlhYPC9wPicpOworICAgIH07Cis8 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0IHJlcXVpcmVzIHRoZSBBaGVt IGZvbnQuIEl0IHRlc3RzIHRoYXQgZHluYW1pY2FsbHkgc2V0IHNoYXBlLWluc2lkZXMgc2hvdWxk IGFmZmVjdCB0aGVpciBibG9jaydzIGNoaWxkcmVuLiBZb3Ugc2hvdWxkIHNlZSB0d28gZ3JlZW4g c3F1YXJlcyBpbnNpZGUgYmx1ZSBvdXRsaW5lcy48L3A+Cis8ZGl2IGlkPSdzaGFwZS1pbnNpZGUx Jz48L2Rpdj4KKzxkaXYgaWQ9J3NoYXBlLWluc2lkZTInPjwvZGl2PgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9leGNsdXNpb25zL3NoYXBlLWluc2lkZS9z aGFwZS1pbnNpZGUtbXVsdGlwbGUtYmxvY2tzLWR5bmFtaWMuaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvZXhjbHVzaW9ucy9zaGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLW11bHRpcGxlLWJsb2Nrcy1k eW5hbWljLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjE1OGZiMzJiYjE5ODQ1YTcyN2JiMTEzZWExZjAzMzUz NGZlNzNlZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXhjbHVzaW9ucy9z aGFwZS1pbnNpZGUvc2hhcGUtaW5zaWRlLW11bHRpcGxlLWJsb2Nrcy1keW5hbWljLmh0bWwKQEAg LTAsMCArMSwyNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlIGlk PSdzdHlsZXNoZWV0Jz4KK2RpdiB7CisgICAgZm9udDogNTBweC8xIEFoZW0sIHNhbnMtc2VyaWY7 CisgICAgY29sb3I6IGdyZWVuOworfQorcCB7CisgICAgbWFyZ2luOiAwOworfQorPC9zdHlsZT4K KzxzY3JpcHQgc3JjPScuLi9yZXNvdXJjZXMvc2ltcGxlLXJlY3RhbmdsZS5qcyc+PC9zY3JpcHQ+ Cis8c2NyaXB0PgorICAgIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgY3Jl YXRlUmVjdGFuZ2xlVGVzdCgnc2hhcGUtaW5zaWRlMScsICdzdHlsZXNoZWV0JywgeyB3aWR0aDog MjAwLCBoZWlnaHQ6IDIwMCB9LCB7IHg6IDUwLCB5OiA1MCwgd2lkdGg6IDEwMCwgaGVpZ2h0OiAx MDAgfSwgJ3B4JywgbnVsbCk7CisgICAgICAgIGNyZWF0ZVJlY3RhbmdsZVRlc3QoJ3NoYXBlLWlu c2lkZTInLCAnc3R5bGVzaGVldCcsIHsgd2lkdGg6IDIwMCwgaGVpZ2h0OiAyMDAgfSwgeyB4OiA1 MCwgeTogNTAsIHdpZHRoOiAxMDAsIGhlaWdodDogMTAwIH0sICdweCcsIG51bGwpOworICAgIH07 Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0IHJlcXVpcmVzIHRoZSBB aGVtIGZvbnQuIEl0IHRlc3RzIHRoYXQgZHluYW1pY2FsbHkgc2V0IHNoYXBlLWluc2lkZXMgc2hv dWxkIGFmZmVjdCB0aGVpciBibG9jaydzIGNoaWxkcmVuLiBZb3Ugc2hvdWxkIHNlZSB0d28gZ3Jl ZW4gc3F1YXJlcyBpbnNpZGUgYmx1ZSBvdXRsaW5lcy48L3A+Cis8ZGl2IGlkPSdzaGFwZS1pbnNp ZGUxJz48cD5YWDwvcD48cD5YWDwvcD48L2Rpdj4KKzxkaXYgaWQ9J3NoYXBlLWluc2lkZTInPjxk aXY+PHA+WFg8L3A+PHA+WFg8L3A+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==