97710 2012-09-26 11:41:00 -0700 REGRESSION(r129521): Broke autocomplete on enter_bug.cgi (Requested by abarth on #webkit). 2012-09-26 11:47:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66752 1 webkit.review.bot webkit.review.bot darin galpeter oldest_to_newest 728800 0 webkit.review.bot 2012-09-26 11:41:00 -0700 http://trac.webkit.org/changeset/129521 broke the build: Broke autocomplete on enter_bug.cgi (Requested by abarth on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 728802 1 165839 webkit.review.bot 2012-09-26 11:41:36 -0700 Created attachment 165839 ROLLOUT of r129521 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 728804 2 165839 abarth 2012-09-26 11:42:25 -0700 Comment on attachment 165839 ROLLOUT of r129521 View in context: https://bugs.webkit.org/attachment.cgi?id=165839&action=review > Websites/bugs.webkit.org/committers-autocomplete.js:401 > - for (var i = 0; i < EMAIL_INPUTS.length; i++) { > - var field = document.getElementById(EMAIL_INPUTS[i]); > - if (field) > - field.addEventListener("focus", function(e) { enableAutoComplete(e.target); }, false); > - } > + document.addEventListener('focusin', function(e) { > + for (var i = 0; i < EMAIL_INPUTS.length; i++) { > + if (e.target.name == EMAIL_INPUTS[i]) { > + enableAutoComplete(e.target); > + break; > + } > + } > + }, false); The problem is you changed this from looking at the "name" to looking at the "id". On enter_bug, we have a name but no ID. 728812 3 165839 webkit.review.bot 2012-09-26 11:47:21 -0700 Comment on attachment 165839 ROLLOUT of r129521 Clearing flags on attachment: 165839 Committed r129677: <http://trac.webkit.org/changeset/129677> 728813 4 webkit.review.bot 2012-09-26 11:47:24 -0700 All reviewed patches have been landed. Closing bug. 165839 2012-09-26 11:41:36 -0700 2012-09-26 11:47:21 -0700 ROLLOUT of r129521 bug-97710-20120926184805.patch text/plain 1810 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5Njc2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAxZGI3M2U5NGQyZWYwNTM5Y2E4YjdkMTY4YWIzYzY4N2RhMzk1NmFhLi4yNGZlMmU4MzJm MWEyYmE4NDRlZGM5NDgzNGY4OGRmNmRlYTAxMTY3IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOS0yNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQu cmV2aWV3LmJvdEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQg cjEyOTUyMS4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTI5NTIx CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzcxMAor CisgICAgICAgIEJyb2tlIGF1dG9jb21wbGV0ZSBvbiBlbnRlcl9idWcuY2dpIChSZXF1ZXN0ZWQg YnkgYWJhcnRoIG9uCisgICAgICAgICN3ZWJraXQpLgorCisgICAgICAgICogY29tbWl0dGVycy1h dXRvY29tcGxldGUuanM6CisKIDIwMTItMDktMjUgIFBldGVyIEdhbCAgPGdhbHBldGVyQGluZi51 LXN6ZWdlZC5odT4KIAogICAgICAgICBjb21taXR0ZXJzLWF1dG9jb21wbGV0ZS5qcyB3b3JrcyBv bmx5IHdpdGggV2ViS2l0IGJhc2VkIGJyb3dzZXJzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdz LndlYmtpdC5vcmcvY29tbWl0dGVycy1hdXRvY29tcGxldGUuanMgYi9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvY29tbWl0dGVycy1hdXRvY29tcGxldGUuanMKaW5kZXggNzA0NDJkN2EwNjM5MGIw YzgxZTRlNmRlZWM5MmVhZWVlZjNlMTZmZS4uMDg0YjUwZDAyYjQwOTUzMTZmMjNiOGI4MjBiMWVl NTM2ZjEzZjIxOCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvbW1pdHRl cnMtYXV0b2NvbXBsZXRlLmpzCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb21taXR0 ZXJzLWF1dG9jb21wbGV0ZS5qcwpAQCAtMzkxLDExICszOTEsMTQgQEAgV2ViS2l0Q29tbWl0dGVy cyA9IChmdW5jdGlvbigpIHsKICAgICAgICAgdXBkYXRlTWVudSgpOwogICAgIH0KIAotICAgIGZv ciAodmFyIGkgPSAwOyBpIDwgRU1BSUxfSU5QVVRTLmxlbmd0aDsgaSsrKSB7Ci0gICAgICAgIHZh ciBmaWVsZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKEVNQUlMX0lOUFVUU1tpXSk7Ci0gICAg ICAgIGlmIChmaWVsZCkKLSAgICAgICAgICAgIGZpZWxkLmFkZEV2ZW50TGlzdGVuZXIoImZvY3Vz IiwgZnVuY3Rpb24oZSkgeyBlbmFibGVBdXRvQ29tcGxldGUoZS50YXJnZXQpOyB9LCBmYWxzZSk7 Ci0gICAgfQorICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoJ2ZvY3VzaW4nLCBmdW5jdGlv bihlKSB7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgRU1BSUxfSU5QVVRTLmxlbmd0aDsg aSsrKSB7CisgICAgICAgICAgICBpZiAoZS50YXJnZXQubmFtZSA9PSBFTUFJTF9JTlBVVFNbaV0p IHsKKyAgICAgICAgICAgICAgICBlbmFibGVBdXRvQ29tcGxldGUoZS50YXJnZXQpOworICAgICAg ICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgfSwgZmFsc2Up OwogCiAgICAgV2ViS2l0Q29tbWl0dGVycy5nZXRDb21taXR0ZXJzKGZ1bmN0aW9uIChjb21taXR0 ZXJzKSB7CiAgICAgICAgIG1fY29tbWl0dGVycyA9IGNvbW1pdHRlcnM7Cg==