97689 2012-09-26 08:49:27 -0700 [chromium][Android] Add WebSecurityOrigin::grantLoadLocalResources() 2012-10-09 14:50:42 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 benm benm abarth dglazkov fishd jamesr mnaganov tkent+wkapi webkit.review.bot oldest_to_newest 728605 0 benm 2012-09-26 08:49:27 -0700 To correctly support the Android WebView#loadDataWithBaseUrl API[1], we would like to expose the WebCore::SecurityPolicy::setLocalLoadPolicy function to Chromium through the API. For more information, please see the chromium bug: https://code.google.com/p/chromium/issues/detail?id=152223 Patch coming. [1]http://developer.android.com/reference/android/webkit/WebView.html#loadDataWithBaseURL(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String) 728651 1 165821 benm 2012-09-26 09:17:08 -0700 Created attachment 165821 patch Adds grantAccessToLocalFiles(bool) to WebKit::WebSecurityPolicy 728656 2 webkit.review.bot 2012-09-26 09:20:46 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 728696 3 165821 abarth 2012-09-26 10:07:23 -0700 Comment on attachment 165821 patch View in context: https://bugs.webkit.org/attachment.cgi?id=165821&action=review Do you really want to this globally for the whole process or just for an individual WebView? > Source/WebKit/chromium/public/WebSecurityPolicy.h:98 > + // Grants access to file:// URLs. > + WEBKIT_EXPORT static void grantAccessToLocalFiles(bool); Also, this boolean parameter is really vague. Perhaps this should be two functions, one that grants local access for all URIs and one that grants access only for local URIs. 728838 4 benm 2012-09-26 12:06:23 -0700 Thanks for looking Adam! (In reply to comment #3) > (From update of attachment 165821 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165821&action=review > > Do you really want to this globally for the whole process or just for an individual WebView? Ah, good call. I suppose what I really want is to get the SecurityOrigin for the page and call it's grantLoadLocalResources() method, and it's actually that that I want to expose to Chromium via the WebKit::WebSecurityOrigin. Does that sounds along the right lines to you? I see however that SecurityOrigin::grantLoadLocalResources is only around for backwards compatibility... can we consider implementing the Android WebView API as implementing backwards compatibility? These checks didn't exist when the original API was implemented inside Android's old WebKit fork... :/ > > > Source/WebKit/chromium/public/WebSecurityPolicy.h:98 > > + // Grants access to file:// URLs. > > + WEBKIT_EXPORT static void grantAccessToLocalFiles(bool); > > Also, this boolean parameter is really vague. Perhaps this should be two functions, one that grants local access for all URIs and one that grants access only for local URIs. This should go away if I head in the direction mentioned above. 728841 5 abarth 2012-09-26 12:08:29 -0700 > Ah, good call. I suppose what I really want is to get the SecurityOrigin for the page and call it's grantLoadLocalResources() method, and it's actually that that I want to expose to Chromium via the WebKit::WebSecurityOrigin. Does that sounds along the right lines to you? Yes, precisely. > I see however that SecurityOrigin::grantLoadLocalResources is only around for backwards compatibility... can we consider implementing the Android WebView API as implementing backwards compatibility? These checks didn't exist when the original API was implemented inside Android's old WebKit fork... :/ We might need to update the comment to explain what it is used for. 728853 6 benm 2012-09-26 12:19:54 -0700 (In reply to comment #5) > > Ah, good call. I suppose what I really want is to get the SecurityOrigin for the page and call it's grantLoadLocalResources() method, and it's actually that that I want to expose to Chromium via the WebKit::WebSecurityOrigin. Does that sounds along the right lines to you? > > Yes, precisely. > > > I see however that SecurityOrigin::grantLoadLocalResources is only around for backwards compatibility... can we consider implementing the Android WebView API as implementing backwards compatibility? These checks didn't exist when the original API was implemented inside Android's old WebKit fork... :/ > > We might need to update the comment to explain what it is used for. OK :) 736776 7 167556 benm 2012-10-08 10:31:12 -0700 Created attachment 167556 patch. Adam, here's v2 of the patch. I didn't have time to create a decent ChangeLog this evening so I appreciate that it's unfit for landing (hence not requesting r?). But I'd be very grateful if you could comment in the context of the chromium side patch (http://codereview.chromium.org/10990056/), and then I can try and fix it up tomorrow UK time. Many thanks :) 736818 8 167556 abarth 2012-10-08 11:13:32 -0700 Comment on attachment 167556 patch. View in context: https://bugs.webkit.org/attachment.cgi?id=167556&action=review > Source/WebKit/chromium/public/WebSecurityPolicy.h:97 > + // Updates the current WebCore::SecurityPolicy to allow local loads from both There is no such thing as WebCore from the point of view of the API. I would have written this as "Updates the current security policy to allow..." > Source/WebKit/chromium/src/WebSecurityOrigin.cpp:163 > +void WebSecurityOrigin::grantLocalLoads() const > +{ > + get()->grantLoadLocalResources(); > +} Any particular reason why you picked a different function name? These functions should have the same name. If you don't like the name in WebCore, we can change it. > Source/WebKit/chromium/src/WebSecurityPolicy.cpp:130 > +void WebSecurityPolicy::allowLocalLoadsForLocalAndSubstituteData() > +{ > + SecurityPolicy::setLocalLoadPolicy(SecurityPolicy::AllowLocalLoadsForLocalAndSubstituteData); > +} > + > +void WebSecurityPolicy::allowLocalLoadsForLocalOnly() > +{ > + SecurityPolicy::setLocalLoadPolicy(SecurityPolicy::AllowLocalLoadsForLocalOnly); > +} It's not clear from the API that these functions twiddle the same state. 736825 9 abarth 2012-10-08 11:19:32 -0700 I commented on the Chromium review as well. It seems very unlikely that you should be manipulating WebKit-global state based on what's happening in a single RenderView. 737947 10 167787 benm 2012-10-09 11:01:09 -0700 Created attachment 167787 patch. ptal Adam. Thanks, Ben 738175 11 167787 abarth 2012-10-09 14:12:03 -0700 Comment on attachment 167787 patch. View in context: https://bugs.webkit.org/attachment.cgi?id=167787&action=review > Source/WebCore/page/SecurityOrigin.cpp:433 > // To be backwards compatible with older versions of WebKit, we also use > // this function to grant the ability to load local resources to documents > // loaded with SubstituteData. This part of the comment is outdated and should be removed. > Source/WebKit/chromium/public/WebSecurityOrigin.h:100 > + // Allows this WebSecurityOrigin access to local resources. > + WEBKIT_EXPORT void grantLoadLocalResources() const; I have some reservations about exposing this API since its easy to use it in an insecure way, but I guess we'll just need to be careful. 738178 12 167846 benm 2012-10-09 14:17:43 -0700 Created attachment 167846 updated comment Thanks Adam! New patch with the updated comment; I'd like the CQ to land for me (I don't have an svn checkout to hand that I can commit from). 738211 13 167846 webkit.review.bot 2012-10-09 14:50:38 -0700 Comment on attachment 167846 updated comment Clearing flags on attachment: 167846 Committed r130815: <http://trac.webkit.org/changeset/130815> 738212 14 webkit.review.bot 2012-10-09 14:50:42 -0700 All reviewed patches have been landed. Closing bug. 165821 2012-09-26 09:17:08 -0700 2012-10-08 10:31:12 -0700 patch 97689.txt text/plain 2433 benm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNTBkNmZlYy4uNGY0ZDZiYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMi0wOS0yNiAgQmVuIE11cmRv Y2ggIDxiZW5tQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXVtBbmRyb2lkXSBBZGQg V2ViU2VjdXJpdHlQb2xpY3k6OmdyYW50QWNjZXNzVG9Mb2NhbEZpbGVzKGJvb2wpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NzY4OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGltcGxlbWVudCB0aGUg QW5kcm9pZCBXZWJWaWV3I2xvYWREYXRhV2l0aEJhc2VVcmwgQVBJLCB3ZSByZXF1aXJlIGEKKyAg ICAgICAgaG9vayBvdXQgZm9yIENocm9taXVtIHRvIGJlIGFibGUgdG8gY29uZmlndXJlIHRoZSBj dXJyZW50CisgICAgICAgIFNlY3VyaXR5UG9saWN5IFdlYktpdCBpcyB1c2luZyBmb3IgbG9jYWwg ZmlsZXMuIEFkZCBzdWNoIGFuIEFQSSB0bworICAgICAgICBXZWJTZWN1cml0eVBvbGljeS4KKwor ICAgICAgICBQbGVhc2Ugc2VlIGNyYnVnLmNvbS8xNTIyMjMgZm9yIGZ1cnRoZXIgaW5mb3JtYXRp b24gYW5kIHRoZSBjaHJvbWl1bQorICAgICAgICBzaWRlIHBhdGNoLgorCisgICAgICAgICogcHVi bGljL1dlYlNlY3VyaXR5UG9saWN5Lmg6CisgICAgICAgIChXZWJTZWN1cml0eVBvbGljeSk6IEFk ZCBncmFudEFjY2Vzc1RvTG9jYWxGaWxlcy4KKyAgICAgICAgKiBzcmMvV2ViU2VjdXJpdHlQb2xp Y3kuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZWN1cml0eVBvbGljeTo6Z3JhbnRBY2Nlc3NU b0xvY2FsRmlsZXMpOgorICAgICAgICAgICAgQ29uZmlndXJlIHRoZSBjdXJyZW50bHkgdXNlZCBT ZWN1cml0eVBvbGljeSBmb3IgbG9jYWwgZmlsZSBsb2Fkcy4KKyAgICAgICAgKFdlYktpdCk6CisK IDIwMTItMDktMjUgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTM5NwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJpdHlQb2xpY3kuaCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5UG9saWN5LmgKaW5kZXggNDYyZGIz MS4uNzM2NzUxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi U2VjdXJpdHlQb2xpY3kuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJT ZWN1cml0eVBvbGljeS5oCkBAIC05NCw2ICs5NCw5IEBAIHB1YmxpYzoKICAgICAvLyBieSBib29r bWFya2xldHMgb3IgamF2YXNjcmlwdDogVVJMcyB0eXBlZCBpbiB0aGUgb21uaWJveC4KICAgICBX RUJLSVRfRVhQT1JUIHN0YXRpYyB2b2lkIHJlZ2lzdGVyVVJMU2NoZW1lQXNOb3RBbGxvd2luZ0ph dmFzY3JpcHRVUkxzKGNvbnN0IFdlYlN0cmluZyYpOwogCisgICAgLy8gR3JhbnRzIGFjY2VzcyB0 byBmaWxlOi8vIFVSTHMuCisgICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMgdm9pZCBncmFudEFjY2Vz c1RvTG9jYWxGaWxlcyhib29sKTsKKwogcHJpdmF0ZToKICAgICBXZWJTZWN1cml0eVBvbGljeSgp OwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5 UG9saWN5LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5UG9saWN5 LmNwcAppbmRleCBlODAwNjE4Li43MDRkNmIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJTZWN1cml0eVBvbGljeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViU2VjdXJpdHlQb2xpY3kuY3BwCkBAIC0xMjAsNCArMTIwLDkgQEAgdm9pZCBX ZWJTZWN1cml0eVBvbGljeTo6cmVnaXN0ZXJVUkxTY2hlbWVBc05vdEFsbG93aW5nSmF2YXNjcmlw dFVSTHMoY29uc3QgV2ViU3QKICAgICBTY2hlbWVSZWdpc3RyeTo6cmVnaXN0ZXJVUkxTY2hlbWVB c05vdEFsbG93aW5nSmF2YXNjcmlwdFVSTHMoc2NoZW1lKTsKIH0KIAordm9pZCBXZWJTZWN1cml0 eVBvbGljeTo6Z3JhbnRBY2Nlc3NUb0xvY2FsRmlsZXMoYm9vbCBhbGxvdykKK3sKKyAgICBTZWN1 cml0eVBvbGljeTo6c2V0TG9jYWxMb2FkUG9saWN5KGFsbG93ID8gU2VjdXJpdHlQb2xpY3k6OkFs bG93TG9jYWxMb2Fkc0ZvckFsbCA6IFNlY3VyaXR5UG9saWN5OjpBbGxvd0xvY2FsTG9hZHNGb3JM b2NhbE9ubHkpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 167556 2012-10-08 10:31:12 -0700 2012-10-09 11:01:09 -0700 patch. 97689.patch text/plain 2959 benm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5T3Jp Z2luLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5o CmluZGV4IGZmZGRmMDkuLjY4YWY4N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaApAQCAtOTYsNiArOTYsOCBAQCBwdWJsaWM6CiAg ICAgLy8gcGFzc3dvcmRzIHN0b3JlZCBpbiBwYXNzd29yZCBtYW5hZ2VyLgogICAgIFdFQktJVF9F WFBPUlQgYm9vbCBjYW5BY2Nlc3NQYXNzd29yZE1hbmFnZXIoKSBjb25zdDsKIAorICAgIFdFQktJ VF9FWFBPUlQgdm9pZCBncmFudExvY2FsTG9hZHMoKSBjb25zdDsKKwogI2lmIFdFQktJVF9JTVBM RU1FTlRBVElPTgogICAgIFdlYlNlY3VyaXR5T3JpZ2luKGNvbnN0IFdURjo6UGFzc1JlZlB0cjxX ZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4mKTsKICAgICBXZWJTZWN1cml0eU9yaWdpbiYgb3BlcmF0 b3I9KGNvbnN0IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4mKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5UG9saWN5 LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eVBvbGljeS5oCmlu ZGV4IDQ2MmRiMzEuLjBiOTUyZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlNlY3VyaXR5UG9saWN5LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViU2VjdXJpdHlQb2xpY3kuaApAQCAtOTQsNiArOTQsMTQgQEAgcHVibGljOgogICAg IC8vIGJ5IGJvb2ttYXJrbGV0cyBvciBqYXZhc2NyaXB0OiBVUkxzIHR5cGVkIGluIHRoZSBvbW5p Ym94LgogICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIHZvaWQgcmVnaXN0ZXJVUkxTY2hlbWVBc05v dEFsbG93aW5nSmF2YXNjcmlwdFVSTHMoY29uc3QgV2ViU3RyaW5nJik7CiAKKyAgICAvLyBVcGRh dGVzIHRoZSBjdXJyZW50IFdlYkNvcmU6OlNlY3VyaXR5UG9saWN5IHRvIGFsbG93IGxvY2FsIGxv YWRzIGZyb20gYm90aAorICAgIC8vIGxvY2FsIFNlY3VyaXR5T3JpZ2lucyBhbmQgVVJMcyBsb2Fk ZWQgdmlhIFN1YnN0aXR1dGVEYXRhLgorICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIHZvaWQgYWxs b3dMb2NhbExvYWRzRm9yTG9jYWxBbmRTdWJzdGl0dXRlRGF0YSgpOworCisgICAgLy8gVXBkYXRl cyB0aGUgY3VycmVudCBXZWJDb2V3OjpTZWN1cml0eVBvbGljeSB0byBhbGxvdyBsb2NhbCBsb2Fk cyBmcm9tCisgICAgLy8gbG9jYWwgU2VjdXJpdHlPcmlnaW5zIG9ubHkuCisgICAgV0VCS0lUX0VY UE9SVCBzdGF0aWMgdm9pZCBhbGxvd0xvY2FsTG9hZHNGb3JMb2NhbE9ubHkoKTsKKwogcHJpdmF0 ZToKICAgICBXZWJTZWN1cml0eVBvbGljeSgpOwogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAppbmRleCA4NTY5ZDRkLi43ZGI4M2Y1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9yaWdpbi5j cHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3Bw CkBAIC0zMyw2ICszMyw3IEBACiAKICNpbmNsdWRlICJLVVJMLmgiCiAjaW5jbHVkZSAiU2VjdXJp dHlPcmlnaW4uaCIKKyNpbmNsdWRlICJTZWN1cml0eVBvbGljeS5oIgogI2luY2x1ZGUgPHB1Ymxp Yy9XZWJTdHJpbmcuaD4KICNpbmNsdWRlIDxwdWJsaWMvV2ViVVJMLmg+CiAjaW5jbHVkZSA8d3Rm L1Bhc3NSZWZQdHIuaD4KQEAgLTE1Niw0ICsxNTcsOSBAQCB2b2lkIFdlYlNlY3VyaXR5T3JpZ2lu Ojphc3NpZ24oV2ViU2VjdXJpdHlPcmlnaW5Qcml2YXRlKiBwKQogICAgIG1fcHJpdmF0ZSA9IHA7 CiB9CiAKK3ZvaWQgV2ViU2VjdXJpdHlPcmlnaW46OmdyYW50TG9jYWxMb2FkcygpIGNvbnN0Cit7 CisgICAgZ2V0KCktPmdyYW50TG9hZExvY2FsUmVzb3VyY2VzKCk7Cit9CisKIH0gLy8gbmFtZXNw YWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2Vj dXJpdHlQb2xpY3kuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlQ b2xpY3kuY3BwCmluZGV4IGMxZDBkODguLjFlNWRmYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5UG9saWN5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eVBvbGljeS5jcHAKQEAgLTExOSw0ICsxMTksMTQgQEAg dm9pZCBXZWJTZWN1cml0eVBvbGljeTo6cmVnaXN0ZXJVUkxTY2hlbWVBc05vdEFsbG93aW5nSmF2 YXNjcmlwdFVSTHMoY29uc3QgV2ViU3QKICAgICBTY2hlbWVSZWdpc3RyeTo6cmVnaXN0ZXJVUkxT Y2hlbWVBc05vdEFsbG93aW5nSmF2YXNjcmlwdFVSTHMoc2NoZW1lKTsKIH0KIAordm9pZCBXZWJT ZWN1cml0eVBvbGljeTo6YWxsb3dMb2NhbExvYWRzRm9yTG9jYWxBbmRTdWJzdGl0dXRlRGF0YSgp Cit7CisgICAgU2VjdXJpdHlQb2xpY3k6OnNldExvY2FsTG9hZFBvbGljeShTZWN1cml0eVBvbGlj eTo6QWxsb3dMb2NhbExvYWRzRm9yTG9jYWxBbmRTdWJzdGl0dXRlRGF0YSk7Cit9CisKK3ZvaWQg V2ViU2VjdXJpdHlQb2xpY3k6OmFsbG93TG9jYWxMb2Fkc0ZvckxvY2FsT25seSgpCit7CisgICAg U2VjdXJpdHlQb2xpY3k6OnNldExvY2FsTG9hZFBvbGljeShTZWN1cml0eVBvbGljeTo6QWxsb3dM b2NhbExvYWRzRm9yTG9jYWxPbmx5KTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg== 167787 2012-10-09 11:01:09 -0700 2012-10-09 14:17:43 -0700 patch. 97689.patch text/plain 3935 benm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMjBiZDM5Li4wOGI4YjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMDkgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29tPgorCisgICAgICAg IFtjaHJvbWl1bV1bQW5kcm9pZF0gQWRkIFdlYlNlY3VyaXR5T3JpZ2luOjpncmFudExvYWRMb2Nh bFJlc291cmNlcygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NzY4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEluIGFkZGl0aW9uIHRvIHRoZSBXZWJLaXQvY2hyb21pdW0gc2lkZSBvZiB0aGUgY2hhbmdl LCByZW1vdmUgdGhlCisgICAgICAgIEFTU0VSVCBpbiBTZWN1cml0eU9yaWdpbjo6Z3JhbnRMb2Fk TG9jYWxSZXNvdXJjZXMoKS4gQW5kcm9pZCBXZWJWaWV3CisgICAgICAgIGlzIGEgbGVnaXRpbWF0 ZSB1c2VyIG9mIHRoaXMgQVBJIGluIGNhc2VzIHdoZXJlIG5laXRoZXIgb2YgdGhlCisgICAgICAg IEFTU0VSVCdkIGNvbmRpdGlvbnMgaG9sZC4KKworICAgICAgICAqIHBhZ2UvU2VjdXJpdHlPcmln aW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW46OmdyYW50TG9hZExvY2Fs UmVzb3VyY2VzKTogUmVtb3ZlIEFTU0VSVC4KKwogMjAxMi0xMC0wOCAgRXJpYyBTZWlkZWwgIDxl cmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW5saW5lIGxvZ2ljYWxIZWlnaHRGb3JSb3dTaXpp bmcgdG8gc2hhdmUgYW5vdGhlciAyLTMlIG9mZiByb2JvaG9ybmV0J3MgcmVzaXplY29sLmh0bWwK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5jcHAKaW5kZXggZGExNTAyMS4uYjRkZWJm MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5jcHAKQEAgLTQzMSw3ICs0MzEs NiBAQCB2b2lkIFNlY3VyaXR5T3JpZ2luOjpncmFudExvYWRMb2NhbFJlc291cmNlcygpCiAgICAg Ly8gVG8gYmUgYmFja3dhcmRzIGNvbXBhdGlibGUgd2l0aCBvbGRlciB2ZXJzaW9ucyBvZiBXZWJL aXQsIHdlIGFsc28gdXNlCiAgICAgLy8gdGhpcyBmdW5jdGlvbiB0byBncmFudCB0aGUgYWJpbGl0 eSB0byBsb2FkIGxvY2FsIHJlc291cmNlcyB0byBkb2N1bWVudHMKICAgICAvLyBsb2FkZWQgd2l0 aCBTdWJzdGl0dXRlRGF0YS4KLSAgICBBU1NFUlQoaXNVbmlxdWUoKSB8fCBTZWN1cml0eVBvbGlj eTo6YWxsb3dTdWJzdGl0dXRlRGF0YUFjY2Vzc1RvTG9jYWwoKSk7CiAgICAgbV9jYW5Mb2FkTG9j YWxSZXNvdXJjZXMgPSB0cnVlOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDRl MGQ4ZjcuLjEzODZlYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMTAtMDkgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29tPgorCisgICAgICAg IFtjaHJvbWl1bV1bQW5kcm9pZF0gQWRkIFdlYlNlY3VyaXR5T3JpZ2luOjpncmFudExvYWRMb2Nh bFJlc291cmNlcygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NzY4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoaXMgY2hhbmdlIGV4cG9zZXMgdGhlIFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luOjpncmFu dExvYWRMb2NhbFJlc291cmNlcygpCisgICAgICAgIGZ1bmN0aW9uIHRvIHRoZSBDaHJvbWl1bSBX ZWJLaXQgQVBJIGxheWVyLiBUaGlzIGlzIG5lZWRlZCBpbiBDaHJvbWl1bQorICAgICAgICB0byBp bXBsZW1lbnQgdGhlIEFuZHJvaWQgV2ViVmlldy5sb2FkRGF0YVdpdGhCYXNlVXJsIGZ1bmN0aW9u IGluIGEKKyAgICAgICAgY29tcGF0aWJsZSBtYW5uZXIuCisKKyAgICAgICAgUGxlYXNlIHNlZSBj cmJ1Zy5jb20vMTUyMjIzIGZvciBmdXJ0aGVyIGluZm9ybWF0aW9uIGFuZCB0aGUgY2hyb21pdW0K KyAgICAgICAgc2lkZSBwYXRjaC4KKworICAgICAgICAqIHB1YmxpYy9XZWJTZWN1cml0eU9yaWdp bi5oOgorICAgICAgICAoV2ViU2VjdXJpdHlPcmlnaW4pOiBBZGQgZ3JhbnRMb2FkTG9jYWxSZXNv dXJjZXMoKSBBUEkuCisgICAgICAgICogc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViU2VjdXJpdHlPcmlnaW46OmdyYW50TG9hZExvY2FsUmVzb3VyY2VzKToK KyAgICAgICAgICAgIEltcGxlbWVudCB0aGUgQVBJIGJ5IGNhbGxpbmcgdGhyb3VnaCB0byB0aGUg V2ViQ29yZSBmdW5jdGlvbgorICAgICAgICAgICAgb2YgdGhlIHNhbWUgbmFtZS4KKyAgICAgICAg KFdlYktpdCk6CisKIDIwMTItMTAtMDggIEFsZWMgRmxldHQgIDxhbGVjZmxldHRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEluZGV4ZWREQjogcmVtb3ZlIGF1dG9nZW5lcmF0ZWQgb2JqZWN0U3Rv cmUvaW5kZXggaWQgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViU2VjdXJpdHlPcmlnaW4uaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YlNlY3VyaXR5T3JpZ2luLmgKaW5kZXggZmZkZGYwOS4uMzU5ZGM3MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5oCkBAIC05Niw2ICs5 Niw5IEBAIHB1YmxpYzoKICAgICAvLyBwYXNzd29yZHMgc3RvcmVkIGluIHBhc3N3b3JkIG1hbmFn ZXIuCiAgICAgV0VCS0lUX0VYUE9SVCBib29sIGNhbkFjY2Vzc1Bhc3N3b3JkTWFuYWdlcigpIGNv bnN0OwogCisgICAgLy8gQWxsb3dzIHRoaXMgV2ViU2VjdXJpdHlPcmlnaW4gYWNjZXNzIHRvIGxv Y2FsIHJlc291cmNlcy4KKyAgICBXRUJLSVRfRVhQT1JUIHZvaWQgZ3JhbnRMb2FkTG9jYWxSZXNv dXJjZXMoKSBjb25zdDsKKwogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogICAgIFdlYlNlY3Vy aXR5T3JpZ2luKGNvbnN0IFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4m KTsKICAgICBXZWJTZWN1cml0eU9yaWdpbiYgb3BlcmF0b3I9KGNvbnN0IFdURjo6UGFzc1JlZlB0 cjxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbj4mKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAppbmRleCA4NTY5ZDRkLi5lZWU1YjYxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwCkBA IC0xNTYsNCArMTU2LDkgQEAgdm9pZCBXZWJTZWN1cml0eU9yaWdpbjo6YXNzaWduKFdlYlNlY3Vy aXR5T3JpZ2luUHJpdmF0ZSogcCkKICAgICBtX3ByaXZhdGUgPSBwOwogfQogCit2b2lkIFdlYlNl Y3VyaXR5T3JpZ2luOjpncmFudExvYWRMb2NhbFJlc291cmNlcygpIGNvbnN0Cit7CisgICAgZ2V0 KCktPmdyYW50TG9hZExvY2FsUmVzb3VyY2VzKCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktp dAo= 167846 2012-10-09 14:17:43 -0700 2012-10-09 14:50:38 -0700 updated comment 97689.patch text/plain 4135 benm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMjBiZDM5Li4wOGI4YjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMDkgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29tPgorCisgICAgICAg IFtjaHJvbWl1bV1bQW5kcm9pZF0gQWRkIFdlYlNlY3VyaXR5T3JpZ2luOjpncmFudExvYWRMb2Nh bFJlc291cmNlcygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NzY4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEluIGFkZGl0aW9uIHRvIHRoZSBXZWJLaXQvY2hyb21pdW0gc2lkZSBvZiB0aGUgY2hhbmdl LCByZW1vdmUgdGhlCisgICAgICAgIEFTU0VSVCBpbiBTZWN1cml0eU9yaWdpbjo6Z3JhbnRMb2Fk TG9jYWxSZXNvdXJjZXMoKS4gQW5kcm9pZCBXZWJWaWV3CisgICAgICAgIGlzIGEgbGVnaXRpbWF0 ZSB1c2VyIG9mIHRoaXMgQVBJIGluIGNhc2VzIHdoZXJlIG5laXRoZXIgb2YgdGhlCisgICAgICAg IEFTU0VSVCdkIGNvbmRpdGlvbnMgaG9sZC4KKworICAgICAgICAqIHBhZ2UvU2VjdXJpdHlPcmln aW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW46OmdyYW50TG9hZExvY2Fs UmVzb3VyY2VzKTogUmVtb3ZlIEFTU0VSVC4KKwogMjAxMi0xMC0wOCAgRXJpYyBTZWlkZWwgIDxl cmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW5saW5lIGxvZ2ljYWxIZWlnaHRGb3JSb3dTaXpp bmcgdG8gc2hhdmUgYW5vdGhlciAyLTMlIG9mZiByb2JvaG9ybmV0J3MgcmVzaXplY29sLmh0bWwK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2VjdXJpdHlPcmlnaW4uY3BwIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5jcHAKaW5kZXggZGExNTAyMS4uZDUzNzUw YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9TZWN1cml0eU9yaWdpbi5jcHAKQEAgLTQyNywxMSArNDI3 LDYgQEAgdm9pZCBTZWN1cml0eU9yaWdpbjo6Z3JhbnRMb2FkTG9jYWxSZXNvdXJjZXMoKQogICAg IC8vIGlzIGEgc2VjdXJpdHkgaGF6YXJkIGJlY2F1c2UgdGhlIGRvY3VtZW50cyB3aXRob3V0IHRo ZSBwcml2aWxlZ2UgY2FuCiAgICAgLy8gb2J0YWluIHRoZSBwcml2aWxlZ2UgYnkgaW5qZWN0aW5n IHNjcmlwdCBpbnRvIHRoZSBkb2N1bWVudHMgdGhhdCBoYXZlCiAgICAgLy8gYmVlbiBncmFudGVk IHRoZSBwcml2aWxlZ2UuCi0gICAgLy8KLSAgICAvLyBUbyBiZSBiYWNrd2FyZHMgY29tcGF0aWJs ZSB3aXRoIG9sZGVyIHZlcnNpb25zIG9mIFdlYktpdCwgd2UgYWxzbyB1c2UKLSAgICAvLyB0aGlz IGZ1bmN0aW9uIHRvIGdyYW50IHRoZSBhYmlsaXR5IHRvIGxvYWQgbG9jYWwgcmVzb3VyY2VzIHRv IGRvY3VtZW50cwotICAgIC8vIGxvYWRlZCB3aXRoIFN1YnN0aXR1dGVEYXRhLgotICAgIEFTU0VS VChpc1VuaXF1ZSgpIHx8IFNlY3VyaXR5UG9saWN5OjphbGxvd1N1YnN0aXR1dGVEYXRhQWNjZXNz VG9Mb2NhbCgpKTsKICAgICBtX2NhbkxvYWRMb2NhbFJlc291cmNlcyA9IHRydWU7CiB9CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNGUwZDhmNy4uMTM4NmVjMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0xMC0wOSAgQmVuIE11cmRvY2gg IDxiZW5tQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXVtBbmRyb2lkXSBBZGQgV2Vi U2VjdXJpdHlPcmlnaW46OmdyYW50TG9hZExvY2FsUmVzb3VyY2VzKCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3Njg5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgZXhwb3NlcyB0aGUg V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW46OmdyYW50TG9hZExvY2FsUmVzb3VyY2VzKCkKKyAgICAg ICAgZnVuY3Rpb24gdG8gdGhlIENocm9taXVtIFdlYktpdCBBUEkgbGF5ZXIuIFRoaXMgaXMgbmVl ZGVkIGluIENocm9taXVtCisgICAgICAgIHRvIGltcGxlbWVudCB0aGUgQW5kcm9pZCBXZWJWaWV3 LmxvYWREYXRhV2l0aEJhc2VVcmwgZnVuY3Rpb24gaW4gYQorICAgICAgICBjb21wYXRpYmxlIG1h bm5lci4KKworICAgICAgICBQbGVhc2Ugc2VlIGNyYnVnLmNvbS8xNTIyMjMgZm9yIGZ1cnRoZXIg aW5mb3JtYXRpb24gYW5kIHRoZSBjaHJvbWl1bQorICAgICAgICBzaWRlIHBhdGNoLgorCisgICAg ICAgICogcHVibGljL1dlYlNlY3VyaXR5T3JpZ2luLmg6CisgICAgICAgIChXZWJTZWN1cml0eU9y aWdpbik6IEFkZCBncmFudExvYWRMb2NhbFJlc291cmNlcygpIEFQSS4KKyAgICAgICAgKiBzcmMv V2ViU2VjdXJpdHlPcmlnaW4uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdp bjo6Z3JhbnRMb2FkTG9jYWxSZXNvdXJjZXMpOgorICAgICAgICAgICAgSW1wbGVtZW50IHRoZSBB UEkgYnkgY2FsbGluZyB0aHJvdWdoIHRvIHRoZSBXZWJDb3JlIGZ1bmN0aW9uCisgICAgICAgICAg ICBvZiB0aGUgc2FtZSBuYW1lLgorICAgICAgICAoV2ViS2l0KToKKwogMjAxMi0xMC0wOCAgQWxl YyBGbGV0dCAgPGFsZWNmbGV0dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBy ZW1vdmUgYXV0b2dlbmVyYXRlZCBvYmplY3RTdG9yZS9pbmRleCBpZCBjb2RlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0eU9yaWdpbi5oIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJpdHlPcmlnaW4uaAppbmRleCBmZmRk ZjA5Li4zNTlkYzczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJTZWN1cml0eU9yaWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YlNlY3VyaXR5T3JpZ2luLmgKQEAgLTk2LDYgKzk2LDkgQEAgcHVibGljOgogICAgIC8vIHBhc3N3 b3JkcyBzdG9yZWQgaW4gcGFzc3dvcmQgbWFuYWdlci4KICAgICBXRUJLSVRfRVhQT1JUIGJvb2wg Y2FuQWNjZXNzUGFzc3dvcmRNYW5hZ2VyKCkgY29uc3Q7CiAKKyAgICAvLyBBbGxvd3MgdGhpcyBX ZWJTZWN1cml0eU9yaWdpbiBhY2Nlc3MgdG8gbG9jYWwgcmVzb3VyY2VzLgorICAgIFdFQktJVF9F WFBPUlQgdm9pZCBncmFudExvYWRMb2NhbFJlc291cmNlcygpIGNvbnN0OworCiAjaWYgV0VCS0lU X0lNUExFTUVOVEFUSU9OCiAgICAgV2ViU2VjdXJpdHlPcmlnaW4oY29uc3QgV1RGOjpQYXNzUmVm UHRyPFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luPiYpOwogICAgIFdlYlNlY3VyaXR5T3JpZ2luJiBv cGVyYXRvcj0oY29uc3QgV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luPiYp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmln aW4uY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3Bw CmluZGV4IDg1NjlkNGQuLmVlZTViNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHAKQEAgLTE1Niw0ICsxNTYsOSBAQCB2b2lkIFdlYlNl Y3VyaXR5T3JpZ2luOjphc3NpZ24oV2ViU2VjdXJpdHlPcmlnaW5Qcml2YXRlKiBwKQogICAgIG1f cHJpdmF0ZSA9IHA7CiB9CiAKK3ZvaWQgV2ViU2VjdXJpdHlPcmlnaW46OmdyYW50TG9hZExvY2Fs UmVzb3VyY2VzKCkgY29uc3QKK3sKKyAgICBnZXQoKS0+Z3JhbnRMb2FkTG9jYWxSZXNvdXJjZXMo KTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0Cg==