97686 2012-09-26 08:25:41 -0700 run-perf-tests must expand environment variables in user provided paths 2012-09-26 12:20:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 marcelo.lira marcelo.lira abarth dpranke eric jesus ojan rafael.lobo rniwa webkit.review.bot oldest_to_newest 728586 0 marcelo.lira 2012-09-26 08:25:41 -0700 Calling run-perf-tests using shell variables for paths values will result in errors when trying to open files using those paths. Examples: $ run-perf-tests --platform=qt --release --output-json-path=~/perf-results $ run-perf-tests --platform=qt --release --output-json-path=$HOME/perf-results '~' and '$HOME' don't get expanded, and further usages like the following will break: codecs.open(path, 'w', 'utf-8') Even worse in the case of the output path, because the error will happen only at the end of the long process of running the performance tests. 728594 1 165810 marcelo.lira 2012-09-26 08:32:36 -0700 Created attachment 165810 Patch 728814 2 jesus 2012-09-26 11:47:52 -0700 (In reply to comment #1) > Created an attachment (id=165810) [details] > Patch I can confirm the issue since I've faced it as well. (And it's quite annoying after you've been running tests for one hour or so.) 728850 3 165810 eric 2012-09-26 12:15:50 -0700 Comment on attachment 165810 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165810&action=review > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:75 > + def _expand_path(option, opt_str, value, parser): > + path = os.path.expandvars(os.path.expanduser(value)) > + setattr(parser.values, option.dest, path) Arguably this should use the Environment abstraction in webkitpy.common. Otherwise, how do you test this? It looks like currently you aren't... :) 728854 4 165810 webkit.review.bot 2012-09-26 12:20:20 -0700 Comment on attachment 165810 Patch Clearing flags on attachment: 165810 Committed r129683: <http://trac.webkit.org/changeset/129683> 728855 5 webkit.review.bot 2012-09-26 12:20:23 -0700 All reviewed patches have been landed. Closing bug. 165810 2012-09-26 08:32:36 -0700 2012-09-26 12:20:20 -0700 Patch bug-97686-20120926123155.patch text/plain 4151 marcelo.lira U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NjI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWJjZWEyOTk0NzAwNDFkNGQzODUzZmE2OTkyZmY4ZGMx NWI0NjIzMC4uYjc4ZTFjNzhlZTYyZWE3OGEyNTM1YTE5NmFkYmM1ZmM2MGNjZmM2MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA5LTI2ICBNYXJjZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBydW4tcGVyZi10ZXN0cyBtdXN0IGV4cGFuZCBlbnZpcm9ubWVudCB2YXJp YWJsZXMgaW4gdXNlciBwcm92aWRlZCBwYXRocworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTc2ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgcnVuLXBlcmYtdGVzdHMgY29tbWFuZCBsaW5lIG9wdGlv bnMgdGhhdCByZWNlaXZlIHBhdGhzIGZyb20gdGhlCisgICAgICAgIHVzZXIgbm93IGV4cGFuZCBh bnkgcG9zc2libGUgZW52aXJvbm1lbnQgdmFyaWFibGVzLCBiZWNhdXNlIFB5dGhvbidzCisgICAg ICAgIGZpbGUgaGFuZGxpbmcgbWV0aG9kcyBkbyBub3QgaGFuZGxlIHRob3NlLgorCisgICAgICAg IEV4YW1wbGVzOgorICAgICAgICBydW4tcGVyZi10ZXN0cyAtLXBsYXRmb3JtPXF0IC0tcmVsZWFz ZSAtLW91dHB1dC1qc29uLXBhdGg9fi9wZXJmLXJlc3VsdHMKKyAgICAgICAgcnVuLXBlcmYtdGVz dHMgLS1wbGF0Zm9ybT1xdCAtLXJlbGVhc2UgLS1vdXRwdXQtanNvbi1wYXRoPSRIT01FL3BlcmYt cmVzdWx0cworCisgICAgICAgIEFsc28gcmVtb3ZlZCB1bnVzZWQgaW1wb3J0cy4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5 OgorICAgICAgICAoUGVyZlRlc3RzUnVubmVyLl9wYXJzZV9hcmdzLl9leHBhbmRfcGF0aCk6IGV4 cGFuZCBlbnZpcm9ubWVudCB2YXJpYWJsZXMgaW4gYSBwYXRoIHBhc3NlZCB2aWEgY29tbWFuZCBs aW5lCisgICAgICAgIChQZXJmVGVzdHNSdW5uZXIuX3BhcnNlX2FyZ3MpOgorCiAyMDEyLTA5LTI2 ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1RLXSBSZW1vdmUgY29sb3IgY29kZXMgY2hhcmFjdGVycyBmcm9tIHJ1bi1ndGstdGVzdHMgb3V0 cHV0IHdoZW4gbm90IHdyaXRpbmcgdG8gYSBUVFkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKaW5kZXgg YzM0ZDBiM2U0NGIwZDhlOTg0Y2U3OWVkNjI1ZDQyMGQzMjk1ODM5MS4uNDYyNjYyYTY4Y2QzYzNm MjQ2MDgwM2QzZmVjZjkxZWJhN2RiYTE3YSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdHNydW5uZXIucHkKQEAgLTI5 LDE5ICsyOSwxNiBAQAogCiAiIiJSdW4gSW5zcGVjdG9yJ3MgcGVyZiB0ZXN0cyBpbiBwZXJmIG1v ZGUuIiIiCiAKK2ltcG9ydCBvcwogaW1wb3J0IGpzb24KIGltcG9ydCBsb2dnaW5nCiBpbXBvcnQg b3B0cGFyc2UKLWltcG9ydCByZQotaW1wb3J0IHN5cwogaW1wb3J0IHRpbWUKIAogZnJvbSB3ZWJr aXRweS5jb21tb24gaW1wb3J0IGZpbmRfZmlsZXMKIGZyb20gd2Via2l0cHkuY29tbW9uLmhvc3Qg aW1wb3J0IEhvc3QKIGZyb20gd2Via2l0cHkuY29tbW9uLm5ldC5maWxlX3VwbG9hZGVyIGltcG9y dCBGaWxlVXBsb2FkZXIKLWZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnZpZXdzIGltcG9ydCBw cmludGluZwogZnJvbSB3ZWJraXRweS5wZXJmb3JtYW5jZV90ZXN0cy5wZXJmdGVzdCBpbXBvcnQg UGVyZlRlc3RGYWN0b3J5Ci1mcm9tIHdlYmtpdHB5LnBlcmZvcm1hbmNlX3Rlc3RzLnBlcmZ0ZXN0 IGltcG9ydCBSZXBsYXlQZXJmVGVzdAogCiAKIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25h bWVfXykKQEAgLTczLDYgKzcwLDkgQEAgY2xhc3MgUGVyZlRlc3RzUnVubmVyKG9iamVjdCk6CiAK ICAgICBAc3RhdGljbWV0aG9kCiAgICAgZGVmIF9wYXJzZV9hcmdzKGFyZ3M9Tm9uZSk6CisgICAg ICAgIGRlZiBfZXhwYW5kX3BhdGgob3B0aW9uLCBvcHRfc3RyLCB2YWx1ZSwgcGFyc2VyKToKKyAg ICAgICAgICAgIHBhdGggPSBvcy5wYXRoLmV4cGFuZHZhcnMob3MucGF0aC5leHBhbmR1c2VyKHZh bHVlKSkKKyAgICAgICAgICAgIHNldGF0dHIocGFyc2VyLnZhbHVlcywgb3B0aW9uLmRlc3QsIHBh dGgpCiAgICAgICAgIHBlcmZfb3B0aW9uX2xpc3QgPSBbCiAgICAgICAgICAgICBvcHRwYXJzZS5t YWtlX29wdGlvbignLS1kZWJ1ZycsIGFjdGlvbj0nc3RvcmVfY29uc3QnLCBjb25zdD0nRGVidWcn LCBkZXN0PSJjb25maWd1cmF0aW9uIiwKICAgICAgICAgICAgICAgICBoZWxwPSdTZXQgdGhlIGNv bmZpZ3VyYXRpb24gdG8gRGVidWcnKSwKQEAgLTk4LDEzICs5OCwxMyBAQCBjbGFzcyBQZXJmVGVz dHNSdW5uZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICBoZWxwPSJQYXVzZSBiZWZvcmUgcnVu bmluZyB0aGUgdGVzdHMgdG8gbGV0IHVzZXIgYXR0YWNoIGEgcGVyZm9ybWFuY2UgbW9uaXRvci4i KSwKICAgICAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW5vLXJlc3VsdHMiLCBhY3Rp b249InN0b3JlX2ZhbHNlIiwgZGVzdD0iZ2VuZXJhdGVfcmVzdWx0cyIsIGRlZmF1bHQ9VHJ1ZSwK ICAgICAgICAgICAgICAgICBoZWxwPSJEbyBubyBnZW5lcmF0ZSByZXN1bHRzIEpTT04gYW5kIHJl c3VsdHMgcGFnZS4iKSwKLSAgICAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW91dHB1 dC1qc29uLXBhdGgiLAorICAgICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tb3V0cHV0 LWpzb24tcGF0aCIsIGFjdGlvbj0nY2FsbGJhY2snLCBjYWxsYmFjaz1fZXhwYW5kX3BhdGgsIHR5 cGU9InN0ciIsCiAgICAgICAgICAgICAgICAgaGVscD0iUGF0aCB0byBnZW5lcmF0ZSBhIEpTT04g ZmlsZSBhdDsgbWF5IGNvbnRhaW4gcHJldmlvdXMgcmVzdWx0cyBpZiBpdCBhbHJlYWR5IGV4aXN0 cy4iKSwKICAgICAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXJlc2V0LXJlc3VsdHMi LCBhY3Rpb249InN0b3JlX3RydWUiLAogICAgICAgICAgICAgICAgIGhlbHA9IkNsZWFycyB0aGUg Y29udGVudCBpbiB0aGUgZ2VuZXJhdGVkIEpTT04gZmlsZSBiZWZvcmUgYWRkaW5nIHRoZSByZXN1 bHRzLiIpLAotICAgICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tc2xhdmUtY29uZmln LWpzb24tcGF0aCIsCisgICAgICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS1zbGF2ZS1j b25maWctanNvbi1wYXRoIiwgYWN0aW9uPSdjYWxsYmFjaycsIGNhbGxiYWNrPV9leHBhbmRfcGF0 aCwgdHlwZT0ic3RyIiwKICAgICAgICAgICAgICAgICBoZWxwPSJPbmx5IHVzZWQgb24gYm90cy4g UGF0aCB0byBhIHNsYXZlIGNvbmZpZ3VyYXRpb24gZmlsZS4iKSwKLSAgICAgICAgICAgIG9wdHBh cnNlLm1ha2Vfb3B0aW9uKCItLXNvdXJjZS1qc29uLXBhdGgiLCBkZXN0PSJzbGF2ZV9jb25maWdf anNvbl9wYXRoIiwKKyAgICAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXNvdXJjZS1q c29uLXBhdGgiLCBhY3Rpb249J2NhbGxiYWNrJywgY2FsbGJhY2s9X2V4cGFuZF9wYXRoLCB0eXBl PSJzdHIiLCBkZXN0PSJzbGF2ZV9jb25maWdfanNvbl9wYXRoIiwKICAgICAgICAgICAgICAgICAj IEZJWE1FOiBSZW1vdmUgdGhpcyBvcHRpb24gb25jZSBidWlsZC53ZWJraXQub3JnIGlzIHVwZGF0 ZWQgdG8gdXNlIC0tc2xhdmUtY29uZmlnLWpzb24tcGF0aC4KICAgICAgICAgICAgICAgICBoZWxw PSJEZXByZWNhdGVkLiBPdmVycmlkZXMgLS1zbGF2ZS1jb25maWctanNvbi1wYXRoLiIpLAogICAg ICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tZGVzY3JpcHRpb24iLAo=