97677 2012-09-26 06:46:12 -0700 Web Inspector: display stack of last layout invalidation instead of first one 2012-09-26 08:04:43 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 728495 0 caseq 2012-09-26 06:46:12 -0700 Inspector's timeline agent used to send only first layout invalidation to front-end, so we displayed first JS stack as the reason for re-layout. It's probably more useful to display the last one, as the scope of layout is expanded, hence the last one has a good chances to be the one with larger impact. Ultimately, we should probably aggregate these and find a way to visualize many stacks. 728508 1 165793 caseq 2012-09-26 06:59:04 -0700 Created attachment 165793 Patch 728567 2 caseq 2012-09-26 08:04:43 -0700 Committed r129645: <http://trac.webkit.org/changeset/129645> 165793 2012-09-26 06:59:04 -0700 2012-09-26 07:45:53 -0700 Patch bug-97677-20120926175822.patch text/plain 2811 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5NjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDg4OWMxYTk1YWYxYmZj YWQxZTU3NmVmNzE1MGZjZDBlMTRjOTlhNi4uZTc5ZGNjZWZiNTZiY2ZkYmZiOGUyOTBkMzc4N2M2 MDIwNWQyZTA4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA5LTI2ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogZGlzcGxheSBzdGFjayBvZiBsYXN0IGxheW91dCBpbnZhbGlkYXRpb24gaW5zdGVhZCBvZiBm aXJzdCBvbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk3Njc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg LSBhZGQgYSBjYWxsIHRvIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkSW52YWxpZGF0ZUxh eW91dCgpIHdoZW4gdXBncmFkaW5nIHJlbGF5b3V0IHJvb3Q7CisgICAgICAgIC0gZG8gbm90IHN1 cHByZXNzIHRpbWVsaW5lJ3MgSW52YWxpZGF0ZSBMYXlvdXQgcmVjb3JkcyBvdGhlciB0aGFuIGZp cnN0LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6ZGlkSW52YWxpZGF0ZUxh eW91dCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVWaWV3OjpzY2hlZHVsZVJlbGF5b3V0T2ZTdWJ0cmVlKToKKworMjAxMi0wOS0yNiAgQW5k cmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFkZCBleHBlcmltZW50IHRvIHNob3cgcmVuZGVyaW5nIGluZm9ybWF0aW9uIG9uIGluc3Bl Y3RvciBvdmVybGF5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NzY2MQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yVGltZWxpbmVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y VGltZWxpbmVBZ2VudC5jcHAKaW5kZXggYTk5NGNkZDExYjE2YmFkMDJjMmI4NjEzYmViODYyNzA0 YTg2M2I4Yy4uMWEyMjgxNTI5N2UxOTE0NmEwMTRlNGFjNWY5NWVjMDkxMzFjZDA4YSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmNw cApAQCAtMjM0LDggKzIzNCw2IEBAIHZvaWQgSW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6ZGlkRGlz cGF0Y2hFdmVudCgpCiAKIHZvaWQgSW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6ZGlkSW52YWxpZGF0 ZUxheW91dChGcmFtZSogZnJhbWUpCiB7Ci0gICAgaWYgKGZyYW1lLT52aWV3KCktPmxheW91dFBl bmRpbmcoKSkKLSAgICAgICAgcmV0dXJuOwogICAgIGFwcGVuZFJlY29yZChJbnNwZWN0b3JPYmpl Y3Q6OmNyZWF0ZSgpLCBUaW1lbGluZVJlY29yZFR5cGU6OkludmFsaWRhdGVMYXlvdXQsIHRydWUs IGZyYW1lKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDlmNzI3NDYyNzU2 OTkzZDhhMTk2M2JiZGU0NDdhMmZiOWEyMzQ4MzQuLmQwN2YwZTNkMGYyMTU3M2MzZWQ1ZGVkNzcy MGVhZGZiNTVlYzU4YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTIxODMsMTIg KzIxODMsMTQgQEAgdm9pZCBGcmFtZVZpZXc6OnNjaGVkdWxlUmVsYXlvdXRPZlN1YnRyZWUoUmVu ZGVyT2JqZWN0KiByZWxheW91dFJvb3QpCiAgICAgICAgICAgICAgICAgbV9sYXlvdXRSb290LT5t YXJrQ29udGFpbmluZ0Jsb2Nrc0ZvckxheW91dChmYWxzZSwgcmVsYXlvdXRSb290KTsKICAgICAg ICAgICAgICAgICBtX2xheW91dFJvb3QgPSByZWxheW91dFJvb3Q7CiAgICAgICAgICAgICAgICAg QVNTRVJUKCFtX2xheW91dFJvb3QtPmNvbnRhaW5lcigpIHx8ICFtX2xheW91dFJvb3QtPmNvbnRh aW5lcigpLT5uZWVkc0xheW91dCgpKTsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JJbnN0cnVt ZW50YXRpb246OmRpZEludmFsaWRhdGVMYXlvdXQobV9mcmFtZS5nZXQoKSk7CiAgICAgICAgICAg ICB9IGVsc2UgewogICAgICAgICAgICAgICAgIC8vIEp1c3QgZG8gYSBmdWxsIHJlbGF5b3V0CiAg ICAgICAgICAgICAgICAgaWYgKG1fbGF5b3V0Um9vdCkKICAgICAgICAgICAgICAgICAgICAgbV9s YXlvdXRSb290LT5tYXJrQ29udGFpbmluZ0Jsb2Nrc0ZvckxheW91dChmYWxzZSk7CiAgICAgICAg ICAgICAgICAgbV9sYXlvdXRSb290ID0gMDsKICAgICAgICAgICAgICAgICByZWxheW91dFJvb3Qt Pm1hcmtDb250YWluaW5nQmxvY2tzRm9yTGF5b3V0KGZhbHNlKTsKKyAgICAgICAgICAgICAgICBJ bnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZEludmFsaWRhdGVMYXlvdXQobV9mcmFtZS5nZXQo KSk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKG1fbGF5b3V0U2No ZWR1bGluZ0VuYWJsZWQpIHsK